Merge pull request #18277 from lidizheng/nogil-unref

Remove GIL for grpc_call_unref
6 years ago · c73c724778
parent 12e6b4b89e 8326ac64e4
commit c73c724778
1 changed files with 4 additions and 3 deletions
--- a/src/python/grpcio/grpc/_cython/_cygrpc/call.pyx.pxi
+++ b/src/python/grpcio/grpc/_cython/_cygrpc/call.pyx.pxi
@ -85,9 +85,10 @@ cdef class Call:
    return result

  def __dealloc__(self):
-    if self.c_call != NULL:
-      grpc_call_unref(self.c_call)
-    grpc_shutdown_blocking()
+    with nogil:
+      if self.c_call != NULL:
+        grpc_call_unref(self.c_call)
+      grpc_shutdown_blocking()

  # The object *should* always be valid from Python. Used for debugging.
  @property