From c26f53cee4c6f72dd61de2e2a5526fe8ea9b20a8 Mon Sep 17 00:00:00 2001 From: Lidi Zheng Date: Tue, 13 Jul 2021 11:01:16 -0700 Subject: [PATCH] Revert "Ensure a new timestamp is obtained in FI filter (#26167)" (#26575) This reverts commit 1e2311c1ce706b6d76bea98345046e78880d3a9f. --- .../ext/filters/fault_injection/fault_injection_filter.cc | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/core/ext/filters/fault_injection/fault_injection_filter.cc b/src/core/ext/filters/fault_injection/fault_injection_filter.cc index 6197e74fd8b..5f8d7794414 100644 --- a/src/core/ext/filters/fault_injection/fault_injection_filter.cc +++ b/src/core/ext/filters/fault_injection/fault_injection_filter.cc @@ -428,12 +428,6 @@ void CallData::DelayBatch(grpc_call_element* elem, MutexLock lock(&delay_mu_); delayed_batch_ = batch; resume_batch_canceller_ = new ResumeBatchCanceller(elem); - // Without this line, ExecCtx::Get()->Now() will return a cached timestamp. If - // there are thousands of RPCs happen on one thread, we might observe ms-level - // error in Now(). This could mean the construction of RPC object is - // microseconds earlier than the filter execution. But we still haven't found - // the root cause. Read more: https://github.com/grpc/grpc/pull/25738. - ExecCtx::Get()->InvalidateNow(); grpc_millis resume_time = ExecCtx::Get()->Now() + fi_policy_->delay; GRPC_CLOSURE_INIT(&batch->handler_private.closure, ResumeBatch, elem, grpc_schedule_on_exec_ctx);