Merge pull request #15180 from jtattermusch/run_tests_auto_set_flakes_optin

run_tests.py --auto_set_flakes should be disabled by default
pull/15189/head
Jan Tattermusch 7 years ago committed by GitHub
commit c12b0ed690
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 8
      tools/run_tests/run_tests.py
  2. 1
      tools/run_tests/run_tests_matrix.py

@ -1420,16 +1420,18 @@ argp.add_argument(
nargs='?', nargs='?',
help='Upload test results to a specified BQ table.') help='Upload test results to a specified BQ table.')
argp.add_argument( argp.add_argument(
'--disable_auto_set_flakes', '--auto_set_flakes',
default=False, default=False,
const=True, const=True,
action='store_const', action='store_const',
help='Disable rerunning historically flaky tests') help=
'Allow repeated runs for tests that have been failing recently (based on BQ historical data).'
)
args = argp.parse_args() args = argp.parse_args()
flaky_tests = set() flaky_tests = set()
shortname_to_cpu = {} shortname_to_cpu = {}
if not args.disable_auto_set_flakes: if args.auto_set_flakes:
try: try:
for test in get_bqtest_data(): for test in get_bqtest_data():
if test.flaky: flaky_tests.add(test.name) if test.flaky: flaky_tests.add(test.name)

@ -529,7 +529,6 @@ if __name__ == "__main__":
extra_args.append('--bq_result_table') extra_args.append('--bq_result_table')
extra_args.append('%s' % args.bq_result_table) extra_args.append('%s' % args.bq_result_table)
extra_args.append('--measure_cpu_costs') extra_args.append('--measure_cpu_costs')
extra_args.append('--disable_auto_set_flakes')
all_jobs = _create_test_jobs(extra_args=extra_args, inner_jobs=args.inner_jobs) + \ all_jobs = _create_test_jobs(extra_args=extra_args, inner_jobs=args.inner_jobs) + \
_create_portability_test_jobs(extra_args=extra_args, inner_jobs=args.inner_jobs) _create_portability_test_jobs(extra_args=extra_args, inner_jobs=args.inner_jobs)

Loading…
Cancel
Save