From 326e06256bef4e618fa2f1c25657606c8a13d2bc Mon Sep 17 00:00:00 2001
From: Jan Tattermusch <jtattermusch@google.com>
Date: Thu, 21 Mar 2019 11:00:38 -0400
Subject: [PATCH 1/7] C# distribtests should test Grpc.Tools codegen too

---
 .../DistribTest/DistribTestDotNet.csproj      |  5 ++++
 .../csharp/DistribTest/testcodegen.proto      | 29 +++++++++++++++++++
 2 files changed, 34 insertions(+)
 create mode 100644 test/distrib/csharp/DistribTest/testcodegen.proto

diff --git a/test/distrib/csharp/DistribTest/DistribTestDotNet.csproj b/test/distrib/csharp/DistribTest/DistribTestDotNet.csproj
index f16a0f99591..d19eac91ba4 100644
--- a/test/distrib/csharp/DistribTest/DistribTestDotNet.csproj
+++ b/test/distrib/csharp/DistribTest/DistribTestDotNet.csproj
@@ -16,8 +16,13 @@
     <PackageReference Include="Grpc" Version="__GRPC_NUGET_VERSION__" />
     <PackageReference Include="Grpc.Auth" Version="__GRPC_NUGET_VERSION__" />
     <PackageReference Include="Grpc.Tools" Version="__GRPC_NUGET_VERSION__" />
+    <PackageReference Include="Google.Protobuf" Version="3.7.0" />
   </ItemGroup>
   
+  <ItemGroup>
+    <Protobuf Include="**\*.proto" />
+  </ItemGroup>
+
   <PropertyGroup Condition="'$(OS)' != 'Windows_NT'">
     <!-- Workaround for https://github.com/dotnet/sdk/issues/335 -->
     <FrameworkPathOverride Condition="Exists('/usr/lib/mono/4.5-api')">/usr/lib/mono/4.5-api</FrameworkPathOverride>
diff --git a/test/distrib/csharp/DistribTest/testcodegen.proto b/test/distrib/csharp/DistribTest/testcodegen.proto
new file mode 100644
index 00000000000..7845ac92c49
--- /dev/null
+++ b/test/distrib/csharp/DistribTest/testcodegen.proto
@@ -0,0 +1,29 @@
+// Copyright 2019 The gRPC Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+syntax = "proto3";
+
+package testcodegen;
+
+service Greeter {
+  rpc SayHello (HelloRequest) returns (HelloReply) {}
+}
+
+message HelloRequest {
+  string name = 1;
+}
+
+message HelloReply {
+  string message = 1;
+}

From 89281d44989133a2b36bc2c5457d138a41036bfe Mon Sep 17 00:00:00 2001
From: Jan Tattermusch <jtattermusch@google.com>
Date: Thu, 21 Mar 2019 11:23:44 -0400
Subject: [PATCH 2/7] test protobuf used

---
 test/distrib/csharp/DistribTest/Program.cs | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/test/distrib/csharp/DistribTest/Program.cs b/test/distrib/csharp/DistribTest/Program.cs
index 376add6b7b5..0ea7211fc45 100644
--- a/test/distrib/csharp/DistribTest/Program.cs
+++ b/test/distrib/csharp/DistribTest/Program.cs
@@ -25,6 +25,9 @@ namespace TestGrpcPackage
     {
         public static void Main(string[] args)
         {
+            // test codegen works
+            var reply = new Testcodegen.HelloReply();
+
             // This code doesn't do much but makes sure the native extension is loaded
             // which is what we are testing here.
             Channel c = new Channel("127.0.0.1:1000", ChannelCredentials.Insecure);

From 133ff03e97c9d1389b321e25bef587ded6689de8 Mon Sep 17 00:00:00 2001
From: Jan Tattermusch <jtattermusch@google.com>
Date: Thu, 21 Mar 2019 11:24:21 -0400
Subject: [PATCH 3/7] classic .csproj Grpc.Tools test

---
 test/distrib/csharp/DistribTest/DistribTest.csproj | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/test/distrib/csharp/DistribTest/DistribTest.csproj b/test/distrib/csharp/DistribTest/DistribTest.csproj
index d18bb05be68..20d103a41b3 100644
--- a/test/distrib/csharp/DistribTest/DistribTest.csproj
+++ b/test/distrib/csharp/DistribTest/DistribTest.csproj
@@ -1,6 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
 <Project ToolsVersion="4.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
   <Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" />
+  <Import Project="..\packages\Grpc.Tools.__GRPC_NUGET_VERSION__\build\Grpc.Tools.props" Condition="Exists('..\packages\Grpc.Tools.__GRPC_NUGET_VERSION__\build\Grpc.Tools.props')" />
   <PropertyGroup>
     <Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
     <Platform Condition=" '$(Platform)' == '' ">AnyCPU</Platform>
@@ -98,16 +99,22 @@
     <Compile Include="Program.cs" />
     <Compile Include="Properties\AssemblyInfo.cs" />
   </ItemGroup>
+  <ItemGroup>
+    <Protobuf Include="**\*.proto" />
+  </ItemGroup>
   <ItemGroup>
     <None Include="packages.config" />
   </ItemGroup>
   <Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
   <Import Project="..\packages\Grpc.Core.__GRPC_NUGET_VERSION__\build\net45\Grpc.Core.targets" Condition="Exists('..\packages\Grpc.Core.__GRPC_NUGET_VERSION__\build\net45\Grpc.Core.targets')" />
+  <Import Project="..\packages\Grpc.Tools.__GRPC_NUGET_VERSION__\build\Grpc.Tools.targets" Condition="Exists('..\packages\Grpc.Tools.__GRPC_NUGET_VERSION__\build\Grpc.Tools.targets')" />
   <Target Name="EnsureNuGetPackageBuildImports" BeforeTargets="PrepareForBuild">
     <PropertyGroup>
       <ErrorText>This project references NuGet package(s) that are missing on this computer. Enable NuGet Package Restore to download them.  For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is {0}.</ErrorText>
     </PropertyGroup>
     <Error Condition="!Exists('..\packages\Grpc.Core.__GRPC_NUGET_VERSION__\build\net45\Grpc.Core.targets')" Text="$([System.String]::Format('$(ErrorText)', '..\packages\Grpc.Core.__GRPC_NUGET_VERSION__\build\net45\Grpc.Core.targets'))" />
+    <Error Condition="!Exists('..\packages\Grpc.Tools.__GRPC_NUGET_VERSION__\build\Grpc.Tools.props')" Text="$([System.String]::Format('$(ErrorText)', '..\packages\Grpc.Tools.__GRPC_NUGET_VERSION__\build\Grpc.Tools.props'))" />
+    <Error Condition="!Exists('..\packages\Grpc.Tools.__GRPC_NUGET_VERSION__\build\Grpc.Tools.targets')" Text="$([System.String]::Format('$(ErrorText)', '..\packages\Grpc.Tools.__GRPC_NUGET_VERSION__\build\Grpc.Tools.targets'))" />
   </Target>
   <!-- To modify your build process, add your task inside one of the targets below and uncomment it. 
        Other similar extension points exist, see Microsoft.Common.targets.

From 80fb0ce67f57bb5f5e57ed8a2ec775077f80d418 Mon Sep 17 00:00:00 2001
From: Jan Tattermusch <jtattermusch@google.com>
Date: Thu, 21 Mar 2019 11:32:15 -0400
Subject: [PATCH 4/7] add Google.Protobuf dependency to legacy csproj

---
 test/distrib/csharp/DistribTest/DistribTest.csproj | 3 +++
 test/distrib/csharp/DistribTest/packages.config    | 1 +
 2 files changed, 4 insertions(+)

diff --git a/test/distrib/csharp/DistribTest/DistribTest.csproj b/test/distrib/csharp/DistribTest/DistribTest.csproj
index 20d103a41b3..e3fc94b4f23 100644
--- a/test/distrib/csharp/DistribTest/DistribTest.csproj
+++ b/test/distrib/csharp/DistribTest/DistribTest.csproj
@@ -94,6 +94,9 @@
     <Reference Include="Google.Apis.Auth.PlatformServices">
       <HintPath>..\packages\Google.Apis.Auth.1.15.0\lib\net45\Google.Apis.Auth.PlatformServices.dll</HintPath>
     </Reference>
+    <Reference Include="Google.Protobuf, Version=3.7.0.0, Culture=neutral, PublicKeyToken=a7d26565bac4d604, processorArchitecture=MSIL">
+      <HintPath>..\packages\Google.Protobuf.3.7.0\lib\net45\Google.Protobuf.dll</HintPath>
+    </Reference>
   </ItemGroup>
   <ItemGroup>
     <Compile Include="Program.cs" />
diff --git a/test/distrib/csharp/DistribTest/packages.config b/test/distrib/csharp/DistribTest/packages.config
index 134add7504d..5e09d5dad01 100644
--- a/test/distrib/csharp/DistribTest/packages.config
+++ b/test/distrib/csharp/DistribTest/packages.config
@@ -8,6 +8,7 @@
   <package id="Grpc.Core" version="__GRPC_NUGET_VERSION__" targetFramework="net45" />
   <package id="Grpc.Core.Api" version="__GRPC_NUGET_VERSION__" targetFramework="net45" />
   <package id="Grpc.Tools" version="__GRPC_NUGET_VERSION__" targetFramework="net45" />
+  <package id="Google.Protobuf" version="3.7.0" targetFramework="net45" />
   <package id="System.Interactive.Async" version="3.0.0" targetFramework="net45" />
   <package id="Newtonsoft.Json" version="7.0.1" targetFramework="net45" />
 </packages>
\ No newline at end of file

From 2ebbac117b72ad3c9111831cd7d86f271232ba53 Mon Sep 17 00:00:00 2001
From: Jan Tattermusch <jtattermusch@google.com>
Date: Wed, 27 Mar 2019 16:28:33 -0400
Subject: [PATCH 5/7] Use msbuild in C# distribtests for legacy .csproj

---
 test/distrib/csharp/run_distrib_test.sh                    | 2 +-
 tools/dockerfile/distribtest/csharp_centos7_x64/Dockerfile | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/test/distrib/csharp/run_distrib_test.sh b/test/distrib/csharp/run_distrib_test.sh
index 61924b91df8..45911cd91a7 100755
--- a/test/distrib/csharp/run_distrib_test.sh
+++ b/test/distrib/csharp/run_distrib_test.sh
@@ -24,7 +24,7 @@ unzip -o "$EXTERNAL_GIT_ROOT/input_artifacts/csharp_nugets_windows_dotnetcli.zip
 # Retry "nuget restore" to work around https://github.com/grpc/grpc/issues/16312
 nuget restore || nuget restore || nuget restore
 
-xbuild DistribTest.sln
+msbuild DistribTest.sln
 
 mono DistribTest/bin/Debug/DistribTest.exe
 
diff --git a/tools/dockerfile/distribtest/csharp_centos7_x64/Dockerfile b/tools/dockerfile/distribtest/csharp_centos7_x64/Dockerfile
index e32b3cb5e25..d9473bb3a5c 100644
--- a/tools/dockerfile/distribtest/csharp_centos7_x64/Dockerfile
+++ b/tools/dockerfile/distribtest/csharp_centos7_x64/Dockerfile
@@ -18,6 +18,7 @@ RUN rpm --import "https://keyserver.ubuntu.com/pks/lookup?op=get&search=0x3FA7E0
 RUN curl https://download.mono-project.com/repo/centos7-stable.repo | tee /etc/yum.repos.d/mono-centos7-stable.repo
 
 RUN yum install -y mono-devel
+RUN yum install -y msbuild
 
 RUN yum install -y nuget
 

From 8665e94b1175a527d2169f1b403004fd8de0df60 Mon Sep 17 00:00:00 2001
From: Jan Tattermusch <jtattermusch@google.com>
Date: Wed, 27 Mar 2019 17:23:35 -0400
Subject: [PATCH 6/7] make Grpc.Tools work inside 32bit docker container on
 linux

---
 src/csharp/Grpc.Tools/Common.cs | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/src/csharp/Grpc.Tools/Common.cs b/src/csharp/Grpc.Tools/Common.cs
index a4fcfc2c53c..d6359804953 100644
--- a/src/csharp/Grpc.Tools/Common.cs
+++ b/src/csharp/Grpc.Tools/Common.cs
@@ -87,6 +87,16 @@ namespace Grpc.Tools
 
             // Hope we are not building on ARM under Xamarin!
             Cpu = Environment.Is64BitOperatingSystem ? CpuKind.X64 : CpuKind.X86;
+
+            // See https://github.com/grpc/grpc/issues/18543
+            // Problem: Is64BitOperatingSystem returns "true" inside a 32-bit docker container.
+            // Workaround: Mono is 64-bit by default on linux, so we get around
+            // this by assuming 32-bit mono linux process means
+            // we should invoke 32-bit version of protoc.
+            if (Os == OsKind.Linux && !Environment.Is64BitProcess)
+            {
+                Cpu = CpuKind.X86;
+            }
 #endif
         }
     };

From 7d489f6a446984b052486a938b72e80c7df49c4d Mon Sep 17 00:00:00 2001
From: Jan Tattermusch <jtattermusch@google.com>
Date: Fri, 29 Mar 2019 12:39:45 -0400
Subject: [PATCH 7/7] use process architecture instead of OS architecture

---
 src/csharp/Grpc.Tools/Common.cs | 14 ++------------
 1 file changed, 2 insertions(+), 12 deletions(-)

diff --git a/src/csharp/Grpc.Tools/Common.cs b/src/csharp/Grpc.Tools/Common.cs
index d6359804953..13cd6a32316 100644
--- a/src/csharp/Grpc.Tools/Common.cs
+++ b/src/csharp/Grpc.Tools/Common.cs
@@ -60,7 +60,7 @@ namespace Grpc.Tools
                : RuntimeInformation.IsOSPlatform(OSPlatform.OSX) ? OsKind.MacOsX
                : OsKind.Unknown;
 
-            switch (RuntimeInformation.OSArchitecture)
+            switch (RuntimeInformation.ProcessArchitecture)
             {
                 case Architecture.X86: Cpu = CpuKind.X86; break;
                 case Architecture.X64: Cpu = CpuKind.X64; break;
@@ -86,17 +86,7 @@ namespace Grpc.Tools
             }
 
             // Hope we are not building on ARM under Xamarin!
-            Cpu = Environment.Is64BitOperatingSystem ? CpuKind.X64 : CpuKind.X86;
-
-            // See https://github.com/grpc/grpc/issues/18543
-            // Problem: Is64BitOperatingSystem returns "true" inside a 32-bit docker container.
-            // Workaround: Mono is 64-bit by default on linux, so we get around
-            // this by assuming 32-bit mono linux process means
-            // we should invoke 32-bit version of protoc.
-            if (Os == OsKind.Linux && !Environment.Is64BitProcess)
-            {
-                Cpu = CpuKind.X86;
-            }
+            Cpu = Environment.Is64BitProcess ? CpuKind.X64 : CpuKind.X86;
 #endif
         }
     };