Changed to a more portable Node version check in binding.gyp

pull/3888/head
murgatroid99 10 years ago
parent e2a1bf46f9
commit c07c734f45
  1. 7
      binding.gyp
  2. 7
      templates/binding.gyp.template

@ -46,10 +46,11 @@
# io.js always reports versions >0 and always exports ALPN symbols. # io.js always reports versions >0 and always exports ALPN symbols.
# Therefore, Node's major version will be truthy if and only if it # Therefore, Node's major version will be truthy if and only if it
# supports ALPN. The output of "node -v" is v[major].[minor].[patch], # supports ALPN. The output of "node -v" is v[major].[minor].[patch],
# like "v4.1.1" in a recent version. We use grep to extract just the # like "v4.1.1" in a recent version. We use cut to split by period and
# major version. "4", would be the output for the example. # take the first field (resulting in "v[major]"), then use cut again
# to take all but the first character, removing the "v".
'defines': [ 'defines': [
'TSI_OPENSSL_ALPN_SUPPORT=<!(node -v | grep -oP "(?<=v)(\d+)(?=\.\d+\.\d+)")' 'TSI_OPENSSL_ALPN_SUPPORT=<!(node --version | cut -d. -f1 | cut -c2-)'
], ],
'include_dirs': [ 'include_dirs': [
'.', '.',

@ -48,10 +48,11 @@
# io.js always reports versions >0 and always exports ALPN symbols. # io.js always reports versions >0 and always exports ALPN symbols.
# Therefore, Node's major version will be truthy if and only if it # Therefore, Node's major version will be truthy if and only if it
# supports ALPN. The output of "node -v" is v[major].[minor].[patch], # supports ALPN. The output of "node -v" is v[major].[minor].[patch],
# like "v4.1.1" in a recent version. We use grep to extract just the # like "v4.1.1" in a recent version. We use cut to split by period and
# major version. "4", would be the output for the example. # take the first field (resulting in "v[major]"), then use cut again
# to take all but the first character, removing the "v".
'defines': [ 'defines': [
'TSI_OPENSSL_ALPN_SUPPORT=<!(node -v | grep -oP "(?<=v)(\d+)(?=\.\d+\.\d+)")' 'TSI_OPENSSL_ALPN_SUPPORT=<!(node --version | cut -d. -f1 | cut -c2-)'
], ],
'include_dirs': [ 'include_dirs': [
'.', '.',

Loading…
Cancel
Save