review feedback: unit test of uri value too strict

pull/2675/head
Stanley Cheung 9 years ago
parent db98e08570
commit c0034dd10b
  1. 2
      src/php/tests/interop/interop_client.php
  2. 2
      src/php/tests/unit_tests/CallTest.php
  3. 2
      src/php/tests/unit_tests/EndToEndTest.php

@ -333,7 +333,7 @@ if (in_array($args['test_case'], array(
} }
$internal_stub = new Grpc\BaseStub($server_address, $opts); $internal_stub = new Grpc\BaseStub($server_address, $opts);
hardAssert($internal_stub->getTarget() == $server_address, hardAssert(is_string($internal_stub->getTarget()),
'Unexpected target URI value'); 'Unexpected target URI value');
$stub = new grpc\testing\TestServiceClient($internal_stub); $stub = new grpc\testing\TestServiceClient($internal_stub);

@ -81,6 +81,6 @@ class CallTest extends PHPUnit_Framework_TestCase{
} }
public function testGetPeer() { public function testGetPeer() {
$this->assertTrue($this->call->getPeer() == 'localhost:' . self::$port); $this->assertTrue(is_string($this->call->getPeer()));
} }
} }

@ -151,6 +151,6 @@ class EndToEndTest extends PHPUnit_Framework_TestCase{
} }
public function testGetTarget() { public function testGetTarget() {
$this->assertTrue($this->channel->getTarget() == 'localhost:' . $this->port); $this->assertTrue(is_string($this->channel->getTarget()));
} }
} }

Loading…
Cancel
Save