Fix handling of no new flakes

pull/12197/head
David Garcia Quintas 7 years ago
parent 4721fc0716
commit bfd9d805a1
  1. 13
      tools/flakes/detect_flakes.py

@ -68,10 +68,13 @@ ORDER BY timestamp desc
query_job = big_query_utils.sync_query_job(bq, 'grpc-testing', query) query_job = big_query_utils.sync_query_job(bq, 'grpc-testing', query)
page = bq.jobs().getQueryResults( page = bq.jobs().getQueryResults(
pageToken=None, **query_job['jobReference']).execute(num_retries=3) pageToken=None, **query_job['jobReference']).execute(num_retries=3)
testname_to_cols = {row['f'][0]['v']: rows = page.get('rows')
(row['f'][1]['v'], row['f'][2]['v'], row['f'][3]['v']) if rows:
for row in page['rows']} return {row['f'][0]['v']:
return testname_to_cols (row['f'][1]['v'], row['f'][2]['v'], row['f'][3]['v'])
for row in rows}
else:
return {}
def get_new_flakes(): def get_new_flakes():
@ -91,6 +94,8 @@ def main():
if new_flakes: if new_flakes:
print("Found {} new flakes:".format(len(new_flakes))) print("Found {} new flakes:".format(len(new_flakes)))
print_table(new_flakes) print_table(new_flakes)
else:
print("No new flakes found!")
if __name__ == '__main__': if __name__ == '__main__':

Loading…
Cancel
Save