From bc75644385af5df2db437c370ed3931e0df66fb4 Mon Sep 17 00:00:00 2001 From: Jan Tattermusch Date: Fri, 28 Sep 2018 12:07:08 +0200 Subject: [PATCH] review comments --- src/csharp/Grpc.Core/Metadata.cs | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/src/csharp/Grpc.Core/Metadata.cs b/src/csharp/Grpc.Core/Metadata.cs index b59aee7d803..bc263c34696 100644 --- a/src/csharp/Grpc.Core/Metadata.cs +++ b/src/csharp/Grpc.Core/Metadata.cs @@ -135,20 +135,16 @@ namespace Grpc.Core } /// - /// + /// Adds a new ASCII-valued metadata entry. See Metadata.Entry constructor for params. /// - /// Metadata key. Gets converted to lowercase. Must not use suffix indicating a binary valued metadata entry. Can only contain lowercase alphanumeric characters, underscores and hyphens. - /// Value string. Only ASCII characters are allowed. public void Add(string key, string value) { Add(new Entry(key, value)); } /// - /// + /// Adds a new binary-valued metadata entry. See Metadata.Entry constructor for params. /// - /// Metadata key. Gets converted to lowercase. Needs to have suffix indicating a binary valued metadata entry. Can only contain lowercase alphanumeric characters, underscores and hyphens. - /// Value bytes. public void Add(string key, byte[] valueBytes) { Add(new Entry(key, valueBytes)); @@ -243,7 +239,7 @@ namespace Grpc.Core /// /// Initializes a new instance of the struct with a binary value. /// - /// Metadata key. Gets converted to lowercase. Needs to have suffix indicating a binary valued metadata entry. Can only contain lowercase alphanumeric characters, underscores and hyphens. + /// Metadata key. Gets converted to lowercase. Needs to have suffix indicating a binary valued metadata entry. Can only contain lowercase alphanumeric characters, underscores, hyphens and dots. /// Value bytes. public Entry(string key, byte[] valueBytes) { @@ -257,9 +253,9 @@ namespace Grpc.Core } /// - /// Initializes a new instance of the struct holding an ASCII value. + /// Initializes a new instance of the struct with an ASCII value. /// - /// Metadata key. Gets converted to lowercase. Must not use suffix indicating a binary valued metadata entry. Can only contain lowercase alphanumeric characters, underscores and hyphens. + /// Metadata key. Gets converted to lowercase. Must not use suffix indicating a binary valued metadata entry. Can only contain lowercase alphanumeric characters, underscores, hyphens and dots. /// Value string. Only ASCII characters are allowed. public Entry(string key, string value) {