Add clarifying comment

pull/912/head
Craig Tiller 10 years ago
parent 45115845cc
commit bb88a048cd
  1. 6
      src/core/transport/chttp2_transport.c
  2. 2
      tools/run_tests/run_lcov.sh

@ -531,6 +531,12 @@ static void destroy_transport(grpc_transport *gt) {
drop_connection(t);
unlock(t);
/* The drop_connection() above puts the transport into an error state, and
the follow-up unlock should then (as part of the cleanup work it does)
ensure that cb is NULL, and therefore not call back anything further.
This check validates this very subtle behavior.
It's shutdown path, so I don't believe an extra lock pair is going to be
problematic for performance. */
lock(t);
GPR_ASSERT(!t->cb);
unlock(t);

@ -35,7 +35,7 @@ out=`realpath ${1:-coverage}`
root=`realpath $(dirname $0)/../..`
tmp=`mktemp`
cd $root
tools/run_tests/run_tests.py -c gcov -l c c++
tools/run_tests/run_tests.py -c gcov -l c c++ || true
lcov --capture --directory . --output-file $tmp
genhtml $tmp --output-directory $out
rm $tmp

Loading…
Cancel
Save