From bae0c705aa0b19293d646548eb8a96d46b8eecfc Mon Sep 17 00:00:00 2001 From: Yijie Ma Date: Wed, 11 Oct 2023 16:26:32 -0700 Subject: [PATCH] [Deps] Update to Clang-16 (#34492) --- .clang-tidy | 16 ++++++++++- BUILD | 3 --- fuzztest/core/channel/BUILD | 1 + fuzztest/core/channel/union_with_test.cc | 7 +++-- include/grpcpp/support/proto_buffer_reader.h | 5 +++- include/grpcpp/support/proto_buffer_writer.h | 5 +++- src/core/BUILD | 27 +++++++------------ .../channel_idle/channel_idle_filter.cc | 4 +-- .../filters/client_channel/dynamic_filters.cc | 1 - .../client_channel/lb_policy/endpoint_list.cc | 1 - .../grpclb/client_load_reporting_filter.cc | 2 -- .../client_channel/lb_policy/grpclb/grpclb.cc | 3 ++- .../outlier_detection/outlier_detection.cc | 1 + .../lb_policy/pick_first/pick_first.cc | 2 +- .../lb_policy/priority/priority.cc | 1 + .../client_channel/lb_policy/rls/rls.cc | 8 +++--- .../lb_policy/round_robin/round_robin.cc | 2 +- .../lb_policy/subchannel_list.h | 1 - .../weighted_round_robin.cc | 1 + .../weighted_target/weighted_target.cc | 1 + .../client_channel/lb_policy/xds/cds.cc | 1 - .../resolver/binder/binder_resolver.cc | 1 - .../resolver/dns/c_ares/dns_resolver_ares.cc | 1 - .../resolver/dns/c_ares/grpc_ares_wrapper.cc | 1 - .../resolver/dns/native/dns_resolver.cc | 1 - .../resolver/polling_resolver.cc | 2 +- .../resolver/xds/xds_resolver.cc | 1 - .../filters/client_channel/retry_filter.cc | 1 - .../retry_filter_legacy_call_data.cc | 1 - .../ext/filters/client_channel/subchannel.cc | 1 - .../subchannel_stream_client.cc | 1 - .../fault_injection/fault_injection_filter.cc | 1 + .../filters/http/client/http_client_filter.cc | 2 -- .../message_compress/compression_filter.cc | 4 --- .../filters/http/server/http_server_filter.cc | 2 -- .../server_load_reporting_filter.cc | 3 +-- .../ext/filters/logging/logging_filter.cc | 1 - .../message_size/message_size_filter.cc | 3 --- src/core/ext/filters/rbac/rbac_filter.cc | 1 + .../server_config_selector_filter.cc | 1 + .../stateful_session_filter.cc | 2 -- src/core/ext/gcp/metadata_query.cc | 1 - .../transport/chaotic_good/client_transport.h | 3 ++- .../chttp2/client/chttp2_connector.cc | 2 -- .../transport/chttp2/server/chttp2_server.cc | 1 - .../chttp2/transport/chttp2_transport.cc | 1 - .../chttp2/transport/flow_control.cc | 1 - .../transport/chttp2/transport/frame_data.cc | 2 -- .../chttp2/transport/frame_goaway.cc | 2 -- .../transport/chttp2/transport/frame_ping.cc | 2 -- .../chttp2/transport/frame_rst_stream.cc | 2 -- .../chttp2/transport/frame_settings.cc | 2 -- .../chttp2/transport/frame_window_update.cc | 2 -- .../chttp2/transport/hpack_parse_result.cc | 2 -- .../ext/transport/chttp2/transport/internal.h | 1 - .../chttp2/transport/ping_rate_policy.cc | 1 - .../ext/transport/chttp2/transport/writing.cc | 2 -- .../cronet/transport/cronet_transport.cc | 1 - ...le_watcher_certificate_provider_factory.cc | 1 - src/core/ext/xds/xds_api.cc | 1 - src/core/ext/xds/xds_bootstrap_grpc.cc | 1 - src/core/ext/xds/xds_client.cc | 1 + src/core/ext/xds/xds_client_stats.h | 1 - src/core/ext/xds/xds_cluster.h | 2 ++ src/core/ext/xds/xds_common_types.cc | 1 - src/core/ext/xds/xds_endpoint.cc | 2 ++ src/core/ext/xds/xds_health_status.cc | 2 ++ src/core/ext/xds/xds_http_filters.cc | 1 - src/core/ext/xds/xds_listener.cc | 4 +-- src/core/ext/xds/xds_route_config.cc | 1 - src/core/ext/xds/xds_transport_grpc.cc | 1 + src/core/lib/address_utils/sockaddr_utils.cc | 1 - src/core/lib/avl/avl.h | 1 + src/core/lib/channel/call_tracer.cc | 1 - src/core/lib/channel/channel_args.cc | 1 - .../channel/channel_args_preconditioning.cc | 1 - src/core/lib/channel/channel_trace.cc | 2 +- src/core/lib/channel/connected_channel.cc | 2 -- src/core/lib/channel/promise_based_filter.cc | 1 - src/core/lib/channel/promise_based_filter.h | 1 - .../lib/channel/server_call_tracer_filter.cc | 1 - src/core/lib/channel/status_util.cc | 1 - .../lib/compression/compression_internal.cc | 2 ++ src/core/lib/config/config_vars.cc | 1 - .../lib/config/config_vars_non_generated.cc | 2 -- src/core/lib/config/core_configuration.cc | 1 - src/core/lib/event_engine/ares_resolver.cc | 3 --- .../channel_args_endpoint_config.cc | 2 ++ src/core/lib/event_engine/event_engine.cc | 2 -- .../posix_engine/ev_epoll1_linux.cc | 1 - .../posix_engine/ev_poll_posix.cc | 1 - .../event_poller_posix_default.cc | 2 ++ .../posix_engine/internal_errqueue.cc | 2 -- .../posix_engine/posix_endpoint.h | 1 - .../event_engine/posix_engine/posix_engine.cc | 1 - .../posix_engine/tcp_socket_utils.cc | 2 -- .../posix_engine/wakeup_fd_eventfd.cc | 1 - .../posix_engine/wakeup_fd_pipe.cc | 1 - src/core/lib/event_engine/slice_buffer.cc | 1 - src/core/lib/event_engine/tcp_socket_utils.cc | 1 - .../thread_pool/work_stealing_thread_pool.cc | 2 ++ src/core/lib/gpr/alloc.cc | 1 + src/core/lib/gprpp/host_port.cc | 2 -- src/core/lib/gprpp/match.h | 2 +- src/core/lib/gprpp/posix/stat.cc | 1 - src/core/lib/gprpp/ref_counted_string.h | 2 ++ src/core/lib/gprpp/status_helper.cc | 1 - src/core/lib/gprpp/strerror.cc | 2 -- src/core/lib/gprpp/time.cc | 1 - src/core/lib/gprpp/uuid_v4.cc | 2 -- src/core/lib/gprpp/validation_errors.cc | 1 - src/core/lib/http/format_request.cc | 1 - src/core/lib/http/httpcli.cc | 2 -- src/core/lib/json/json_object_loader.h | 1 - src/core/lib/json/json_reader.cc | 1 - .../lib/load_balancing/lb_policy_registry.cc | 1 - src/core/lib/matchers/matchers.cc | 1 - src/core/lib/promise/activity.cc | 1 - src/core/lib/promise/cancel_callback.h | 2 -- src/core/lib/promise/context.h | 1 - src/core/lib/promise/detail/join_state.h | 2 -- src/core/lib/promise/detail/promise_factory.h | 1 - src/core/lib/promise/detail/seq_state.h | 1 - src/core/lib/promise/for_each.h | 2 -- src/core/lib/promise/if.h | 1 - src/core/lib/promise/interceptor_list.h | 1 - src/core/lib/promise/join.h | 1 - src/core/lib/promise/latch.h | 2 -- src/core/lib/promise/loop.h | 2 +- src/core/lib/promise/map.h | 1 - src/core/lib/promise/map_pipe.h | 1 - src/core/lib/promise/party.cc | 2 -- src/core/lib/promise/party.h | 1 - src/core/lib/promise/pipe.h | 2 -- src/core/lib/promise/prioritized_race.h | 1 - src/core/lib/promise/promise.h | 1 - src/core/lib/promise/race.h | 1 - src/core/lib/promise/seq.h | 1 - src/core/lib/promise/try_join.h | 2 +- src/core/lib/resolver/resolver_registry.cc | 2 -- .../security/authorization/audit_logging.cc | 1 - .../grpc_authorization_policy_provider.cc | 1 + .../authorization/grpc_server_authz_filter.cc | 2 +- .../lib/security/authorization/matchers.cc | 1 - .../lib/security/authorization/rbac_policy.cc | 2 -- .../security/authorization/rbac_translator.cc | 1 - .../security/authorization/stdout_logger.cc | 1 - .../credentials/alts/alts_credentials.cc | 2 -- .../composite/composite_credentials.cc | 2 +- .../aws_external_account_credentials.cc | 1 - .../external/aws_request_signer.cc | 2 -- .../external/external_account_credentials.cc | 2 -- .../url_external_account_credentials.cc | 4 +-- .../google_default_credentials.cc | 1 - .../credentials/iam/iam_credentials.cc | 1 - .../insecure/insecure_credentials.cc | 2 -- .../credentials/jwt/jwt_credentials.h | 1 - .../security/credentials/jwt/jwt_verifier.cc | 3 +-- .../credentials/local/local_credentials.cc | 2 -- .../credentials/oauth2/oauth2_credentials.h | 1 - .../credentials/plugin/plugin_credentials.cc | 1 - .../credentials/ssl/ssl_credentials.cc | 1 - .../tls/grpc_tls_certificate_distributor.cc | 2 -- .../tls/grpc_tls_credentials_options.cc | 2 ++ .../credentials/tls/tls_credentials.cc | 1 - .../lib/security/credentials/tls/tls_utils.cc | 2 ++ .../credentials/xds/xds_credentials.cc | 1 - .../fake/fake_security_connector.cc | 1 - .../ssl/ssl_security_connector.cc | 1 - .../tls/tls_security_connector.cc | 1 - .../security/transport/client_auth_filter.cc | 1 - .../security/transport/server_auth_filter.cc | 4 --- src/core/lib/surface/call.cc | 3 --- src/core/lib/surface/call_log_batch.cc | 2 -- src/core/lib/surface/call_trace.cc | 1 - src/core/lib/surface/completion_queue.cc | 1 - src/core/lib/surface/event_string.cc | 1 - src/core/lib/surface/lame_client.cc | 1 + src/core/lib/surface/server.cc | 1 - src/core/lib/transport/batch_builder.h | 1 - src/core/lib/transport/connectivity_state.cc | 2 -- src/core/lib/transport/error_utils.cc | 2 -- src/core/lib/transport/handshaker.cc | 2 -- src/core/lib/transport/metadata_batch.cc | 1 - .../lib/transport/tcp_connect_handshaker.cc | 1 - src/core/lib/transport/transport.cc | 1 + src/core/lib/transport/transport.h | 2 -- src/core/lib/transport/transport_op_string.cc | 2 -- src/core/lib/uri/uri_parser.cc | 1 - src/cpp/client/client_context.cc | 1 - src/cpp/common/tls_certificate_verifier.cc | 1 - src/cpp/ext/csm/BUILD | 2 -- src/cpp/ext/csm/metadata_exchange.cc | 2 -- src/cpp/ext/filters/census/client_filter.cc | 1 - .../ext/filters/census/server_call_tracer.cc | 3 --- src/cpp/ext/gcp/BUILD | 1 - src/cpp/ext/gcp/environment_autodetect.cc | 2 -- src/cpp/ext/gcp/observability.cc | 1 + src/cpp/ext/gcp/observability_config.h | 3 ++- src/cpp/ext/gcp/observability_logging_sink.cc | 1 - src/cpp/ext/otel/otel_client_filter.cc | 1 - src/cpp/ext/otel/otel_server_call_tracer.cc | 1 - src/cpp/server/channelz/channelz_service.cc | 2 ++ src/cpp/server/load_reporter/load_reporter.h | 2 ++ ...reporting_service_server_builder_plugin.cc | 1 - src/cpp/server/orca/orca_service.cc | 1 - src/cpp/server/secure_server_credentials.cc | 1 - src/cpp/server/server_builder.cc | 1 - src/cpp/server/server_cc.cc | 1 + src/cpp/server/server_context.cc | 2 +- src/cpp/thread_manager/thread_manager.cc | 1 - src/cpp/util/byte_buffer_cc.cc | 1 + src/cpp/util/status.cc | 2 ++ .../grpc_clang_format/Dockerfile.template | 2 +- .../grpc_clang_tidy/Dockerfile.template | 2 +- .../dockerfile/grpc_iwyu/Dockerfile.template | 4 +-- .../Dockerfile.template | 2 +- .../test/sanity/Dockerfile.template | 4 +-- .../parse_address_with_named_scope_id_test.cc | 1 - test/core/avl/avl_fuzzer.cc | 1 + test/core/avl/avl_test.cc | 2 ++ test/core/backoff/backoff_test.cc | 1 + .../backoff/random_early_detection_test.cc | 2 ++ .../core/bad_client/tests/bad_streaming_id.cc | 2 ++ .../tests/initial_settings_frame.cc | 2 -- test/core/bad_connection/close_fd_test.cc | 2 -- test/core/channel/call_tracer_test.cc | 1 - test/core/channel/channel_stack_test.cc | 2 -- test/core/channel/channelz_test.cc | 1 - .../server_call_tracer_factory_test.cc | 2 ++ .../client_channel/client_channel_test.cc | 2 ++ .../lb_policy/lb_policy_test_lib.h | 1 - ...outlier_detection_lb_config_parser_test.cc | 2 ++ .../lb_policy/rls_lb_config_parser_test.cc | 2 ++ .../lb_policy/round_robin_test.cc | 1 + .../weighted_round_robin_config_test.cc | 2 ++ .../lb_policy/weighted_round_robin_test.cc | 1 + ...xds_override_host_lb_config_parser_test.cc | 2 ++ .../resolvers/binder_resolver_test.cc | 1 - .../resolvers/fake_resolver_test.cc | 1 - .../resolvers/google_c2p_resolver_test.cc | 2 -- .../resolvers/sockaddr_resolver_test.cc | 1 - .../miscompile_with_no_unique_address_test.cc | 2 ++ test/core/compression/compression_test.cc | 2 ++ .../core/compression/message_compress_test.cc | 2 ++ test/core/config/core_configuration_test.cc | 1 - test/core/end2end/BUILD | 1 + test/core/end2end/cq_verifier.cc | 1 - test/core/end2end/dualstack_socket_test.cc | 1 - test/core/end2end/end2end_test_suites.cc | 3 +-- test/core/end2end/fuzzers/client_fuzzer.cc | 2 ++ test/core/end2end/fuzzers/fuzzing_common.cc | 2 -- test/core/end2end/fuzzers/network_input.cc | 1 - test/core/end2end/fuzzers/server_fuzzer.cc | 3 ++- test/core/end2end/tests/bad_ping.cc | 2 ++ test/core/end2end/tests/binary_metadata.cc | 2 ++ test/core/end2end/tests/call_host_override.cc | 2 ++ .../end2end/tests/cancel_before_invoke.cc | 2 ++ test/core/end2end/tests/cancel_in_a_vacuum.cc | 2 ++ test/core/end2end/tests/cancel_with_status.cc | 2 ++ test/core/end2end/tests/client_streaming.cc | 2 ++ test/core/end2end/tests/default_host.cc | 2 ++ .../core/end2end/tests/disappearing_server.cc | 2 ++ test/core/end2end/tests/empty_batch.cc | 2 ++ .../core/end2end/tests/filter_causes_close.cc | 2 ++ test/core/end2end/tests/filter_init_fails.cc | 2 ++ test/core/end2end/tests/filtered_metadata.cc | 2 ++ .../end2end/tests/graceful_server_shutdown.cc | 2 ++ test/core/end2end/tests/grpc_authz.cc | 1 - test/core/end2end/tests/high_initial_seqno.cc | 2 ++ .../end2end/tests/invoke_large_request.cc | 2 ++ test/core/end2end/tests/keepalive_timeout.cc | 2 ++ test/core/end2end/tests/large_metadata.cc | 1 - .../end2end/tests/max_concurrent_streams.cc | 2 ++ test/core/end2end/tests/max_connection_age.cc | 2 ++ .../core/end2end/tests/max_connection_idle.cc | 2 ++ test/core/end2end/tests/max_message_length.cc | 1 - test/core/end2end/tests/negative_deadline.cc | 2 ++ test/core/end2end/tests/no_logging.cc | 1 - test/core/end2end/tests/payload.cc | 2 ++ .../core/end2end/tests/ping_pong_streaming.cc | 2 ++ test/core/end2end/tests/proxy_auth.cc | 2 ++ .../end2end/tests/request_with_payload.cc | 2 ++ .../end2end/tests/resource_quota_server.cc | 1 - test/core/end2end/tests/retry.cc | 2 ++ ...retry_cancel_after_first_attempt_starts.cc | 2 ++ .../tests/retry_cancel_during_delay.cc | 1 - ...retry_cancel_with_multiple_send_batches.cc | 1 - test/core/end2end/tests/retry_disabled.cc | 2 ++ ...ry_exceeds_buffer_size_in_initial_batch.cc | 2 ++ test/core/end2end/tests/retry_lb_fail.cc | 1 + .../tests/retry_non_retriable_status.cc | 2 ++ ...ry_non_retriable_status_before_trailers.cc | 2 ++ .../tests/retry_per_attempt_recv_timeout.cc | 2 +- ...er_attempt_recv_timeout_on_last_attempt.cc | 2 +- .../tests/retry_recv_initial_metadata.cc | 3 ++- test/core/end2end/tests/retry_recv_message.cc | 2 ++ .../tests/retry_recv_message_replay.cc | 1 + .../retry_recv_trailing_metadata_error.cc | 1 + .../tests/retry_send_initial_metadata_refs.cc | 1 - .../core/end2end/tests/retry_send_op_fails.cc | 1 + .../end2end/tests/retry_send_recv_batch.cc | 2 ++ .../tests/retry_server_pushback_delay.cc | 3 ++- .../tests/retry_server_pushback_disabled.cc | 3 ++- .../tests/retry_streaming_after_commit.cc | 2 ++ ...reaming_succeeds_before_replay_finished.cc | 2 ++ test/core/end2end/tests/retry_throttled.cc | 2 ++ .../end2end/tests/retry_too_many_attempts.cc | 2 ++ .../end2end/tests/retry_transparent_goaway.cc | 1 + ...etry_transparent_max_concurrent_streams.cc | 2 ++ .../retry_transparent_not_sent_on_wire.cc | 1 + .../tests/retry_unref_before_finish.cc | 2 ++ .../end2end/tests/retry_unref_before_recv.cc | 2 ++ .../end2end/tests/server_finishes_request.cc | 2 ++ test/core/end2end/tests/server_streaming.cc | 2 ++ .../end2end/tests/shutdown_finishes_calls.cc | 2 ++ .../end2end/tests/simple_delayed_request.cc | 2 ++ test/core/end2end/tests/simple_metadata.cc | 2 ++ .../end2end/tests/streaming_error_response.cc | 2 ++ test/core/end2end/tests/trailing_metadata.cc | 2 ++ test/core/end2end/tests/write_buffering.cc | 2 ++ .../end2end/tests/write_buffering_at_end.cc | 2 ++ .../core/event_engine/common_closures_test.cc | 2 ++ .../core/event_engine/endpoint_config_test.cc | 2 ++ test/core/event_engine/forkable_test.cc | 2 ++ .../fuzzing_event_engine.h | 1 - test/core/event_engine/handle_tests.cc | 2 ++ test/core/event_engine/mock_event_engine.h | 1 - .../posix/event_poller_posix_test.cc | 2 -- .../event_engine/posix/posix_endpoint_test.cc | 1 - .../posix/posix_engine_test_utils.cc | 2 -- .../posix/posix_event_engine_connect_test.cc | 3 --- .../posix/tcp_posix_socket_utils_test.cc | 2 ++ .../event_engine/posix/timer_manager_test.cc | 1 - .../posix/traced_buffer_list_test.cc | 2 ++ test/core/event_engine/slice_buffer_test.cc | 1 + test/core/event_engine/test_init.cc | 2 ++ .../posix/oracle_event_engine_posix.cc | 1 - .../test_suite/tests/client_test.cc | 3 --- .../event_engine/test_suite/tests/dns_test.cc | 1 - .../test_suite/tests/server_test.cc | 3 --- .../test_suite/tests/timer_test.cc | 1 - .../test_suite/tools/echo_client.cc | 4 --- test/core/event_engine/thread_pool_test.cc | 1 - test/core/experiments/experiments_test.cc | 2 ++ test/core/filters/BUILD | 11 ++++---- test/core/filters/client_auth_filter_test.cc | 3 +-- .../filters/client_authority_filter_test.cc | 5 ++-- test/core/filters/filter_test_test.cc | 3 ++- test/core/gpr/alloc_test.cc | 2 ++ test/core/gpr/cpu_test.cc | 2 ++ test/core/gpr/log_test.cc | 2 ++ test/core/gpr/spinlock_test.cc | 2 ++ test/core/gpr/sync_test.cc | 2 ++ test/core/gpr/time_test.cc | 2 ++ test/core/gpr/useful_test.cc | 1 + test/core/gprpp/cpp_impl_of_test.cc | 2 ++ test/core/gprpp/dual_ref_counted_test.cc | 2 ++ test/core/gprpp/if_list_test.cc | 2 ++ test/core/gprpp/match_test.cc | 2 +- test/core/gprpp/mpscq_test.cc | 2 ++ test/core/gprpp/notification_test.cc | 1 + test/core/gprpp/ref_counted_ptr_test.cc | 2 ++ test/core/gprpp/stat_test.cc | 2 ++ test/core/gprpp/table_test.cc | 1 + test/core/gprpp/unique_type_name_test.cc | 1 - test/core/gprpp/work_serializer_test.cc | 1 - test/core/handshake/server_ssl.cc | 2 ++ test/core/http/format_request_test.cc | 2 ++ test/core/http/httpcli_test.cc | 4 +-- test/core/http/httpcli_test_util.cc | 1 + test/core/http/httpscli_test.cc | 3 +-- test/core/http/parser_test.cc | 1 - test/core/json/fuzzer.cc | 1 - test/core/memory_usage/callback_client.cc | 1 - test/core/memory_usage/callback_server.cc | 1 - test/core/memory_usage/client.cc | 1 - test/core/memory_usage/server.cc | 1 - .../network_benchmarks/low_level_ping_pong.cc | 2 -- test/core/promise/BUILD | 1 + test/core/promise/activity_test.cc | 1 + test/core/promise/cancel_callback_test.cc | 3 +++ test/core/promise/context_test.cc | 2 ++ test/core/promise/for_each_test.cc | 3 --- test/core/promise/inter_activity_pipe_test.cc | 2 ++ test/core/promise/interceptor_list_test.cc | 1 - test/core/promise/join_test.cc | 1 + test/core/promise/loop_test.cc | 3 +-- test/core/promise/map_pipe_test.cc | 3 --- test/core/promise/map_test.cc | 2 ++ test/core/promise/pipe_test.cc | 1 - test/core/promise/prioritized_race_test.cc | 2 ++ test/core/promise/promise_fuzzer.cc | 2 -- test/core/promise/promise_test.cc | 3 +++ test/core/promise/race_test.cc | 2 ++ test/core/promise/seq_test.cc | 3 --- test/core/promise/sleep_test.cc | 3 ++- test/core/promise/try_join_test.cc | 3 ++- test/core/promise/try_seq_metadata_test.cc | 2 -- test/core/promise/try_seq_test.cc | 2 -- .../resource_quota/periodic_update_test.cc | 1 - test/core/resource_quota/thread_quota_test.cc | 2 ++ test/core/slice/b64_test.cc | 2 ++ test/core/slice/percent_encoding_test.cc | 1 + test/core/slice/slice_buffer_test.cc | 1 + test/core/slice/slice_string_helpers_test.cc | 2 ++ test/core/surface/byte_buffer_reader_test.cc | 2 ++ test/core/surface/completion_queue_test.cc | 2 ++ .../completion_queue_threading_test.cc | 2 ++ test/core/surface/init_test.cc | 3 --- test/core/surface/lame_client_test.cc | 2 ++ .../surface/secure_channel_create_test.cc | 2 ++ test/core/surface/server_test.cc | 2 ++ .../chaotic_good/frame_header_test.cc | 1 - test/core/transport/chttp2/alpn_test.cc | 2 ++ .../core/transport/chttp2/bin_decoder_test.cc | 2 ++ .../core/transport/chttp2/bin_encoder_test.cc | 2 ++ .../transport/chttp2/flow_control_fuzzer.cc | 1 - .../chttp2/hpack_parser_fuzzer_test.cc | 1 - .../transport/chttp2/hpack_sync_fuzzer.cc | 1 - .../max_concurrent_streams_policy_test.cc | 2 ++ .../chttp2/ping_configuration_test.cc | 2 ++ test/core/transport/chttp2/varint_test.cc | 2 ++ .../core/transport/connectivity_state_test.cc | 1 - test/core/transport/pid_controller_test.cc | 1 + test/core/transport/status_conversion_test.cc | 2 ++ test/core/transport/timeout_encoding_test.cc | 1 - test/core/util/cmdline.cc | 1 - test/core/util/fuzzer_corpus_test.cc | 1 - test/core/util/fuzzing_channel_args.h | 2 ++ test/core/util/histogram_test.cc | 2 ++ test/core/util/osa_distance_test.cc | 2 ++ test/core/util/passthru_endpoint.cc | 1 - test/core/util/port_server_client.cc | 1 - test/core/util/port_server_client.h | 1 + test/core/util/test_config.cc | 3 --- test/core/util/test_lb_policies.cc | 1 - ...tcher_certificate_provider_factory_test.cc | 1 - .../xds/xds_audit_logger_registry_test.cc | 1 - test/core/xds/xds_bootstrap_test.cc | 1 - test/core/xds/xds_client_test.cc | 4 +-- .../xds/xds_cluster_resource_type_test.cc | 1 - test/core/xds/xds_common_types_test.cc | 1 - .../xds/xds_endpoint_resource_type_test.cc | 2 +- test/core/xds/xds_http_filters_test.cc | 2 -- .../xds/xds_listener_resource_type_test.cc | 1 - .../xds_route_config_resource_type_test.cc | 1 - test/core/xds/xds_transport_fake.cc | 2 -- test/cpp/end2end/async_end2end_test.cc | 2 +- test/cpp/interop/grpclb_fallback_test.cc | 5 ---- test/cpp/interop/observability_client.cc | 4 +++ .../observability_interop_server_bootstrap.cc | 2 ++ test/cpp/interop/xds_stats_watcher.cc | 4 ++- test/cpp/microbenchmarks/bm_chttp2_hpack.cc | 4 ++- test/cpp/qps/driver.cc | 1 - .../dockerimage_current_versions.bzl | 4 +-- .../bazelify_tests/test/portability_tests.bzl | 2 +- tools/codegen/core/experiments_compiler.py | 3 +++ tools/dockerfile/grpc_clang_format/Dockerfile | 2 +- tools/dockerfile/grpc_clang_tidy/Dockerfile | 2 +- tools/dockerfile/grpc_iwyu/Dockerfile | 4 +-- tools/dockerfile/grpc_iwyu/iwyu.sh | 12 +++------ .../test/cxx_clang_15_x64.current_version | 1 - .../test/cxx_clang_16_x64.current_version | 1 + .../Dockerfile | 2 +- tools/dockerfile/test/sanity.current_version | 2 +- tools/dockerfile/test/sanity/Dockerfile | 4 +-- tools/run_tests/run_tests.py | 6 ++--- tools/run_tests/run_tests_matrix.py | 2 +- 469 files changed, 429 insertions(+), 452 deletions(-) rename templates/tools/dockerfile/test/{cxx_clang_15_x64 => cxx_clang_16_x64}/Dockerfile.template (97%) delete mode 100644 tools/dockerfile/test/cxx_clang_15_x64.current_version create mode 100644 tools/dockerfile/test/cxx_clang_16_x64.current_version rename tools/dockerfile/test/{cxx_clang_15_x64 => cxx_clang_16_x64}/Dockerfile (98%) diff --git a/.clang-tidy b/.clang-tidy index 03f4fcd290f..70f083cec64 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -1,15 +1,24 @@ --- # Note on checks are disabled on purpose # +# - abseil-cleanup-ctad +# Requires C++17 and higher. +# # - abseil-no-namespace # https://bugs.llvm.org/show_bug.cgi?id=47947 # +# - bugprone-exception-escape +# https://github.com/llvm/llvm-project/issues/54668 (seems to be fixed in LLVM17) +# # - bugprone-reserved-identifier # Some macros need to be defined for portability purpose; e.g. _BSD_SOURCE. # # - modernize-redundant-void-arg # Some source should be strictly C99 and func(void) should be used. # +# - google-readability-casting +# https://github.com/llvm/llvm-project/issues/57959 +# # Note on checks which will be enabled in future. These are good to have but # it's not activated yet due to the existing issues with the checks. # Once those issues are clear, these checks can be enabled later. @@ -48,14 +57,17 @@ # - readability-else-after-return # - readability-implicit-bool-conversion # - readability-redundant-declaration +# - readability-redundant-string-cstr # Checks: '-*, abseil-*, + -abseil-cleanup-ctad, -abseil-no-namespace, bugprone-*, -bugprone-assignment-in-if-condition, -bugprone-branch-clone, -bugprone-easily-swappable-parameters, + -bugprone-exception-escape, -bugprone-implicit-widening-of-multiplication-result, -bugprone-infinite-loop, -bugprone-narrowing-conversions, @@ -66,6 +78,7 @@ Checks: '-*, -bugprone-too-small-loop-variable, -bugprone-unchecked-optional-access, google-*, + -google-readability-casting, -google-runtime-int, -google-runtime-references, performance-*, @@ -73,6 +86,7 @@ Checks: '-*, -performance-no-int-to-ptr, -performance-unnecessary-copy-initialization, -performance-unnecessary-value-param, + clang-diagnostic-deprecated-declarations, clang-diagnostic-deprecated-register, clang-diagnostic-expansion-to-defined, clang-diagnostic-ignored-attributes, @@ -120,7 +134,7 @@ Checks: '-*, readability-redundant-control-flow, readability-redundant-function-ptr-dereference, readability-redundant-smartptr-get, - readability-redundant-string-cstr, + -readability-redundant-string-cstr, readability-redundant-string-init, readability-simplify-boolean-expr, readability-static-definition-in-anonymous-namespace, diff --git a/BUILD b/BUILD index 6f341e1c431..3a7792f456e 100644 --- a/BUILD +++ b/BUILD @@ -2340,7 +2340,6 @@ grpc_cc_library( external_deps = [ "absl/base", "absl/base:core_headers", - "absl/meta:type_traits", "absl/status", "absl/status:statusor", "absl/strings", @@ -3163,7 +3162,6 @@ grpc_cc_library( ], external_deps = [ "absl/base:core_headers", - "absl/container:flat_hash_set", "absl/functional:any_invocable", "absl/status", "absl/status:statusor", @@ -3582,7 +3580,6 @@ grpc_cc_library( ], external_deps = [ "absl/base:core_headers", - "absl/meta:type_traits", "absl/status", "absl/status:statusor", "absl/strings", diff --git a/fuzztest/core/channel/BUILD b/fuzztest/core/channel/BUILD index fcc1948a276..e724bb743af 100644 --- a/fuzztest/core/channel/BUILD +++ b/fuzztest/core/channel/BUILD @@ -18,6 +18,7 @@ grpc_fuzz_test( name = "union_with_test", srcs = ["union_with_test.cc"], external_deps = [ + "absl/types:variant", "fuzztest", "fuzztest_main", "gtest", diff --git a/fuzztest/core/channel/union_with_test.cc b/fuzztest/core/channel/union_with_test.cc index 6e3d0a06d19..8174a3a4eb3 100644 --- a/fuzztest/core/channel/union_with_test.cc +++ b/fuzztest/core/channel/union_with_test.cc @@ -14,11 +14,14 @@ // Test to verify Fuzztest integration -#include "fuzztest/fuzztest.h" +#include +#include +#include +#include "fuzztest/fuzztest.h" #include "gtest/gtest.h" - #include "src/core/lib/channel/channel_args.h" +#include "absl/types/variant.h" namespace grpc_core { diff --git a/include/grpcpp/support/proto_buffer_reader.h b/include/grpcpp/support/proto_buffer_reader.h index e269b41a72b..dc0c29601ed 100644 --- a/include/grpcpp/support/proto_buffer_reader.h +++ b/include/grpcpp/support/proto_buffer_reader.h @@ -126,11 +126,14 @@ class ProtoBufferReader : public grpc::protobuf::io::ZeroCopyInputStream { /// Read the next `count` bytes and append it to the given Cord. // (override is conditionally omitted here to support old Protobuf which // doesn't have ReadCord method) - // NOLINTNEXTLINE(modernize-use-override) + // NOLINTBEGIN(modernize-use-override, + // clang-diagnostic-inconsistent-missing-override) virtual bool ReadCord(absl::Cord* cord, int count) #if GOOGLE_PROTOBUF_VERSION >= 4022000 override #endif + // NOLINTEND(modernize-use-override, + // clang-diagnostic-inconsistent-missing-override) { if (!status().ok()) { return false; diff --git a/include/grpcpp/support/proto_buffer_writer.h b/include/grpcpp/support/proto_buffer_writer.h index 5e1d16ed2ae..83d81060e87 100644 --- a/include/grpcpp/support/proto_buffer_writer.h +++ b/include/grpcpp/support/proto_buffer_writer.h @@ -156,11 +156,14 @@ class ProtoBufferWriter : public grpc::protobuf::io::ZeroCopyOutputStream { /// blocks of the cord, and the slices of the byte_buffer. // (override is conditionally omitted here to support old Protobuf which // doesn't have ReadCord method) - // NOLINTNEXTLINE(modernize-use-override) + // NOLINTBEGIN(modernize-use-override, + // clang-diagnostic-inconsistent-missing-override) virtual bool WriteCord(const absl::Cord& cord) #if GOOGLE_PROTOBUF_VERSION >= 4022000 override #endif + // NOLINTEND(modernize-use-override, + // clang-diagnostic-inconsistent-missing-override) { grpc_slice_buffer* buffer = slice_buffer(); size_t cur = 0; diff --git a/src/core/BUILD b/src/core/BUILD index baa411c0004..0d5ecd9eaef 100644 --- a/src/core/BUILD +++ b/src/core/BUILD @@ -414,7 +414,6 @@ grpc_cc_library( "try_seq", "//:gpr", "//:gpr_platform", - "//:grpc_trace", ], ) @@ -443,7 +442,6 @@ grpc_cc_library( "//:event_engine_base_hdrs", "//:exec_ctx", "//:gpr", - "//:grpc_trace", "//:ref_counted_ptr", ], ) @@ -633,7 +631,6 @@ grpc_cc_library( "promise_trace", "//:gpr", "//:gpr_platform", - "//:grpc_trace", ], ) @@ -706,7 +703,6 @@ grpc_cc_library( "promise_like", "promise_trace", "//:gpr", - "//:grpc_trace", ], ) @@ -833,7 +829,6 @@ grpc_cc_library( "poll", "promise_trace", "//:gpr", - "//:grpc_trace", ], ) @@ -856,7 +851,6 @@ grpc_cc_library( "promise_trace", "//:debug_location", "//:gpr", - "//:grpc_trace", ], ) @@ -883,7 +877,6 @@ grpc_cc_library( "seq", "//:debug_location", "//:gpr", - "//:grpc_trace", "//:ref_counted_ptr", ], ) @@ -955,7 +948,6 @@ grpc_cc_library( "promise_trace", "//:gpr", "//:gpr_platform", - "//:grpc_trace", ], ) @@ -1048,7 +1040,6 @@ grpc_cc_library( "absl/base:core_headers", "absl/status", "absl/status:statusor", - "absl/strings", "absl/types:optional", ], language = "c++", @@ -1904,7 +1895,6 @@ grpc_cc_library( "absl/container:flat_hash_map", "absl/functional:any_invocable", "absl/hash", - "absl/meta:type_traits", "absl/status", "absl/status:statusor", "absl/strings", @@ -2050,7 +2040,6 @@ grpc_cc_library( "absl/container:flat_hash_map", "absl/functional:any_invocable", "absl/hash", - "absl/meta:type_traits", "absl/status", "absl/status:statusor", "absl/strings", @@ -3717,6 +3706,7 @@ grpc_cc_library( ], external_deps = [ "absl/base:core_headers", + "absl/meta:type_traits", "absl/random", "absl/status", "absl/status:statusor", @@ -3852,7 +3842,6 @@ grpc_cc_library( "json_args", "json_object_loader", "latch", - "poll", "race", "service_config_parser", "slice", @@ -3881,6 +3870,7 @@ grpc_cc_library( ], external_deps = [ "absl/base:core_headers", + "absl/meta:type_traits", "absl/random", "absl/status", "absl/status:statusor", @@ -3983,7 +3973,6 @@ grpc_cc_library( "json_object_loader", "map", "pipe", - "poll", "ref_counted_string", "service_config_parser", "slice", @@ -4015,7 +4004,6 @@ grpc_cc_library( external_deps = [ "absl/base:core_headers", "absl/container:inlined_vector", - "absl/meta:type_traits", "absl/status", "absl/status:statusor", "absl/strings", @@ -4047,7 +4035,6 @@ grpc_cc_library( "lb_policy_registry", "map", "pipe", - "poll", "pollset_set", "ref_counted", "resolved_address", @@ -4857,6 +4844,7 @@ grpc_cc_library( "json_object_loader", "lb_policy", "lb_policy_factory", + "resolved_address", "subchannel_interface", "time", "useful", @@ -4932,6 +4920,7 @@ grpc_cc_library( "ext/filters/client_channel/lb_policy/round_robin/round_robin.cc", ], external_deps = [ + "absl/meta:type_traits", "absl/random", "absl/status", "absl/status:statusor", @@ -4985,6 +4974,7 @@ grpc_cc_library( ], external_deps = [ "absl/base:core_headers", + "absl/meta:type_traits", "absl/random", "absl/status", "absl/status:statusor", @@ -5052,6 +5042,7 @@ grpc_cc_library( ], external_deps = [ "absl/base:core_headers", + "absl/meta:type_traits", "absl/random", "absl/status", "absl/status:statusor", @@ -5114,6 +5105,7 @@ grpc_cc_library( "lb_policy_factory", "lb_policy_registry", "pollset_set", + "ref_counted_string", "time", "validation_errors", "//:channel_arg_names", @@ -5138,6 +5130,7 @@ grpc_cc_library( ], external_deps = [ "absl/base:core_headers", + "absl/meta:type_traits", "absl/random", "absl/status", "absl/status:statusor", @@ -5237,7 +5230,7 @@ grpc_cc_library( "//:src/cpp/server/load_reporter/constants.h", ], external_deps = [ - "absl/meta:type_traits", + "absl/container:inlined_vector", "absl/status", "absl/status:statusor", "absl/strings", @@ -5331,6 +5324,7 @@ grpc_cc_library( "time", "//:backoff", "//:debug_location", + "//:endpoint_addresses", "//:event_engine_base_hdrs", "//:exec_ctx", "//:gpr", @@ -6077,7 +6071,6 @@ grpc_cc_library( "logging_sink", "map", "pipe", - "poll", "slice", "slice_buffer", "time", diff --git a/src/core/ext/filters/channel_idle/channel_idle_filter.cc b/src/core/ext/filters/channel_idle/channel_idle_filter.cc index 64202101d6b..53961f29c5f 100644 --- a/src/core/ext/filters/channel_idle/channel_idle_filter.cc +++ b/src/core/ext/filters/channel_idle/channel_idle_filter.cc @@ -19,12 +19,11 @@ #include "src/core/ext/filters/channel_idle/channel_idle_filter.h" -#include - #include #include #include "absl/base/thread_annotations.h" +#include "absl/meta/type_traits.h" #include "absl/random/random.h" #include "absl/types/optional.h" @@ -54,6 +53,7 @@ #include "src/core/lib/surface/channel_init.h" #include "src/core/lib/surface/channel_stack_type.h" #include "src/core/lib/transport/http2_errors.h" +#include "src/core/lib/transport/metadata_batch.h" namespace grpc_core { diff --git a/src/core/ext/filters/client_channel/dynamic_filters.cc b/src/core/ext/filters/client_channel/dynamic_filters.cc index a96e2bc51b0..7572bb05221 100644 --- a/src/core/ext/filters/client_channel/dynamic_filters.cc +++ b/src/core/ext/filters/client_channel/dynamic_filters.cc @@ -21,7 +21,6 @@ #include #include -#include #include #include "absl/status/statusor.h" diff --git a/src/core/ext/filters/client_channel/lb_policy/endpoint_list.cc b/src/core/ext/filters/client_channel/lb_policy/endpoint_list.cc index bc0e0bb6ca2..2c878bb2db0 100644 --- a/src/core/ext/filters/client_channel/lb_policy/endpoint_list.cc +++ b/src/core/ext/filters/client_channel/lb_policy/endpoint_list.cc @@ -20,7 +20,6 @@ #include -#include #include #include #include diff --git a/src/core/ext/filters/client_channel/lb_policy/grpclb/client_load_reporting_filter.cc b/src/core/ext/filters/client_channel/lb_policy/grpclb/client_load_reporting_filter.cc index d9e979b7c43..a83150321a4 100644 --- a/src/core/ext/filters/client_channel/lb_policy/grpclb/client_load_reporting_filter.cc +++ b/src/core/ext/filters/client_channel/lb_policy/grpclb/client_load_reporting_filter.cc @@ -25,7 +25,6 @@ #include #include -#include "absl/meta/type_traits.h" #include "absl/types/optional.h" #include "src/core/ext/filters/client_channel/lb_policy/grpclb/grpclb_client_stats.h" @@ -34,7 +33,6 @@ #include "src/core/lib/promise/context.h" #include "src/core/lib/promise/map.h" #include "src/core/lib/promise/pipe.h" -#include "src/core/lib/promise/poll.h" #include "src/core/lib/resource_quota/arena.h" #include "src/core/lib/transport/metadata_batch.h" #include "src/core/lib/transport/transport.h" diff --git a/src/core/ext/filters/client_channel/lb_policy/grpclb/grpclb.cc b/src/core/ext/filters/client_channel/lb_policy/grpclb/grpclb.cc index 0d85f997228..b7cae78d8b3 100644 --- a/src/core/ext/filters/client_channel/lb_policy/grpclb/grpclb.cc +++ b/src/core/ext/filters/client_channel/lb_policy/grpclb/grpclb.cc @@ -64,7 +64,6 @@ #include #include -#include #include #include #include @@ -753,9 +752,11 @@ GrpcLb::PickResult GrpcLb::Picker::Pick(PickArgs args) { // The metadata value is a hack: we pretend the pointer points to // a string and rely on the client_load_reporting filter to know // how to interpret it. + // NOLINTBEGIN(bugprone-string-constructor) args.initial_metadata->Add( GrpcLbClientStatsMetadata::key(), absl::string_view(reinterpret_cast(client_stats), 0)); + // NOLINTEND(bugprone-string-constructor) // Update calls-started. client_stats->AddCallStarted(); } diff --git a/src/core/ext/filters/client_channel/lb_policy/outlier_detection/outlier_detection.cc b/src/core/ext/filters/client_channel/lb_policy/outlier_detection/outlier_detection.cc index f6c456e4689..8569f24019d 100644 --- a/src/core/ext/filters/client_channel/lb_policy/outlier_detection/outlier_detection.cc +++ b/src/core/ext/filters/client_channel/lb_policy/outlier_detection/outlier_detection.cc @@ -33,6 +33,7 @@ #include #include "absl/base/thread_annotations.h" +#include "absl/meta/type_traits.h" #include "absl/random/random.h" #include "absl/status/status.h" #include "absl/status/statusor.h" diff --git a/src/core/ext/filters/client_channel/lb_policy/pick_first/pick_first.cc b/src/core/ext/filters/client_channel/lb_policy/pick_first/pick_first.cc index 2b3ed28eec0..4775aedae51 100644 --- a/src/core/ext/filters/client_channel/lb_policy/pick_first/pick_first.cc +++ b/src/core/ext/filters/client_channel/lb_policy/pick_first/pick_first.cc @@ -23,7 +23,6 @@ #include #include -#include #include #include #include @@ -55,6 +54,7 @@ #include "src/core/lib/gprpp/work_serializer.h" #include "src/core/lib/iomgr/exec_ctx.h" #include "src/core/lib/iomgr/iomgr_fwd.h" +#include "src/core/lib/iomgr/resolved_address.h" #include "src/core/lib/json/json.h" #include "src/core/lib/json/json_args.h" #include "src/core/lib/json/json_object_loader.h" diff --git a/src/core/ext/filters/client_channel/lb_policy/priority/priority.cc b/src/core/ext/filters/client_channel/lb_policy/priority/priority.cc index 09bb347f537..e1e21072bc0 100644 --- a/src/core/ext/filters/client_channel/lb_policy/priority/priority.cc +++ b/src/core/ext/filters/client_channel/lb_policy/priority/priority.cc @@ -47,6 +47,7 @@ #include "src/core/lib/gprpp/debug_location.h" #include "src/core/lib/gprpp/orphanable.h" #include "src/core/lib/gprpp/ref_counted_ptr.h" +#include "src/core/lib/gprpp/ref_counted_string.h" #include "src/core/lib/gprpp/time.h" #include "src/core/lib/gprpp/validation_errors.h" #include "src/core/lib/gprpp/work_serializer.h" diff --git a/src/core/ext/filters/client_channel/lb_policy/rls/rls.cc b/src/core/ext/filters/client_channel/lb_policy/rls/rls.cc index dc71d4e4409..f51ef89a0be 100644 --- a/src/core/ext/filters/client_channel/lb_policy/rls/rls.cc +++ b/src/core/ext/filters/client_channel/lb_policy/rls/rls.cc @@ -28,7 +28,6 @@ #include #include -#include #include #include #include @@ -94,7 +93,6 @@ #include "src/core/lib/load_balancing/lb_policy_registry.h" #include "src/core/lib/resolver/endpoint_addresses.h" #include "src/core/lib/resolver/resolver_registry.h" -#include "src/core/lib/security/credentials/credentials.h" #include "src/core/lib/security/credentials/fake/fake_credentials.h" #include "src/core/lib/service_config/service_config_impl.h" #include "src/core/lib/slice/slice.h" @@ -902,7 +900,7 @@ std::map BuildKeyMap( auto it = key_builder_map.find(std::string(path)); if (it == key_builder_map.end()) { // Didn't find exact match, try method wildcard. - last_slash_pos = path.rfind("/"); + last_slash_pos = path.rfind('/'); GPR_DEBUG_ASSERT(last_slash_pos != path.npos); if (GPR_UNLIKELY(last_slash_pos == path.npos)) return {}; std::string service(path.substr(0, last_slash_pos + 1)); @@ -936,7 +934,7 @@ std::map BuildKeyMap( // Add service key. if (!key_builder->service_key.empty()) { if (last_slash_pos == path.npos) { - last_slash_pos = path.rfind("/"); + last_slash_pos = path.rfind('/'); GPR_DEBUG_ASSERT(last_slash_pos != path.npos); if (GPR_UNLIKELY(last_slash_pos == path.npos)) return {}; } @@ -946,7 +944,7 @@ std::map BuildKeyMap( // Add method key. if (!key_builder->method_key.empty()) { if (last_slash_pos == path.npos) { - last_slash_pos = path.rfind("/"); + last_slash_pos = path.rfind('/'); GPR_DEBUG_ASSERT(last_slash_pos != path.npos); if (GPR_UNLIKELY(last_slash_pos == path.npos)) return {}; } diff --git a/src/core/ext/filters/client_channel/lb_policy/round_robin/round_robin.cc b/src/core/ext/filters/client_channel/lb_policy/round_robin/round_robin.cc index 87d291ca858..51e89c8e5b3 100644 --- a/src/core/ext/filters/client_channel/lb_policy/round_robin/round_robin.cc +++ b/src/core/ext/filters/client_channel/lb_policy/round_robin/round_robin.cc @@ -18,7 +18,6 @@ #include #include -#include #include #include @@ -27,6 +26,7 @@ #include #include +#include "absl/meta/type_traits.h" #include "absl/random/random.h" #include "absl/status/status.h" #include "absl/status/statusor.h" diff --git a/src/core/ext/filters/client_channel/lb_policy/subchannel_list.h b/src/core/ext/filters/client_channel/lb_policy/subchannel_list.h index 47384794869..cb52ad92daa 100644 --- a/src/core/ext/filters/client_channel/lb_policy/subchannel_list.h +++ b/src/core/ext/filters/client_channel/lb_policy/subchannel_list.h @@ -23,7 +23,6 @@ #include #include -#include #include #include diff --git a/src/core/ext/filters/client_channel/lb_policy/weighted_round_robin/weighted_round_robin.cc b/src/core/ext/filters/client_channel/lb_policy/weighted_round_robin/weighted_round_robin.cc index 5c426d467a0..102cd6aa7cf 100644 --- a/src/core/ext/filters/client_channel/lb_policy/weighted_round_robin/weighted_round_robin.cc +++ b/src/core/ext/filters/client_channel/lb_policy/weighted_round_robin/weighted_round_robin.cc @@ -32,6 +32,7 @@ #include #include "absl/base/thread_annotations.h" +#include "absl/meta/type_traits.h" #include "absl/random/random.h" #include "absl/status/status.h" #include "absl/status/statusor.h" diff --git a/src/core/ext/filters/client_channel/lb_policy/weighted_target/weighted_target.cc b/src/core/ext/filters/client_channel/lb_policy/weighted_target/weighted_target.cc index fad7aa96857..eecd112445a 100644 --- a/src/core/ext/filters/client_channel/lb_policy/weighted_target/weighted_target.cc +++ b/src/core/ext/filters/client_channel/lb_policy/weighted_target/weighted_target.cc @@ -27,6 +27,7 @@ #include #include "absl/base/thread_annotations.h" +#include "absl/meta/type_traits.h" #include "absl/random/random.h" #include "absl/status/status.h" #include "absl/status/statusor.h" diff --git a/src/core/ext/filters/client_channel/lb_policy/xds/cds.cc b/src/core/ext/filters/client_channel/lb_policy/xds/cds.cc index 2aeeab3a2bf..f1278b98ae4 100644 --- a/src/core/ext/filters/client_channel/lb_policy/xds/cds.cc +++ b/src/core/ext/filters/client_channel/lb_policy/xds/cds.cc @@ -32,7 +32,6 @@ #include "absl/types/optional.h" #include "absl/types/variant.h" -#include #include #include #include diff --git a/src/core/ext/filters/client_channel/resolver/binder/binder_resolver.cc b/src/core/ext/filters/client_channel/resolver/binder/binder_resolver.cc index f0fac923155..15d7ec1eaca 100644 --- a/src/core/ext/filters/client_channel/resolver/binder/binder_resolver.cc +++ b/src/core/ext/filters/client_channel/resolver/binder/binder_resolver.cc @@ -28,7 +28,6 @@ #include #include -#include #include #include "absl/status/statusor.h" diff --git a/src/core/ext/filters/client_channel/resolver/dns/c_ares/dns_resolver_ares.cc b/src/core/ext/filters/client_channel/resolver/dns/c_ares/dns_resolver_ares.cc index c85c850a87d..dde7570eded 100644 --- a/src/core/ext/filters/client_channel/resolver/dns/c_ares/dns_resolver_ares.cc +++ b/src/core/ext/filters/client_channel/resolver/dns/c_ares/dns_resolver_ares.cc @@ -60,7 +60,6 @@ #include -#include "absl/container/flat_hash_set.h" #include "absl/strings/str_cat.h" #include "src/core/ext/filters/client_channel/lb_policy/grpclb/grpclb_balancer_addresses.h" diff --git a/src/core/ext/filters/client_channel/resolver/dns/c_ares/grpc_ares_wrapper.cc b/src/core/ext/filters/client_channel/resolver/dns/c_ares/grpc_ares_wrapper.cc index c4ffb3975a1..14dcc8814ed 100644 --- a/src/core/ext/filters/client_channel/resolver/dns/c_ares/grpc_ares_wrapper.cc +++ b/src/core/ext/filters/client_channel/resolver/dns/c_ares/grpc_ares_wrapper.cc @@ -19,7 +19,6 @@ #include #include -#include #include #include "absl/strings/string_view.h" diff --git a/src/core/ext/filters/client_channel/resolver/dns/native/dns_resolver.cc b/src/core/ext/filters/client_channel/resolver/dns/native/dns_resolver.cc index bcc6df9510e..158bd63c3f9 100644 --- a/src/core/ext/filters/client_channel/resolver/dns/native/dns_resolver.cc +++ b/src/core/ext/filters/client_channel/resolver/dns/native/dns_resolver.cc @@ -18,7 +18,6 @@ #include #include -#include #include #include diff --git a/src/core/ext/filters/client_channel/resolver/polling_resolver.cc b/src/core/ext/filters/client_channel/resolver/polling_resolver.cc index bd99aebae53..bcad27530b5 100644 --- a/src/core/ext/filters/client_channel/resolver/polling_resolver.cc +++ b/src/core/ext/filters/client_channel/resolver/polling_resolver.cc @@ -28,7 +28,6 @@ #include "absl/status/status.h" #include "absl/status/statusor.h" #include "absl/strings/str_cat.h" -#include "absl/strings/string_view.h" #include "absl/strings/strip.h" #include @@ -39,6 +38,7 @@ #include "src/core/lib/gprpp/ref_counted_ptr.h" #include "src/core/lib/gprpp/work_serializer.h" #include "src/core/lib/iomgr/exec_ctx.h" +#include "src/core/lib/resolver/endpoint_addresses.h" #include "src/core/lib/service_config/service_config.h" #include "src/core/lib/uri/uri_parser.h" diff --git a/src/core/ext/filters/client_channel/resolver/xds/xds_resolver.cc b/src/core/ext/filters/client_channel/resolver/xds/xds_resolver.cc index 7d452dce98b..58b932b8055 100644 --- a/src/core/ext/filters/client_channel/resolver/xds/xds_resolver.cc +++ b/src/core/ext/filters/client_channel/resolver/xds/xds_resolver.cc @@ -21,7 +21,6 @@ #include #include -#include #include #include #include diff --git a/src/core/ext/filters/client_channel/retry_filter.cc b/src/core/ext/filters/client_channel/retry_filter.cc index 85c2df31667..cb29fbee2a4 100644 --- a/src/core/ext/filters/client_channel/retry_filter.cc +++ b/src/core/ext/filters/client_channel/retry_filter.cc @@ -21,7 +21,6 @@ #include #include "absl/status/statusor.h" -#include "absl/strings/string_view.h" #include "absl/strings/strip.h" #include "absl/types/optional.h" diff --git a/src/core/ext/filters/client_channel/retry_filter_legacy_call_data.cc b/src/core/ext/filters/client_channel/retry_filter_legacy_call_data.cc index f1d230d0a55..649526b04fd 100644 --- a/src/core/ext/filters/client_channel/retry_filter_legacy_call_data.cc +++ b/src/core/ext/filters/client_channel/retry_filter_legacy_call_data.cc @@ -20,7 +20,6 @@ #include #include -#include #include "absl/status/status.h" #include "absl/strings/str_cat.h" diff --git a/src/core/ext/filters/client_channel/subchannel.cc b/src/core/ext/filters/client_channel/subchannel.cc index 2799ba8c25e..f6b808606be 100644 --- a/src/core/ext/filters/client_channel/subchannel.cc +++ b/src/core/ext/filters/client_channel/subchannel.cc @@ -24,7 +24,6 @@ #include #include #include -#include #include #include "absl/status/statusor.h" diff --git a/src/core/ext/filters/client_channel/subchannel_stream_client.cc b/src/core/ext/filters/client_channel/subchannel_stream_client.cc index ad51f5396f9..e40da82db6d 100644 --- a/src/core/ext/filters/client_channel/subchannel_stream_client.cc +++ b/src/core/ext/filters/client_channel/subchannel_stream_client.cc @@ -21,7 +21,6 @@ #include #include -#include #include #include diff --git a/src/core/ext/filters/fault_injection/fault_injection_filter.cc b/src/core/ext/filters/fault_injection/fault_injection_filter.cc index f1db4e22b4b..843de69bbc1 100644 --- a/src/core/ext/filters/fault_injection/fault_injection_filter.cc +++ b/src/core/ext/filters/fault_injection/fault_injection_filter.cc @@ -27,6 +27,7 @@ #include #include +#include "absl/meta/type_traits.h" #include "absl/status/status.h" #include "absl/strings/numbers.h" #include "absl/strings/str_cat.h" diff --git a/src/core/ext/filters/http/client/http_client_filter.cc b/src/core/ext/filters/http/client/http_client_filter.cc index 6ed05d95186..57847e6d79d 100644 --- a/src/core/ext/filters/http/client/http_client_filter.cc +++ b/src/core/ext/filters/http/client/http_client_filter.cc @@ -21,7 +21,6 @@ #include #include -#include #include #include #include @@ -44,7 +43,6 @@ #include "src/core/lib/promise/latch.h" #include "src/core/lib/promise/map.h" #include "src/core/lib/promise/pipe.h" -#include "src/core/lib/promise/poll.h" #include "src/core/lib/promise/race.h" #include "src/core/lib/resource_quota/arena.h" #include "src/core/lib/slice/percent_encoding.h" diff --git a/src/core/ext/filters/http/message_compress/compression_filter.cc b/src/core/ext/filters/http/message_compress/compression_filter.cc index 2fefd04bb66..b3c8d521cc9 100644 --- a/src/core/ext/filters/http/message_compress/compression_filter.cc +++ b/src/core/ext/filters/http/message_compress/compression_filter.cc @@ -19,12 +19,9 @@ #include #include -#include #include -#include #include -#include "absl/meta/type_traits.h" #include "absl/status/status.h" #include "absl/strings/str_cat.h" #include "absl/strings/str_format.h" @@ -49,7 +46,6 @@ #include "src/core/lib/promise/context.h" #include "src/core/lib/promise/latch.h" #include "src/core/lib/promise/pipe.h" -#include "src/core/lib/promise/poll.h" #include "src/core/lib/promise/prioritized_race.h" #include "src/core/lib/resource_quota/arena.h" #include "src/core/lib/slice/slice_buffer.h" diff --git a/src/core/ext/filters/http/server/http_server_filter.cc b/src/core/ext/filters/http/server/http_server_filter.cc index f9cee6987f6..2d4953dd26b 100644 --- a/src/core/ext/filters/http/server/http_server_filter.cc +++ b/src/core/ext/filters/http/server/http_server_filter.cc @@ -22,11 +22,9 @@ #include #include -#include #include #include "absl/base/attributes.h" -#include "absl/meta/type_traits.h" #include "absl/strings/string_view.h" #include "absl/types/optional.h" diff --git a/src/core/ext/filters/load_reporting/server_load_reporting_filter.cc b/src/core/ext/filters/load_reporting/server_load_reporting_filter.cc index 77575cddf1f..3730c205297 100644 --- a/src/core/ext/filters/load_reporting/server_load_reporting_filter.cc +++ b/src/core/ext/filters/load_reporting/server_load_reporting_filter.cc @@ -25,12 +25,11 @@ #include #include -#include #include #include #include -#include "absl/meta/type_traits.h" +#include "absl/container/inlined_vector.h" #include "absl/status/status.h" #include "absl/strings/ascii.h" #include "absl/strings/str_cat.h" diff --git a/src/core/ext/filters/logging/logging_filter.cc b/src/core/ext/filters/logging/logging_filter.cc index db02366fee5..2d4b6eb9a46 100644 --- a/src/core/ext/filters/logging/logging_filter.cc +++ b/src/core/ext/filters/logging/logging_filter.cc @@ -65,7 +65,6 @@ #include "src/core/lib/promise/context.h" #include "src/core/lib/promise/map.h" #include "src/core/lib/promise/pipe.h" -#include "src/core/lib/promise/poll.h" #include "src/core/lib/resolver/resolver_registry.h" #include "src/core/lib/resource_quota/arena.h" #include "src/core/lib/slice/slice.h" diff --git a/src/core/ext/filters/message_size/message_size_filter.cc b/src/core/ext/filters/message_size/message_size_filter.cc index be5505cf05a..bcf9fc567c2 100644 --- a/src/core/ext/filters/message_size/message_size_filter.cc +++ b/src/core/ext/filters/message_size/message_size_filter.cc @@ -21,8 +21,6 @@ #include #include -#include -#include #include #include "absl/strings/str_format.h" @@ -40,7 +38,6 @@ #include "src/core/lib/promise/activity.h" #include "src/core/lib/promise/context.h" #include "src/core/lib/promise/latch.h" -#include "src/core/lib/promise/poll.h" #include "src/core/lib/promise/race.h" #include "src/core/lib/resource_quota/arena.h" #include "src/core/lib/service_config/service_config_call_data.h" diff --git a/src/core/ext/filters/rbac/rbac_filter.cc b/src/core/ext/filters/rbac/rbac_filter.cc index 4f8b018208c..2e38121ca0c 100644 --- a/src/core/ext/filters/rbac/rbac_filter.cc +++ b/src/core/ext/filters/rbac/rbac_filter.cc @@ -38,6 +38,7 @@ #include "src/core/lib/security/authorization/grpc_authorization_engine.h" #include "src/core/lib/security/context/security_context.h" #include "src/core/lib/service_config/service_config_call_data.h" +#include "src/core/lib/transport/metadata_batch.h" #include "src/core/lib/transport/transport_fwd.h" #include "src/core/lib/transport/transport_impl.h" diff --git a/src/core/ext/filters/server_config_selector/server_config_selector_filter.cc b/src/core/ext/filters/server_config_selector/server_config_selector_filter.cc index 982ac991bfa..3d9a23fcc7c 100644 --- a/src/core/ext/filters/server_config_selector/server_config_selector_filter.cc +++ b/src/core/ext/filters/server_config_selector/server_config_selector_filter.cc @@ -40,6 +40,7 @@ #include "src/core/lib/resource_quota/arena.h" #include "src/core/lib/service_config/service_config.h" #include "src/core/lib/service_config/service_config_call_data.h" +#include "src/core/lib/transport/metadata_batch.h" #include "src/core/lib/transport/transport.h" namespace grpc_core { diff --git a/src/core/ext/filters/stateful_session/stateful_session_filter.cc b/src/core/ext/filters/stateful_session/stateful_session_filter.cc index ee0351bd633..4ed600937c0 100644 --- a/src/core/ext/filters/stateful_session/stateful_session_filter.cc +++ b/src/core/ext/filters/stateful_session/stateful_session_filter.cc @@ -37,7 +37,6 @@ #include "absl/types/optional.h" #include -#include #include "src/core/ext/filters/client_channel/resolver/xds/xds_resolver.h" #include "src/core/ext/filters/stateful_session/stateful_session_service_config_parser.h" @@ -50,7 +49,6 @@ #include "src/core/lib/promise/context.h" #include "src/core/lib/promise/map.h" #include "src/core/lib/promise/pipe.h" -#include "src/core/lib/promise/poll.h" #include "src/core/lib/resource_quota/arena.h" #include "src/core/lib/service_config/service_config_call_data.h" #include "src/core/lib/slice/slice.h" diff --git a/src/core/ext/gcp/metadata_query.cc b/src/core/ext/gcp/metadata_query.cc index 59a62dd0cc0..273a7732ab2 100644 --- a/src/core/ext/gcp/metadata_query.cc +++ b/src/core/ext/gcp/metadata_query.cc @@ -22,7 +22,6 @@ #include -#include #include #include diff --git a/src/core/ext/transport/chaotic_good/client_transport.h b/src/core/ext/transport/chaotic_good/client_transport.h index d8e9cca3632..4bd5a132b0c 100644 --- a/src/core/ext/transport/chaotic_good/client_transport.h +++ b/src/core/ext/transport/chaotic_good/client_transport.h @@ -39,6 +39,7 @@ #include "src/core/lib/promise/pipe.h" #include "src/core/lib/promise/seq.h" #include "src/core/lib/slice/slice_buffer.h" +#include "src/core/lib/transport/metadata_batch.h" // IWYU pragma: keep #include "src/core/lib/transport/promise_endpoint.h" #include "src/core/lib/transport/transport.h" @@ -112,4 +113,4 @@ class ClientTransport { } // namespace chaotic_good } // namespace grpc_core -#endif // GRPC_SRC_CORE_EXT_TRANSPORT_CHAOTIC_GOOD_CLIENT_TRANSPORT_H \ No newline at end of file +#endif // GRPC_SRC_CORE_EXT_TRANSPORT_CHAOTIC_GOOD_CLIENT_TRANSPORT_H diff --git a/src/core/ext/transport/chttp2/client/chttp2_connector.cc b/src/core/ext/transport/chttp2/client/chttp2_connector.cc index e720ce52ddb..92940a9a994 100644 --- a/src/core/ext/transport/chttp2/client/chttp2_connector.cc +++ b/src/core/ext/transport/chttp2/client/chttp2_connector.cc @@ -22,7 +22,6 @@ #include -#include #include #include #include @@ -33,7 +32,6 @@ #include #include -#include #include #include #include diff --git a/src/core/ext/transport/chttp2/server/chttp2_server.cc b/src/core/ext/transport/chttp2/server/chttp2_server.cc index 30e9c8562f0..a36c5685750 100644 --- a/src/core/ext/transport/chttp2/server/chttp2_server.cc +++ b/src/core/ext/transport/chttp2/server/chttp2_server.cc @@ -24,7 +24,6 @@ #include #include -#include #include #include #include diff --git a/src/core/ext/transport/chttp2/transport/chttp2_transport.cc b/src/core/ext/transport/chttp2/transport/chttp2_transport.cc index f3583339b2d..9bc9cc49cae 100644 --- a/src/core/ext/transport/chttp2/transport/chttp2_transport.cc +++ b/src/core/ext/transport/chttp2/transport/chttp2_transport.cc @@ -24,7 +24,6 @@ #include #include -#include #include #include #include diff --git a/src/core/ext/transport/chttp2/transport/flow_control.cc b/src/core/ext/transport/chttp2/transport/flow_control.cc index 175f00119cd..722063983d3 100644 --- a/src/core/ext/transport/chttp2/transport/flow_control.cc +++ b/src/core/ext/transport/chttp2/transport/flow_control.cc @@ -24,7 +24,6 @@ #include #include -#include #include #include #include diff --git a/src/core/ext/transport/chttp2/transport/frame_data.cc b/src/core/ext/transport/chttp2/transport/frame_data.cc index 0cdc7fae75a..0cead5912de 100644 --- a/src/core/ext/transport/chttp2/transport/frame_data.cc +++ b/src/core/ext/transport/chttp2/transport/frame_data.cc @@ -22,8 +22,6 @@ #include -#include - #include "absl/status/status.h" #include "absl/strings/str_format.h" diff --git a/src/core/ext/transport/chttp2/transport/frame_goaway.cc b/src/core/ext/transport/chttp2/transport/frame_goaway.cc index 03a66c18b3c..e7d1c558d4f 100644 --- a/src/core/ext/transport/chttp2/transport/frame_goaway.cc +++ b/src/core/ext/transport/chttp2/transport/frame_goaway.cc @@ -22,8 +22,6 @@ #include -#include - #include "absl/base/attributes.h" #include "absl/status/status.h" #include "absl/strings/str_format.h" diff --git a/src/core/ext/transport/chttp2/transport/frame_ping.cc b/src/core/ext/transport/chttp2/transport/frame_ping.cc index 5eeff67e4fe..f2e92a2829d 100644 --- a/src/core/ext/transport/chttp2/transport/frame_ping.cc +++ b/src/core/ext/transport/chttp2/transport/frame_ping.cc @@ -24,8 +24,6 @@ #include #include -#include -#include #include "absl/container/flat_hash_map.h" #include "absl/status/status.h" diff --git a/src/core/ext/transport/chttp2/transport/frame_rst_stream.cc b/src/core/ext/transport/chttp2/transport/frame_rst_stream.cc index 1de1ed0fe85..6c3a56ef74f 100644 --- a/src/core/ext/transport/chttp2/transport/frame_rst_stream.cc +++ b/src/core/ext/transport/chttp2/transport/frame_rst_stream.cc @@ -22,8 +22,6 @@ #include -#include - #include "absl/random/distributions.h" #include "absl/status/status.h" #include "absl/strings/str_cat.h" diff --git a/src/core/ext/transport/chttp2/transport/frame_settings.cc b/src/core/ext/transport/chttp2/transport/frame_settings.cc index 04d7177da02..e4bf9d4fdba 100644 --- a/src/core/ext/transport/chttp2/transport/frame_settings.cc +++ b/src/core/ext/transport/chttp2/transport/frame_settings.cc @@ -22,13 +22,11 @@ #include -#include #include #include "absl/base/attributes.h" #include "absl/status/status.h" #include "absl/strings/str_format.h" -#include "absl/strings/string_view.h" #include #include diff --git a/src/core/ext/transport/chttp2/transport/frame_window_update.cc b/src/core/ext/transport/chttp2/transport/frame_window_update.cc index aab8f762051..87dac6aaa92 100644 --- a/src/core/ext/transport/chttp2/transport/frame_window_update.cc +++ b/src/core/ext/transport/chttp2/transport/frame_window_update.cc @@ -22,8 +22,6 @@ #include -#include - #include "absl/status/status.h" #include "absl/strings/str_cat.h" #include "absl/strings/str_format.h" diff --git a/src/core/ext/transport/chttp2/transport/hpack_parse_result.cc b/src/core/ext/transport/chttp2/transport/hpack_parse_result.cc index cbd316931ad..9c38776b368 100644 --- a/src/core/ext/transport/chttp2/transport/hpack_parse_result.cc +++ b/src/core/ext/transport/chttp2/transport/hpack_parse_result.cc @@ -18,8 +18,6 @@ #include -#include - #include "absl/strings/str_format.h" #include "src/core/ext/transport/chttp2/transport/hpack_constants.h" diff --git a/src/core/ext/transport/chttp2/transport/internal.h b/src/core/ext/transport/chttp2/transport/internal.h index b6146cde9b9..842bc7a3ca3 100644 --- a/src/core/ext/transport/chttp2/transport/internal.h +++ b/src/core/ext/transport/chttp2/transport/internal.h @@ -28,7 +28,6 @@ #include #include "absl/container/flat_hash_map.h" -#include "absl/meta/type_traits.h" #include "absl/random/random.h" #include "absl/status/status.h" #include "absl/strings/string_view.h" diff --git a/src/core/ext/transport/chttp2/transport/ping_rate_policy.cc b/src/core/ext/transport/chttp2/transport/ping_rate_policy.cc index bfe271aaaf9..3bf1cf634bc 100644 --- a/src/core/ext/transport/chttp2/transport/ping_rate_policy.cc +++ b/src/core/ext/transport/chttp2/transport/ping_rate_policy.cc @@ -18,7 +18,6 @@ #include #include -#include #include "absl/strings/str_cat.h" #include "absl/types/optional.h" diff --git a/src/core/ext/transport/chttp2/transport/writing.cc b/src/core/ext/transport/chttp2/transport/writing.cc index 3c335852837..9405db52706 100644 --- a/src/core/ext/transport/chttp2/transport/writing.cc +++ b/src/core/ext/transport/chttp2/transport/writing.cc @@ -28,11 +28,9 @@ #include "absl/container/flat_hash_map.h" #include "absl/status/status.h" -#include "absl/strings/string_view.h" #include "absl/types/optional.h" #include -#include #include #include diff --git a/src/core/ext/transport/cronet/transport/cronet_transport.cc b/src/core/ext/transport/cronet/transport/cronet_transport.cc index 270639362a0..746476773d8 100644 --- a/src/core/ext/transport/cronet/transport/cronet_transport.cc +++ b/src/core/ext/transport/cronet/transport/cronet_transport.cc @@ -24,7 +24,6 @@ #include #include -#include #include #include #include diff --git a/src/core/ext/xds/file_watcher_certificate_provider_factory.cc b/src/core/ext/xds/file_watcher_certificate_provider_factory.cc index 8053fc6e470..3f5c17461ae 100644 --- a/src/core/ext/xds/file_watcher_certificate_provider_factory.cc +++ b/src/core/ext/xds/file_watcher_certificate_provider_factory.cc @@ -21,7 +21,6 @@ #include "src/core/ext/xds/file_watcher_certificate_provider_factory.h" #include -#include #include #include #include diff --git a/src/core/ext/xds/xds_api.cc b/src/core/ext/xds/xds_api.cc index 6da587ed9aa..8b77e30ed79 100644 --- a/src/core/ext/xds/xds_api.cc +++ b/src/core/ext/xds/xds_api.cc @@ -21,7 +21,6 @@ #include #include -#include #include #include #include diff --git a/src/core/ext/xds/xds_bootstrap_grpc.cc b/src/core/ext/xds/xds_bootstrap_grpc.cc index 20da6a7f0f2..92b27257d3b 100644 --- a/src/core/ext/xds/xds_bootstrap_grpc.cc +++ b/src/core/ext/xds/xds_bootstrap_grpc.cc @@ -21,7 +21,6 @@ #include #include -#include #include #include #include diff --git a/src/core/ext/xds/xds_client.cc b/src/core/ext/xds/xds_client.cc index a77707a89f3..19d2702a6d5 100644 --- a/src/core/ext/xds/xds_client.cc +++ b/src/core/ext/xds/xds_client.cc @@ -22,6 +22,7 @@ #include #include +#include #include #include "absl/strings/match.h" diff --git a/src/core/ext/xds/xds_client_stats.h b/src/core/ext/xds/xds_client_stats.h index 2b9aba9b134..24c96f06d76 100644 --- a/src/core/ext/xds/xds_client_stats.h +++ b/src/core/ext/xds/xds_client_stats.h @@ -23,7 +23,6 @@ #include #include -#include #include #include #include diff --git a/src/core/ext/xds/xds_cluster.h b/src/core/ext/xds/xds_cluster.h index aa3ac67baec..efdc606f8c4 100644 --- a/src/core/ext/xds/xds_cluster.h +++ b/src/core/ext/xds/xds_cluster.h @@ -33,6 +33,8 @@ #include "envoy/extensions/transport_sockets/tls/v3/tls.upbdefs.h" #include "upb/reflection/def.h" +#include + #include "src/core/ext/filters/client_channel/lb_policy/outlier_detection/outlier_detection.h" #include "src/core/ext/xds/xds_bootstrap.h" #include "src/core/ext/xds/xds_bootstrap_grpc.h" diff --git a/src/core/ext/xds/xds_common_types.cc b/src/core/ext/xds/xds_common_types.cc index 73985d17258..f3d5c087d39 100644 --- a/src/core/ext/xds/xds_common_types.cc +++ b/src/core/ext/xds/xds_common_types.cc @@ -22,7 +22,6 @@ #include #include -#include #include #include diff --git a/src/core/ext/xds/xds_endpoint.cc b/src/core/ext/xds/xds_endpoint.cc index 2fb3babbf3b..7ac79519ea5 100644 --- a/src/core/ext/xds/xds_endpoint.cc +++ b/src/core/ext/xds/xds_endpoint.cc @@ -55,6 +55,8 @@ #include "src/core/lib/gprpp/validation_errors.h" #include "src/core/lib/iomgr/resolved_address.h" +// IWYU pragma: no_include "absl/meta/type_traits.h" + namespace grpc_core { namespace { diff --git a/src/core/ext/xds/xds_health_status.cc b/src/core/ext/xds/xds_health_status.cc index 8626a6f46f6..57f719f26cd 100644 --- a/src/core/ext/xds/xds_health_status.cc +++ b/src/core/ext/xds/xds_health_status.cc @@ -18,6 +18,8 @@ #include "src/core/ext/xds/xds_health_status.h" +#include + #include "envoy/config/core/v3/health_check.upb.h" namespace grpc_core { diff --git a/src/core/ext/xds/xds_http_filters.cc b/src/core/ext/xds/xds_http_filters.cc index d773e9908bc..b724b5facdd 100644 --- a/src/core/ext/xds/xds_http_filters.cc +++ b/src/core/ext/xds/xds_http_filters.cc @@ -18,7 +18,6 @@ #include "src/core/ext/xds/xds_http_filters.h" -#include #include #include #include diff --git a/src/core/ext/xds/xds_listener.cc b/src/core/ext/xds/xds_listener.cc index c4b12f53883..08b30ecbc07 100644 --- a/src/core/ext/xds/xds_listener.cc +++ b/src/core/ext/xds/xds_listener.cc @@ -20,7 +20,6 @@ #include -#include #include #include @@ -37,7 +36,6 @@ #include "envoy/config/listener/v3/listener.upb.h" #include "envoy/config/listener/v3/listener.upbdefs.h" #include "envoy/config/listener/v3/listener_components.upb.h" -#include "envoy/config/rbac/v3/rbac.upb.h" #include "envoy/config/route/v3/route.upb.h" #include "envoy/extensions/filters/network/http_connection_manager/v3/http_connection_manager.upb.h" #include "envoy/extensions/filters/network/http_connection_manager/v3/http_connection_manager.upbdefs.h" @@ -45,7 +43,6 @@ #include "google/protobuf/any.upb.h" #include "google/protobuf/duration.upb.h" #include "google/protobuf/wrappers.upb.h" -#include "upb/base/string_view.h" #include "upb/text/encode.h" #include @@ -60,6 +57,7 @@ #include "src/core/lib/gprpp/match.h" #include "src/core/lib/gprpp/validation_errors.h" #include "src/core/lib/iomgr/sockaddr.h" +#include "src/core/lib/matchers/matchers.h" namespace grpc_core { diff --git a/src/core/ext/xds/xds_route_config.cc b/src/core/ext/xds/xds_route_config.cc index 178757fbd59..6ac99572604 100644 --- a/src/core/ext/xds/xds_route_config.cc +++ b/src/core/ext/xds/xds_route_config.cc @@ -21,7 +21,6 @@ #include #include -#include #include #include #include diff --git a/src/core/ext/xds/xds_transport_grpc.cc b/src/core/ext/xds/xds_transport_grpc.cc index 844e570ada8..5ac9b38b823 100644 --- a/src/core/ext/xds/xds_transport_grpc.cc +++ b/src/core/ext/xds/xds_transport_grpc.cc @@ -22,6 +22,7 @@ #include #include +#include #include #include "absl/strings/str_cat.h" diff --git a/src/core/lib/address_utils/sockaddr_utils.cc b/src/core/lib/address_utils/sockaddr_utils.cc index 74bc7d29b1f..a1442afe5da 100644 --- a/src/core/lib/address_utils/sockaddr_utils.cc +++ b/src/core/lib/address_utils/sockaddr_utils.cc @@ -27,7 +27,6 @@ #endif #include -#include #include #include diff --git a/src/core/lib/avl/avl.h b/src/core/lib/avl/avl.h index 269bdb85c70..4df3a0c1e4a 100644 --- a/src/core/lib/avl/avl.h +++ b/src/core/lib/avl/avl.h @@ -20,6 +20,7 @@ #include #include // IWYU pragma: keep +#include #include #include "src/core/lib/gpr/useful.h" diff --git a/src/core/lib/channel/call_tracer.cc b/src/core/lib/channel/call_tracer.cc index 9763b89469f..d45f62da860 100644 --- a/src/core/lib/channel/call_tracer.cc +++ b/src/core/lib/channel/call_tracer.cc @@ -20,7 +20,6 @@ #include "src/core/lib/channel/call_tracer.h" -#include #include #include diff --git a/src/core/lib/channel/channel_args.cc b/src/core/lib/channel/channel_args.cc index 3d8c04c3456..95010e332f0 100644 --- a/src/core/lib/channel/channel_args.cc +++ b/src/core/lib/channel/channel_args.cc @@ -25,7 +25,6 @@ #include #include -#include #include #include #include diff --git a/src/core/lib/channel/channel_args_preconditioning.cc b/src/core/lib/channel/channel_args_preconditioning.cc index a251be38a10..1fe51ad6879 100644 --- a/src/core/lib/channel/channel_args_preconditioning.cc +++ b/src/core/lib/channel/channel_args_preconditioning.cc @@ -16,7 +16,6 @@ #include "src/core/lib/channel/channel_args_preconditioning.h" -#include #include namespace grpc_core { diff --git a/src/core/lib/channel/channel_trace.cc b/src/core/lib/channel/channel_trace.cc index aa7913f1e55..4ba57020dc8 100644 --- a/src/core/lib/channel/channel_trace.cc +++ b/src/core/lib/channel/channel_trace.cc @@ -20,7 +20,7 @@ #include "src/core/lib/channel/channel_trace.h" -#include +#include #include #include "absl/strings/str_cat.h" diff --git a/src/core/lib/channel/connected_channel.cc b/src/core/lib/channel/connected_channel.cc index 7cf9423f4e7..d70d0e82ac6 100644 --- a/src/core/lib/channel/connected_channel.cc +++ b/src/core/lib/channel/connected_channel.cc @@ -23,7 +23,6 @@ #include #include -#include #include #include #include @@ -32,7 +31,6 @@ #include "absl/status/status.h" #include "absl/status/statusor.h" #include "absl/types/optional.h" -#include "absl/types/variant.h" #include #include diff --git a/src/core/lib/channel/promise_based_filter.cc b/src/core/lib/channel/promise_based_filter.cc index 67c6700d6fb..2000daf9402 100644 --- a/src/core/lib/channel/promise_based_filter.cc +++ b/src/core/lib/channel/promise_based_filter.cc @@ -17,7 +17,6 @@ #include "src/core/lib/channel/promise_based_filter.h" #include -#include #include #include #include diff --git a/src/core/lib/channel/promise_based_filter.h b/src/core/lib/channel/promise_based_filter.h index fc5839e66bb..19efe505db2 100644 --- a/src/core/lib/channel/promise_based_filter.h +++ b/src/core/lib/channel/promise_based_filter.h @@ -25,7 +25,6 @@ #include #include -#include #include #include #include diff --git a/src/core/lib/channel/server_call_tracer_filter.cc b/src/core/lib/channel/server_call_tracer_filter.cc index 893f33e4e5b..680ca145d25 100644 --- a/src/core/lib/channel/server_call_tracer_filter.cc +++ b/src/core/lib/channel/server_call_tracer_filter.cc @@ -36,7 +36,6 @@ #include "src/core/lib/promise/context.h" #include "src/core/lib/promise/map.h" #include "src/core/lib/promise/pipe.h" -#include "src/core/lib/promise/poll.h" #include "src/core/lib/surface/channel_init.h" #include "src/core/lib/surface/channel_stack_type.h" #include "src/core/lib/transport/transport.h" diff --git a/src/core/lib/channel/status_util.cc b/src/core/lib/channel/status_util.cc index bd6bb3845e3..742043a00f1 100644 --- a/src/core/lib/channel/status_util.cc +++ b/src/core/lib/channel/status_util.cc @@ -22,7 +22,6 @@ #include -#include #include #include "absl/strings/str_cat.h" diff --git a/src/core/lib/compression/compression_internal.cc b/src/core/lib/compression/compression_internal.cc index 6b18915b668..426909eb8d9 100644 --- a/src/core/lib/compression/compression_internal.cc +++ b/src/core/lib/compression/compression_internal.cc @@ -22,6 +22,8 @@ #include +#include + #include "absl/container/inlined_vector.h" #include "absl/strings/ascii.h" #include "absl/strings/str_format.h" diff --git a/src/core/lib/config/config_vars.cc b/src/core/lib/config/config_vars.cc index b00017c763d..75b56d344c7 100644 --- a/src/core/lib/config/config_vars.cc +++ b/src/core/lib/config/config_vars.cc @@ -20,7 +20,6 @@ #include "src/core/lib/config/config_vars.h" -#include #include #include "absl/flags/flag.h" diff --git a/src/core/lib/config/config_vars_non_generated.cc b/src/core/lib/config/config_vars_non_generated.cc index 2261d968680..78af08c1d8d 100644 --- a/src/core/lib/config/config_vars_non_generated.cc +++ b/src/core/lib/config/config_vars_non_generated.cc @@ -14,8 +14,6 @@ #include -#include - #include #include diff --git a/src/core/lib/config/core_configuration.cc b/src/core/lib/config/core_configuration.cc index 7ae1b099d52..782b0621154 100644 --- a/src/core/lib/config/core_configuration.cc +++ b/src/core/lib/config/core_configuration.cc @@ -16,7 +16,6 @@ #include "src/core/lib/config/core_configuration.h" -#include #include #include #include diff --git a/src/core/lib/event_engine/ares_resolver.cc b/src/core/lib/event_engine/ares_resolver.cc index 7e6160e1299..08ab6185a35 100644 --- a/src/core/lib/event_engine/ares_resolver.cc +++ b/src/core/lib/event_engine/ares_resolver.cc @@ -15,8 +15,6 @@ #include "src/core/lib/event_engine/ares_resolver.h" -#include - #include #include @@ -47,7 +45,6 @@ #include #include -#include #include #include #include diff --git a/src/core/lib/event_engine/channel_args_endpoint_config.cc b/src/core/lib/event_engine/channel_args_endpoint_config.cc index 7541d8327c9..df8e56e29dd 100644 --- a/src/core/lib/event_engine/channel_args_endpoint_config.cc +++ b/src/core/lib/event_engine/channel_args_endpoint_config.cc @@ -15,6 +15,8 @@ #include "src/core/lib/event_engine/channel_args_endpoint_config.h" +#include + #include "absl/types/optional.h" #include diff --git a/src/core/lib/event_engine/event_engine.cc b/src/core/lib/event_engine/event_engine.cc index 7ef2333f97f..af39b46cc31 100644 --- a/src/core/lib/event_engine/event_engine.cc +++ b/src/core/lib/event_engine/event_engine.cc @@ -13,8 +13,6 @@ // limitations under the License. #include -#include - #include namespace grpc_event_engine { diff --git a/src/core/lib/event_engine/posix_engine/ev_epoll1_linux.cc b/src/core/lib/event_engine/posix_engine/ev_epoll1_linux.cc index 7155ee1609f..a159cbb6101 100644 --- a/src/core/lib/event_engine/posix_engine/ev_epoll1_linux.cc +++ b/src/core/lib/event_engine/posix_engine/ev_epoll1_linux.cc @@ -18,7 +18,6 @@ #include #include -#include #include #include "absl/status/status.h" diff --git a/src/core/lib/event_engine/posix_engine/ev_poll_posix.cc b/src/core/lib/event_engine/posix_engine/ev_poll_posix.cc index 56fd15c26f0..57c7e6ec6a6 100644 --- a/src/core/lib/event_engine/posix_engine/ev_poll_posix.cc +++ b/src/core/lib/event_engine/posix_engine/ev_poll_posix.cc @@ -19,7 +19,6 @@ #include #include -#include #include #include #include diff --git a/src/core/lib/event_engine/posix_engine/event_poller_posix_default.cc b/src/core/lib/event_engine/posix_engine/event_poller_posix_default.cc index 89853899f91..c028d62b7a7 100644 --- a/src/core/lib/event_engine/posix_engine/event_poller_posix_default.cc +++ b/src/core/lib/event_engine/posix_engine/event_poller_posix_default.cc @@ -14,6 +14,8 @@ #include +#include + #include "absl/strings/str_split.h" #include "absl/strings/string_view.h" diff --git a/src/core/lib/event_engine/posix_engine/internal_errqueue.cc b/src/core/lib/event_engine/posix_engine/internal_errqueue.cc index 81114f0852e..dfe22a73819 100644 --- a/src/core/lib/event_engine/posix_engine/internal_errqueue.cc +++ b/src/core/lib/event_engine/posix_engine/internal_errqueue.cc @@ -16,8 +16,6 @@ #include "src/core/lib/event_engine/posix_engine/internal_errqueue.h" -#include - #include #include "src/core/lib/iomgr/port.h" diff --git a/src/core/lib/event_engine/posix_engine/posix_endpoint.h b/src/core/lib/event_engine/posix_engine/posix_endpoint.h index 3e8f6162601..854d4576e8d 100644 --- a/src/core/lib/event_engine/posix_engine/posix_endpoint.h +++ b/src/core/lib/event_engine/posix_engine/posix_endpoint.h @@ -29,7 +29,6 @@ #include "absl/container/flat_hash_map.h" #include "absl/functional/any_invocable.h" #include "absl/hash/hash.h" -#include "absl/meta/type_traits.h" #include "absl/status/status.h" #include "absl/status/statusor.h" diff --git a/src/core/lib/event_engine/posix_engine/posix_engine.cc b/src/core/lib/event_engine/posix_engine/posix_engine.cc index 013d5c24b4c..e373b1d6ebf 100644 --- a/src/core/lib/event_engine/posix_engine/posix_engine.cc +++ b/src/core/lib/event_engine/posix_engine/posix_engine.cc @@ -27,7 +27,6 @@ #include "absl/cleanup/cleanup.h" #include "absl/functional/any_invocable.h" -#include "absl/meta/type_traits.h" #include "absl/status/status.h" #include "absl/strings/str_cat.h" diff --git a/src/core/lib/event_engine/posix_engine/tcp_socket_utils.cc b/src/core/lib/event_engine/posix_engine/tcp_socket_utils.cc index ab94d95faf8..845e48cdf41 100644 --- a/src/core/lib/event_engine/posix_engine/tcp_socket_utils.cc +++ b/src/core/lib/event_engine/posix_engine/tcp_socket_utils.cc @@ -17,13 +17,11 @@ #include "src/core/lib/event_engine/posix_engine/tcp_socket_utils.h" #include -#include #include #include "absl/cleanup/cleanup.h" #include "absl/status/statusor.h" #include "absl/strings/str_cat.h" -#include "absl/strings/string_view.h" #include "absl/types/optional.h" #include diff --git a/src/core/lib/event_engine/posix_engine/wakeup_fd_eventfd.cc b/src/core/lib/event_engine/posix_engine/wakeup_fd_eventfd.cc index 2a24d6a5d50..e7b2016ee25 100644 --- a/src/core/lib/event_engine/posix_engine/wakeup_fd_eventfd.cc +++ b/src/core/lib/event_engine/posix_engine/wakeup_fd_eventfd.cc @@ -17,7 +17,6 @@ #include #include "absl/strings/str_cat.h" -#include "absl/strings/string_view.h" #include "src/core/lib/gprpp/crash.h" // IWYU pragma: keep #include "src/core/lib/iomgr/port.h" diff --git a/src/core/lib/event_engine/posix_engine/wakeup_fd_pipe.cc b/src/core/lib/event_engine/posix_engine/wakeup_fd_pipe.cc index 8901bf570a0..81ad04876c8 100644 --- a/src/core/lib/event_engine/posix_engine/wakeup_fd_pipe.cc +++ b/src/core/lib/event_engine/posix_engine/wakeup_fd_pipe.cc @@ -18,7 +18,6 @@ #include #include "absl/strings/str_cat.h" -#include "absl/strings/string_view.h" #include "src/core/lib/gprpp/crash.h" // IWYU pragma: keep #include "src/core/lib/iomgr/port.h" diff --git a/src/core/lib/event_engine/slice_buffer.cc b/src/core/lib/event_engine/slice_buffer.cc index f739f7e95b9..04d711904fe 100644 --- a/src/core/lib/event_engine/slice_buffer.cc +++ b/src/core/lib/event_engine/slice_buffer.cc @@ -18,7 +18,6 @@ #include #include -#include #include #include "src/core/lib/slice/slice.h" diff --git a/src/core/lib/event_engine/tcp_socket_utils.cc b/src/core/lib/event_engine/tcp_socket_utils.cc index bc6f939556f..a5fa15223d1 100644 --- a/src/core/lib/event_engine/tcp_socket_utils.cc +++ b/src/core/lib/event_engine/tcp_socket_utils.cc @@ -45,7 +45,6 @@ #include #include -#include #include #include "absl/status/status.h" diff --git a/src/core/lib/event_engine/thread_pool/work_stealing_thread_pool.cc b/src/core/lib/event_engine/thread_pool/work_stealing_thread_pool.cc index 1943c8e841a..efd3f86c60b 100644 --- a/src/core/lib/event_engine/thread_pool/work_stealing_thread_pool.cc +++ b/src/core/lib/event_engine/thread_pool/work_stealing_thread_pool.cc @@ -42,6 +42,8 @@ #include "src/core/lib/gprpp/thd.h" #include "src/core/lib/gprpp/time.h" +// IWYU pragma: no_include + // ## Thread Pool Fork-handling // // Thread-safety needs special attention with regard to fork() calls. The diff --git a/src/core/lib/gpr/alloc.cc b/src/core/lib/gpr/alloc.cc index 7d0f7eb36d5..67e07f81f09 100644 --- a/src/core/lib/gpr/alloc.cc +++ b/src/core/lib/gpr/alloc.cc @@ -50,6 +50,7 @@ void gpr_free(void* p) { free(p); } void* gpr_realloc(void* p, size_t size) { if ((size == 0) && (p == nullptr)) return nullptr; + // NOLINTNEXTLINE(bugprone-suspicious-realloc-usage) p = realloc(p, size); if (!p) { abort(); diff --git a/src/core/lib/gprpp/host_port.cc b/src/core/lib/gprpp/host_port.cc index 4e19c39a8d2..47404626f97 100644 --- a/src/core/lib/gprpp/host_port.cc +++ b/src/core/lib/gprpp/host_port.cc @@ -22,8 +22,6 @@ #include -#include - #include "absl/strings/str_format.h" #include "absl/strings/string_view.h" diff --git a/src/core/lib/gprpp/match.h b/src/core/lib/gprpp/match.h index 5b210207f33..510e653f490 100644 --- a/src/core/lib/gprpp/match.h +++ b/src/core/lib/gprpp/match.h @@ -17,7 +17,7 @@ #include -#include +#include #include "absl/types/variant.h" diff --git a/src/core/lib/gprpp/posix/stat.cc b/src/core/lib/gprpp/posix/stat.cc index 4212ea991d4..d0a8ada998e 100644 --- a/src/core/lib/gprpp/posix/stat.cc +++ b/src/core/lib/gprpp/posix/stat.cc @@ -21,7 +21,6 @@ // IWYU pragma: no_include #include "absl/status/status.h" -#include "absl/strings/string_view.h" #ifdef GPR_POSIX_STAT diff --git a/src/core/lib/gprpp/ref_counted_string.h b/src/core/lib/gprpp/ref_counted_string.h index 8bcdb87eea9..62fb15ded98 100644 --- a/src/core/lib/gprpp/ref_counted_string.h +++ b/src/core/lib/gprpp/ref_counted_string.h @@ -21,6 +21,8 @@ #include +#include + #include "absl/strings/string_view.h" #include "src/core/lib/gprpp/ref_counted.h" diff --git a/src/core/lib/gprpp/status_helper.cc b/src/core/lib/gprpp/status_helper.cc index bb6c84e81b9..a7b7dda8eca 100644 --- a/src/core/lib/gprpp/status_helper.cc +++ b/src/core/lib/gprpp/status_helper.cc @@ -22,7 +22,6 @@ #include -#include #include #include "absl/strings/cord.h" diff --git a/src/core/lib/gprpp/strerror.cc b/src/core/lib/gprpp/strerror.cc index d2d3e9f9269..021e61ba48f 100644 --- a/src/core/lib/gprpp/strerror.cc +++ b/src/core/lib/gprpp/strerror.cc @@ -18,8 +18,6 @@ #include -#include - #include "absl/strings/str_format.h" namespace grpc_core { diff --git a/src/core/lib/gprpp/time.cc b/src/core/lib/gprpp/time.cc index 40ba366c574..ba04e3347fd 100644 --- a/src/core/lib/gprpp/time.cc +++ b/src/core/lib/gprpp/time.cc @@ -18,7 +18,6 @@ #include #include -#include #include #include #include diff --git a/src/core/lib/gprpp/uuid_v4.cc b/src/core/lib/gprpp/uuid_v4.cc index ee98556f94e..5c3f3cd8e36 100644 --- a/src/core/lib/gprpp/uuid_v4.cc +++ b/src/core/lib/gprpp/uuid_v4.cc @@ -20,8 +20,6 @@ #include "src/core/lib/gprpp/uuid_v4.h" -#include - #include "absl/strings/str_format.h" namespace grpc_core { diff --git a/src/core/lib/gprpp/validation_errors.cc b/src/core/lib/gprpp/validation_errors.cc index d6fecce934b..fd6402e0f35 100644 --- a/src/core/lib/gprpp/validation_errors.cc +++ b/src/core/lib/gprpp/validation_errors.cc @@ -16,7 +16,6 @@ #include "src/core/lib/gprpp/validation_errors.h" -#include #include #include "absl/status/status.h" diff --git a/src/core/lib/http/format_request.cc b/src/core/lib/http/format_request.cc index 053bc1c4dcd..ec0862cb48f 100644 --- a/src/core/lib/http/format_request.cc +++ b/src/core/lib/http/format_request.cc @@ -24,7 +24,6 @@ #include #include -#include #include #include diff --git a/src/core/lib/http/httpcli.cc b/src/core/lib/http/httpcli.cc index 9691889cf98..153a2776896 100644 --- a/src/core/lib/http/httpcli.cc +++ b/src/core/lib/http/httpcli.cc @@ -22,7 +22,6 @@ #include -#include #include #include @@ -31,7 +30,6 @@ #include "absl/strings/str_format.h" #include -#include #include #include #include diff --git a/src/core/lib/json/json_object_loader.h b/src/core/lib/json/json_object_loader.h index 45bbc087f97..ba5f3c68fe5 100644 --- a/src/core/lib/json/json_object_loader.h +++ b/src/core/lib/json/json_object_loader.h @@ -22,7 +22,6 @@ #include #include #include -#include #include #include "absl/meta/type_traits.h" diff --git a/src/core/lib/json/json_reader.cc b/src/core/lib/json/json_reader.cc index a7fda444c63..9152c25ef7c 100644 --- a/src/core/lib/json/json_reader.cc +++ b/src/core/lib/json/json_reader.cc @@ -20,7 +20,6 @@ #include #include -#include #include #include #include diff --git a/src/core/lib/load_balancing/lb_policy_registry.cc b/src/core/lib/load_balancing/lb_policy_registry.cc index d1b2121af3b..6d6c15eb4b2 100644 --- a/src/core/lib/load_balancing/lb_policy_registry.cc +++ b/src/core/lib/load_balancing/lb_policy_registry.cc @@ -19,7 +19,6 @@ #include "src/core/lib/load_balancing/lb_policy_registry.h" #include -#include #include #include #include diff --git a/src/core/lib/matchers/matchers.cc b/src/core/lib/matchers/matchers.cc index 0b165fa82f2..406b9c00f35 100644 --- a/src/core/lib/matchers/matchers.cc +++ b/src/core/lib/matchers/matchers.cc @@ -16,7 +16,6 @@ #include "src/core/lib/matchers/matchers.h" -#include #include #include "absl/status/status.h" diff --git a/src/core/lib/promise/activity.cc b/src/core/lib/promise/activity.cc index 9bdf87733ac..7beaeb1c704 100644 --- a/src/core/lib/promise/activity.cc +++ b/src/core/lib/promise/activity.cc @@ -18,7 +18,6 @@ #include -#include #include #include "absl/strings/str_cat.h" diff --git a/src/core/lib/promise/cancel_callback.h b/src/core/lib/promise/cancel_callback.h index 9e2e5bed672..f4f002b8f37 100644 --- a/src/core/lib/promise/cancel_callback.h +++ b/src/core/lib/promise/cancel_callback.h @@ -17,8 +17,6 @@ #include -#include - #include "src/core/lib/promise/detail/promise_like.h" namespace grpc_core { diff --git a/src/core/lib/promise/context.h b/src/core/lib/promise/context.h index d730407e9ba..594c2d911fc 100644 --- a/src/core/lib/promise/context.h +++ b/src/core/lib/promise/context.h @@ -17,7 +17,6 @@ #include -#include #include #include diff --git a/src/core/lib/promise/detail/join_state.h b/src/core/lib/promise/detail/join_state.h index 84a3f37188b..1fbadd4372d 100644 --- a/src/core/lib/promise/detail/join_state.h +++ b/src/core/lib/promise/detail/join_state.h @@ -20,12 +20,10 @@ #include #include -#include #include #include -#include "src/core/lib/debug/trace.h" #include "src/core/lib/gprpp/bitset.h" #include "src/core/lib/gprpp/construct_destruct.h" #include "src/core/lib/promise/detail/promise_like.h" diff --git a/src/core/lib/promise/detail/promise_factory.h b/src/core/lib/promise/detail/promise_factory.h index 127819598a2..d278a650782 100644 --- a/src/core/lib/promise/detail/promise_factory.h +++ b/src/core/lib/promise/detail/promise_factory.h @@ -18,7 +18,6 @@ #include #include -#include #include #include "absl/meta/type_traits.h" diff --git a/src/core/lib/promise/detail/seq_state.h b/src/core/lib/promise/detail/seq_state.h index 5ee32418a53..18616a942b1 100644 --- a/src/core/lib/promise/detail/seq_state.h +++ b/src/core/lib/promise/detail/seq_state.h @@ -27,7 +27,6 @@ #include -#include "src/core/lib/debug/trace.h" #include "src/core/lib/gprpp/construct_destruct.h" #include "src/core/lib/promise/detail/promise_factory.h" #include "src/core/lib/promise/detail/promise_like.h" diff --git a/src/core/lib/promise/for_each.h b/src/core/lib/promise/for_each.h index d681b6cc416..1e6a8294312 100644 --- a/src/core/lib/promise/for_each.h +++ b/src/core/lib/promise/for_each.h @@ -20,7 +20,6 @@ #include #include -#include #include #include "absl/status/status.h" @@ -28,7 +27,6 @@ #include -#include "src/core/lib/debug/trace.h" #include "src/core/lib/gprpp/construct_destruct.h" #include "src/core/lib/promise/activity.h" #include "src/core/lib/promise/detail/promise_factory.h" diff --git a/src/core/lib/promise/if.h b/src/core/lib/promise/if.h index 22956a2f72d..e659ad30ed8 100644 --- a/src/core/lib/promise/if.h +++ b/src/core/lib/promise/if.h @@ -18,7 +18,6 @@ #include #include -#include #include #include "absl/status/statusor.h" diff --git a/src/core/lib/promise/interceptor_list.h b/src/core/lib/promise/interceptor_list.h index 1e460b9c145..0b81216fddd 100644 --- a/src/core/lib/promise/interceptor_list.h +++ b/src/core/lib/promise/interceptor_list.h @@ -30,7 +30,6 @@ #include -#include "src/core/lib/debug/trace.h" #include "src/core/lib/gprpp/construct_destruct.h" #include "src/core/lib/gprpp/debug_location.h" #include "src/core/lib/promise/context.h" diff --git a/src/core/lib/promise/join.h b/src/core/lib/promise/join.h index 370cb6d2943..014fe4ac296 100644 --- a/src/core/lib/promise/join.h +++ b/src/core/lib/promise/join.h @@ -20,7 +20,6 @@ #include #include -#include #include "absl/meta/type_traits.h" diff --git a/src/core/lib/promise/latch.h b/src/core/lib/promise/latch.h index 914a61acb53..a8f911809f5 100644 --- a/src/core/lib/promise/latch.h +++ b/src/core/lib/promise/latch.h @@ -21,14 +21,12 @@ #include #include -#include #include #include "absl/strings/str_cat.h" #include -#include "src/core/lib/debug/trace.h" #include "src/core/lib/promise/activity.h" #include "src/core/lib/promise/poll.h" #include "src/core/lib/promise/trace.h" diff --git a/src/core/lib/promise/loop.h b/src/core/lib/promise/loop.h index bd77f088e32..4908a472667 100644 --- a/src/core/lib/promise/loop.h +++ b/src/core/lib/promise/loop.h @@ -17,7 +17,7 @@ #include -#include +#include #include "absl/status/status.h" #include "absl/status/statusor.h" diff --git a/src/core/lib/promise/map.h b/src/core/lib/promise/map.h index 44e19bb96ac..59efef428fa 100644 --- a/src/core/lib/promise/map.h +++ b/src/core/lib/promise/map.h @@ -20,7 +20,6 @@ #include #include -#include #include #include "src/core/lib/promise/detail/promise_like.h" diff --git a/src/core/lib/promise/map_pipe.h b/src/core/lib/promise/map_pipe.h index 6f7312da047..d609cdfd70a 100644 --- a/src/core/lib/promise/map_pipe.h +++ b/src/core/lib/promise/map_pipe.h @@ -21,7 +21,6 @@ #include -#include "src/core/lib/debug/trace.h" #include "src/core/lib/promise/detail/promise_factory.h" #include "src/core/lib/promise/for_each.h" #include "src/core/lib/promise/map.h" diff --git a/src/core/lib/promise/party.cc b/src/core/lib/promise/party.cc index a2622fa73d2..040afbfe9a3 100644 --- a/src/core/lib/promise/party.cc +++ b/src/core/lib/promise/party.cc @@ -17,14 +17,12 @@ #include "src/core/lib/promise/party.h" #include -#include #include "absl/base/thread_annotations.h" #include "absl/strings/str_format.h" #include -#include "src/core/lib/debug/trace.h" #include "src/core/lib/gprpp/sync.h" #include "src/core/lib/iomgr/exec_ctx.h" #include "src/core/lib/promise/activity.h" diff --git a/src/core/lib/promise/party.h b/src/core/lib/promise/party.h index 206cbd5af80..493a00925d1 100644 --- a/src/core/lib/promise/party.h +++ b/src/core/lib/promise/party.h @@ -30,7 +30,6 @@ #include #include -#include "src/core/lib/debug/trace.h" #include "src/core/lib/gprpp/construct_destruct.h" #include "src/core/lib/gprpp/crash.h" #include "src/core/lib/gprpp/ref_counted.h" diff --git a/src/core/lib/promise/pipe.h b/src/core/lib/promise/pipe.h index 6de4f4ae584..1e188b0d5a7 100644 --- a/src/core/lib/promise/pipe.h +++ b/src/core/lib/promise/pipe.h @@ -22,7 +22,6 @@ #include #include -#include #include #include "absl/strings/str_cat.h" @@ -31,7 +30,6 @@ #include -#include "src/core/lib/debug/trace.h" #include "src/core/lib/gprpp/debug_location.h" #include "src/core/lib/gprpp/ref_counted_ptr.h" #include "src/core/lib/promise/activity.h" diff --git a/src/core/lib/promise/prioritized_race.h b/src/core/lib/promise/prioritized_race.h index 0a6ab57880d..166c4d2dad1 100644 --- a/src/core/lib/promise/prioritized_race.h +++ b/src/core/lib/promise/prioritized_race.h @@ -17,7 +17,6 @@ #include -#include #include namespace grpc_core { diff --git a/src/core/lib/promise/promise.h b/src/core/lib/promise/promise.h index 5da762f99eb..ab9b0d6becd 100644 --- a/src/core/lib/promise/promise.h +++ b/src/core/lib/promise/promise.h @@ -18,7 +18,6 @@ #include #include -#include #include "absl/functional/any_invocable.h" #include "absl/status/status.h" diff --git a/src/core/lib/promise/race.h b/src/core/lib/promise/race.h index 5638ca9daf0..f363c93e5e2 100644 --- a/src/core/lib/promise/race.h +++ b/src/core/lib/promise/race.h @@ -17,7 +17,6 @@ #include -#include #include namespace grpc_core { diff --git a/src/core/lib/promise/seq.h b/src/core/lib/promise/seq.h index 70b8590def8..1ed533299d6 100644 --- a/src/core/lib/promise/seq.h +++ b/src/core/lib/promise/seq.h @@ -19,7 +19,6 @@ #include -#include #include #include "src/core/lib/promise/detail/basic_seq.h" diff --git a/src/core/lib/promise/try_join.h b/src/core/lib/promise/try_join.h index 4ed59479fd7..efc0cfd78cb 100644 --- a/src/core/lib/promise/try_join.h +++ b/src/core/lib/promise/try_join.h @@ -18,7 +18,7 @@ #include #include -#include +#include #include "absl/meta/type_traits.h" #include "absl/status/status.h" diff --git a/src/core/lib/resolver/resolver_registry.cc b/src/core/lib/resolver/resolver_registry.cc index 5d5f2ab0409..821b71d4050 100644 --- a/src/core/lib/resolver/resolver_registry.cc +++ b/src/core/lib/resolver/resolver_registry.cc @@ -18,8 +18,6 @@ #include "src/core/lib/resolver/resolver_registry.h" -#include - #include "absl/status/status.h" #include "absl/status/statusor.h" #include "absl/strings/ascii.h" diff --git a/src/core/lib/security/authorization/audit_logging.cc b/src/core/lib/security/authorization/audit_logging.cc index b70fe522c66..b1df62da30d 100644 --- a/src/core/lib/security/authorization/audit_logging.cc +++ b/src/core/lib/security/authorization/audit_logging.cc @@ -20,7 +20,6 @@ #include "src/core/lib/security/authorization/audit_logging.h" -#include #include #include #include diff --git a/src/core/lib/security/authorization/grpc_authorization_policy_provider.cc b/src/core/lib/security/authorization/grpc_authorization_policy_provider.cc index c2704e4651e..4133f436a13 100644 --- a/src/core/lib/security/authorization/grpc_authorization_policy_provider.cc +++ b/src/core/lib/security/authorization/grpc_authorization_policy_provider.cc @@ -34,6 +34,7 @@ #include "src/core/lib/iomgr/error.h" #include "src/core/lib/iomgr/load_file.h" #include "src/core/lib/security/authorization/grpc_authorization_engine.h" +#include "src/core/lib/security/authorization/rbac_policy.h" #include "src/core/lib/security/authorization/rbac_translator.h" #include "src/core/lib/slice/slice.h" #include "src/core/lib/slice/slice_internal.h" diff --git a/src/core/lib/security/authorization/grpc_server_authz_filter.cc b/src/core/lib/security/authorization/grpc_server_authz_filter.cc index 3f4d9b832a2..8de911b5469 100644 --- a/src/core/lib/security/authorization/grpc_server_authz_filter.cc +++ b/src/core/lib/security/authorization/grpc_server_authz_filter.cc @@ -23,7 +23,6 @@ #include "absl/status/status.h" #include "absl/strings/str_join.h" -#include "absl/strings/string_view.h" #include @@ -33,6 +32,7 @@ #include "src/core/lib/promise/promise.h" #include "src/core/lib/security/authorization/authorization_engine.h" #include "src/core/lib/security/authorization/evaluate_args.h" +#include "src/core/lib/transport/metadata_batch.h" #include "src/core/lib/transport/transport.h" namespace grpc_core { diff --git a/src/core/lib/security/authorization/matchers.cc b/src/core/lib/security/authorization/matchers.cc index 3c4a51f01c5..3407cc48574 100644 --- a/src/core/lib/security/authorization/matchers.cc +++ b/src/core/lib/security/authorization/matchers.cc @@ -18,7 +18,6 @@ #include -#include #include #include "absl/status/status.h" diff --git a/src/core/lib/security/authorization/rbac_policy.cc b/src/core/lib/security/authorization/rbac_policy.cc index 96cc0770868..dd5a8fffdae 100644 --- a/src/core/lib/security/authorization/rbac_policy.cc +++ b/src/core/lib/security/authorization/rbac_policy.cc @@ -16,8 +16,6 @@ #include "src/core/lib/security/authorization/rbac_policy.h" -#include -#include #include #include "absl/strings/str_format.h" diff --git a/src/core/lib/security/authorization/rbac_translator.cc b/src/core/lib/security/authorization/rbac_translator.cc index 8134a394920..eb67014e08d 100644 --- a/src/core/lib/security/authorization/rbac_translator.cc +++ b/src/core/lib/security/authorization/rbac_translator.cc @@ -19,7 +19,6 @@ #include #include -#include #include #include #include diff --git a/src/core/lib/security/authorization/stdout_logger.cc b/src/core/lib/security/authorization/stdout_logger.cc index 4f1fc05d01e..7aae9a2cac3 100644 --- a/src/core/lib/security/authorization/stdout_logger.cc +++ b/src/core/lib/security/authorization/stdout_logger.cc @@ -17,7 +17,6 @@ #include "src/core/lib/security/authorization/stdout_logger.h" #include -#include #include #include diff --git a/src/core/lib/security/credentials/alts/alts_credentials.cc b/src/core/lib/security/credentials/alts/alts_credentials.cc index 947b4abc9ac..55626975305 100644 --- a/src/core/lib/security/credentials/alts/alts_credentials.cc +++ b/src/core/lib/security/credentials/alts/alts_credentials.cc @@ -22,8 +22,6 @@ #include -#include "absl/strings/string_view.h" - #include #include #include diff --git a/src/core/lib/security/credentials/composite/composite_credentials.cc b/src/core/lib/security/credentials/composite/composite_credentials.cc index cf3fa8d2229..0ff934fcd01 100644 --- a/src/core/lib/security/credentials/composite/composite_credentials.cc +++ b/src/core/lib/security/credentials/composite/composite_credentials.cc @@ -26,7 +26,6 @@ #include "absl/strings/str_cat.h" #include "absl/strings/str_join.h" -#include "absl/strings/string_view.h" #include @@ -34,6 +33,7 @@ #include "src/core/lib/gprpp/ref_counted_ptr.h" #include "src/core/lib/promise/try_seq.h" #include "src/core/lib/surface/api_trace.h" +#include "src/core/lib/transport/metadata_batch.h" // // grpc_composite_channel_credentials diff --git a/src/core/lib/security/credentials/external/aws_external_account_credentials.cc b/src/core/lib/security/credentials/external/aws_external_account_credentials.cc index 5ba5d64ea02..68ddaaeb903 100644 --- a/src/core/lib/security/credentials/external/aws_external_account_credentials.cc +++ b/src/core/lib/security/credentials/external/aws_external_account_credentials.cc @@ -19,7 +19,6 @@ #include -#include #include #include diff --git a/src/core/lib/security/credentials/external/aws_request_signer.cc b/src/core/lib/security/credentials/external/aws_request_signer.cc index 83c983a31f2..6c22f1ad567 100644 --- a/src/core/lib/security/credentials/external/aws_request_signer.cc +++ b/src/core/lib/security/credentials/external/aws_request_signer.cc @@ -17,8 +17,6 @@ #include "src/core/lib/security/credentials/external/aws_request_signer.h" -#include -#include #include #include diff --git a/src/core/lib/security/credentials/external/external_account_credentials.cc b/src/core/lib/security/credentials/external/external_account_credentials.cc index ea03743baed..93228dbca4e 100644 --- a/src/core/lib/security/credentials/external/external_account_credentials.cc +++ b/src/core/lib/security/credentials/external/external_account_credentials.cc @@ -20,8 +20,6 @@ #include #include -#include -#include #include #include #include diff --git a/src/core/lib/security/credentials/external/url_external_account_credentials.cc b/src/core/lib/security/credentials/external/url_external_account_credentials.cc index 8f257a1b8ef..0e4cb8afba1 100644 --- a/src/core/lib/security/credentials/external/url_external_account_credentials.cc +++ b/src/core/lib/security/credentials/external/url_external_account_credentials.cc @@ -19,7 +19,6 @@ #include -#include #include #include @@ -174,8 +173,7 @@ void UrlExternalAccountCredentials::RetrieveSubjectToken( http_request_creds = RefCountedPtr( grpc_insecure_credentials_create()); } else { - http_request_creds = RefCountedPtr( - CreateHttpRequestSSLCredentials()); + http_request_creds = CreateHttpRequestSSLCredentials(); } http_request_ = HttpRequest::Get(std::move(*url_for_request), nullptr /* channel args */, diff --git a/src/core/lib/security/credentials/google_default/google_default_credentials.cc b/src/core/lib/security/credentials/google_default/google_default_credentials.cc index 3601adae6a2..15755378a06 100644 --- a/src/core/lib/security/credentials/google_default/google_default_credentials.cc +++ b/src/core/lib/security/credentials/google_default/google_default_credentials.cc @@ -35,7 +35,6 @@ #include #include #include -#include #include #include diff --git a/src/core/lib/security/credentials/iam/iam_credentials.cc b/src/core/lib/security/credentials/iam/iam_credentials.cc index fb4b07eeb5a..8b56c03f03f 100644 --- a/src/core/lib/security/credentials/iam/iam_credentials.cc +++ b/src/core/lib/security/credentials/iam/iam_credentials.cc @@ -22,7 +22,6 @@ #include -#include #include #include diff --git a/src/core/lib/security/credentials/insecure/insecure_credentials.cc b/src/core/lib/security/credentials/insecure/insecure_credentials.cc index f6ede975f93..cce66f6e290 100644 --- a/src/core/lib/security/credentials/insecure/insecure_credentials.cc +++ b/src/core/lib/security/credentials/insecure/insecure_credentials.cc @@ -22,8 +22,6 @@ #include -#include "absl/strings/string_view.h" - #include "src/core/lib/channel/channel_args.h" #include "src/core/lib/security/security_connector/insecure/insecure_security_connector.h" diff --git a/src/core/lib/security/credentials/jwt/jwt_credentials.h b/src/core/lib/security/credentials/jwt/jwt_credentials.h index b03b79f1a94..05d4c2d38b0 100644 --- a/src/core/lib/security/credentials/jwt/jwt_credentials.h +++ b/src/core/lib/security/credentials/jwt/jwt_credentials.h @@ -23,7 +23,6 @@ #include -#include #include #include "absl/status/statusor.h" diff --git a/src/core/lib/security/credentials/jwt/jwt_verifier.cc b/src/core/lib/security/credentials/jwt/jwt_verifier.cc index 725ca7d9f58..346f2491fa8 100644 --- a/src/core/lib/security/credentials/jwt/jwt_verifier.cc +++ b/src/core/lib/security/credentials/jwt/jwt_verifier.cc @@ -45,7 +45,6 @@ #include "absl/status/statusor.h" #include "absl/strings/string_view.h" -#include #include #include #include @@ -66,7 +65,7 @@ #include "src/core/lib/iomgr/iomgr_fwd.h" #include "src/core/lib/iomgr/polling_entity.h" #include "src/core/lib/json/json_reader.h" -#include "src/core/lib/security/credentials/credentials.h" +#include "src/core/lib/security/credentials/credentials.h" // IWYU pragma: keep #include "src/core/lib/slice/b64.h" #include "src/core/lib/slice/slice.h" #include "src/core/lib/slice/slice_internal.h" diff --git a/src/core/lib/security/credentials/local/local_credentials.cc b/src/core/lib/security/credentials/local/local_credentials.cc index c4fa10eb9c9..5c9e598223a 100644 --- a/src/core/lib/security/credentials/local/local_credentials.cc +++ b/src/core/lib/security/credentials/local/local_credentials.cc @@ -22,8 +22,6 @@ #include -#include "absl/strings/string_view.h" - #include #include "src/core/lib/security/security_connector/local/local_security_connector.h" diff --git a/src/core/lib/security/credentials/oauth2/oauth2_credentials.h b/src/core/lib/security/credentials/oauth2/oauth2_credentials.h index 9815a8d3ee3..31c0c227fc9 100644 --- a/src/core/lib/security/credentials/oauth2/oauth2_credentials.h +++ b/src/core/lib/security/credentials/oauth2/oauth2_credentials.h @@ -22,7 +22,6 @@ #include #include -#include #include #include diff --git a/src/core/lib/security/credentials/plugin/plugin_credentials.cc b/src/core/lib/security/credentials/plugin/plugin_credentials.cc index bdfdce011bf..6031df47b9b 100644 --- a/src/core/lib/security/credentials/plugin/plugin_credentials.cc +++ b/src/core/lib/security/credentials/plugin/plugin_credentials.cc @@ -27,7 +27,6 @@ #include "absl/strings/str_cat.h" #include "absl/strings/string_view.h" -#include #include #include diff --git a/src/core/lib/security/credentials/ssl/ssl_credentials.cc b/src/core/lib/security/credentials/ssl/ssl_credentials.cc index de612abc193..99be297f8c4 100644 --- a/src/core/lib/security/credentials/ssl/ssl_credentials.cc +++ b/src/core/lib/security/credentials/ssl/ssl_credentials.cc @@ -25,7 +25,6 @@ #include #include -#include "absl/strings/string_view.h" #include "absl/types/optional.h" #include diff --git a/src/core/lib/security/credentials/tls/grpc_tls_certificate_distributor.cc b/src/core/lib/security/credentials/tls/grpc_tls_certificate_distributor.cc index f303353e9d5..a956beb32e7 100644 --- a/src/core/lib/security/credentials/tls/grpc_tls_certificate_distributor.cc +++ b/src/core/lib/security/credentials/tls/grpc_tls_certificate_distributor.cc @@ -18,8 +18,6 @@ #include "src/core/lib/security/credentials/tls/grpc_tls_certificate_distributor.h" -#include - #include "absl/status/status.h" #include diff --git a/src/core/lib/security/credentials/tls/grpc_tls_credentials_options.cc b/src/core/lib/security/credentials/tls/grpc_tls_credentials_options.cc index 2f951b57542..57f753b974c 100644 --- a/src/core/lib/security/credentials/tls/grpc_tls_credentials_options.cc +++ b/src/core/lib/security/credentials/tls/grpc_tls_credentials_options.cc @@ -20,6 +20,8 @@ #include "src/core/lib/security/credentials/tls/grpc_tls_credentials_options.h" +#include + #include #include "src/core/lib/debug/trace.h" diff --git a/src/core/lib/security/credentials/tls/tls_credentials.cc b/src/core/lib/security/credentials/tls/tls_credentials.cc index 34f27c0d593..c13cb8609f0 100644 --- a/src/core/lib/security/credentials/tls/tls_credentials.cc +++ b/src/core/lib/security/credentials/tls/tls_credentials.cc @@ -23,7 +23,6 @@ #include #include -#include "absl/strings/string_view.h" #include "absl/types/optional.h" #include diff --git a/src/core/lib/security/credentials/tls/tls_utils.cc b/src/core/lib/security/credentials/tls/tls_utils.cc index 9d41f33dc3b..c973e28b859 100644 --- a/src/core/lib/security/credentials/tls/tls_utils.cc +++ b/src/core/lib/security/credentials/tls/tls_utils.cc @@ -22,6 +22,8 @@ #include +#include + #include "absl/strings/ascii.h" #include "absl/strings/match.h" #include "absl/strings/str_cat.h" diff --git a/src/core/lib/security/credentials/xds/xds_credentials.cc b/src/core/lib/security/credentials/xds/xds_credentials.cc index 9d9fe3df2a7..957e36274b2 100644 --- a/src/core/lib/security/credentials/xds/xds_credentials.cc +++ b/src/core/lib/security/credentials/xds/xds_credentials.cc @@ -20,7 +20,6 @@ #include "src/core/lib/security/credentials/xds/xds_credentials.h" -#include "absl/strings/string_view.h" #include "absl/types/optional.h" #include diff --git a/src/core/lib/security/security_connector/fake/fake_security_connector.cc b/src/core/lib/security/security_connector/fake/fake_security_connector.cc index 384da2cd480..ca672ab48b6 100644 --- a/src/core/lib/security/security_connector/fake/fake_security_connector.cc +++ b/src/core/lib/security/security_connector/fake/fake_security_connector.cc @@ -23,7 +23,6 @@ #include #include -#include #include #include diff --git a/src/core/lib/security/security_connector/ssl/ssl_security_connector.cc b/src/core/lib/security/security_connector/ssl/ssl_security_connector.cc index 34fbd571b7d..c5c81fa47c2 100644 --- a/src/core/lib/security/security_connector/ssl/ssl_security_connector.cc +++ b/src/core/lib/security/security_connector/ssl/ssl_security_connector.cc @@ -23,7 +23,6 @@ #include #include -#include #include #include diff --git a/src/core/lib/security/security_connector/tls/tls_security_connector.cc b/src/core/lib/security/security_connector/tls/tls_security_connector.cc index d25b279a39c..7dfd24dfb9a 100644 --- a/src/core/lib/security/security_connector/tls/tls_security_connector.cc +++ b/src/core/lib/security/security_connector/tls/tls_security_connector.cc @@ -22,7 +22,6 @@ #include -#include #include #include #include diff --git a/src/core/lib/security/transport/client_auth_filter.cc b/src/core/lib/security/transport/client_auth_filter.cc index fa1e9f3bd92..e3e30e8265f 100644 --- a/src/core/lib/security/transport/client_auth_filter.cc +++ b/src/core/lib/security/transport/client_auth_filter.cc @@ -18,7 +18,6 @@ #include -#include #include #include diff --git a/src/core/lib/security/transport/server_auth_filter.cc b/src/core/lib/security/transport/server_auth_filter.cc index 548eb6c271e..765ddcdf42b 100644 --- a/src/core/lib/security/transport/server_auth_filter.cc +++ b/src/core/lib/security/transport/server_auth_filter.cc @@ -18,14 +18,11 @@ #include -#include - #include #include #include #include #include -#include #include #include "absl/status/status.h" @@ -33,7 +30,6 @@ #include #include -#include #include #include #include diff --git a/src/core/lib/surface/call.cc b/src/core/lib/surface/call.cc index db2f05e1651..f4e7ad8076e 100644 --- a/src/core/lib/surface/call.cc +++ b/src/core/lib/surface/call.cc @@ -27,7 +27,6 @@ #include #include -#include #include #include #include @@ -36,7 +35,6 @@ #include #include "absl/base/thread_annotations.h" -#include "absl/meta/type_traits.h" #include "absl/status/status.h" #include "absl/strings/str_cat.h" #include "absl/strings/str_format.h" @@ -55,7 +53,6 @@ #include #include #include -#include #include "src/core/lib/channel/call_finalization.h" #include "src/core/lib/channel/call_tracer.h" diff --git a/src/core/lib/surface/call_log_batch.cc b/src/core/lib/surface/call_log_batch.cc index b3bd633db57..473faa8424c 100644 --- a/src/core/lib/surface/call_log_batch.cc +++ b/src/core/lib/surface/call_log_batch.cc @@ -22,13 +22,11 @@ #include #include -#include #include #include #include "absl/strings/str_format.h" #include "absl/strings/str_join.h" -#include "absl/strings/string_view.h" #include #include diff --git a/src/core/lib/surface/call_trace.cc b/src/core/lib/surface/call_trace.cc index 6b4610df0d3..163418f5083 100644 --- a/src/core/lib/surface/call_trace.cc +++ b/src/core/lib/surface/call_trace.cc @@ -23,7 +23,6 @@ #include "absl/base/thread_annotations.h" #include "absl/container/flat_hash_map.h" -#include "absl/meta/type_traits.h" #include "absl/status/status.h" #include "absl/strings/str_cat.h" diff --git a/src/core/lib/surface/completion_queue.cc b/src/core/lib/surface/completion_queue.cc index 5ef0142604c..0bd2cefec9e 100644 --- a/src/core/lib/surface/completion_queue.cc +++ b/src/core/lib/surface/completion_queue.cc @@ -24,7 +24,6 @@ #include #include -#include #include #include #include diff --git a/src/core/lib/surface/event_string.cc b/src/core/lib/surface/event_string.cc index cf5390fe2ff..0666d4beff8 100644 --- a/src/core/lib/surface/event_string.cc +++ b/src/core/lib/surface/event_string.cc @@ -21,7 +21,6 @@ #include "src/core/lib/surface/event_string.h" #include -#include #include #include "absl/strings/str_format.h" diff --git a/src/core/lib/surface/lame_client.cc b/src/core/lib/surface/lame_client.cc index 7fbdf8e64b4..3ed6b9b0d63 100644 --- a/src/core/lib/surface/lame_client.cc +++ b/src/core/lib/surface/lame_client.cc @@ -47,6 +47,7 @@ #include "src/core/lib/surface/channel.h" #include "src/core/lib/surface/channel_stack_type.h" #include "src/core/lib/transport/connectivity_state.h" +#include "src/core/lib/transport/metadata_batch.h" #include "src/core/lib/transport/transport.h" // Avoid some IWYU confusion: diff --git a/src/core/lib/surface/server.cc b/src/core/lib/surface/server.cc index 3dda49d0061..6f76ef26f7e 100644 --- a/src/core/lib/surface/server.cc +++ b/src/core/lib/surface/server.cc @@ -24,7 +24,6 @@ #include #include -#include #include #include #include diff --git a/src/core/lib/transport/batch_builder.h b/src/core/lib/transport/batch_builder.h index 7ef352b7e77..9effd2ec4c3 100644 --- a/src/core/lib/transport/batch_builder.h +++ b/src/core/lib/transport/batch_builder.h @@ -19,7 +19,6 @@ #include -#include #include #include #include diff --git a/src/core/lib/transport/connectivity_state.cc b/src/core/lib/transport/connectivity_state.cc index ceda57d1bf2..1ea3e192b07 100644 --- a/src/core/lib/transport/connectivity_state.cc +++ b/src/core/lib/transport/connectivity_state.cc @@ -20,8 +20,6 @@ #include "src/core/lib/transport/connectivity_state.h" -#include - #include #include "src/core/lib/gprpp/debug_location.h" diff --git a/src/core/lib/transport/error_utils.cc b/src/core/lib/transport/error_utils.cc index 6246c9bbe47..2e53b31ce2d 100644 --- a/src/core/lib/transport/error_utils.cc +++ b/src/core/lib/transport/error_utils.cc @@ -24,8 +24,6 @@ #include -#include "absl/strings/string_view.h" - #include #include "src/core/lib/gprpp/status_helper.h" diff --git a/src/core/lib/transport/handshaker.cc b/src/core/lib/transport/handshaker.cc index c18426a0171..ccf55608a55 100644 --- a/src/core/lib/transport/handshaker.cc +++ b/src/core/lib/transport/handshaker.cc @@ -22,7 +22,6 @@ #include -#include #include #include @@ -31,7 +30,6 @@ #include #include -#include #include #include #include diff --git a/src/core/lib/transport/metadata_batch.cc b/src/core/lib/transport/metadata_batch.cc index 92282cfe4a2..7dcd1a0dd57 100644 --- a/src/core/lib/transport/metadata_batch.cc +++ b/src/core/lib/transport/metadata_batch.cc @@ -19,7 +19,6 @@ #include #include -#include #include "absl/strings/escaping.h" #include "absl/strings/match.h" diff --git a/src/core/lib/transport/tcp_connect_handshaker.cc b/src/core/lib/transport/tcp_connect_handshaker.cc index 0088c21f7b8..cf56bce34f8 100644 --- a/src/core/lib/transport/tcp_connect_handshaker.cc +++ b/src/core/lib/transport/tcp_connect_handshaker.cc @@ -25,7 +25,6 @@ #include "absl/base/thread_annotations.h" #include "absl/status/status.h" #include "absl/status/statusor.h" -#include "absl/strings/string_view.h" #include "absl/types/optional.h" #include diff --git a/src/core/lib/transport/transport.cc b/src/core/lib/transport/transport.cc index 055d298780f..7c0be3d5c50 100644 --- a/src/core/lib/transport/transport.cc +++ b/src/core/lib/transport/transport.cc @@ -27,6 +27,7 @@ #include "absl/status/status.h" #include "absl/strings/str_cat.h" +#include "absl/strings/string_view.h" #include #include diff --git a/src/core/lib/transport/transport.h b/src/core/lib/transport/transport.h index 4fc047dc317..a25b509f6fc 100644 --- a/src/core/lib/transport/transport.h +++ b/src/core/lib/transport/transport.h @@ -27,11 +27,9 @@ #include #include -#include #include #include "absl/status/status.h" -#include "absl/strings/string_view.h" #include "absl/types/optional.h" #include diff --git a/src/core/lib/transport/transport_op_string.cc b/src/core/lib/transport/transport_op_string.cc index 3d8e86bda2c..3f2a073a913 100644 --- a/src/core/lib/transport/transport_op_string.cc +++ b/src/core/lib/transport/transport_op_string.cc @@ -18,7 +18,6 @@ #include -#include #include #include @@ -31,7 +30,6 @@ #include "src/core/lib/channel/channel_stack.h" #include "src/core/lib/gprpp/orphanable.h" #include "src/core/lib/gprpp/status_helper.h" -#include "src/core/lib/iomgr/error.h" #include "src/core/lib/slice/slice_buffer.h" #include "src/core/lib/transport/connectivity_state.h" #include "src/core/lib/transport/metadata_batch.h" diff --git a/src/core/lib/uri/uri_parser.cc b/src/core/lib/uri/uri_parser.cc index 3c50629db29..8c24d252da4 100644 --- a/src/core/lib/uri/uri_parser.cc +++ b/src/core/lib/uri/uri_parser.cc @@ -23,7 +23,6 @@ #include #include -#include #include #include #include diff --git a/src/cpp/client/client_context.cc b/src/cpp/client/client_context.cc index 6a60ba43a3f..b986946e64d 100644 --- a/src/cpp/client/client_context.cc +++ b/src/cpp/client/client_context.cc @@ -18,7 +18,6 @@ #include -#include #include #include #include diff --git a/src/cpp/common/tls_certificate_verifier.cc b/src/cpp/common/tls_certificate_verifier.cc index 9ad3e0f0f15..093062a6202 100644 --- a/src/cpp/common/tls_certificate_verifier.cc +++ b/src/cpp/common/tls_certificate_verifier.cc @@ -19,7 +19,6 @@ #include #include #include -#include #include #include diff --git a/src/cpp/ext/csm/BUILD b/src/cpp/ext/csm/BUILD index f7433baac00..80552667871 100644 --- a/src/cpp/ext/csm/BUILD +++ b/src/cpp/ext/csm/BUILD @@ -42,7 +42,6 @@ grpc_cc_library( ], external_deps = [ "absl/functional:any_invocable", - "absl/meta:type_traits", "absl/status:statusor", "absl/strings", "absl/types:optional", @@ -63,7 +62,6 @@ grpc_cc_library( "//src/core:channel_args", "//src/core:env", "//src/core:error", - "//src/core:json", "//src/core:json_args", "//src/core:json_object_loader", "//src/core:json_reader", diff --git a/src/cpp/ext/csm/metadata_exchange.cc b/src/cpp/ext/csm/metadata_exchange.cc index 567de4b6d5a..0f0c5f4642a 100644 --- a/src/cpp/ext/csm/metadata_exchange.cc +++ b/src/cpp/ext/csm/metadata_exchange.cc @@ -27,7 +27,6 @@ #include #include -#include "absl/meta/type_traits.h" #include "absl/status/statusor.h" #include "absl/strings/escaping.h" #include "absl/strings/str_split.h" @@ -46,7 +45,6 @@ #include "src/core/lib/gprpp/env.h" #include "src/core/lib/iomgr/error.h" #include "src/core/lib/iomgr/load_file.h" -#include "src/core/lib/json/json.h" #include "src/core/lib/json/json_args.h" #include "src/core/lib/json/json_object_loader.h" #include "src/core/lib/json/json_reader.h" diff --git a/src/cpp/ext/filters/census/client_filter.cc b/src/cpp/ext/filters/census/client_filter.cc index 0e787893a04..05980c89659 100644 --- a/src/cpp/ext/filters/census/client_filter.cc +++ b/src/cpp/ext/filters/census/client_filter.cc @@ -25,7 +25,6 @@ #include #include -#include #include #include #include diff --git a/src/cpp/ext/filters/census/server_call_tracer.cc b/src/cpp/ext/filters/census/server_call_tracer.cc index 4a6bb0ed480..7c933b09101 100644 --- a/src/cpp/ext/filters/census/server_call_tracer.cc +++ b/src/cpp/ext/filters/census/server_call_tracer.cc @@ -23,13 +23,10 @@ #include #include -#include -#include #include #include #include -#include "absl/meta/type_traits.h" #include "absl/strings/str_cat.h" #include "absl/strings/str_format.h" #include "absl/strings/string_view.h" diff --git a/src/cpp/ext/gcp/BUILD b/src/cpp/ext/gcp/BUILD index 41c9878390d..744b8ff2119 100644 --- a/src/cpp/ext/gcp/BUILD +++ b/src/cpp/ext/gcp/BUILD @@ -153,7 +153,6 @@ grpc_cc_library( "absl/base:core_headers", "absl/container:flat_hash_map", "absl/functional:any_invocable", - "absl/meta:type_traits", "absl/status", "absl/status:statusor", "absl/types:optional", diff --git a/src/cpp/ext/gcp/environment_autodetect.cc b/src/cpp/ext/gcp/environment_autodetect.cc index 1e9f998ecd3..8a3f1ecc58e 100644 --- a/src/cpp/ext/gcp/environment_autodetect.cc +++ b/src/cpp/ext/gcp/environment_autodetect.cc @@ -20,12 +20,10 @@ #include "src/cpp/ext/gcp/environment_autodetect.h" -#include #include #include #include "absl/container/flat_hash_map.h" -#include "absl/meta/type_traits.h" #include "absl/status/status.h" #include "absl/status/statusor.h" #include "absl/types/optional.h" diff --git a/src/cpp/ext/gcp/observability.cc b/src/cpp/ext/gcp/observability.cc index 94a88fd810f..1cb156d5d49 100644 --- a/src/cpp/ext/gcp/observability.cc +++ b/src/cpp/ext/gcp/observability.cc @@ -41,6 +41,7 @@ #include "opencensus/trace/trace_config.h" #include +#include #include #include #include diff --git a/src/cpp/ext/gcp/observability_config.h b/src/cpp/ext/gcp/observability_config.h index d17d4f65afc..05d566cf279 100644 --- a/src/cpp/ext/gcp/observability_config.h +++ b/src/cpp/ext/gcp/observability_config.h @@ -84,7 +84,8 @@ struct GcpObservabilityConfig { }; struct CloudTrace { - float sampling_rate = 0; + CloudTrace() : sampling_rate(0) {} + float sampling_rate; static const grpc_core::JsonLoaderInterface* JsonLoader( const grpc_core::JsonArgs&) { diff --git a/src/cpp/ext/gcp/observability_logging_sink.cc b/src/cpp/ext/gcp/observability_logging_sink.cc index 2ae582fa54e..8d85746e171 100644 --- a/src/cpp/ext/gcp/observability_logging_sink.cc +++ b/src/cpp/ext/gcp/observability_logging_sink.cc @@ -21,7 +21,6 @@ #include "src/cpp/ext/gcp/observability_logging_sink.h" #include -#include #include #include diff --git a/src/cpp/ext/otel/otel_client_filter.cc b/src/cpp/ext/otel/otel_client_filter.cc index 7f2efee20f2..9f4535dbca8 100644 --- a/src/cpp/ext/otel/otel_client_filter.cc +++ b/src/cpp/ext/otel/otel_client_filter.cc @@ -24,7 +24,6 @@ #include #include -#include #include #include #include diff --git a/src/cpp/ext/otel/otel_server_call_tracer.cc b/src/cpp/ext/otel/otel_server_call_tracer.cc index d65eef3d54b..1695ede607c 100644 --- a/src/cpp/ext/otel/otel_server_call_tracer.cc +++ b/src/cpp/ext/otel/otel_server_call_tracer.cc @@ -21,7 +21,6 @@ #include "src/cpp/ext/otel/otel_server_call_tracer.h" #include -#include #include #include #include diff --git a/src/cpp/server/channelz/channelz_service.cc b/src/cpp/server/channelz/channelz_service.cc index 39e7ade93ab..570a656948e 100644 --- a/src/cpp/server/channelz/channelz_service.cc +++ b/src/cpp/server/channelz/channelz_service.cc @@ -20,6 +20,8 @@ #include "src/cpp/server/channelz/channelz_service.h" +#include + #include #include diff --git a/src/cpp/server/load_reporter/load_reporter.h b/src/cpp/server/load_reporter/load_reporter.h index a1b1c7ec3ea..7351689e0f1 100644 --- a/src/cpp/server/load_reporter/load_reporter.h +++ b/src/cpp/server/load_reporter/load_reporter.h @@ -42,6 +42,8 @@ #include "src/cpp/server/load_reporter/load_data_store.h" #include "src/proto/grpc/lb/v1/load_reporter.pb.h" +// IWYU pragma: no_include + namespace grpc { namespace load_reporter { diff --git a/src/cpp/server/load_reporter/load_reporting_service_server_builder_plugin.cc b/src/cpp/server/load_reporter/load_reporting_service_server_builder_plugin.cc index edd3223f7f1..261a404d0ca 100644 --- a/src/cpp/server/load_reporter/load_reporting_service_server_builder_plugin.cc +++ b/src/cpp/server/load_reporter/load_reporting_service_server_builder_plugin.cc @@ -22,7 +22,6 @@ #include -#include #include #include diff --git a/src/cpp/server/orca/orca_service.cc b/src/cpp/server/orca/orca_service.cc index 23734ff399c..985f1ca8006 100644 --- a/src/cpp/server/orca/orca_service.cc +++ b/src/cpp/server/orca/orca_service.cc @@ -15,7 +15,6 @@ // #include -#include #include #include diff --git a/src/cpp/server/secure_server_credentials.cc b/src/cpp/server/secure_server_credentials.cc index 8874700410d..d88b5950ef9 100644 --- a/src/cpp/server/secure_server_credentials.cc +++ b/src/cpp/server/secure_server_credentials.cc @@ -25,7 +25,6 @@ #include #include -#include #include #include #include diff --git a/src/cpp/server/server_builder.cc b/src/cpp/server/server_builder.cc index 6f42aaa46bb..6d5924404f4 100644 --- a/src/cpp/server/server_builder.cc +++ b/src/cpp/server/server_builder.cc @@ -17,7 +17,6 @@ // #include -#include #include #include diff --git a/src/cpp/server/server_cc.cc b/src/cpp/server/server_cc.cc index fbf8311b740..39529d08306 100644 --- a/src/cpp/server/server_cc.cc +++ b/src/cpp/server/server_cc.cc @@ -58,6 +58,7 @@ #include #include #include +#include #include #include #include diff --git a/src/cpp/server/server_context.cc b/src/cpp/server/server_context.cc index 3f3edaffc44..41dfcf7d6a1 100644 --- a/src/cpp/server/server_context.cc +++ b/src/cpp/server/server_context.cc @@ -21,8 +21,8 @@ #include #include #include -#include #include +#include #include #include #include diff --git a/src/cpp/thread_manager/thread_manager.cc b/src/cpp/thread_manager/thread_manager.cc index 558e9b873bf..2675f32af62 100644 --- a/src/cpp/thread_manager/thread_manager.cc +++ b/src/cpp/thread_manager/thread_manager.cc @@ -19,7 +19,6 @@ #include "src/cpp/thread_manager/thread_manager.h" #include -#include #include "absl/strings/str_format.h" diff --git a/src/cpp/util/byte_buffer_cc.cc b/src/cpp/util/byte_buffer_cc.cc index acb60921df9..687df553505 100644 --- a/src/cpp/util/byte_buffer_cc.cc +++ b/src/cpp/util/byte_buffer_cc.cc @@ -16,6 +16,7 @@ // // +#include #include #include diff --git a/src/cpp/util/status.cc b/src/cpp/util/status.cc index 0a130bca845..3fcaebf8ad0 100644 --- a/src/cpp/util/status.cc +++ b/src/cpp/util/status.cc @@ -16,6 +16,8 @@ // // +#include + #include namespace grpc { diff --git a/templates/tools/dockerfile/grpc_clang_format/Dockerfile.template b/templates/tools/dockerfile/grpc_clang_format/Dockerfile.template index 47076066f73..3ada7cedb14 100644 --- a/templates/tools/dockerfile/grpc_clang_format/Dockerfile.template +++ b/templates/tools/dockerfile/grpc_clang_format/Dockerfile.template @@ -14,7 +14,7 @@ # See the License for the specific language governing permissions and # limitations under the License. - FROM silkeh/clang:15-bullseye + FROM silkeh/clang:16-bullseye ADD clang_format_all_the_things.sh / diff --git a/templates/tools/dockerfile/grpc_clang_tidy/Dockerfile.template b/templates/tools/dockerfile/grpc_clang_tidy/Dockerfile.template index ee20410d0b3..814829d790d 100644 --- a/templates/tools/dockerfile/grpc_clang_tidy/Dockerfile.template +++ b/templates/tools/dockerfile/grpc_clang_tidy/Dockerfile.template @@ -14,7 +14,7 @@ # See the License for the specific language governing permissions and # limitations under the License. - FROM silkeh/clang:15-bullseye + FROM silkeh/clang:16-bullseye # Install prerequisites for the clang-tidy script RUN apt-get update && apt-get install -y python3 jq git && apt-get clean diff --git a/templates/tools/dockerfile/grpc_iwyu/Dockerfile.template b/templates/tools/dockerfile/grpc_iwyu/Dockerfile.template index 93348ae80d6..ecb4deef283 100644 --- a/templates/tools/dockerfile/grpc_iwyu/Dockerfile.template +++ b/templates/tools/dockerfile/grpc_iwyu/Dockerfile.template @@ -17,10 +17,10 @@ # Docker file for running IWYU. # Updated: 2022-11-03 - FROM silkeh/clang:15-bullseye + FROM silkeh/clang:16-bullseye # Install prerequisites for the iwyu script - RUN apt-get update && apt-get install -y python3 jq git cmake python zlib1g-dev libtinfo-dev libclang-15-dev && apt-get clean + RUN apt-get update && apt-get install -y python3 jq git cmake python zlib1g-dev libtinfo-dev libclang-16-dev && apt-get clean ADD iwyu.sh / # When running locally, we'll be impersonating the current user, so we need diff --git a/templates/tools/dockerfile/test/cxx_clang_15_x64/Dockerfile.template b/templates/tools/dockerfile/test/cxx_clang_16_x64/Dockerfile.template similarity index 97% rename from templates/tools/dockerfile/test/cxx_clang_15_x64/Dockerfile.template rename to templates/tools/dockerfile/test/cxx_clang_16_x64/Dockerfile.template index ef3de5ddbd2..0c8d6049e53 100644 --- a/templates/tools/dockerfile/test/cxx_clang_15_x64/Dockerfile.template +++ b/templates/tools/dockerfile/test/cxx_clang_16_x64/Dockerfile.template @@ -14,7 +14,7 @@ # See the License for the specific language governing permissions and # limitations under the License. - FROM silkeh/clang:15-bullseye + FROM silkeh/clang:16-bullseye RUN apt-get update && apt-get install -y build-essential curl git time wget zip && apt-get clean <%include file="../../git_avoid_dubious_ownership_error.include"/> diff --git a/templates/tools/dockerfile/test/sanity/Dockerfile.template b/templates/tools/dockerfile/test/sanity/Dockerfile.template index 09f5cb21ea1..1ae00b5395b 100644 --- a/templates/tools/dockerfile/test/sanity/Dockerfile.template +++ b/templates/tools/dockerfile/test/sanity/Dockerfile.template @@ -14,7 +14,7 @@ # See the License for the specific language governing permissions and # limitations under the License. - FROM silkeh/clang:15-bullseye + FROM silkeh/clang:16-bullseye <%include file="../../apt_get_basic.include"/> @@ -55,7 +55,7 @@ RUN apt-get update && apt-get install -y jq git # Install prerequisites for the iwyu script - RUN apt-get update && apt-get install -y jq git cmake zlib1g-dev libtinfo-dev libclang-15-dev && apt-get clean + RUN apt-get update && apt-get install -y jq git cmake zlib1g-dev libtinfo-dev libclang-16-dev && apt-get clean <%include file="../../bazel.include"/> <%include file="../../buildifier.include"/> diff --git a/test/core/address_utils/parse_address_with_named_scope_id_test.cc b/test/core/address_utils/parse_address_with_named_scope_id_test.cc index 2e9f66bbbea..8ed013b7d3a 100644 --- a/test/core/address_utils/parse_address_with_named_scope_id_test.cc +++ b/test/core/address_utils/parse_address_with_named_scope_id_test.cc @@ -26,7 +26,6 @@ #include #endif -#include #include #include "absl/status/status.h" diff --git a/test/core/avl/avl_fuzzer.cc b/test/core/avl/avl_fuzzer.cc index a71df5e0297..914fdb78b3a 100644 --- a/test/core/avl/avl_fuzzer.cc +++ b/test/core/avl/avl_fuzzer.cc @@ -15,6 +15,7 @@ #include #include +#include #include #include diff --git a/test/core/avl/avl_test.cc b/test/core/avl/avl_test.cc index e1c983628ce..2bd56c81bc6 100644 --- a/test/core/avl/avl_test.cc +++ b/test/core/avl/avl_test.cc @@ -14,6 +14,8 @@ #include "src/core/lib/avl/avl.h" +#include + #include "gtest/gtest.h" namespace grpc_core { diff --git a/test/core/backoff/backoff_test.cc b/test/core/backoff/backoff_test.cc index 2f4ed7de6ec..6e1619e71da 100644 --- a/test/core/backoff/backoff_test.cc +++ b/test/core/backoff/backoff_test.cc @@ -19,6 +19,7 @@ #include "src/core/lib/backoff/backoff.h" #include +#include #include "gtest/gtest.h" diff --git a/test/core/backoff/random_early_detection_test.cc b/test/core/backoff/random_early_detection_test.cc index 38b3de1e86a..778fe873bf0 100644 --- a/test/core/backoff/random_early_detection_test.cc +++ b/test/core/backoff/random_early_detection_test.cc @@ -14,6 +14,8 @@ #include "src/core/lib/backoff/random_early_detection.h" +#include + #include "absl/random/random.h" #include "gtest/gtest.h" diff --git a/test/core/bad_client/tests/bad_streaming_id.cc b/test/core/bad_client/tests/bad_streaming_id.cc index 00abd442407..14c676fb0d9 100644 --- a/test/core/bad_client/tests/bad_streaming_id.cc +++ b/test/core/bad_client/tests/bad_streaming_id.cc @@ -16,6 +16,8 @@ // // +#include + #include #include diff --git a/test/core/bad_client/tests/initial_settings_frame.cc b/test/core/bad_client/tests/initial_settings_frame.cc index be4d2a14464..4f0af52b016 100644 --- a/test/core/bad_client/tests/initial_settings_frame.cc +++ b/test/core/bad_client/tests/initial_settings_frame.cc @@ -16,8 +16,6 @@ // // -#include - #include "absl/strings/str_cat.h" #include diff --git a/test/core/bad_connection/close_fd_test.cc b/test/core/bad_connection/close_fd_test.cc index 06a68a8478a..e940008eb5e 100644 --- a/test/core/bad_connection/close_fd_test.cc +++ b/test/core/bad_connection/close_fd_test.cc @@ -23,8 +23,6 @@ // #include -#include - #include "absl/status/statusor.h" #include "absl/strings/str_format.h" diff --git a/test/core/channel/call_tracer_test.cc b/test/core/channel/call_tracer_test.cc index ceb6cb5ee45..8941142be28 100644 --- a/test/core/channel/call_tracer_test.cc +++ b/test/core/channel/call_tracer_test.cc @@ -18,7 +18,6 @@ #include "src/core/lib/channel/call_tracer.h" -#include #include #include diff --git a/test/core/channel/channel_stack_test.cc b/test/core/channel/channel_stack_test.cc index bef33d8315e..7ed34f60b64 100644 --- a/test/core/channel/channel_stack_test.cc +++ b/test/core/channel/channel_stack_test.cc @@ -18,8 +18,6 @@ #include "src/core/lib/channel/channel_stack.h" -#include - #include "absl/status/status.h" #include "absl/types/optional.h" #include "gtest/gtest.h" diff --git a/test/core/channel/channelz_test.cc b/test/core/channel/channelz_test.cc index 4f346ece06a..3b57b4a6ef7 100644 --- a/test/core/channel/channelz_test.cc +++ b/test/core/channel/channelz_test.cc @@ -24,7 +24,6 @@ #include #include #include -#include #include #include "absl/status/status.h" diff --git a/test/core/channel/server_call_tracer_factory_test.cc b/test/core/channel/server_call_tracer_factory_test.cc index b4e01a50ab1..09e79852fea 100644 --- a/test/core/channel/server_call_tracer_factory_test.cc +++ b/test/core/channel/server_call_tracer_factory_test.cc @@ -12,6 +12,8 @@ // See the License for the specific language governing permissions and // limitations under the License. +#include + #include "gtest/gtest.h" #include "src/core/lib/channel/call_tracer.h" diff --git a/test/core/client_channel/client_channel_test.cc b/test/core/client_channel/client_channel_test.cc index 5e553b1ee20..400f8509a95 100644 --- a/test/core/client_channel/client_channel_test.cc +++ b/test/core/client_channel/client_channel_test.cc @@ -18,6 +18,8 @@ #include "src/core/ext/filters/client_channel/client_channel.h" +#include + #include "absl/types/optional.h" #include "gtest/gtest.h" diff --git a/test/core/client_channel/lb_policy/lb_policy_test_lib.h b/test/core/client_channel/lb_policy/lb_policy_test_lib.h index b202cab2ff9..72ed07319ef 100644 --- a/test/core/client_channel/lb_policy/lb_policy_test_lib.h +++ b/test/core/client_channel/lb_policy/lb_policy_test_lib.h @@ -26,7 +26,6 @@ #include #include #include -#include #include #include #include diff --git a/test/core/client_channel/lb_policy/outlier_detection_lb_config_parser_test.cc b/test/core/client_channel/lb_policy/outlier_detection_lb_config_parser_test.cc index b09e2d1d8a8..a7fede5a639 100644 --- a/test/core/client_channel/lb_policy/outlier_detection_lb_config_parser_test.cc +++ b/test/core/client_channel/lb_policy/outlier_detection_lb_config_parser_test.cc @@ -14,6 +14,8 @@ // limitations under the License. // +#include + #include "absl/status/status.h" #include "absl/status/statusor.h" #include "gmock/gmock.h" diff --git a/test/core/client_channel/lb_policy/rls_lb_config_parser_test.cc b/test/core/client_channel/lb_policy/rls_lb_config_parser_test.cc index cf8d2343af5..3ed3bae3c19 100644 --- a/test/core/client_channel/lb_policy/rls_lb_config_parser_test.cc +++ b/test/core/client_channel/lb_policy/rls_lb_config_parser_test.cc @@ -14,6 +14,8 @@ // limitations under the License. // +#include + #include "absl/status/status.h" #include "absl/status/statusor.h" #include "gmock/gmock.h" diff --git a/test/core/client_channel/lb_policy/round_robin_test.cc b/test/core/client_channel/lb_policy/round_robin_test.cc index ab0924bf5be..d0e5229fd3f 100644 --- a/test/core/client_channel/lb_policy/round_robin_test.cc +++ b/test/core/client_channel/lb_policy/round_robin_test.cc @@ -15,6 +15,7 @@ // #include +#include #include "absl/status/status.h" #include "absl/strings/string_view.h" diff --git a/test/core/client_channel/lb_policy/weighted_round_robin_config_test.cc b/test/core/client_channel/lb_policy/weighted_round_robin_config_test.cc index d3312d9661c..000d2db30e3 100644 --- a/test/core/client_channel/lb_policy/weighted_round_robin_config_test.cc +++ b/test/core/client_channel/lb_policy/weighted_round_robin_config_test.cc @@ -14,6 +14,8 @@ // limitations under the License. // +#include + #include "absl/status/status.h" #include "absl/status/statusor.h" #include "gtest/gtest.h" diff --git a/test/core/client_channel/lb_policy/weighted_round_robin_test.cc b/test/core/client_channel/lb_policy/weighted_round_robin_test.cc index 75f37244f2a..a3efc6d62e2 100644 --- a/test/core/client_channel/lb_policy/weighted_round_robin_test.cc +++ b/test/core/client_channel/lb_policy/weighted_round_robin_test.cc @@ -20,6 +20,7 @@ #include #include #include +#include #include #include #include diff --git a/test/core/client_channel/lb_policy/xds_override_host_lb_config_parser_test.cc b/test/core/client_channel/lb_policy/xds_override_host_lb_config_parser_test.cc index 9871ed5e865..8574c0baccf 100644 --- a/test/core/client_channel/lb_policy/xds_override_host_lb_config_parser_test.cc +++ b/test/core/client_channel/lb_policy/xds_override_host_lb_config_parser_test.cc @@ -14,6 +14,8 @@ // limitations under the License. // +#include + #include "absl/status/status.h" #include "absl/status/statusor.h" #include "gtest/gtest.h" diff --git a/test/core/client_channel/resolvers/binder_resolver_test.cc b/test/core/client_channel/resolvers/binder_resolver_test.cc index 66ad680886d..5c2c7d4fda3 100644 --- a/test/core/client_channel/resolvers/binder_resolver_test.cc +++ b/test/core/client_channel/resolvers/binder_resolver_test.cc @@ -19,7 +19,6 @@ #include "absl/status/status.h" #include "absl/status/statusor.h" -#include "absl/strings/string_view.h" #include "gtest/gtest.h" #include "src/core/lib/config/core_configuration.h" diff --git a/test/core/client_channel/resolvers/fake_resolver_test.cc b/test/core/client_channel/resolvers/fake_resolver_test.cc index f6ac7c32bed..a02bfa24418 100644 --- a/test/core/client_channel/resolvers/fake_resolver_test.cc +++ b/test/core/client_channel/resolvers/fake_resolver_test.cc @@ -23,7 +23,6 @@ #include #include -#include #include #include #include diff --git a/test/core/client_channel/resolvers/google_c2p_resolver_test.cc b/test/core/client_channel/resolvers/google_c2p_resolver_test.cc index 96e717a1be5..ee77b07e469 100644 --- a/test/core/client_channel/resolvers/google_c2p_resolver_test.cc +++ b/test/core/client_channel/resolvers/google_c2p_resolver_test.cc @@ -18,7 +18,6 @@ #include #include -#include #include #include #include @@ -28,7 +27,6 @@ #include "gtest/gtest.h" #include -#include #include #include #include diff --git a/test/core/client_channel/resolvers/sockaddr_resolver_test.cc b/test/core/client_channel/resolvers/sockaddr_resolver_test.cc index b0485c639bd..49cb0db9ac0 100644 --- a/test/core/client_channel/resolvers/sockaddr_resolver_test.cc +++ b/test/core/client_channel/resolvers/sockaddr_resolver_test.cc @@ -22,7 +22,6 @@ #include "absl/status/status.h" #include "absl/status/statusor.h" -#include "absl/strings/string_view.h" #include "gtest/gtest.h" #include diff --git a/test/core/compiler_bugs/miscompile_with_no_unique_address_test.cc b/test/core/compiler_bugs/miscompile_with_no_unique_address_test.cc index 596ff111914..81aa23d06cf 100644 --- a/test/core/compiler_bugs/miscompile_with_no_unique_address_test.cc +++ b/test/core/compiler_bugs/miscompile_with_no_unique_address_test.cc @@ -14,6 +14,8 @@ #include +#include + #include "gtest/gtest.h" // Make a template argument to test which bit pattern remains in A's destructor diff --git a/test/core/compression/compression_test.cc b/test/core/compression/compression_test.cc index 5b03f0a0953..3b869ca5471 100644 --- a/test/core/compression/compression_test.cc +++ b/test/core/compression/compression_test.cc @@ -19,6 +19,8 @@ #include #include +#include + #include "gtest/gtest.h" #include diff --git a/test/core/compression/message_compress_test.cc b/test/core/compression/message_compress_test.cc index bae0122a03b..1cd5a07984d 100644 --- a/test/core/compression/message_compress_test.cc +++ b/test/core/compression/message_compress_test.cc @@ -22,6 +22,8 @@ #include #include +#include + #include "gtest/gtest.h" #include diff --git a/test/core/config/core_configuration_test.cc b/test/core/config/core_configuration_test.cc index 7d39154c846..bf2e10b1890 100644 --- a/test/core/config/core_configuration_test.cc +++ b/test/core/config/core_configuration_test.cc @@ -14,7 +14,6 @@ #include "src/core/lib/config/core_configuration.h" -#include #include #include #include diff --git a/test/core/end2end/BUILD b/test/core/end2end/BUILD index 15300f92f77..f046f6d9ace 100644 --- a/test/core/end2end/BUILD +++ b/test/core/end2end/BUILD @@ -196,6 +196,7 @@ grpc_cc_library( ], external_deps = [ "absl/base:core_headers", + "absl/meta:type_traits", "absl/random", "absl/status", "absl/strings:str_format", diff --git a/test/core/end2end/cq_verifier.cc b/test/core/end2end/cq_verifier.cc index a905c84508b..98112d7523a 100644 --- a/test/core/end2end/cq_verifier.cc +++ b/test/core/end2end/cq_verifier.cc @@ -23,7 +23,6 @@ #include #include -#include #include #include #include diff --git a/test/core/end2end/dualstack_socket_test.cc b/test/core/end2end/dualstack_socket_test.cc index 16d7df29c91..db0d1d710a6 100644 --- a/test/core/end2end/dualstack_socket_test.cc +++ b/test/core/end2end/dualstack_socket_test.cc @@ -17,7 +17,6 @@ // #include -#include #include #include diff --git a/test/core/end2end/end2end_test_suites.cc b/test/core/end2end/end2end_test_suites.cc index a2d2b44c418..eeab30bc63d 100644 --- a/test/core/end2end/end2end_test_suites.cc +++ b/test/core/end2end/end2end_test_suites.cc @@ -18,8 +18,6 @@ #include #include #include -#include -#include #include #include #include @@ -27,6 +25,7 @@ #include #include "absl/base/thread_annotations.h" +#include "absl/meta/type_traits.h" #include "absl/random/random.h" #include "absl/status/status.h" #include "absl/strings/str_format.h" diff --git a/test/core/end2end/fuzzers/client_fuzzer.cc b/test/core/end2end/fuzzers/client_fuzzer.cc index 599db39fe43..5cf394f23b1 100644 --- a/test/core/end2end/fuzzers/client_fuzzer.cc +++ b/test/core/end2end/fuzzers/client_fuzzer.cc @@ -12,6 +12,8 @@ // See the License for the specific language governing permissions and // limitations under the License. +#include + #include "absl/status/statusor.h" #include "absl/types/optional.h" diff --git a/test/core/end2end/fuzzers/fuzzing_common.cc b/test/core/end2end/fuzzers/fuzzing_common.cc index ced2df856c2..683dce5e3a9 100644 --- a/test/core/end2end/fuzzers/fuzzing_common.cc +++ b/test/core/end2end/fuzzers/fuzzing_common.cc @@ -20,10 +20,8 @@ #include -#include #include #include -#include #include "absl/strings/str_cat.h" #include "absl/types/optional.h" diff --git a/test/core/end2end/fuzzers/network_input.cc b/test/core/end2end/fuzzers/network_input.cc index 565195a3265..41bc542734a 100644 --- a/test/core/end2end/fuzzers/network_input.cc +++ b/test/core/end2end/fuzzers/network_input.cc @@ -19,7 +19,6 @@ #include #include -#include #include #include #include diff --git a/test/core/end2end/fuzzers/server_fuzzer.cc b/test/core/end2end/fuzzers/server_fuzzer.cc index 580973a44ea..be2df348792 100644 --- a/test/core/end2end/fuzzers/server_fuzzer.cc +++ b/test/core/end2end/fuzzers/server_fuzzer.cc @@ -12,6 +12,8 @@ // See the License for the specific language governing permissions and // limitations under the License. +#include + #include "absl/types/optional.h" #include @@ -28,7 +30,6 @@ #include "src/core/lib/iomgr/endpoint.h" #include "src/core/lib/iomgr/error.h" #include "src/core/lib/iomgr/exec_ctx.h" -#include "src/core/lib/resource_quota/resource_quota.h" #include "src/core/lib/surface/server.h" #include "src/core/lib/transport/transport_fwd.h" #include "src/libfuzzer/libfuzzer_macro.h" diff --git a/test/core/end2end/tests/bad_ping.cc b/test/core/end2end/tests/bad_ping.cc index d13a19605b2..1aa247e46e3 100644 --- a/test/core/end2end/tests/bad_ping.cc +++ b/test/core/end2end/tests/bad_ping.cc @@ -16,6 +16,8 @@ // // +#include + #include "gtest/gtest.h" #include diff --git a/test/core/end2end/tests/binary_metadata.cc b/test/core/end2end/tests/binary_metadata.cc index 85076d8c6e0..b4718a8c004 100644 --- a/test/core/end2end/tests/binary_metadata.cc +++ b/test/core/end2end/tests/binary_metadata.cc @@ -16,6 +16,8 @@ // // +#include + #include "gtest/gtest.h" #include diff --git a/test/core/end2end/tests/call_host_override.cc b/test/core/end2end/tests/call_host_override.cc index 678e5080373..e56b1deb231 100644 --- a/test/core/end2end/tests/call_host_override.cc +++ b/test/core/end2end/tests/call_host_override.cc @@ -16,6 +16,8 @@ // // +#include + #include "absl/types/optional.h" #include "gtest/gtest.h" diff --git a/test/core/end2end/tests/cancel_before_invoke.cc b/test/core/end2end/tests/cancel_before_invoke.cc index 68dd5aedb78..38432d190f9 100644 --- a/test/core/end2end/tests/cancel_before_invoke.cc +++ b/test/core/end2end/tests/cancel_before_invoke.cc @@ -16,6 +16,8 @@ // // +#include + #include "gtest/gtest.h" #include diff --git a/test/core/end2end/tests/cancel_in_a_vacuum.cc b/test/core/end2end/tests/cancel_in_a_vacuum.cc index 1fa99ffc79f..aadd1c4558d 100644 --- a/test/core/end2end/tests/cancel_in_a_vacuum.cc +++ b/test/core/end2end/tests/cancel_in_a_vacuum.cc @@ -16,6 +16,8 @@ // // +#include + #include "test/core/end2end/end2end_tests.h" namespace grpc_core { diff --git a/test/core/end2end/tests/cancel_with_status.cc b/test/core/end2end/tests/cancel_with_status.cc index 8fb09d3f666..702222ebdf9 100644 --- a/test/core/end2end/tests/cancel_with_status.cc +++ b/test/core/end2end/tests/cancel_with_status.cc @@ -16,6 +16,8 @@ // // +#include + #include "gtest/gtest.h" #include diff --git a/test/core/end2end/tests/client_streaming.cc b/test/core/end2end/tests/client_streaming.cc index 62c4f3034b4..c1c284bd005 100644 --- a/test/core/end2end/tests/client_streaming.cc +++ b/test/core/end2end/tests/client_streaming.cc @@ -16,6 +16,8 @@ // // +#include + #include "gtest/gtest.h" #include diff --git a/test/core/end2end/tests/default_host.cc b/test/core/end2end/tests/default_host.cc index 7cbe6d17a36..8bd53f3bb7a 100644 --- a/test/core/end2end/tests/default_host.cc +++ b/test/core/end2end/tests/default_host.cc @@ -16,6 +16,8 @@ // // +#include + #include "absl/types/optional.h" #include "gmock/gmock.h" #include "gtest/gtest.h" diff --git a/test/core/end2end/tests/disappearing_server.cc b/test/core/end2end/tests/disappearing_server.cc index 557e6ab2383..82857c7d4c0 100644 --- a/test/core/end2end/tests/disappearing_server.cc +++ b/test/core/end2end/tests/disappearing_server.cc @@ -16,6 +16,8 @@ // // +#include + #include "gtest/gtest.h" #include diff --git a/test/core/end2end/tests/empty_batch.cc b/test/core/end2end/tests/empty_batch.cc index b5728f200af..276bacebd39 100644 --- a/test/core/end2end/tests/empty_batch.cc +++ b/test/core/end2end/tests/empty_batch.cc @@ -16,6 +16,8 @@ // // +#include + #include "test/core/end2end/end2end_tests.h" namespace grpc_core { diff --git a/test/core/end2end/tests/filter_causes_close.cc b/test/core/end2end/tests/filter_causes_close.cc index a6f4f7498b3..f8cb97682b8 100644 --- a/test/core/end2end/tests/filter_causes_close.cc +++ b/test/core/end2end/tests/filter_causes_close.cc @@ -19,6 +19,7 @@ #include #include +#include #include "absl/status/status.h" #include "gtest/gtest.h" @@ -37,6 +38,7 @@ #include "src/core/lib/promise/arena_promise.h" #include "src/core/lib/promise/promise.h" #include "src/core/lib/surface/channel_stack_type.h" +#include "src/core/lib/transport/metadata_batch.h" #include "src/core/lib/transport/transport.h" #include "test/core/end2end/end2end_tests.h" diff --git a/test/core/end2end/tests/filter_init_fails.cc b/test/core/end2end/tests/filter_init_fails.cc index be8c7260186..188e7a53a60 100644 --- a/test/core/end2end/tests/filter_init_fails.cc +++ b/test/core/end2end/tests/filter_init_fails.cc @@ -20,6 +20,7 @@ #include #include +#include #include #include "absl/status/status.h" @@ -41,6 +42,7 @@ #include "src/core/lib/promise/arena_promise.h" #include "src/core/lib/promise/promise.h" #include "src/core/lib/surface/channel_stack_type.h" +#include "src/core/lib/transport/metadata_batch.h" #include "src/core/lib/transport/transport.h" #include "test/core/end2end/end2end_tests.h" diff --git a/test/core/end2end/tests/filtered_metadata.cc b/test/core/end2end/tests/filtered_metadata.cc index 0248cb5ff6c..6ec6858d367 100644 --- a/test/core/end2end/tests/filtered_metadata.cc +++ b/test/core/end2end/tests/filtered_metadata.cc @@ -16,6 +16,8 @@ // // +#include + #include "absl/strings/string_view.h" #include "absl/types/optional.h" #include "gtest/gtest.h" diff --git a/test/core/end2end/tests/graceful_server_shutdown.cc b/test/core/end2end/tests/graceful_server_shutdown.cc index 194c436e6ef..4bfc209aa74 100644 --- a/test/core/end2end/tests/graceful_server_shutdown.cc +++ b/test/core/end2end/tests/graceful_server_shutdown.cc @@ -16,6 +16,8 @@ // // +#include + #include "gtest/gtest.h" #include diff --git a/test/core/end2end/tests/grpc_authz.cc b/test/core/end2end/tests/grpc_authz.cc index 0de07397ed8..6421b24f7a6 100644 --- a/test/core/end2end/tests/grpc_authz.cc +++ b/test/core/end2end/tests/grpc_authz.cc @@ -15,7 +15,6 @@ #include #include "absl/status/status.h" -#include "absl/strings/string_view.h" #include "gtest/gtest.h" #include diff --git a/test/core/end2end/tests/high_initial_seqno.cc b/test/core/end2end/tests/high_initial_seqno.cc index e891d25ad11..ac5e0eacc3d 100644 --- a/test/core/end2end/tests/high_initial_seqno.cc +++ b/test/core/end2end/tests/high_initial_seqno.cc @@ -16,6 +16,8 @@ // // +#include + #include "gtest/gtest.h" #include diff --git a/test/core/end2end/tests/invoke_large_request.cc b/test/core/end2end/tests/invoke_large_request.cc index 92ddacc4acf..f7c5eb7cbe6 100644 --- a/test/core/end2end/tests/invoke_large_request.cc +++ b/test/core/end2end/tests/invoke_large_request.cc @@ -18,6 +18,8 @@ #include +#include + #include "gtest/gtest.h" #include diff --git a/test/core/end2end/tests/keepalive_timeout.cc b/test/core/end2end/tests/keepalive_timeout.cc index a001c8112dc..70aafa9f9d8 100644 --- a/test/core/end2end/tests/keepalive_timeout.cc +++ b/test/core/end2end/tests/keepalive_timeout.cc @@ -16,6 +16,8 @@ // // +#include + #include "absl/strings/string_view.h" #include "gtest/gtest.h" diff --git a/test/core/end2end/tests/large_metadata.cc b/test/core/end2end/tests/large_metadata.cc index d44f5e725ba..499e3ff6886 100644 --- a/test/core/end2end/tests/large_metadata.cc +++ b/test/core/end2end/tests/large_metadata.cc @@ -20,7 +20,6 @@ #include -#include "absl/strings/string_view.h" #include "gmock/gmock.h" #include "gtest/gtest.h" diff --git a/test/core/end2end/tests/max_concurrent_streams.cc b/test/core/end2end/tests/max_concurrent_streams.cc index b8aa9898249..154251ea655 100644 --- a/test/core/end2end/tests/max_concurrent_streams.cc +++ b/test/core/end2end/tests/max_concurrent_streams.cc @@ -16,6 +16,8 @@ // // +#include + #include "gtest/gtest.h" #include diff --git a/test/core/end2end/tests/max_connection_age.cc b/test/core/end2end/tests/max_connection_age.cc index 9a1a47cea03..f8ac906e7b5 100644 --- a/test/core/end2end/tests/max_connection_age.cc +++ b/test/core/end2end/tests/max_connection_age.cc @@ -18,6 +18,8 @@ #include +#include + #include "gtest/gtest.h" #include diff --git a/test/core/end2end/tests/max_connection_idle.cc b/test/core/end2end/tests/max_connection_idle.cc index 3c8332f2e33..1fd5285a2be 100644 --- a/test/core/end2end/tests/max_connection_idle.cc +++ b/test/core/end2end/tests/max_connection_idle.cc @@ -16,6 +16,8 @@ // // +#include + #include "absl/types/optional.h" #include "gmock/gmock.h" #include "gtest/gtest.h" diff --git a/test/core/end2end/tests/max_message_length.cc b/test/core/end2end/tests/max_message_length.cc index 83c53f01b86..8d472ca6660 100644 --- a/test/core/end2end/tests/max_message_length.cc +++ b/test/core/end2end/tests/max_message_length.cc @@ -18,7 +18,6 @@ #include -#include "absl/strings/string_view.h" #include "gmock/gmock.h" #include "gtest/gtest.h" diff --git a/test/core/end2end/tests/negative_deadline.cc b/test/core/end2end/tests/negative_deadline.cc index cb9d1bc156b..dc418784048 100644 --- a/test/core/end2end/tests/negative_deadline.cc +++ b/test/core/end2end/tests/negative_deadline.cc @@ -16,6 +16,8 @@ // // +#include + #include "gtest/gtest.h" #include diff --git a/test/core/end2end/tests/no_logging.cc b/test/core/end2end/tests/no_logging.cc index 4b875cb1a5c..774d7bfe712 100644 --- a/test/core/end2end/tests/no_logging.cc +++ b/test/core/end2end/tests/no_logging.cc @@ -21,7 +21,6 @@ #include #include #include -#include #include "absl/strings/str_cat.h" #include "absl/strings/string_view.h" diff --git a/test/core/end2end/tests/payload.cc b/test/core/end2end/tests/payload.cc index 9ed3a0281ad..6bcb041a7aa 100644 --- a/test/core/end2end/tests/payload.cc +++ b/test/core/end2end/tests/payload.cc @@ -16,6 +16,8 @@ // // +#include + #include "gtest/gtest.h" #include diff --git a/test/core/end2end/tests/ping_pong_streaming.cc b/test/core/end2end/tests/ping_pong_streaming.cc index 009675237ca..1bec19445b3 100644 --- a/test/core/end2end/tests/ping_pong_streaming.cc +++ b/test/core/end2end/tests/ping_pong_streaming.cc @@ -16,6 +16,8 @@ // // +#include + #include #include "src/core/lib/gprpp/time.h" diff --git a/test/core/end2end/tests/proxy_auth.cc b/test/core/end2end/tests/proxy_auth.cc index 4de91f8c758..1de11151610 100644 --- a/test/core/end2end/tests/proxy_auth.cc +++ b/test/core/end2end/tests/proxy_auth.cc @@ -16,6 +16,8 @@ // // +#include + #include "absl/types/optional.h" #include "gtest/gtest.h" diff --git a/test/core/end2end/tests/request_with_payload.cc b/test/core/end2end/tests/request_with_payload.cc index 370a65ee588..bbfdf8ce5ed 100644 --- a/test/core/end2end/tests/request_with_payload.cc +++ b/test/core/end2end/tests/request_with_payload.cc @@ -16,6 +16,8 @@ // // +#include + #include "gtest/gtest.h" #include diff --git a/test/core/end2end/tests/resource_quota_server.cc b/test/core/end2end/tests/resource_quota_server.cc index 680106cd1a1..acf4c109089 100644 --- a/test/core/end2end/tests/resource_quota_server.cc +++ b/test/core/end2end/tests/resource_quota_server.cc @@ -19,7 +19,6 @@ #include #include -#include #include #include "absl/strings/str_format.h" diff --git a/test/core/end2end/tests/retry.cc b/test/core/end2end/tests/retry.cc index 84991d0e42d..ad9d875f9d1 100644 --- a/test/core/end2end/tests/retry.cc +++ b/test/core/end2end/tests/retry.cc @@ -16,6 +16,8 @@ // // +#include + #include "absl/types/optional.h" #include "gtest/gtest.h" diff --git a/test/core/end2end/tests/retry_cancel_after_first_attempt_starts.cc b/test/core/end2end/tests/retry_cancel_after_first_attempt_starts.cc index cbe7dcd517d..e8998799f40 100644 --- a/test/core/end2end/tests/retry_cancel_after_first_attempt_starts.cc +++ b/test/core/end2end/tests/retry_cancel_after_first_attempt_starts.cc @@ -14,6 +14,8 @@ // limitations under the License. // +#include + #include "absl/types/optional.h" #include diff --git a/test/core/end2end/tests/retry_cancel_during_delay.cc b/test/core/end2end/tests/retry_cancel_during_delay.cc index 5018b796a52..19606535468 100644 --- a/test/core/end2end/tests/retry_cancel_during_delay.cc +++ b/test/core/end2end/tests/retry_cancel_during_delay.cc @@ -14,7 +14,6 @@ // limitations under the License. // -#include #include #include "absl/strings/str_format.h" diff --git a/test/core/end2end/tests/retry_cancel_with_multiple_send_batches.cc b/test/core/end2end/tests/retry_cancel_with_multiple_send_batches.cc index 28b3f04d4a2..578c253198a 100644 --- a/test/core/end2end/tests/retry_cancel_with_multiple_send_batches.cc +++ b/test/core/end2end/tests/retry_cancel_with_multiple_send_batches.cc @@ -16,7 +16,6 @@ // // -#include #include #include diff --git a/test/core/end2end/tests/retry_disabled.cc b/test/core/end2end/tests/retry_disabled.cc index f16295d9475..dc59d38f28b 100644 --- a/test/core/end2end/tests/retry_disabled.cc +++ b/test/core/end2end/tests/retry_disabled.cc @@ -16,6 +16,8 @@ // // +#include + #include "absl/types/optional.h" #include "gtest/gtest.h" diff --git a/test/core/end2end/tests/retry_exceeds_buffer_size_in_initial_batch.cc b/test/core/end2end/tests/retry_exceeds_buffer_size_in_initial_batch.cc index 47476a023b3..9d1382f4fa7 100644 --- a/test/core/end2end/tests/retry_exceeds_buffer_size_in_initial_batch.cc +++ b/test/core/end2end/tests/retry_exceeds_buffer_size_in_initial_batch.cc @@ -16,6 +16,8 @@ // // +#include + #include "absl/types/optional.h" #include "gtest/gtest.h" diff --git a/test/core/end2end/tests/retry_lb_fail.cc b/test/core/end2end/tests/retry_lb_fail.cc index 75d8dca976e..bb015ed2081 100644 --- a/test/core/end2end/tests/retry_lb_fail.cc +++ b/test/core/end2end/tests/retry_lb_fail.cc @@ -15,6 +15,7 @@ // #include +#include #include "absl/status/status.h" #include "gtest/gtest.h" diff --git a/test/core/end2end/tests/retry_non_retriable_status.cc b/test/core/end2end/tests/retry_non_retriable_status.cc index 45e8b923461..ce09e2a575d 100644 --- a/test/core/end2end/tests/retry_non_retriable_status.cc +++ b/test/core/end2end/tests/retry_non_retriable_status.cc @@ -16,6 +16,8 @@ // // +#include + #include "absl/types/optional.h" #include "gtest/gtest.h" diff --git a/test/core/end2end/tests/retry_non_retriable_status_before_trailers.cc b/test/core/end2end/tests/retry_non_retriable_status_before_trailers.cc index b4a083d687b..55bd0480e1f 100644 --- a/test/core/end2end/tests/retry_non_retriable_status_before_trailers.cc +++ b/test/core/end2end/tests/retry_non_retriable_status_before_trailers.cc @@ -16,6 +16,8 @@ // // +#include + #include "absl/types/optional.h" #include "gtest/gtest.h" diff --git a/test/core/end2end/tests/retry_per_attempt_recv_timeout.cc b/test/core/end2end/tests/retry_per_attempt_recv_timeout.cc index 20103656be4..9d06d0b5c3d 100644 --- a/test/core/end2end/tests/retry_per_attempt_recv_timeout.cc +++ b/test/core/end2end/tests/retry_per_attempt_recv_timeout.cc @@ -14,7 +14,7 @@ // limitations under the License. // -#include +#include #include "absl/strings/str_format.h" #include "absl/types/optional.h" diff --git a/test/core/end2end/tests/retry_per_attempt_recv_timeout_on_last_attempt.cc b/test/core/end2end/tests/retry_per_attempt_recv_timeout_on_last_attempt.cc index 45e4ae87058..bcee49d5bc2 100644 --- a/test/core/end2end/tests/retry_per_attempt_recv_timeout_on_last_attempt.cc +++ b/test/core/end2end/tests/retry_per_attempt_recv_timeout_on_last_attempt.cc @@ -14,7 +14,7 @@ // limitations under the License. // -#include +#include #include "absl/strings/str_format.h" #include "absl/types/optional.h" diff --git a/test/core/end2end/tests/retry_recv_initial_metadata.cc b/test/core/end2end/tests/retry_recv_initial_metadata.cc index eee7683da39..9c83255e2ac 100644 --- a/test/core/end2end/tests/retry_recv_initial_metadata.cc +++ b/test/core/end2end/tests/retry_recv_initial_metadata.cc @@ -16,7 +16,8 @@ // // -#include "absl/strings/string_view.h" +#include + #include "absl/types/optional.h" #include "gtest/gtest.h" diff --git a/test/core/end2end/tests/retry_recv_message.cc b/test/core/end2end/tests/retry_recv_message.cc index bf231e59e3d..bee892a9e9e 100644 --- a/test/core/end2end/tests/retry_recv_message.cc +++ b/test/core/end2end/tests/retry_recv_message.cc @@ -16,6 +16,8 @@ // // +#include + #include "absl/types/optional.h" #include "gtest/gtest.h" diff --git a/test/core/end2end/tests/retry_recv_message_replay.cc b/test/core/end2end/tests/retry_recv_message_replay.cc index ba3000afa14..25163aa2b3c 100644 --- a/test/core/end2end/tests/retry_recv_message_replay.cc +++ b/test/core/end2end/tests/retry_recv_message_replay.cc @@ -16,6 +16,7 @@ // // +#include #include #include "absl/status/status.h" diff --git a/test/core/end2end/tests/retry_recv_trailing_metadata_error.cc b/test/core/end2end/tests/retry_recv_trailing_metadata_error.cc index 8f0ddeb2ab1..943e2b411e9 100644 --- a/test/core/end2end/tests/retry_recv_trailing_metadata_error.cc +++ b/test/core/end2end/tests/retry_recv_trailing_metadata_error.cc @@ -14,6 +14,7 @@ // limitations under the License. // +#include #include #include "absl/status/status.h" diff --git a/test/core/end2end/tests/retry_send_initial_metadata_refs.cc b/test/core/end2end/tests/retry_send_initial_metadata_refs.cc index 676efd1543c..5958580cb90 100644 --- a/test/core/end2end/tests/retry_send_initial_metadata_refs.cc +++ b/test/core/end2end/tests/retry_send_initial_metadata_refs.cc @@ -18,7 +18,6 @@ #include -#include "absl/strings/string_view.h" #include "absl/types/optional.h" #include "gtest/gtest.h" diff --git a/test/core/end2end/tests/retry_send_op_fails.cc b/test/core/end2end/tests/retry_send_op_fails.cc index cc45fe051ac..b3ecadd7d8c 100644 --- a/test/core/end2end/tests/retry_send_op_fails.cc +++ b/test/core/end2end/tests/retry_send_op_fails.cc @@ -16,6 +16,7 @@ // // +#include #include #include "absl/status/status.h" diff --git a/test/core/end2end/tests/retry_send_recv_batch.cc b/test/core/end2end/tests/retry_send_recv_batch.cc index 01e488cf36c..75194d043c3 100644 --- a/test/core/end2end/tests/retry_send_recv_batch.cc +++ b/test/core/end2end/tests/retry_send_recv_batch.cc @@ -14,6 +14,8 @@ // limitations under the License. // +#include + #include "gtest/gtest.h" #include diff --git a/test/core/end2end/tests/retry_server_pushback_delay.cc b/test/core/end2end/tests/retry_server_pushback_delay.cc index 4eacd99fdbb..dff07f9698f 100644 --- a/test/core/end2end/tests/retry_server_pushback_delay.cc +++ b/test/core/end2end/tests/retry_server_pushback_delay.cc @@ -16,7 +16,8 @@ // // -#include "absl/strings/string_view.h" +#include + #include "absl/types/optional.h" #include "gtest/gtest.h" diff --git a/test/core/end2end/tests/retry_server_pushback_disabled.cc b/test/core/end2end/tests/retry_server_pushback_disabled.cc index 268bb6a041d..ecbac8e8969 100644 --- a/test/core/end2end/tests/retry_server_pushback_disabled.cc +++ b/test/core/end2end/tests/retry_server_pushback_disabled.cc @@ -16,7 +16,8 @@ // // -#include "absl/strings/string_view.h" +#include + #include "absl/types/optional.h" #include "gtest/gtest.h" diff --git a/test/core/end2end/tests/retry_streaming_after_commit.cc b/test/core/end2end/tests/retry_streaming_after_commit.cc index fb65325a9c8..ecb42085956 100644 --- a/test/core/end2end/tests/retry_streaming_after_commit.cc +++ b/test/core/end2end/tests/retry_streaming_after_commit.cc @@ -16,6 +16,8 @@ // // +#include + #include "absl/types/optional.h" #include "gtest/gtest.h" diff --git a/test/core/end2end/tests/retry_streaming_succeeds_before_replay_finished.cc b/test/core/end2end/tests/retry_streaming_succeeds_before_replay_finished.cc index f9621b84a24..6870ec0ab9f 100644 --- a/test/core/end2end/tests/retry_streaming_succeeds_before_replay_finished.cc +++ b/test/core/end2end/tests/retry_streaming_succeeds_before_replay_finished.cc @@ -16,6 +16,8 @@ // // +#include + #include "absl/types/optional.h" #include "gtest/gtest.h" diff --git a/test/core/end2end/tests/retry_throttled.cc b/test/core/end2end/tests/retry_throttled.cc index 3dba07c026b..52415d623ea 100644 --- a/test/core/end2end/tests/retry_throttled.cc +++ b/test/core/end2end/tests/retry_throttled.cc @@ -16,6 +16,8 @@ // // +#include + #include "absl/types/optional.h" #include "gtest/gtest.h" diff --git a/test/core/end2end/tests/retry_too_many_attempts.cc b/test/core/end2end/tests/retry_too_many_attempts.cc index 43c4e82d9c6..a51a9abb439 100644 --- a/test/core/end2end/tests/retry_too_many_attempts.cc +++ b/test/core/end2end/tests/retry_too_many_attempts.cc @@ -16,6 +16,8 @@ // // +#include + #include "absl/types/optional.h" #include "gtest/gtest.h" diff --git a/test/core/end2end/tests/retry_transparent_goaway.cc b/test/core/end2end/tests/retry_transparent_goaway.cc index a1d3609f5a3..f00ad2c15c0 100644 --- a/test/core/end2end/tests/retry_transparent_goaway.cc +++ b/test/core/end2end/tests/retry_transparent_goaway.cc @@ -14,6 +14,7 @@ // limitations under the License. // +#include #include #include "absl/status/status.h" diff --git a/test/core/end2end/tests/retry_transparent_max_concurrent_streams.cc b/test/core/end2end/tests/retry_transparent_max_concurrent_streams.cc index 335d934423e..f5ed1821637 100644 --- a/test/core/end2end/tests/retry_transparent_max_concurrent_streams.cc +++ b/test/core/end2end/tests/retry_transparent_max_concurrent_streams.cc @@ -14,6 +14,8 @@ // limitations under the License. // +#include + #include "absl/types/optional.h" #include "gtest/gtest.h" diff --git a/test/core/end2end/tests/retry_transparent_not_sent_on_wire.cc b/test/core/end2end/tests/retry_transparent_not_sent_on_wire.cc index b5766886874..29acc7e4279 100644 --- a/test/core/end2end/tests/retry_transparent_not_sent_on_wire.cc +++ b/test/core/end2end/tests/retry_transparent_not_sent_on_wire.cc @@ -16,6 +16,7 @@ #include +#include #include #include "absl/status/status.h" diff --git a/test/core/end2end/tests/retry_unref_before_finish.cc b/test/core/end2end/tests/retry_unref_before_finish.cc index ceff069e9ce..8957160457b 100644 --- a/test/core/end2end/tests/retry_unref_before_finish.cc +++ b/test/core/end2end/tests/retry_unref_before_finish.cc @@ -14,6 +14,8 @@ // limitations under the License. // +#include + #include "gtest/gtest.h" #include diff --git a/test/core/end2end/tests/retry_unref_before_recv.cc b/test/core/end2end/tests/retry_unref_before_recv.cc index a11c3c5bc4f..c6503dea747 100644 --- a/test/core/end2end/tests/retry_unref_before_recv.cc +++ b/test/core/end2end/tests/retry_unref_before_recv.cc @@ -14,6 +14,8 @@ // limitations under the License. // +#include + #include "absl/types/optional.h" #include "gtest/gtest.h" diff --git a/test/core/end2end/tests/server_finishes_request.cc b/test/core/end2end/tests/server_finishes_request.cc index 3b47e11cedb..5d27facf228 100644 --- a/test/core/end2end/tests/server_finishes_request.cc +++ b/test/core/end2end/tests/server_finishes_request.cc @@ -16,6 +16,8 @@ // // +#include + #include "gtest/gtest.h" #include diff --git a/test/core/end2end/tests/server_streaming.cc b/test/core/end2end/tests/server_streaming.cc index 0982094a365..76e61ac1cd6 100644 --- a/test/core/end2end/tests/server_streaming.cc +++ b/test/core/end2end/tests/server_streaming.cc @@ -16,6 +16,8 @@ // // +#include + #include "gtest/gtest.h" #include diff --git a/test/core/end2end/tests/shutdown_finishes_calls.cc b/test/core/end2end/tests/shutdown_finishes_calls.cc index 6997da88b02..8b305bf78e2 100644 --- a/test/core/end2end/tests/shutdown_finishes_calls.cc +++ b/test/core/end2end/tests/shutdown_finishes_calls.cc @@ -16,6 +16,8 @@ // // +#include + #include "gtest/gtest.h" #include diff --git a/test/core/end2end/tests/simple_delayed_request.cc b/test/core/end2end/tests/simple_delayed_request.cc index 1cf0885225b..e22ea978335 100644 --- a/test/core/end2end/tests/simple_delayed_request.cc +++ b/test/core/end2end/tests/simple_delayed_request.cc @@ -16,6 +16,8 @@ // // +#include + #include "gtest/gtest.h" #include diff --git a/test/core/end2end/tests/simple_metadata.cc b/test/core/end2end/tests/simple_metadata.cc index 24983ccc44b..0fbfc3c685e 100644 --- a/test/core/end2end/tests/simple_metadata.cc +++ b/test/core/end2end/tests/simple_metadata.cc @@ -16,6 +16,8 @@ // // +#include + #include "gtest/gtest.h" #include diff --git a/test/core/end2end/tests/streaming_error_response.cc b/test/core/end2end/tests/streaming_error_response.cc index 004ed53f4a1..8861e89d4ec 100644 --- a/test/core/end2end/tests/streaming_error_response.cc +++ b/test/core/end2end/tests/streaming_error_response.cc @@ -19,6 +19,8 @@ /// \file Verify that status ordering rules are obeyed. /// \ref doc/status_ordering.md +#include + #include "gtest/gtest.h" #include diff --git a/test/core/end2end/tests/trailing_metadata.cc b/test/core/end2end/tests/trailing_metadata.cc index cfd3f1ecada..9b8de263def 100644 --- a/test/core/end2end/tests/trailing_metadata.cc +++ b/test/core/end2end/tests/trailing_metadata.cc @@ -16,6 +16,8 @@ // // +#include + #include "gtest/gtest.h" #include diff --git a/test/core/end2end/tests/write_buffering.cc b/test/core/end2end/tests/write_buffering.cc index 81d3f5e0b94..6cddfffbec8 100644 --- a/test/core/end2end/tests/write_buffering.cc +++ b/test/core/end2end/tests/write_buffering.cc @@ -16,6 +16,8 @@ // // +#include + #include "gtest/gtest.h" #include diff --git a/test/core/end2end/tests/write_buffering_at_end.cc b/test/core/end2end/tests/write_buffering_at_end.cc index aa80b72efd1..efaedeaa921 100644 --- a/test/core/end2end/tests/write_buffering_at_end.cc +++ b/test/core/end2end/tests/write_buffering_at_end.cc @@ -16,6 +16,8 @@ // // +#include + #include "gtest/gtest.h" #include diff --git a/test/core/event_engine/common_closures_test.cc b/test/core/event_engine/common_closures_test.cc index 6149bad16a0..c1a184a011b 100644 --- a/test/core/event_engine/common_closures_test.cc +++ b/test/core/event_engine/common_closures_test.cc @@ -16,6 +16,8 @@ #include "src/core/lib/event_engine/common_closures.h" +#include + #include "absl/functional/any_invocable.h" #include "gtest/gtest.h" diff --git a/test/core/event_engine/endpoint_config_test.cc b/test/core/event_engine/endpoint_config_test.cc index 10b639235b3..329f09ee639 100644 --- a/test/core/event_engine/endpoint_config_test.cc +++ b/test/core/event_engine/endpoint_config_test.cc @@ -13,6 +13,8 @@ // limitations under the License. #include +#include + #include "absl/types/optional.h" #include "gtest/gtest.h" diff --git a/test/core/event_engine/forkable_test.cc b/test/core/event_engine/forkable_test.cc index 15d702c7fa7..55f591c6ebe 100644 --- a/test/core/event_engine/forkable_test.cc +++ b/test/core/event_engine/forkable_test.cc @@ -23,6 +23,8 @@ #include #endif // GPR_POSIX_SUBPROCESS +#include + #include "absl/types/optional.h" #include "gtest/gtest.h" diff --git a/test/core/event_engine/fuzzing_event_engine/fuzzing_event_engine.h b/test/core/event_engine/fuzzing_event_engine/fuzzing_event_engine.h index 27ff7a813a1..5f83f44c9ea 100644 --- a/test/core/event_engine/fuzzing_event_engine/fuzzing_event_engine.h +++ b/test/core/event_engine/fuzzing_event_engine/fuzzing_event_engine.h @@ -22,7 +22,6 @@ #include #include #include -#include #include #include #include diff --git a/test/core/event_engine/handle_tests.cc b/test/core/event_engine/handle_tests.cc index be5c35f9e23..335d48bb938 100644 --- a/test/core/event_engine/handle_tests.cc +++ b/test/core/event_engine/handle_tests.cc @@ -13,6 +13,8 @@ // limitations under the License. #include +#include + #include "gtest/gtest.h" #include diff --git a/test/core/event_engine/mock_event_engine.h b/test/core/event_engine/mock_event_engine.h index e25f526cc7f..62266bdb12d 100644 --- a/test/core/event_engine/mock_event_engine.h +++ b/test/core/event_engine/mock_event_engine.h @@ -15,7 +15,6 @@ #ifndef GRPC_TEST_CORE_EVENT_ENGINE_MOCK_EVENT_ENGINE_H #define GRPC_TEST_CORE_EVENT_ENGINE_MOCK_EVENT_ENGINE_H -#include #include #include "absl/functional/any_invocable.h" diff --git a/test/core/event_engine/posix/event_poller_posix_test.cc b/test/core/event_engine/posix/event_poller_posix_test.cc index 15700abb121..8f81cdf2639 100644 --- a/test/core/event_engine/posix/event_poller_posix_test.cc +++ b/test/core/event_engine/posix/event_poller_posix_test.cc @@ -19,9 +19,7 @@ #include #include #include -#include #include -#include #include #include "absl/status/statusor.h" diff --git a/test/core/event_engine/posix/posix_endpoint_test.cc b/test/core/event_engine/posix/posix_endpoint_test.cc index e58bd84bf3e..31852e8da7f 100644 --- a/test/core/event_engine/posix/posix_endpoint_test.cc +++ b/test/core/event_engine/posix/posix_endpoint_test.cc @@ -18,7 +18,6 @@ #include #include #include -#include #include #include #include diff --git a/test/core/event_engine/posix/posix_engine_test_utils.cc b/test/core/event_engine/posix/posix_engine_test_utils.cc index 4c81939bc42..fabceaf167c 100644 --- a/test/core/event_engine/posix/posix_engine_test_utils.cc +++ b/test/core/event_engine/posix/posix_engine_test_utils.cc @@ -20,8 +20,6 @@ #include #include -#include - #include "absl/strings/str_format.h" #include diff --git a/test/core/event_engine/posix/posix_event_engine_connect_test.cc b/test/core/event_engine/posix/posix_event_engine_connect_test.cc index 9d988259ee9..e436e77f60b 100644 --- a/test/core/event_engine/posix/posix_event_engine_connect_test.cc +++ b/test/core/event_engine/posix/posix_event_engine_connect_test.cc @@ -14,7 +14,6 @@ #include #include #include -#include #include #include #include @@ -22,9 +21,7 @@ #include #include #include -#include #include -#include #include #include #include diff --git a/test/core/event_engine/posix/tcp_posix_socket_utils_test.cc b/test/core/event_engine/posix/tcp_posix_socket_utils_test.cc index abc17c5520c..d958b191cd0 100644 --- a/test/core/event_engine/posix/tcp_posix_socket_utils_test.cc +++ b/test/core/event_engine/posix/tcp_posix_socket_utils_test.cc @@ -15,6 +15,8 @@ #include #include +#include + #include "absl/status/status.h" #include "gtest/gtest.h" diff --git a/test/core/event_engine/posix/timer_manager_test.cc b/test/core/event_engine/posix/timer_manager_test.cc index a7449154e93..ad30ab4804e 100644 --- a/test/core/event_engine/posix/timer_manager_test.cc +++ b/test/core/event_engine/posix/timer_manager_test.cc @@ -14,7 +14,6 @@ #include "src/core/lib/event_engine/posix_engine/timer_manager.h" -#include #include #include #include diff --git a/test/core/event_engine/posix/traced_buffer_list_test.cc b/test/core/event_engine/posix/traced_buffer_list_test.cc index afb3a9e7cb4..c765c674212 100644 --- a/test/core/event_engine/posix/traced_buffer_list_test.cc +++ b/test/core/event_engine/posix/traced_buffer_list_test.cc @@ -16,6 +16,8 @@ #include +#include + #include "gtest/gtest.h" #include diff --git a/test/core/event_engine/slice_buffer_test.cc b/test/core/event_engine/slice_buffer_test.cc index 5330795581f..7ebf7ba4bc4 100644 --- a/test/core/event_engine/slice_buffer_test.cc +++ b/test/core/event_engine/slice_buffer_test.cc @@ -16,6 +16,7 @@ #include +#include #include #include "gtest/gtest.h" diff --git a/test/core/event_engine/test_init.cc b/test/core/event_engine/test_init.cc index 341cb4ae3f8..a8aa559894f 100644 --- a/test/core/event_engine/test_init.cc +++ b/test/core/event_engine/test_init.cc @@ -15,6 +15,8 @@ #include "test/core/event_engine/test_init.h" +#include + #include "absl/strings/str_cat.h" namespace grpc_event_engine { diff --git a/test/core/event_engine/test_suite/posix/oracle_event_engine_posix.cc b/test/core/event_engine/test_suite/posix/oracle_event_engine_posix.cc index ee3bb8bae9b..465e80713c9 100644 --- a/test/core/event_engine/test_suite/posix/oracle_event_engine_posix.cc +++ b/test/core/event_engine/test_suite/posix/oracle_event_engine_posix.cc @@ -21,7 +21,6 @@ #include #include #include -#include #include #include "absl/status/status.h" diff --git a/test/core/event_engine/test_suite/tests/client_test.cc b/test/core/event_engine/test_suite/tests/client_test.cc index 47bcf4236f4..7071973da44 100644 --- a/test/core/event_engine/test_suite/tests/client_test.cc +++ b/test/core/event_engine/test_suite/tests/client_test.cc @@ -12,12 +12,9 @@ // See the License for the specific language governing permissions and // limitations under the License. -#include - #include #include #include -#include #include #include #include diff --git a/test/core/event_engine/test_suite/tests/dns_test.cc b/test/core/event_engine/test_suite/tests/dns_test.cc index 5149959c82b..4c09f49846e 100644 --- a/test/core/event_engine/test_suite/tests/dns_test.cc +++ b/test/core/event_engine/test_suite/tests/dns_test.cc @@ -17,7 +17,6 @@ #include #include -#include #include #include #include diff --git a/test/core/event_engine/test_suite/tests/server_test.cc b/test/core/event_engine/test_suite/tests/server_test.cc index bbcba7e9352..bd88a1325ff 100644 --- a/test/core/event_engine/test_suite/tests/server_test.cc +++ b/test/core/event_engine/test_suite/tests/server_test.cc @@ -12,12 +12,9 @@ // See the License for the specific language governing permissions and // limitations under the License. -#include - #include #include #include -#include #include #include #include diff --git a/test/core/event_engine/test_suite/tests/timer_test.cc b/test/core/event_engine/test_suite/tests/timer_test.cc index e5865851a08..d0ad5fd211b 100644 --- a/test/core/event_engine/test_suite/tests/timer_test.cc +++ b/test/core/event_engine/test_suite/tests/timer_test.cc @@ -18,7 +18,6 @@ #include #include #include -#include #include #include #include diff --git a/test/core/event_engine/test_suite/tools/echo_client.cc b/test/core/event_engine/test_suite/tools/echo_client.cc index 3f527bc4a8b..e821730aaba 100644 --- a/test/core/event_engine/test_suite/tools/echo_client.cc +++ b/test/core/event_engine/test_suite/tools/echo_client.cc @@ -13,7 +13,6 @@ // limitations under the License. #include -#include #include #include @@ -32,9 +31,7 @@ // //test/core/event_engine/test_suite/tools:my_event_engine_echo_client #include -#include #include -#include #include #include @@ -44,7 +41,6 @@ #include "absl/status/status.h" #include "absl/status/statusor.h" #include "absl/strings/str_format.h" -#include "absl/strings/string_view.h" #include #include diff --git a/test/core/event_engine/thread_pool_test.cc b/test/core/event_engine/thread_pool_test.cc index 4cb1426c892..55fe074d72a 100644 --- a/test/core/event_engine/thread_pool_test.cc +++ b/test/core/event_engine/thread_pool_test.cc @@ -14,7 +14,6 @@ #include "src/core/lib/event_engine/thread_pool/thread_pool.h" -#include #include #include #include diff --git a/test/core/experiments/experiments_test.cc b/test/core/experiments/experiments_test.cc index 618cccde8cb..f9513624f7f 100644 --- a/test/core/experiments/experiments_test.cc +++ b/test/core/experiments/experiments_test.cc @@ -18,6 +18,8 @@ #include "test/core/experiments/fixtures/experiments.h" +#include + #include "gtest/gtest.h" #include "src/core/lib/experiments/config.h" diff --git a/test/core/filters/BUILD b/test/core/filters/BUILD index 470473d5996..a3f47f166a5 100644 --- a/test/core/filters/BUILD +++ b/test/core/filters/BUILD @@ -55,7 +55,10 @@ grpc_cc_library( grpc_cc_test( name = "filter_test_test", srcs = ["filter_test_test.cc"], - external_deps = ["gtest"], + external_deps = [ + "absl/status:statusor", + "gtest", + ], uses_event_engine = False, uses_polling = False, deps = [ @@ -63,6 +66,7 @@ grpc_cc_test( "//:grpc_unsecure", "//src/core:activity", "//src/core:arena_promise", + "//src/core:channel_args", "//src/core:map", "//src/core:pipe", "//src/core:poll", @@ -78,7 +82,6 @@ grpc_cc_test( "absl/status", "absl/status:statusor", "absl/strings", - "absl/types:optional", "gtest", ], language = "c++", @@ -87,7 +90,6 @@ grpc_cc_test( deps = [ "filter_test", "//:grpc", - "//:grpc_public_hdrs", "//:grpc_security_base", "//:promise", "//:ref_counted_ptr", @@ -105,7 +107,6 @@ grpc_cc_test( external_deps = [ "absl/status", "absl/strings", - "absl/types:optional", "gtest", ], language = "c++", @@ -113,7 +114,7 @@ grpc_cc_test( uses_polling = False, deps = [ "filter_test", - "//:grpc", + "//:channel_arg_names", "//src/core:grpc_client_authority_filter", ], ) diff --git a/test/core/filters/client_auth_filter_test.cc b/test/core/filters/client_auth_filter_test.cc index f8343bf8282..4596cdee59f 100644 --- a/test/core/filters/client_auth_filter_test.cc +++ b/test/core/filters/client_auth_filter_test.cc @@ -18,14 +18,12 @@ #include "absl/status/status.h" #include "absl/status/statusor.h" #include "absl/strings/string_view.h" -#include "absl/types/optional.h" #include "gmock/gmock.h" #include "gtest/gtest.h" #include #include #include -#include #include "src/core/lib/channel/channel_args.h" #include "src/core/lib/channel/promise_based_filter.h" @@ -39,6 +37,7 @@ #include "src/core/lib/security/credentials/fake/fake_credentials.h" #include "src/core/lib/security/security_connector/security_connector.h" #include "src/core/lib/security/transport/auth_filters.h" +#include "src/core/lib/transport/metadata_batch.h" #include "src/core/lib/transport/transport.h" #include "test/core/filters/filter_test.h" diff --git a/test/core/filters/client_authority_filter_test.cc b/test/core/filters/client_authority_filter_test.cc index 06a438fec91..cdb99d9999d 100644 --- a/test/core/filters/client_authority_filter_test.cc +++ b/test/core/filters/client_authority_filter_test.cc @@ -14,13 +14,14 @@ #include "src/core/ext/filters/http/client_authority_filter.h" +#include + #include "absl/status/status.h" #include "absl/strings/string_view.h" -#include "absl/types/optional.h" #include "gmock/gmock.h" #include "gtest/gtest.h" -#include +#include #include "test/core/filters/filter_test.h" diff --git a/test/core/filters/filter_test_test.cc b/test/core/filters/filter_test_test.cc index 030ba4914a6..565914dd038 100644 --- a/test/core/filters/filter_test_test.cc +++ b/test/core/filters/filter_test_test.cc @@ -19,12 +19,13 @@ #include #include +#include "absl/status/statusor.h" #include "gmock/gmock.h" #include "gtest/gtest.h" #include -#include +#include "src/core/lib/channel/channel_args.h" #include "src/core/lib/channel/promise_based_filter.h" #include "src/core/lib/promise/activity.h" #include "src/core/lib/promise/arena_promise.h" diff --git a/test/core/gpr/alloc_test.cc b/test/core/gpr/alloc_test.cc index e8dc5b9d08e..faab42475a0 100644 --- a/test/core/gpr/alloc_test.cc +++ b/test/core/gpr/alloc_test.cc @@ -19,6 +19,8 @@ #include #include +#include + #include "gtest/gtest.h" #include diff --git a/test/core/gpr/cpu_test.cc b/test/core/gpr/cpu_test.cc index 8717bef425e..e582bca1c74 100644 --- a/test/core/gpr/cpu_test.cc +++ b/test/core/gpr/cpu_test.cc @@ -25,6 +25,8 @@ #include #include +#include + #include "gtest/gtest.h" #include diff --git a/test/core/gpr/log_test.cc b/test/core/gpr/log_test.cc index 4879fd76d53..2e1ea0c5ca7 100644 --- a/test/core/gpr/log_test.cc +++ b/test/core/gpr/log_test.cc @@ -18,6 +18,8 @@ #include +#include + #include #include diff --git a/test/core/gpr/spinlock_test.cc b/test/core/gpr/spinlock_test.cc index f4159197416..6f78f2dd717 100644 --- a/test/core/gpr/spinlock_test.cc +++ b/test/core/gpr/spinlock_test.cc @@ -23,6 +23,8 @@ #include #include +#include + #include "gtest/gtest.h" #include diff --git a/test/core/gpr/sync_test.cc b/test/core/gpr/sync_test.cc index 5f0343b3ed1..4e84c68fcf2 100644 --- a/test/core/gpr/sync_test.cc +++ b/test/core/gpr/sync_test.cc @@ -21,6 +21,8 @@ #include #include +#include + #include "gtest/gtest.h" #include diff --git a/test/core/gpr/time_test.cc b/test/core/gpr/time_test.cc index a69a598b42e..cb201b70ea8 100644 --- a/test/core/gpr/time_test.cc +++ b/test/core/gpr/time_test.cc @@ -22,6 +22,8 @@ #include #include +#include + #include "gtest/gtest.h" #include diff --git a/test/core/gpr/useful_test.cc b/test/core/gpr/useful_test.cc index 358396db204..f2742d15214 100644 --- a/test/core/gpr/useful_test.cc +++ b/test/core/gpr/useful_test.cc @@ -23,6 +23,7 @@ #include #include +#include #include "gtest/gtest.h" diff --git a/test/core/gprpp/cpp_impl_of_test.cc b/test/core/gprpp/cpp_impl_of_test.cc index d610c2d27ce..00b164cb3aa 100644 --- a/test/core/gprpp/cpp_impl_of_test.cc +++ b/test/core/gprpp/cpp_impl_of_test.cc @@ -14,6 +14,8 @@ #include "src/core/lib/gprpp/cpp_impl_of.h" +#include + #include typedef struct grpc_foo grpc_foo; diff --git a/test/core/gprpp/dual_ref_counted_test.cc b/test/core/gprpp/dual_ref_counted_test.cc index 917fac0d290..ffb57f3dae6 100644 --- a/test/core/gprpp/dual_ref_counted_test.cc +++ b/test/core/gprpp/dual_ref_counted_test.cc @@ -16,6 +16,8 @@ #include "src/core/lib/gprpp/dual_ref_counted.h" +#include + #include "gtest/gtest.h" #include "test/core/util/test_config.h" diff --git a/test/core/gprpp/if_list_test.cc b/test/core/gprpp/if_list_test.cc index b46d582ec5d..38dce561bf4 100644 --- a/test/core/gprpp/if_list_test.cc +++ b/test/core/gprpp/if_list_test.cc @@ -14,6 +14,8 @@ #include "src/core/lib/gprpp/if_list.h" +#include + #include "gtest/gtest.h" namespace grpc_core { diff --git a/test/core/gprpp/match_test.cc b/test/core/gprpp/match_test.cc index c88b29fa7b0..370a6501564 100644 --- a/test/core/gprpp/match_test.cc +++ b/test/core/gprpp/match_test.cc @@ -16,7 +16,7 @@ #include -#include +#include #include "gtest/gtest.h" diff --git a/test/core/gprpp/mpscq_test.cc b/test/core/gprpp/mpscq_test.cc index 409144b9d53..ddb5ef6883f 100644 --- a/test/core/gprpp/mpscq_test.cc +++ b/test/core/gprpp/mpscq_test.cc @@ -21,6 +21,8 @@ #include #include +#include + #include "gtest/gtest.h" #include diff --git a/test/core/gprpp/notification_test.cc b/test/core/gprpp/notification_test.cc index be431dce0de..ed5dcf48021 100644 --- a/test/core/gprpp/notification_test.cc +++ b/test/core/gprpp/notification_test.cc @@ -14,6 +14,7 @@ #include "src/core/lib/gprpp/notification.h" +#include #include #include "gtest/gtest.h" diff --git a/test/core/gprpp/ref_counted_ptr_test.cc b/test/core/gprpp/ref_counted_ptr_test.cc index c6e7b0a4588..fb9e3f0c597 100644 --- a/test/core/gprpp/ref_counted_ptr_test.cc +++ b/test/core/gprpp/ref_counted_ptr_test.cc @@ -18,6 +18,8 @@ #include "src/core/lib/gprpp/ref_counted_ptr.h" +#include + #include "absl/container/flat_hash_set.h" #include "gtest/gtest.h" diff --git a/test/core/gprpp/stat_test.cc b/test/core/gprpp/stat_test.cc index c39a25ba89e..b3b504ee552 100644 --- a/test/core/gprpp/stat_test.cc +++ b/test/core/gprpp/stat_test.cc @@ -18,6 +18,8 @@ #include +#include + #include "gtest/gtest.h" #include diff --git a/test/core/gprpp/table_test.cc b/test/core/gprpp/table_test.cc index 672795256d5..9c9ba507263 100644 --- a/test/core/gprpp/table_test.cc +++ b/test/core/gprpp/table_test.cc @@ -16,6 +16,7 @@ #include #include +#include #include "absl/types/optional.h" #include "gtest/gtest.h" diff --git a/test/core/gprpp/unique_type_name_test.cc b/test/core/gprpp/unique_type_name_test.cc index e34dde3b193..bce147edd32 100644 --- a/test/core/gprpp/unique_type_name_test.cc +++ b/test/core/gprpp/unique_type_name_test.cc @@ -14,7 +14,6 @@ #include "src/core/lib/gprpp/unique_type_name.h" -#include #include #include diff --git a/test/core/gprpp/work_serializer_test.cc b/test/core/gprpp/work_serializer_test.cc index d97d98fe4b6..9ac9de73091 100644 --- a/test/core/gprpp/work_serializer_test.cc +++ b/test/core/gprpp/work_serializer_test.cc @@ -20,7 +20,6 @@ #include -#include #include #include #include diff --git a/test/core/handshake/server_ssl.cc b/test/core/handshake/server_ssl.cc index 318f8d79614..36575005dc6 100644 --- a/test/core/handshake/server_ssl.cc +++ b/test/core/handshake/server_ssl.cc @@ -16,6 +16,8 @@ // // +#include + #include "gtest/gtest.h" #include "test/core/handshake/server_ssl_common.h" diff --git a/test/core/http/format_request_test.cc b/test/core/http/format_request_test.cc index 4f87367139a..11830958c93 100644 --- a/test/core/http/format_request_test.cc +++ b/test/core/http/format_request_test.cc @@ -20,6 +20,8 @@ #include +#include + #include "gtest/gtest.h" #include "src/core/lib/http/httpcli.h" diff --git a/test/core/http/httpcli_test.cc b/test/core/http/httpcli_test.cc index 98fc2c934fd..4a2a2ea570f 100644 --- a/test/core/http/httpcli_test.cc +++ b/test/core/http/httpcli_test.cc @@ -21,8 +21,6 @@ #include #include -#include -#include #include #include #include @@ -264,7 +262,7 @@ TEST_F(HttpRequestTest, CancelGetDuringDNSResolution) { kWaitForClientToSendFirstBytes, grpc_core::testing::FakeUdpAndTcpServer::CloseSocketUponCloseFromPeer); g_fake_non_responsive_dns_server_port = fake_dns_server.port(); - void (*prev_test_only_inject_config)(ares_channel * channel) = + void (*prev_test_only_inject_config)(ares_channel* channel) = grpc_ares_test_only_inject_config; grpc_ares_test_only_inject_config = InjectNonResponsiveDNSServer; // Run the same test on several threads in parallel to try to trigger races diff --git a/test/core/http/httpcli_test_util.cc b/test/core/http/httpcli_test_util.cc index 5381fb03dd3..93fb3a70281 100644 --- a/test/core/http/httpcli_test_util.cc +++ b/test/core/http/httpcli_test_util.cc @@ -20,6 +20,7 @@ #include +#include #include #include diff --git a/test/core/http/httpscli_test.cc b/test/core/http/httpscli_test.cc index 35da8634f7e..82d35509143 100644 --- a/test/core/http/httpscli_test.cc +++ b/test/core/http/httpscli_test.cc @@ -20,7 +20,6 @@ #include #include -#include #include #include #include @@ -57,7 +56,7 @@ #include "src/core/lib/iomgr/iomgr_fwd.h" #include "src/core/lib/iomgr/polling_entity.h" #include "src/core/lib/iomgr/pollset.h" -#include "src/core/lib/security/credentials/credentials.h" +#include "src/core/lib/security/credentials/credentials.h" // IWYU pragma: keep #include "src/core/lib/uri/uri_parser.h" #include "test/core/http/httpcli_test_util.h" #include "test/core/util/fake_udp_and_tcp_server.h" diff --git a/test/core/http/parser_test.cc b/test/core/http/parser_test.cc index b445af22f48..ebe8995057b 100644 --- a/test/core/http/parser_test.cc +++ b/test/core/http/parser_test.cc @@ -21,7 +21,6 @@ #include #include -#include #include #include "absl/status/status.h" diff --git a/test/core/json/fuzzer.cc b/test/core/json/fuzzer.cc index ba311c4f473..97493aacbb1 100644 --- a/test/core/json/fuzzer.cc +++ b/test/core/json/fuzzer.cc @@ -25,7 +25,6 @@ #include #include -#include "src/core/lib/json/json.h" #include "src/core/lib/json/json_reader.h" #include "src/core/lib/json/json_writer.h" diff --git a/test/core/memory_usage/callback_client.cc b/test/core/memory_usage/callback_client.cc index 59d3ec96dc0..6923fcacd84 100644 --- a/test/core/memory_usage/callback_client.cc +++ b/test/core/memory_usage/callback_client.cc @@ -27,7 +27,6 @@ #include "absl/flags/flag.h" #include "absl/flags/parse.h" -#include "absl/strings/string_view.h" #include #include diff --git a/test/core/memory_usage/callback_server.cc b/test/core/memory_usage/callback_server.cc index c2decb9154b..2b7a3fc88af 100644 --- a/test/core/memory_usage/callback_server.cc +++ b/test/core/memory_usage/callback_server.cc @@ -24,7 +24,6 @@ #include "absl/flags/flag.h" #include "absl/flags/parse.h" -#include "absl/strings/string_view.h" #include #include diff --git a/test/core/memory_usage/client.cc b/test/core/memory_usage/client.cc index c7c73b4ad96..ae76e137263 100644 --- a/test/core/memory_usage/client.cc +++ b/test/core/memory_usage/client.cc @@ -27,7 +27,6 @@ #include "absl/flags/flag.h" #include "absl/flags/parse.h" -#include "absl/strings/string_view.h" #include #include diff --git a/test/core/memory_usage/server.cc b/test/core/memory_usage/server.cc index 9ccab48de9c..c4eaf7735bd 100644 --- a/test/core/memory_usage/server.cc +++ b/test/core/memory_usage/server.cc @@ -28,7 +28,6 @@ #include "absl/base/attributes.h" #include "absl/flags/flag.h" #include "absl/flags/parse.h" -#include "absl/strings/string_view.h" #include #include diff --git a/test/core/network_benchmarks/low_level_ping_pong.cc b/test/core/network_benchmarks/low_level_ping_pong.cc index aeb139a5acf..1ee173b9cac 100644 --- a/test/core/network_benchmarks/low_level_ping_pong.cc +++ b/test/core/network_benchmarks/low_level_ping_pong.cc @@ -35,8 +35,6 @@ #endif #include -#include - #include #include #include diff --git a/test/core/promise/BUILD b/test/core/promise/BUILD index 734e1856fe1..c974eeec7f6 100644 --- a/test/core/promise/BUILD +++ b/test/core/promise/BUILD @@ -533,6 +533,7 @@ grpc_cc_test( "//:exec_ctx", "//:gpr", "//:grpc", + "//:orphanable", "//src/core:default_event_engine", "//src/core:exec_ctx_wakeup_scheduler", "//src/core:notification", diff --git a/test/core/promise/activity_test.cc b/test/core/promise/activity_test.cc index 44c3ce16bd2..3f2726dfa53 100644 --- a/test/core/promise/activity_test.cc +++ b/test/core/promise/activity_test.cc @@ -18,6 +18,7 @@ #include #include +#include #include "gmock/gmock.h" #include "gtest/gtest.h" diff --git a/test/core/promise/cancel_callback_test.cc b/test/core/promise/cancel_callback_test.cc index a844ed8331a..64ca6d0a8ce 100644 --- a/test/core/promise/cancel_callback_test.cc +++ b/test/core/promise/cancel_callback_test.cc @@ -14,6 +14,9 @@ #include "src/core/lib/promise/cancel_callback.h" +#include +#include + #include "gtest/gtest.h" #include "src/core/lib/promise/poll.h" diff --git a/test/core/promise/context_test.cc b/test/core/promise/context_test.cc index 8be2c5b5327..71d09aba858 100644 --- a/test/core/promise/context_test.cc +++ b/test/core/promise/context_test.cc @@ -14,6 +14,8 @@ #include "src/core/lib/promise/context.h" +#include + #include "gtest/gtest.h" namespace grpc_core { diff --git a/test/core/promise/for_each_test.cc b/test/core/promise/for_each_test.cc index c560103b6c5..94287697d50 100644 --- a/test/core/promise/for_each_test.cc +++ b/test/core/promise/for_each_test.cc @@ -14,9 +14,6 @@ #include "src/core/lib/promise/for_each.h" -#include - -#include #include #include "gmock/gmock.h" diff --git a/test/core/promise/inter_activity_pipe_test.cc b/test/core/promise/inter_activity_pipe_test.cc index 84c1bd95341..dffc796f268 100644 --- a/test/core/promise/inter_activity_pipe_test.cc +++ b/test/core/promise/inter_activity_pipe_test.cc @@ -14,6 +14,8 @@ #include "src/core/lib/promise/inter_activity_pipe.h" +#include + #include "absl/status/status.h" #include "gtest/gtest.h" diff --git a/test/core/promise/interceptor_list_test.cc b/test/core/promise/interceptor_list_test.cc index b1290874089..ad8941e72b1 100644 --- a/test/core/promise/interceptor_list_test.cc +++ b/test/core/promise/interceptor_list_test.cc @@ -14,7 +14,6 @@ #include "src/core/lib/promise/interceptor_list.h" -#include #include #include "gtest/gtest.h" diff --git a/test/core/promise/join_test.cc b/test/core/promise/join_test.cc index 5e6f2bc7ab1..288d3a64539 100644 --- a/test/core/promise/join_test.cc +++ b/test/core/promise/join_test.cc @@ -14,6 +14,7 @@ #include "src/core/lib/promise/join.h" +#include #include #include "gtest/gtest.h" diff --git a/test/core/promise/loop_test.cc b/test/core/promise/loop_test.cc index 9a8e619249b..42362327915 100644 --- a/test/core/promise/loop_test.cc +++ b/test/core/promise/loop_test.cc @@ -14,8 +14,7 @@ #include "src/core/lib/promise/loop.h" -#include - +#include #include #include "gtest/gtest.h" diff --git a/test/core/promise/map_pipe_test.cc b/test/core/promise/map_pipe_test.cc index 53a7d60a382..8cd88aa6187 100644 --- a/test/core/promise/map_pipe_test.cc +++ b/test/core/promise/map_pipe_test.cc @@ -14,9 +14,6 @@ #include "src/core/lib/promise/map_pipe.h" -#include - -#include #include #include diff --git a/test/core/promise/map_test.cc b/test/core/promise/map_test.cc index eacc66674d3..c153327971c 100644 --- a/test/core/promise/map_test.cc +++ b/test/core/promise/map_test.cc @@ -14,6 +14,8 @@ #include "src/core/lib/promise/map.h" +#include + #include "absl/functional/any_invocable.h" #include "gtest/gtest.h" diff --git a/test/core/promise/pipe_test.cc b/test/core/promise/pipe_test.cc index e91178cf9fe..abc7e44f904 100644 --- a/test/core/promise/pipe_test.cc +++ b/test/core/promise/pipe_test.cc @@ -14,7 +14,6 @@ #include "src/core/lib/promise/pipe.h" -#include #include #include #include diff --git a/test/core/promise/prioritized_race_test.cc b/test/core/promise/prioritized_race_test.cc index e181425c678..c663fe041d0 100644 --- a/test/core/promise/prioritized_race_test.cc +++ b/test/core/promise/prioritized_race_test.cc @@ -14,6 +14,8 @@ #include "src/core/lib/promise/prioritized_race.h" +#include + #include "gtest/gtest.h" #include "src/core/lib/promise/poll.h" diff --git a/test/core/promise/promise_fuzzer.cc b/test/core/promise/promise_fuzzer.cc index 413524d35d1..db13409435f 100644 --- a/test/core/promise/promise_fuzzer.cc +++ b/test/core/promise/promise_fuzzer.cc @@ -12,8 +12,6 @@ // See the License for the specific language governing permissions and // limitations under the License. -#include - #include #include #include diff --git a/test/core/promise/promise_test.cc b/test/core/promise/promise_test.cc index 8c01687b678..a5a0f476c09 100644 --- a/test/core/promise/promise_test.cc +++ b/test/core/promise/promise_test.cc @@ -14,6 +14,9 @@ #include "src/core/lib/promise/promise.h" +#include +#include + #include "gtest/gtest.h" namespace grpc_core { diff --git a/test/core/promise/race_test.cc b/test/core/promise/race_test.cc index 3f742990a6a..16fbdb13d0a 100644 --- a/test/core/promise/race_test.cc +++ b/test/core/promise/race_test.cc @@ -14,6 +14,8 @@ #include "src/core/lib/promise/race.h" +#include + #include "gtest/gtest.h" #include "src/core/lib/promise/poll.h" diff --git a/test/core/promise/seq_test.cc b/test/core/promise/seq_test.cc index 8bfd4fadbc8..326329523e6 100644 --- a/test/core/promise/seq_test.cc +++ b/test/core/promise/seq_test.cc @@ -14,9 +14,6 @@ #include "src/core/lib/promise/seq.h" -#include - -#include #include #include #include diff --git a/test/core/promise/sleep_test.cc b/test/core/promise/sleep_test.cc index ac8abcec64f..371a7c08fa8 100644 --- a/test/core/promise/sleep_test.cc +++ b/test/core/promise/sleep_test.cc @@ -14,7 +14,7 @@ #include "src/core/lib/promise/sleep.h" -#include +#include #include #include #include @@ -28,6 +28,7 @@ #include "src/core/lib/event_engine/default_event_engine.h" #include "src/core/lib/gprpp/notification.h" +#include "src/core/lib/gprpp/orphanable.h" #include "src/core/lib/iomgr/exec_ctx.h" #include "src/core/lib/promise/exec_ctx_wakeup_scheduler.h" #include "src/core/lib/promise/race.h" diff --git a/test/core/promise/try_join_test.cc b/test/core/promise/try_join_test.cc index 2c9eceb723f..63814b5279a 100644 --- a/test/core/promise/try_join_test.cc +++ b/test/core/promise/try_join_test.cc @@ -15,7 +15,8 @@ #include "src/core/lib/promise/try_join.h" #include -#include +#include +#include #include "absl/utility/utility.h" #include "gtest/gtest.h" diff --git a/test/core/promise/try_seq_metadata_test.cc b/test/core/promise/try_seq_metadata_test.cc index 2729e9fe67b..dc0fb8ca92e 100644 --- a/test/core/promise/try_seq_metadata_test.cc +++ b/test/core/promise/try_seq_metadata_test.cc @@ -12,8 +12,6 @@ // See the License for the specific language governing permissions and // limitations under the License. -#include - #include #include "gtest/gtest.h" diff --git a/test/core/promise/try_seq_test.cc b/test/core/promise/try_seq_test.cc index c45e9a20f58..18a916d048d 100644 --- a/test/core/promise/try_seq_test.cc +++ b/test/core/promise/try_seq_test.cc @@ -14,10 +14,8 @@ #include "src/core/lib/promise/try_seq.h" -#include #include -#include #include #include diff --git a/test/core/resource_quota/periodic_update_test.cc b/test/core/resource_quota/periodic_update_test.cc index c4551098edc..90d98913693 100644 --- a/test/core/resource_quota/periodic_update_test.cc +++ b/test/core/resource_quota/periodic_update_test.cc @@ -16,7 +16,6 @@ #include -#include #include #include #include diff --git a/test/core/resource_quota/thread_quota_test.cc b/test/core/resource_quota/thread_quota_test.cc index c8462713854..931283b680e 100644 --- a/test/core/resource_quota/thread_quota_test.cc +++ b/test/core/resource_quota/thread_quota_test.cc @@ -14,6 +14,8 @@ #include "src/core/lib/resource_quota/thread_quota.h" +#include + #include "gtest/gtest.h" namespace grpc_core { diff --git a/test/core/slice/b64_test.cc b/test/core/slice/b64_test.cc index d6615b3dc0c..ecfb49f4295 100644 --- a/test/core/slice/b64_test.cc +++ b/test/core/slice/b64_test.cc @@ -21,6 +21,8 @@ #include #include +#include + #include "absl/strings/string_view.h" #include "gtest/gtest.h" diff --git a/test/core/slice/percent_encoding_test.cc b/test/core/slice/percent_encoding_test.cc index e1821ed75f4..6877c1dd647 100644 --- a/test/core/slice/percent_encoding_test.cc +++ b/test/core/slice/percent_encoding_test.cc @@ -20,6 +20,7 @@ #include +#include #include #include "gtest/gtest.h" diff --git a/test/core/slice/slice_buffer_test.cc b/test/core/slice/slice_buffer_test.cc index cc833555071..a440ed0d3b8 100644 --- a/test/core/slice/slice_buffer_test.cc +++ b/test/core/slice/slice_buffer_test.cc @@ -18,6 +18,7 @@ #include +#include #include #include "gtest/gtest.h" diff --git a/test/core/slice/slice_string_helpers_test.cc b/test/core/slice/slice_string_helpers_test.cc index 3184af11689..3b045bccede 100644 --- a/test/core/slice/slice_string_helpers_test.cc +++ b/test/core/slice/slice_string_helpers_test.cc @@ -18,6 +18,8 @@ #include "src/core/lib/slice/slice_string_helpers.h" +#include + #include "gtest/gtest.h" #include diff --git a/test/core/surface/byte_buffer_reader_test.cc b/test/core/surface/byte_buffer_reader_test.cc index 65e19b03ee1..94183fe916d 100644 --- a/test/core/surface/byte_buffer_reader_test.cc +++ b/test/core/surface/byte_buffer_reader_test.cc @@ -18,6 +18,8 @@ #include +#include + #include "gtest/gtest.h" #include diff --git a/test/core/surface/completion_queue_test.cc b/test/core/surface/completion_queue_test.cc index 1a428997813..1bf392f31f7 100644 --- a/test/core/surface/completion_queue_test.cc +++ b/test/core/surface/completion_queue_test.cc @@ -20,6 +20,8 @@ #include +#include + #include "absl/status/status.h" #include "gtest/gtest.h" diff --git a/test/core/surface/completion_queue_threading_test.cc b/test/core/surface/completion_queue_threading_test.cc index 3beb48d10d9..7c6afb9cad2 100644 --- a/test/core/surface/completion_queue_threading_test.cc +++ b/test/core/surface/completion_queue_threading_test.cc @@ -19,6 +19,8 @@ #include #include +#include + #include "absl/status/status.h" #include "gtest/gtest.h" diff --git a/test/core/surface/init_test.cc b/test/core/surface/init_test.cc index 5065712753d..3f3e4607d66 100644 --- a/test/core/surface/init_test.cc +++ b/test/core/surface/init_test.cc @@ -18,11 +18,8 @@ #include "src/core/lib/surface/init.h" -#include - #include #include -#include #include "absl/time/clock.h" #include "absl/time/time.h" diff --git a/test/core/surface/lame_client_test.cc b/test/core/surface/lame_client_test.cc index c046c7da9fb..7d514dab2af 100644 --- a/test/core/surface/lame_client_test.cc +++ b/test/core/surface/lame_client_test.cc @@ -18,6 +18,8 @@ #include +#include + #include "absl/status/status.h" #include "gtest/gtest.h" diff --git a/test/core/surface/secure_channel_create_test.cc b/test/core/surface/secure_channel_create_test.cc index 8fca5ad9c01..1b876bb632b 100644 --- a/test/core/surface/secure_channel_create_test.cc +++ b/test/core/surface/secure_channel_create_test.cc @@ -16,6 +16,8 @@ // // +#include + #include "gtest/gtest.h" #include diff --git a/test/core/surface/server_test.cc b/test/core/surface/server_test.cc index 9e7d35d3130..c3a927a9f8b 100644 --- a/test/core/surface/server_test.cc +++ b/test/core/surface/server_test.cc @@ -20,6 +20,7 @@ #include #include +#include #include "absl/status/statusor.h" #include "absl/strings/str_cat.h" @@ -35,6 +36,7 @@ #include "src/core/lib/gpr/useful.h" #include "src/core/lib/gprpp/host_port.h" #include "src/core/lib/iomgr/resolve_address.h" +#include "src/core/lib/iomgr/resolved_address.h" #include "src/core/lib/security/credentials/fake/fake_credentials.h" #include "test/core/util/port.h" #include "test/core/util/test_config.h" diff --git a/test/core/transport/chaotic_good/frame_header_test.cc b/test/core/transport/chaotic_good/frame_header_test.cc index d8d8d15bcdf..a382315fa14 100644 --- a/test/core/transport/chaotic_good/frame_header_test.cc +++ b/test/core/transport/chaotic_good/frame_header_test.cc @@ -14,7 +14,6 @@ #include "src/core/ext/transport/chaotic_good/frame_header.h" -#include #include #include diff --git a/test/core/transport/chttp2/alpn_test.cc b/test/core/transport/chttp2/alpn_test.cc index 57db877a3be..b638714ff3b 100644 --- a/test/core/transport/chttp2/alpn_test.cc +++ b/test/core/transport/chttp2/alpn_test.cc @@ -18,6 +18,8 @@ #include "src/core/ext/transport/chttp2/alpn/alpn.h" +#include + #include "gtest/gtest.h" #include "test/core/util/test_config.h" diff --git a/test/core/transport/chttp2/bin_decoder_test.cc b/test/core/transport/chttp2/bin_decoder_test.cc index b7673da1707..ae4b77501ba 100644 --- a/test/core/transport/chttp2/bin_decoder_test.cc +++ b/test/core/transport/chttp2/bin_decoder_test.cc @@ -20,6 +20,8 @@ #include +#include + #include "gtest/gtest.h" #include diff --git a/test/core/transport/chttp2/bin_encoder_test.cc b/test/core/transport/chttp2/bin_encoder_test.cc index 22643e38fb1..f1801f5052f 100644 --- a/test/core/transport/chttp2/bin_encoder_test.cc +++ b/test/core/transport/chttp2/bin_encoder_test.cc @@ -20,6 +20,8 @@ #include +#include + #include #include diff --git a/test/core/transport/chttp2/flow_control_fuzzer.cc b/test/core/transport/chttp2/flow_control_fuzzer.cc index 2a51319466c..6b5fece0c24 100644 --- a/test/core/transport/chttp2/flow_control_fuzzer.cc +++ b/test/core/transport/chttp2/flow_control_fuzzer.cc @@ -22,7 +22,6 @@ #include #include #include -#include #include #include diff --git a/test/core/transport/chttp2/hpack_parser_fuzzer_test.cc b/test/core/transport/chttp2/hpack_parser_fuzzer_test.cc index d7dc1553378..c167cf9ce49 100644 --- a/test/core/transport/chttp2/hpack_parser_fuzzer_test.cc +++ b/test/core/transport/chttp2/hpack_parser_fuzzer_test.cc @@ -20,7 +20,6 @@ #include #include -#include #include #include "absl/cleanup/cleanup.h" diff --git a/test/core/transport/chttp2/hpack_sync_fuzzer.cc b/test/core/transport/chttp2/hpack_sync_fuzzer.cc index 81809afcf71..47e426547a7 100644 --- a/test/core/transport/chttp2/hpack_sync_fuzzer.cc +++ b/test/core/transport/chttp2/hpack_sync_fuzzer.cc @@ -18,7 +18,6 @@ #include #include -#include #include #include #include diff --git a/test/core/transport/chttp2/max_concurrent_streams_policy_test.cc b/test/core/transport/chttp2/max_concurrent_streams_policy_test.cc index 68a18dfadee..11b347dbcd8 100644 --- a/test/core/transport/chttp2/max_concurrent_streams_policy_test.cc +++ b/test/core/transport/chttp2/max_concurrent_streams_policy_test.cc @@ -14,6 +14,8 @@ #include "src/core/ext/transport/chttp2/transport/max_concurrent_streams_policy.h" +#include + #include "gtest/gtest.h" namespace grpc_core { diff --git a/test/core/transport/chttp2/ping_configuration_test.cc b/test/core/transport/chttp2/ping_configuration_test.cc index f278fcd40e5..27b64ffb6eb 100644 --- a/test/core/transport/chttp2/ping_configuration_test.cc +++ b/test/core/transport/chttp2/ping_configuration_test.cc @@ -12,6 +12,8 @@ // See the License for the specific language governing permissions and // limitations under the License. +#include + #include "gtest/gtest.h" #include diff --git a/test/core/transport/chttp2/varint_test.cc b/test/core/transport/chttp2/varint_test.cc index 026ad9c3433..efa9645876c 100644 --- a/test/core/transport/chttp2/varint_test.cc +++ b/test/core/transport/chttp2/varint_test.cc @@ -18,6 +18,8 @@ #include "src/core/ext/transport/chttp2/transport/varint.h" +#include + #include "gtest/gtest.h" #include diff --git a/test/core/transport/connectivity_state_test.cc b/test/core/transport/connectivity_state_test.cc index 2f74739fea9..372ddfb22d4 100644 --- a/test/core/transport/connectivity_state_test.cc +++ b/test/core/transport/connectivity_state_test.cc @@ -18,7 +18,6 @@ #include "src/core/lib/transport/connectivity_state.h" -#include "absl/strings/string_view.h" #include "gtest/gtest.h" #include diff --git a/test/core/transport/pid_controller_test.cc b/test/core/transport/pid_controller_test.cc index 82c5e4b6584..1d7cedcb8db 100644 --- a/test/core/transport/pid_controller_test.cc +++ b/test/core/transport/pid_controller_test.cc @@ -20,6 +20,7 @@ #include +#include #include #include "gtest/gtest.h" diff --git a/test/core/transport/status_conversion_test.cc b/test/core/transport/status_conversion_test.cc index 4d4b6eb1a13..c3d3d4c79c3 100644 --- a/test/core/transport/status_conversion_test.cc +++ b/test/core/transport/status_conversion_test.cc @@ -18,6 +18,8 @@ #include "src/core/lib/transport/status_conversion.h" +#include + #include "gtest/gtest.h" #include diff --git a/test/core/transport/timeout_encoding_test.cc b/test/core/transport/timeout_encoding_test.cc index 2ac4aeb43fb..420fd930fee 100644 --- a/test/core/transport/timeout_encoding_test.cc +++ b/test/core/transport/timeout_encoding_test.cc @@ -18,7 +18,6 @@ #include "src/core/lib/transport/timeout_encoding.h" -#include #include #include "absl/strings/str_format.h" diff --git a/test/core/util/cmdline.cc b/test/core/util/cmdline.cc index f3e7eb596ef..c1e34992af5 100644 --- a/test/core/util/cmdline.cc +++ b/test/core/util/cmdline.cc @@ -24,7 +24,6 @@ #include #include -#include #include #include "absl/strings/str_cat.h" diff --git a/test/core/util/fuzzer_corpus_test.cc b/test/core/util/fuzzer_corpus_test.cc index f1e831765ef..ff9721f3ce0 100644 --- a/test/core/util/fuzzer_corpus_test.cc +++ b/test/core/util/fuzzer_corpus_test.cc @@ -27,7 +27,6 @@ #include #include "absl/flags/flag.h" -#include "absl/strings/string_view.h" #include "absl/types/optional.h" #include "gtest/gtest.h" diff --git a/test/core/util/fuzzing_channel_args.h b/test/core/util/fuzzing_channel_args.h index 4ace14a513d..c8d1b84afd3 100644 --- a/test/core/util/fuzzing_channel_args.h +++ b/test/core/util/fuzzing_channel_args.h @@ -17,6 +17,8 @@ #include +#include + #include "src/core/lib/channel/channel_args.h" #include "src/core/lib/gprpp/ref_counted_ptr.h" #include "src/core/lib/resource_quota/resource_quota.h" diff --git a/test/core/util/histogram_test.cc b/test/core/util/histogram_test.cc index 6ffe5b9a223..6a70431d447 100644 --- a/test/core/util/histogram_test.cc +++ b/test/core/util/histogram_test.cc @@ -18,6 +18,8 @@ #include "test/core/util/histogram.h" +#include + #include "gtest/gtest.h" #include diff --git a/test/core/util/osa_distance_test.cc b/test/core/util/osa_distance_test.cc index a4962af8e81..4ac637f4a04 100644 --- a/test/core/util/osa_distance_test.cc +++ b/test/core/util/osa_distance_test.cc @@ -14,6 +14,8 @@ #include "test/core/util/osa_distance.h" +#include + #include "gtest/gtest.h" namespace grpc_core { diff --git a/test/core/util/passthru_endpoint.cc b/test/core/util/passthru_endpoint.cc index 1743dcfc33a..cc37aabd278 100644 --- a/test/core/util/passthru_endpoint.cc +++ b/test/core/util/passthru_endpoint.cc @@ -22,7 +22,6 @@ #include #include -#include #include #include diff --git a/test/core/util/port_server_client.cc b/test/core/util/port_server_client.cc index 2f504424ae5..632d644c0bb 100644 --- a/test/core/util/port_server_client.cc +++ b/test/core/util/port_server_client.cc @@ -25,7 +25,6 @@ #include #include -#include #include #include #include diff --git a/test/core/util/port_server_client.h b/test/core/util/port_server_client.h index 97865ba6e77..3e479350e88 100644 --- a/test/core/util/port_server_client.h +++ b/test/core/util/port_server_client.h @@ -19,6 +19,7 @@ #ifndef GRPC_TEST_CORE_UTIL_PORT_SERVER_CLIENT_H #define GRPC_TEST_CORE_UTIL_PORT_SERVER_CLIENT_H +#include // C interface to port_server.py // must be synchronized with tools/run_tests/python_utils/start_port_server.py diff --git a/test/core/util/test_config.cc b/test/core/util/test_config.cc index 5b9264ceeb4..fd2990c5595 100644 --- a/test/core/util/test_config.cc +++ b/test/core/util/test_config.cc @@ -21,9 +21,6 @@ #include #include -#include -#include - #include "absl/debugging/failure_signal_handler.h" #include "absl/status/status.h" #include "absl/strings/match.h" diff --git a/test/core/util/test_lb_policies.cc b/test/core/util/test_lb_policies.cc index 96938505397..8fb255d65ed 100644 --- a/test/core/util/test_lb_policies.cc +++ b/test/core/util/test_lb_policies.cc @@ -18,7 +18,6 @@ #include -#include #include #include diff --git a/test/core/xds/file_watcher_certificate_provider_factory_test.cc b/test/core/xds/file_watcher_certificate_provider_factory_test.cc index 6397f73827d..fd839ba206e 100644 --- a/test/core/xds/file_watcher_certificate_provider_factory_test.cc +++ b/test/core/xds/file_watcher_certificate_provider_factory_test.cc @@ -18,7 +18,6 @@ #include "src/core/ext/xds/file_watcher_certificate_provider_factory.h" -#include #include #include "absl/status/status.h" diff --git a/test/core/xds/xds_audit_logger_registry_test.cc b/test/core/xds/xds_audit_logger_registry_test.cc index 4f82ac5cffb..abfc73801e6 100644 --- a/test/core/xds/xds_audit_logger_registry_test.cc +++ b/test/core/xds/xds_audit_logger_registry_test.cc @@ -18,7 +18,6 @@ #include "src/core/ext/xds/xds_audit_logger_registry.h" -#include #include #include diff --git a/test/core/xds/xds_bootstrap_test.cc b/test/core/xds/xds_bootstrap_test.cc index c39ee8811a6..e881b9f9dd7 100644 --- a/test/core/xds/xds_bootstrap_test.cc +++ b/test/core/xds/xds_bootstrap_test.cc @@ -18,7 +18,6 @@ #include -#include #include #include #include diff --git a/test/core/xds/xds_client_test.cc b/test/core/xds/xds_client_test.cc index ddb24d57658..4f75e4ee7d4 100644 --- a/test/core/xds/xds_client_test.cc +++ b/test/core/xds/xds_client_test.cc @@ -82,7 +82,7 @@ class XdsClientTest : public ::testing::Test { public: class FakeNode : public Node { public: - FakeNode() = default; + FakeNode() : id_("xds_client_test") {} const std::string& id() const override { return id_; } const std::string& cluster() const override { return cluster_; } const std::string& locality_region() const override { @@ -112,7 +112,7 @@ class XdsClientTest : public ::testing::Test { } private: - std::string id_ = "xds_client_test"; + std::string id_; std::string cluster_; std::string locality_region_; std::string locality_zone_; diff --git a/test/core/xds/xds_cluster_resource_type_test.cc b/test/core/xds/xds_cluster_resource_type_test.cc index 7d0a4048680..5fd5d20a181 100644 --- a/test/core/xds/xds_cluster_resource_type_test.cc +++ b/test/core/xds/xds_cluster_resource_type_test.cc @@ -14,7 +14,6 @@ // limitations under the License. // -#include #include #include #include diff --git a/test/core/xds/xds_common_types_test.cc b/test/core/xds/xds_common_types_test.cc index 7b641700066..c5b0fbdef3b 100644 --- a/test/core/xds/xds_common_types_test.cc +++ b/test/core/xds/xds_common_types_test.cc @@ -16,7 +16,6 @@ #include "src/core/ext/xds/xds_common_types.h" -#include #include #include #include diff --git a/test/core/xds/xds_endpoint_resource_type_test.cc b/test/core/xds/xds_endpoint_resource_type_test.cc index 820e7b1ed33..a7e668c060f 100644 --- a/test/core/xds/xds_endpoint_resource_type_test.cc +++ b/test/core/xds/xds_endpoint_resource_type_test.cc @@ -16,7 +16,6 @@ #include -#include #include #include #include @@ -49,6 +48,7 @@ #include "src/core/lib/gprpp/crash.h" #include "src/core/lib/gprpp/ref_counted_ptr.h" #include "src/core/lib/iomgr/error.h" +#include "src/core/lib/iomgr/resolved_address.h" #include "src/core/lib/resolver/endpoint_addresses.h" #include "src/proto/grpc/testing/xds/v3/address.pb.h" #include "src/proto/grpc/testing/xds/v3/base.pb.h" diff --git a/test/core/xds/xds_http_filters_test.cc b/test/core/xds/xds_http_filters_test.cc index e23b3b13fb1..85c0fcfcd4e 100644 --- a/test/core/xds/xds_http_filters_test.cc +++ b/test/core/xds/xds_http_filters_test.cc @@ -16,8 +16,6 @@ #include "src/core/ext/xds/xds_http_filters.h" -#include -#include #include #include #include diff --git a/test/core/xds/xds_listener_resource_type_test.cc b/test/core/xds/xds_listener_resource_type_test.cc index e26190042b0..9d0459baf2e 100644 --- a/test/core/xds/xds_listener_resource_type_test.cc +++ b/test/core/xds/xds_listener_resource_type_test.cc @@ -14,7 +14,6 @@ // limitations under the License. // -#include #include #include #include diff --git a/test/core/xds/xds_route_config_resource_type_test.cc b/test/core/xds/xds_route_config_resource_type_test.cc index 0d16f6633dd..8bd81fbfcce 100644 --- a/test/core/xds/xds_route_config_resource_type_test.cc +++ b/test/core/xds/xds_route_config_resource_type_test.cc @@ -16,7 +16,6 @@ #include -#include #include #include #include diff --git a/test/core/xds/xds_transport_fake.cc b/test/core/xds/xds_transport_fake.cc index 6a29a3688f3..7e7a85eec56 100644 --- a/test/core/xds/xds_transport_fake.cc +++ b/test/core/xds/xds_transport_fake.cc @@ -18,8 +18,6 @@ #include "test/core/xds/xds_transport_fake.h" -#include - #include #include #include diff --git a/test/cpp/end2end/async_end2end_test.cc b/test/cpp/end2end/async_end2end_test.cc index 76682e93a33..503cc071038 100644 --- a/test/cpp/end2end/async_end2end_test.cc +++ b/test/cpp/end2end/async_end2end_test.cc @@ -326,7 +326,7 @@ class AsyncEnd2endTest : public ::testing::TestWithParam { // deleted std::unique_ptr sync_plugin_disabler( new ServerBuilderSyncPluginDisabler()); - builder.SetOption(move(sync_plugin_disabler)); + builder.SetOption(std::move(sync_plugin_disabler)); server_ = builder.BuildAndStart(); } diff --git a/test/cpp/interop/grpclb_fallback_test.cc b/test/cpp/interop/grpclb_fallback_test.cc index 39f008eb216..48189d6c692 100644 --- a/test/cpp/interop/grpclb_fallback_test.cc +++ b/test/cpp/interop/grpclb_fallback_test.cc @@ -118,11 +118,6 @@ GrpclbRouteType DoRPCAndGetPath(TestService::Stub* stub, int deadline_seconds) { return DoRPCAndGetPath(stub, deadline_seconds, FailFast); } -GrpclbRouteType DoWaitForReadyRPCAndGetPath(TestService::Stub* stub, - int deadline_seconds) { - return DoRPCAndGetPath(stub, deadline_seconds, WaitForReady); -} - bool TcpUserTimeoutMutateFd(int fd, grpc_socket_mutator* /*mutator*/) { int timeout = 20000; // 20 seconds gpr_log(GPR_INFO, "Setting socket option TCP_USER_TIMEOUT on fd: %d", fd); diff --git a/test/cpp/interop/observability_client.cc b/test/cpp/interop/observability_client.cc index 23ef200c1a3..2139dbc89d3 100644 --- a/test/cpp/interop/observability_client.cc +++ b/test/cpp/interop/observability_client.cc @@ -213,6 +213,8 @@ int main(int argc, char** argv) { int ret = 0; if (absl::GetFlag(FLAGS_enable_observability)) { + // TODO(someone): remove deprecated usage + // NOLINTNEXTLINE(clang-diagnostic-deprecated-declarations) auto status = grpc::experimental::GcpObservabilityInit(); gpr_log(GPR_DEBUG, "GcpObservabilityInit() status_code: %d", status.code()); if (!status.ok()) { @@ -393,6 +395,8 @@ int main(int argc, char** argv) { } if (absl::GetFlag(FLAGS_enable_observability)) { + // TODO(someone): remove deprecated usage + // NOLINTNEXTLINE(clang-diagnostic-deprecated-declarations) grpc::experimental::GcpObservabilityClose(); } diff --git a/test/cpp/interop/observability_interop_server_bootstrap.cc b/test/cpp/interop/observability_interop_server_bootstrap.cc index bb982cf1f4a..cf98d4f1232 100644 --- a/test/cpp/interop/observability_interop_server_bootstrap.cc +++ b/test/cpp/interop/observability_interop_server_bootstrap.cc @@ -41,6 +41,8 @@ int main(int argc, char** argv) { signal(SIGINT, sigint_handler); if (absl::GetFlag(FLAGS_enable_observability)) { + // TODO(someone): remove deprecated usage + // NOLINTNEXTLINE(clang-diagnostic-deprecated-declarations) auto status = grpc::experimental::GcpObservabilityInit(); gpr_log(GPR_DEBUG, "GcpObservabilityInit() status_code: %d", status.code()); if (!status.ok()) { diff --git a/test/cpp/interop/xds_stats_watcher.cc b/test/cpp/interop/xds_stats_watcher.cc index eda0d635252..d6cb3037b8a 100644 --- a/test/cpp/interop/xds_stats_watcher.cc +++ b/test/cpp/interop/xds_stats_watcher.cc @@ -145,14 +145,16 @@ void XdsStatsWatcher::GetCurrentRpcStats( StatsWatchers* stats_watchers) { std::unique_lock lock(m_); response->CopyFrom(accumulated_stats_); - // TODO(@donnadionne): delete deprecated stats below when the test is no + // TODO(someone): delete deprecated stats below when the test is no // longer using them. + // NOLINTBEGIN(clang-diagnostic-deprecated-declarations) auto& response_rpcs_started_by_method = *response->mutable_num_rpcs_started_by_method(); auto& response_rpcs_succeeded_by_method = *response->mutable_num_rpcs_succeeded_by_method(); auto& response_rpcs_failed_by_method = *response->mutable_num_rpcs_failed_by_method(); + // NOLINTEND(clang-diagnostic-deprecated-declarations) for (const auto& rpc_by_type : rpcs_by_type_) { auto total_succeeded = 0; for (const auto& rpc_by_peer : rpc_by_type.second) { diff --git a/test/cpp/microbenchmarks/bm_chttp2_hpack.cc b/test/cpp/microbenchmarks/bm_chttp2_hpack.cc index 22da025e5cb..1ba7787cc0b 100644 --- a/test/cpp/microbenchmarks/bm_chttp2_hpack.cc +++ b/test/cpp/microbenchmarks/bm_chttp2_hpack.cc @@ -330,7 +330,9 @@ BENCHMARK_TEMPLATE(BM_HpackEncoderEncodeHeader, static void BM_HpackParserInitDestroy(benchmark::State& state) { grpc_core::ExecCtx exec_ctx; for (auto _ : state) { - { grpc_core::HPackParser(); } + { + grpc_core::HPackParser(); + } grpc_core::ExecCtx::Get()->Flush(); } } diff --git a/test/cpp/qps/driver.cc b/test/cpp/qps/driver.cc index 09571ddde6c..ef09eb068ae 100644 --- a/test/cpp/qps/driver.cc +++ b/test/cpp/qps/driver.cc @@ -105,7 +105,6 @@ static double SystemTime(const ClientStats& s) { return s.time_system(); } static double UserTime(const ClientStats& s) { return s.time_user(); } static double CliPollCount(const ClientStats& s) { return s.cq_poll_count(); } static double SvrPollCount(const ServerStats& s) { return s.cq_poll_count(); } -static double ServerWallTime(const ServerStats& s) { return s.time_elapsed(); } static double ServerSystemTime(const ServerStats& s) { return s.time_system(); } static double ServerUserTime(const ServerStats& s) { return s.time_user(); } static double ServerTotalCpuTime(const ServerStats& s) { diff --git a/tools/bazelify_tests/dockerimage_current_versions.bzl b/tools/bazelify_tests/dockerimage_current_versions.bzl index 5b532f9e3e7..108aa47a9cd 100644 --- a/tools/bazelify_tests/dockerimage_current_versions.bzl +++ b/tools/bazelify_tests/dockerimage_current_versions.bzl @@ -95,7 +95,7 @@ DOCKERIMAGE_CURRENT_VERSIONS = { "tools/dockerfile/test/csharp_debian11_arm64.current_version": "docker://us-docker.pkg.dev/grpc-testing/testing-images-public/csharp_debian11_arm64@sha256:4d4bc5f15e03f3d3d8fd889670ecde2c66a2e4d2dd9db80733c05c1d90c8a248", "tools/dockerfile/test/csharp_debian11_x64.current_version": "docker://us-docker.pkg.dev/grpc-testing/testing-images-public/csharp_debian11_x64@sha256:b2e5c47d986312ea0850e2f2e696b45d23ee0aabceea161d31e28559e19ec4a5", "tools/dockerfile/test/cxx_alpine_x64.current_version": "docker://us-docker.pkg.dev/grpc-testing/testing-images-public/cxx_alpine_x64@sha256:f2019edf9f2afd5042567f11afb1aa78a789fc9acdcce5ee0c14cc11f6830ed7", - "tools/dockerfile/test/cxx_clang_15_x64.current_version": "docker://us-docker.pkg.dev/grpc-testing/testing-images-public/cxx_clang_15_x64@sha256:c41629b44bfcdbc644ac90c3de4ca9f4d5a4fbc7daea8be2c5d6e4942acf6743", + "tools/dockerfile/test/cxx_clang_16_x64.current_version": "docker://us-docker.pkg.dev/grpc-testing/testing-images-public/cxx_clang_16_x64@sha256:7559d2743aa03e3247e6c80b412aec06b56a1a3aaa45ac174c07ea94afe62e1d", "tools/dockerfile/test/cxx_clang_6_x64.current_version": "docker://us-docker.pkg.dev/grpc-testing/testing-images-public/cxx_clang_6_x64@sha256:8e9ddd6c0f3d04c1bf9370cc59712a4e5883f68f307643a9b6dcb2dbd678b579", "tools/dockerfile/test/cxx_debian11_openssl102_x64.current_version": "docker://us-docker.pkg.dev/grpc-testing/testing-images-public/cxx_debian11_openssl102_x64@sha256:3bae65e56c756c491dfc4b02cff554ae3c4edd9d366d0d05d27e429b59a01b0f", "tools/dockerfile/test/cxx_debian11_x64.current_version": "docker://us-docker.pkg.dev/grpc-testing/testing-images-public/cxx_debian11_x64@sha256:ecd1fbc04423ac9c667a3fbd985a9530e9a4387db372e22229a4d9d77034f4c3", @@ -112,5 +112,5 @@ DOCKERIMAGE_CURRENT_VERSIONS = { "tools/dockerfile/test/rbe_ubuntu2204.current_version": "docker://us-docker.pkg.dev/grpc-testing/testing-images-public/rbe_ubuntu2204@sha256:a193b5d481ddd24cffbbe31d81c95f97e5a9f417fdd6ba8b7be972c28dfaa9e7", "tools/dockerfile/test/ruby_debian11_arm64.current_version": "docker://us-docker.pkg.dev/grpc-testing/testing-images-public/ruby_debian11_arm64@sha256:7e77cf17e2e8657f4cc23ac9f93630bf13213fff961799e0f16dae17cd45cf6d", "tools/dockerfile/test/ruby_debian11_x64.current_version": "docker://us-docker.pkg.dev/grpc-testing/testing-images-public/ruby_debian11_x64@sha256:e4cb502caccf2db733268ce2ddc951fda8a9df2f7f53d6b74523c33d40c83006", - "tools/dockerfile/test/sanity.current_version": "docker://us-docker.pkg.dev/grpc-testing/testing-images-public/sanity@sha256:697961d9bc7e8b61598b707fade0b1a5d2e4e8c12e7ed66b07ab35eb619f0722", + "tools/dockerfile/test/sanity.current_version": "docker://us-docker.pkg.dev/grpc-testing/testing-images-public/sanity@sha256:49745399fdef994b033fd8a5cad293d822ac25289770b7c342e34e781ff41590", } diff --git a/tools/bazelify_tests/test/portability_tests.bzl b/tools/bazelify_tests/test/portability_tests.bzl index 220b55010d6..50c42c2f2f8 100644 --- a/tools/bazelify_tests/test/portability_tests.bzl +++ b/tools/bazelify_tests/test/portability_tests.bzl @@ -58,7 +58,7 @@ def generate_run_tests_portability_tests(name): ["gcc_12_openssl309", "--cmake_configure_extra_args=-DgRPC_SSL_PROVIDER=package", "tools/dockerfile/test/cxx_debian12_openssl309_x64.current_version"], ["gcc_musl", "", "tools/dockerfile/test/cxx_alpine_x64.current_version"], ["clang_6", "--cmake_configure_extra_args=-DCMAKE_C_COMPILER=clang --cmake_configure_extra_args=-DCMAKE_CXX_COMPILER=clang++", "tools/dockerfile/test/cxx_clang_6_x64.current_version"], - ["clang_15", "--cmake_configure_extra_args=-DCMAKE_C_COMPILER=clang --cmake_configure_extra_args=-DCMAKE_CXX_COMPILER=clang++", "tools/dockerfile/test/cxx_clang_15_x64.current_version"], + ["clang_16", "--cmake_configure_extra_args=-DCMAKE_C_COMPILER=clang --cmake_configure_extra_args=-DCMAKE_CXX_COMPILER=clang++", "tools/dockerfile/test/cxx_clang_16_x64.current_version"], ] for compiler_name, args, docker_image_version in compiler_configs: diff --git a/tools/codegen/core/experiments_compiler.py b/tools/codegen/core/experiments_compiler.py index 78ebbc55065..0e61422f28a 100644 --- a/tools/codegen/core/experiments_compiler.py +++ b/tools/codegen/core/experiments_compiler.py @@ -70,6 +70,9 @@ def _EXPERIMENTS_TEST_SKELETON(defs, test_body): #include #include "test/core/experiments/fixtures/experiments.h" + +#include + #include "gtest/gtest.h" #include "src/core/lib/experiments/config.h" diff --git a/tools/dockerfile/grpc_clang_format/Dockerfile b/tools/dockerfile/grpc_clang_format/Dockerfile index 72257a71219..f3d675bab2f 100644 --- a/tools/dockerfile/grpc_clang_format/Dockerfile +++ b/tools/dockerfile/grpc_clang_format/Dockerfile @@ -12,7 +12,7 @@ # See the License for the specific language governing permissions and # limitations under the License. -FROM silkeh/clang:15-bullseye +FROM silkeh/clang:16-bullseye ADD clang_format_all_the_things.sh / diff --git a/tools/dockerfile/grpc_clang_tidy/Dockerfile b/tools/dockerfile/grpc_clang_tidy/Dockerfile index 297bdfbdd2e..71125ada0d7 100644 --- a/tools/dockerfile/grpc_clang_tidy/Dockerfile +++ b/tools/dockerfile/grpc_clang_tidy/Dockerfile @@ -12,7 +12,7 @@ # See the License for the specific language governing permissions and # limitations under the License. -FROM silkeh/clang:15-bullseye +FROM silkeh/clang:16-bullseye # Install prerequisites for the clang-tidy script RUN apt-get update && apt-get install -y python3 jq git && apt-get clean diff --git a/tools/dockerfile/grpc_iwyu/Dockerfile b/tools/dockerfile/grpc_iwyu/Dockerfile index a57dfc00115..01b9a2d3a4a 100644 --- a/tools/dockerfile/grpc_iwyu/Dockerfile +++ b/tools/dockerfile/grpc_iwyu/Dockerfile @@ -15,10 +15,10 @@ # Docker file for running IWYU. # Updated: 2022-11-03 -FROM silkeh/clang:15-bullseye +FROM silkeh/clang:16-bullseye # Install prerequisites for the iwyu script -RUN apt-get update && apt-get install -y python3 jq git cmake python zlib1g-dev libtinfo-dev libclang-15-dev && apt-get clean +RUN apt-get update && apt-get install -y python3 jq git cmake python zlib1g-dev libtinfo-dev libclang-16-dev && apt-get clean ADD iwyu.sh / # When running locally, we'll be impersonating the current user, so we need diff --git a/tools/dockerfile/grpc_iwyu/iwyu.sh b/tools/dockerfile/grpc_iwyu/iwyu.sh index af4d86833d3..776e79c5213 100755 --- a/tools/dockerfile/grpc_iwyu/iwyu.sh +++ b/tools/dockerfile/grpc_iwyu/iwyu.sh @@ -39,16 +39,16 @@ git clone https://github.com/include-what-you-use/include-what-you-use.git iwyu # ############################################################################### -# latest commit on the clang 15 branch +# latest commit on the clang_16 branch cd ${IWYU_ROOT}/iwyu -git checkout 7f0b6c304acf69c42bb7f6e03c63f836924cb7e0 +git checkout 7301b1fc88e5e16d8df73aecea55037d9c0a371b if [ $? -ne 0 ]; then echo "Failed to checkout iwyu commit" exit 1 fi mkdir -p ${IWYU_ROOT}/iwyu_build cd ${IWYU_ROOT}/iwyu_build -cmake -G "Unix Makefiles" -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DLLVM_ROOT_DIR=/usr/lib/llvm-15 ${IWYU_ROOT}/iwyu +cmake -G "Unix Makefiles" -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DLLVM_ROOT_DIR=/usr/lib/llvm-16 ${IWYU_ROOT}/iwyu if [ $? -ne 0 ]; then echo "Failed to cmake iwyu" exit 1 @@ -60,10 +60,6 @@ if [ $? -ne 0 ]; then fi cd ${IWYU_ROOT} -# patch python shebang for our environment (we need python3, not python) -sed -i 's,^#!/usr/bin/env python,#!/usr/bin/env python3,g' ${IWYU_ROOT}/iwyu/iwyu_tool.py -sed -i 's,^#!/usr/bin/env python,#!/usr/bin/env python3,g' ${IWYU_ROOT}/iwyu/fix_includes.py - cat compile_commands.json \ | sed "s/ -DNDEBUG//g" \ | sed "s/ -std=c\\+\\+14/ -std=c++17/g" \ @@ -130,7 +126,7 @@ cat iwyu/iwyu.*.out > iwyu.out ${IWYU_ROOT}/iwyu/fix_includes.py \ --nocomments \ --nosafe_headers \ - --ignore_re='^(include/.*|src/core/lib/security/credentials/tls/grpc_tls_credentials_options\.h)' \ + --ignore_re='^(include/.*|src/core/lib/security/credentials/tls/grpc_tls_credentials_options\.h|external/.*)' \ < iwyu.out \ | grep 'IWYU edited 0 files on your behalf' diff --git a/tools/dockerfile/test/cxx_clang_15_x64.current_version b/tools/dockerfile/test/cxx_clang_15_x64.current_version deleted file mode 100644 index b8e66d280d3..00000000000 --- a/tools/dockerfile/test/cxx_clang_15_x64.current_version +++ /dev/null @@ -1 +0,0 @@ -us-docker.pkg.dev/grpc-testing/testing-images-public/cxx_clang_15_x64:3f2c40d2de5d4d986d17381920927a9d53760e19@sha256:c41629b44bfcdbc644ac90c3de4ca9f4d5a4fbc7daea8be2c5d6e4942acf6743 \ No newline at end of file diff --git a/tools/dockerfile/test/cxx_clang_16_x64.current_version b/tools/dockerfile/test/cxx_clang_16_x64.current_version new file mode 100644 index 00000000000..f4737b6ccbe --- /dev/null +++ b/tools/dockerfile/test/cxx_clang_16_x64.current_version @@ -0,0 +1 @@ +us-docker.pkg.dev/grpc-testing/testing-images-public/cxx_clang_16_x64:b7ca144315b9ef26226ac3d6e2817ecf523abc07@sha256:7559d2743aa03e3247e6c80b412aec06b56a1a3aaa45ac174c07ea94afe62e1d \ No newline at end of file diff --git a/tools/dockerfile/test/cxx_clang_15_x64/Dockerfile b/tools/dockerfile/test/cxx_clang_16_x64/Dockerfile similarity index 98% rename from tools/dockerfile/test/cxx_clang_15_x64/Dockerfile rename to tools/dockerfile/test/cxx_clang_16_x64/Dockerfile index a4143f48dd1..1f8f112bac9 100644 --- a/tools/dockerfile/test/cxx_clang_15_x64/Dockerfile +++ b/tools/dockerfile/test/cxx_clang_16_x64/Dockerfile @@ -12,7 +12,7 @@ # See the License for the specific language governing permissions and # limitations under the License. -FROM silkeh/clang:15-bullseye +FROM silkeh/clang:16-bullseye RUN apt-get update && apt-get install -y build-essential curl git time wget zip && apt-get clean #================= diff --git a/tools/dockerfile/test/sanity.current_version b/tools/dockerfile/test/sanity.current_version index 5223f72eb91..d8f6ffe1e74 100644 --- a/tools/dockerfile/test/sanity.current_version +++ b/tools/dockerfile/test/sanity.current_version @@ -1 +1 @@ -us-docker.pkg.dev/grpc-testing/testing-images-public/sanity:33d6fede0d99054071b50e7d0b990f0b55a35f69@sha256:697961d9bc7e8b61598b707fade0b1a5d2e4e8c12e7ed66b07ab35eb619f0722 \ No newline at end of file +us-docker.pkg.dev/grpc-testing/testing-images-public/sanity:4df7e77523dc402f423cb024d8ae9693b562cba1@sha256:49745399fdef994b033fd8a5cad293d822ac25289770b7c342e34e781ff41590 \ No newline at end of file diff --git a/tools/dockerfile/test/sanity/Dockerfile b/tools/dockerfile/test/sanity/Dockerfile index 26971861f3b..bdd6c4d55b4 100644 --- a/tools/dockerfile/test/sanity/Dockerfile +++ b/tools/dockerfile/test/sanity/Dockerfile @@ -12,7 +12,7 @@ # See the License for the specific language governing permissions and # limitations under the License. -FROM silkeh/clang:15-bullseye +FROM silkeh/clang:16-bullseye #================= # Basic C core dependencies @@ -105,7 +105,7 @@ RUN python3 -m pip install --upgrade --ignore-installed PyYAML==5.4.1 --user RUN apt-get update && apt-get install -y jq git # Install prerequisites for the iwyu script -RUN apt-get update && apt-get install -y jq git cmake zlib1g-dev libtinfo-dev libclang-15-dev && apt-get clean +RUN apt-get update && apt-get install -y jq git cmake zlib1g-dev libtinfo-dev libclang-16-dev && apt-get clean #======================== # Bazel installation diff --git a/tools/run_tests/run_tests.py b/tools/run_tests/run_tests.py index ec961dbb672..64d2cfcbeb0 100755 --- a/tools/run_tests/run_tests.py +++ b/tools/run_tests/run_tests.py @@ -584,8 +584,8 @@ class CLanguage(object): return ("alpine", []) elif compiler == "clang6": return ("clang_6", self._clang_cmake_configure_extra_args()) - elif compiler == "clang15": - return ("clang_15", self._clang_cmake_configure_extra_args()) + elif compiler == "clang16": + return ("clang_16", self._clang_cmake_configure_extra_args()) else: raise Exception("Compiler %s not supported." % compiler) @@ -1713,7 +1713,7 @@ argp.add_argument( "gcc12_openssl309", "gcc_musl", "clang6", - "clang15", + "clang16", # TODO: Automatically populate from supported version "python2.7", "python3.5", diff --git a/tools/run_tests/run_tests_matrix.py b/tools/run_tests/run_tests_matrix.py index 32398a2244e..d858e102c10 100755 --- a/tools/run_tests/run_tests_matrix.py +++ b/tools/run_tests/run_tests_matrix.py @@ -360,7 +360,7 @@ def _create_portability_test_jobs( "gcc12_openssl309", "gcc_musl", "clang6", - "clang15", + "clang16", ]: test_jobs += _generate_jobs( languages=["c", "c++"],