[Deps] Update to Clang-16 (#34492)

<!--

If you know who should review your pull request, please assign it to
that
person, otherwise the pull request would get assigned randomly.

If your pull request is for a specific language, please add the
appropriate
lang label.

-->

.clang-tidy

@@ -1,15 +1,24 @@
 ---
 # Note on checks are disabled on purpose
 #
+# - abseil-cleanup-ctad
+#   Requires C++17 and higher.
+#
 # - abseil-no-namespace
 #   https://bugs.llvm.org/show_bug.cgi?id=47947
 #
+# - bugprone-exception-escape
+#   https://github.com/llvm/llvm-project/issues/54668 (seems to be fixed in LLVM17)
+#
 # - bugprone-reserved-identifier
 #   Some macros need to be defined for portability purpose; e.g. _BSD_SOURCE.
 #
 # - modernize-redundant-void-arg
 #   Some source should be strictly C99 and func(void) should be used.
 #
+# - google-readability-casting
+#   https://github.com/llvm/llvm-project/issues/57959
+#
 # Note on checks which will be enabled in future. These are good to have but
 # it's not activated yet due to the existing issues with the checks.
 # Once those issues are clear, these checks can be enabled later.
@@ -48,14 +57,17 @@
 # - readability-else-after-return
 # - readability-implicit-bool-conversion
 # - readability-redundant-declaration
+# - readability-redundant-string-cstr
 #
 Checks: '-*,
   abseil-*,
+  -abseil-cleanup-ctad,
   -abseil-no-namespace,
   bugprone-*,
   -bugprone-assignment-in-if-condition,
   -bugprone-branch-clone,
   -bugprone-easily-swappable-parameters,
+  -bugprone-exception-escape,
   -bugprone-implicit-widening-of-multiplication-result,
   -bugprone-infinite-loop,
   -bugprone-narrowing-conversions,
@@ -66,6 +78,7 @@ Checks: '-*,
   -bugprone-too-small-loop-variable,
   -bugprone-unchecked-optional-access,
   google-*,
+  -google-readability-casting,
   -google-runtime-int,
   -google-runtime-references,
   performance-*,
@@ -73,6 +86,7 @@ Checks: '-*,
   -performance-no-int-to-ptr,
   -performance-unnecessary-copy-initialization,
   -performance-unnecessary-value-param,
+  clang-diagnostic-deprecated-declarations,
   clang-diagnostic-deprecated-register,
   clang-diagnostic-expansion-to-defined,
   clang-diagnostic-ignored-attributes,
@@ -120,7 +134,7 @@ Checks: '-*,
   readability-redundant-control-flow,
   readability-redundant-function-ptr-dereference,
   readability-redundant-smartptr-get,
-  readability-redundant-string-cstr,
+  -readability-redundant-string-cstr,
   readability-redundant-string-init,
   readability-simplify-boolean-expr,
   readability-static-definition-in-anonymous-namespace,

BUILD

@@ -2340,7 +2340,6 @@ grpc_cc_library(
     external_deps = [
         "absl/base",
         "absl/base:core_headers",
-        "absl/meta:type_traits",
         "absl/status",
         "absl/status:statusor",
         "absl/strings",
@@ -3163,7 +3162,6 @@ grpc_cc_library(
     ],
     external_deps = [
         "absl/base:core_headers",
-        "absl/container:flat_hash_set",
         "absl/functional:any_invocable",
         "absl/status",
         "absl/status:statusor",
@@ -3582,7 +3580,6 @@ grpc_cc_library(
     ],
     external_deps = [
         "absl/base:core_headers",
-        "absl/meta:type_traits",
         "absl/status",
         "absl/status:statusor",
         "absl/strings",

fuzztest/core/channel/BUILD

@@ -18,6 +18,7 @@ grpc_fuzz_test(
     name = "union_with_test",
     srcs = ["union_with_test.cc"],
     external_deps = [
+        "absl/types:variant",
         "fuzztest",
         "fuzztest_main",
         "gtest",

fuzztest/core/channel/union_with_test.cc

@@ -14,11 +14,14 @@
 
 // Test to verify Fuzztest integration
 
-#include "fuzztest/fuzztest.h"
+#include <string>
+#include <utility>
+#include <vector>
 
+#include "fuzztest/fuzztest.h"
 #include "gtest/gtest.h"
-
 #include "src/core/lib/channel/channel_args.h"
+#include "absl/types/variant.h"
 
 namespace grpc_core {
 

include/grpcpp/support/proto_buffer_reader.h

@@ -126,11 +126,14 @@ class ProtoBufferReader : public grpc::protobuf::io::ZeroCopyInputStream {
   /// Read the next `count` bytes and append it to the given Cord.
   // (override is conditionally omitted here to support old Protobuf which
   //  doesn't have ReadCord method)
-  // NOLINTNEXTLINE(modernize-use-override)
+  // NOLINTBEGIN(modernize-use-override,
+  // clang-diagnostic-inconsistent-missing-override)
   virtual bool ReadCord(absl::Cord* cord, int count)
 #if GOOGLE_PROTOBUF_VERSION >= 4022000
       override
 #endif
+  // NOLINTEND(modernize-use-override,
+  // clang-diagnostic-inconsistent-missing-override)
   {
     if (!status().ok()) {
       return false;

include/grpcpp/support/proto_buffer_writer.h

@@ -156,11 +156,14 @@ class ProtoBufferWriter : public grpc::protobuf::io::ZeroCopyOutputStream {
   /// blocks of the cord, and the slices of the byte_buffer.
   // (override is conditionally omitted here to support old Protobuf which
   //  doesn't have ReadCord method)
-  // NOLINTNEXTLINE(modernize-use-override)
+  // NOLINTBEGIN(modernize-use-override,
+  // clang-diagnostic-inconsistent-missing-override)
   virtual bool WriteCord(const absl::Cord& cord)
 #if GOOGLE_PROTOBUF_VERSION >= 4022000
       override
 #endif
+  // NOLINTEND(modernize-use-override,
+  // clang-diagnostic-inconsistent-missing-override)
   {
     grpc_slice_buffer* buffer = slice_buffer();
     size_t cur = 0;

src/core/BUILD

@@ -414,7 +414,6 @@ grpc_cc_library(
         "try_seq",
         "//:gpr",
         "//:gpr_platform",
-        "//:grpc_trace",
     ],
 )
 
@@ -443,7 +442,6 @@ grpc_cc_library(
         "//:event_engine_base_hdrs",
         "//:exec_ctx",
         "//:gpr",
-        "//:grpc_trace",
         "//:ref_counted_ptr",
     ],
 )
@@ -633,7 +631,6 @@ grpc_cc_library(
         "promise_trace",
         "//:gpr",
         "//:gpr_platform",
-        "//:grpc_trace",
     ],
 )
 
@@ -706,7 +703,6 @@ grpc_cc_library(
         "promise_like",
         "promise_trace",
         "//:gpr",
-        "//:grpc_trace",
     ],
 )
 
@@ -833,7 +829,6 @@ grpc_cc_library(
         "poll",
         "promise_trace",
         "//:gpr",
-        "//:grpc_trace",
     ],
 )
 
@@ -856,7 +851,6 @@ grpc_cc_library(
         "promise_trace",
         "//:debug_location",
         "//:gpr",
-        "//:grpc_trace",
     ],
 )
 
@@ -883,7 +877,6 @@ grpc_cc_library(
         "seq",
         "//:debug_location",
         "//:gpr",
-        "//:grpc_trace",
         "//:ref_counted_ptr",
     ],
 )
@@ -955,7 +948,6 @@ grpc_cc_library(
         "promise_trace",
         "//:gpr",
         "//:gpr_platform",
-        "//:grpc_trace",
     ],
 )
 
@@ -1048,7 +1040,6 @@ grpc_cc_library(
         "absl/base:core_headers",
         "absl/status",
         "absl/status:statusor",
-        "absl/strings",
         "absl/types:optional",
     ],
     language = "c++",
@@ -1904,7 +1895,6 @@ grpc_cc_library(
         "absl/container:flat_hash_map",
         "absl/functional:any_invocable",
         "absl/hash",
-        "absl/meta:type_traits",
         "absl/status",
         "absl/status:statusor",
         "absl/strings",
@@ -2050,7 +2040,6 @@ grpc_cc_library(
         "absl/container:flat_hash_map",
         "absl/functional:any_invocable",
         "absl/hash",
-        "absl/meta:type_traits",
         "absl/status",
         "absl/status:statusor",
         "absl/strings",
@@ -3717,6 +3706,7 @@ grpc_cc_library(
     ],
     external_deps = [
         "absl/base:core_headers",
+        "absl/meta:type_traits",
         "absl/random",
         "absl/status",
         "absl/status:statusor",
@@ -3852,7 +3842,6 @@ grpc_cc_library(
         "json_args",
         "json_object_loader",
         "latch",
-        "poll",
         "race",
         "service_config_parser",
         "slice",
@@ -3881,6 +3870,7 @@ grpc_cc_library(
     ],
     external_deps = [
         "absl/base:core_headers",
+        "absl/meta:type_traits",
         "absl/random",
         "absl/status",
         "absl/status:statusor",
@@ -3983,7 +3973,6 @@ grpc_cc_library(
         "json_object_loader",
         "map",
         "pipe",
-        "poll",
         "ref_counted_string",
         "service_config_parser",
         "slice",
@@ -4015,7 +4004,6 @@ grpc_cc_library(
     external_deps = [
         "absl/base:core_headers",
         "absl/container:inlined_vector",
-        "absl/meta:type_traits",
         "absl/status",
         "absl/status:statusor",
         "absl/strings",
@@ -4047,7 +4035,6 @@ grpc_cc_library(
         "lb_policy_registry",
         "map",
         "pipe",
-        "poll",
         "pollset_set",
         "ref_counted",
         "resolved_address",
@@ -4857,6 +4844,7 @@ grpc_cc_library(
         "json_object_loader",
         "lb_policy",
         "lb_policy_factory",
+        "resolved_address",
         "subchannel_interface",
         "time",
         "useful",
@@ -4932,6 +4920,7 @@ grpc_cc_library(
         "ext/filters/client_channel/lb_policy/round_robin/round_robin.cc",
     ],
     external_deps = [
+        "absl/meta:type_traits",
         "absl/random",
         "absl/status",
         "absl/status:statusor",
@@ -4985,6 +4974,7 @@ grpc_cc_library(
     ],
     external_deps = [
         "absl/base:core_headers",
+        "absl/meta:type_traits",
         "absl/random",
         "absl/status",
         "absl/status:statusor",
@@ -5052,6 +5042,7 @@ grpc_cc_library(
     ],
     external_deps = [
         "absl/base:core_headers",
+        "absl/meta:type_traits",
         "absl/random",
         "absl/status",
         "absl/status:statusor",
@@ -5114,6 +5105,7 @@ grpc_cc_library(
         "lb_policy_factory",
         "lb_policy_registry",
         "pollset_set",
+        "ref_counted_string",
         "time",
         "validation_errors",
         "//:channel_arg_names",
@@ -5138,6 +5130,7 @@ grpc_cc_library(
     ],
     external_deps = [
         "absl/base:core_headers",
+        "absl/meta:type_traits",
         "absl/random",
         "absl/status",
         "absl/status:statusor",
@@ -5237,7 +5230,7 @@ grpc_cc_library(
         "//:src/cpp/server/load_reporter/constants.h",
     ],
     external_deps = [
-        "absl/meta:type_traits",
+        "absl/container:inlined_vector",
         "absl/status",
         "absl/status:statusor",
         "absl/strings",
@@ -5331,6 +5324,7 @@ grpc_cc_library(
         "time",
         "//:backoff",
         "//:debug_location",
+        "//:endpoint_addresses",
         "//:event_engine_base_hdrs",
         "//:exec_ctx",
         "//:gpr",
@@ -6077,7 +6071,6 @@ grpc_cc_library(
         "logging_sink",
         "map",
         "pipe",
-        "poll",
         "slice",
         "slice_buffer",
         "time",

src/core/ext/filters/channel_idle/channel_idle_filter.cc

@@ -19,12 +19,11 @@
 
 #include "src/core/ext/filters/channel_idle/channel_idle_filter.h"
 
-#include <stdint.h>
-
 #include <functional>
 #include <utility>
 
 #include "absl/base/thread_annotations.h"
+#include "absl/meta/type_traits.h"
 #include "absl/random/random.h"
 #include "absl/types/optional.h"
 
@@ -54,6 +53,7 @@
 #include "src/core/lib/surface/channel_init.h"
 #include "src/core/lib/surface/channel_stack_type.h"
 #include "src/core/lib/transport/http2_errors.h"
+#include "src/core/lib/transport/metadata_batch.h"
 
 namespace grpc_core {
 

src/core/ext/filters/client_channel/dynamic_filters.cc

@@ -21,7 +21,6 @@
 #include <stddef.h>
 
 #include <new>
-#include <string>
 #include <utility>
 
 #include "absl/status/statusor.h"

src/core/ext/filters/client_channel/lb_policy/endpoint_list.cc

@@ -20,7 +20,6 @@
 
 #include <stdlib.h>
 
-#include <algorithm>
 #include <memory>
 #include <utility>
 #include <vector>

src/core/ext/filters/client_channel/lb_policy/grpclb/client_load_reporting_filter.cc

@@ -25,7 +25,6 @@
 #include <type_traits>
 #include <utility>
 
-#include "absl/meta/type_traits.h"
 #include "absl/types/optional.h"
 
 #include "src/core/ext/filters/client_channel/lb_policy/grpclb/grpclb_client_stats.h"
@@ -34,7 +33,6 @@
 #include "src/core/lib/promise/context.h"
 #include "src/core/lib/promise/map.h"
 #include "src/core/lib/promise/pipe.h"
-#include "src/core/lib/promise/poll.h"
 #include "src/core/lib/resource_quota/arena.h"
 #include "src/core/lib/transport/metadata_batch.h"
 #include "src/core/lib/transport/transport.h"

src/core/ext/filters/client_channel/lb_policy/grpclb/grpclb.cc

@@ -64,7 +64,6 @@
 
 #include <algorithm>
 #include <atomic>
-#include <initializer_list>
 #include <map>
 #include <memory>
 #include <string>
@@ -753,9 +752,11 @@ GrpcLb::PickResult GrpcLb::Picker::Pick(PickArgs args) {
       // The metadata value is a hack: we pretend the pointer points to
       // a string and rely on the client_load_reporting filter to know
       // how to interpret it.
+      // NOLINTBEGIN(bugprone-string-constructor)
       args.initial_metadata->Add(
           GrpcLbClientStatsMetadata::key(),
           absl::string_view(reinterpret_cast<const char*>(client_stats), 0));
+      // NOLINTEND(bugprone-string-constructor)
       // Update calls-started.
       client_stats->AddCallStarted();
     }

src/core/ext/filters/client_channel/lb_policy/outlier_detection/outlier_detection.cc

@@ -33,6 +33,7 @@
 #include <vector>
 
 #include "absl/base/thread_annotations.h"
+#include "absl/meta/type_traits.h"
 #include "absl/random/random.h"
 #include "absl/status/status.h"
 #include "absl/status/statusor.h"

src/core/ext/filters/client_channel/lb_policy/pick_first/pick_first.cc

@@ -23,7 +23,6 @@
 
 #include <algorithm>
 #include <memory>
-#include <string>
 #include <type_traits>
 #include <utility>
 #include <vector>
@@ -55,6 +54,7 @@
 #include "src/core/lib/gprpp/work_serializer.h"
 #include "src/core/lib/iomgr/exec_ctx.h"
 #include "src/core/lib/iomgr/iomgr_fwd.h"
+#include "src/core/lib/iomgr/resolved_address.h"
 #include "src/core/lib/json/json.h"
 #include "src/core/lib/json/json_args.h"
 #include "src/core/lib/json/json_object_loader.h"

src/core/ext/filters/client_channel/lb_policy/priority/priority.cc

@@ -47,6 +47,7 @@
 #include "src/core/lib/gprpp/debug_location.h"
 #include "src/core/lib/gprpp/orphanable.h"
 #include "src/core/lib/gprpp/ref_counted_ptr.h"
+#include "src/core/lib/gprpp/ref_counted_string.h"
 #include "src/core/lib/gprpp/time.h"
 #include "src/core/lib/gprpp/validation_errors.h"
 #include "src/core/lib/gprpp/work_serializer.h"

src/core/ext/filters/client_channel/lb_policy/rls/rls.cc

@@ -28,7 +28,6 @@
 
 #include <algorithm>
 #include <deque>
-#include <initializer_list>
 #include <list>
 #include <map>
 #include <memory>
@@ -94,7 +93,6 @@
 #include "src/core/lib/load_balancing/lb_policy_registry.h"
 #include "src/core/lib/resolver/endpoint_addresses.h"
 #include "src/core/lib/resolver/resolver_registry.h"
-#include "src/core/lib/security/credentials/credentials.h"
 #include "src/core/lib/security/credentials/fake/fake_credentials.h"
 #include "src/core/lib/service_config/service_config_impl.h"
 #include "src/core/lib/slice/slice.h"
@@ -902,7 +900,7 @@ std::map<std::string, std::string> BuildKeyMap(
   auto it = key_builder_map.find(std::string(path));
   if (it == key_builder_map.end()) {
     // Didn't find exact match, try method wildcard.
-    last_slash_pos = path.rfind("/");
+    last_slash_pos = path.rfind('/');
     GPR_DEBUG_ASSERT(last_slash_pos != path.npos);
     if (GPR_UNLIKELY(last_slash_pos == path.npos)) return {};
     std::string service(path.substr(0, last_slash_pos + 1));
@@ -936,7 +934,7 @@ std::map<std::string, std::string> BuildKeyMap(
   // Add service key.
   if (!key_builder->service_key.empty()) {
     if (last_slash_pos == path.npos) {
-      last_slash_pos = path.rfind("/");
+      last_slash_pos = path.rfind('/');
       GPR_DEBUG_ASSERT(last_slash_pos != path.npos);
       if (GPR_UNLIKELY(last_slash_pos == path.npos)) return {};
     }
@@ -946,7 +944,7 @@ std::map<std::string, std::string> BuildKeyMap(
   // Add method key.
   if (!key_builder->method_key.empty()) {
     if (last_slash_pos == path.npos) {
-      last_slash_pos = path.rfind("/");
+      last_slash_pos = path.rfind('/');
       GPR_DEBUG_ASSERT(last_slash_pos != path.npos);
       if (GPR_UNLIKELY(last_slash_pos == path.npos)) return {};
     }

src/core/ext/filters/client_channel/lb_policy/round_robin/round_robin.cc

@@ -18,7 +18,6 @@
 
 #include <inttypes.h>
 #include <stdlib.h>
-#include <string.h>
 
 #include <algorithm>
 #include <atomic>
@@ -27,6 +26,7 @@
 #include <utility>
 #include <vector>
 
+#include "absl/meta/type_traits.h"
 #include "absl/random/random.h"
 #include "absl/status/status.h"
 #include "absl/status/statusor.h"

src/core/ext/filters/client_channel/lb_policy/subchannel_list.h

@@ -23,7 +23,6 @@
 #include <string.h>
 
 #include <memory>
-#include <string>
 #include <utility>
 #include <vector>
 

src/core/ext/filters/client_channel/lb_policy/weighted_round_robin/weighted_round_robin.cc

@@ -32,6 +32,7 @@
 #include <vector>
 
 #include "absl/base/thread_annotations.h"
+#include "absl/meta/type_traits.h"
 #include "absl/random/random.h"
 #include "absl/status/status.h"
 #include "absl/status/statusor.h"

src/core/ext/filters/client_channel/lb_policy/weighted_target/weighted_target.cc

@@ -27,6 +27,7 @@
 #include <vector>
 
 #include "absl/base/thread_annotations.h"
+#include "absl/meta/type_traits.h"
 #include "absl/random/random.h"
 #include "absl/status/status.h"
 #include "absl/status/statusor.h"

src/core/ext/filters/client_channel/lb_policy/xds/cds.cc

@@ -32,7 +32,6 @@
 #include "absl/types/optional.h"
 #include "absl/types/variant.h"
 
-#include <grpc/grpc.h>
 #include <grpc/grpc_security.h>
 #include <grpc/impl/connectivity_state.h>
 #include <grpc/support/json.h>

src/core/ext/filters/client_channel/resolver/binder/binder_resolver.cc

@@ -28,7 +28,6 @@
 #include <sys/un.h>
 
 #include <memory>
-#include <string>
 #include <utility>
 
 #include "absl/status/statusor.h"

src/core/ext/filters/client_channel/resolver/dns/c_ares/dns_resolver_ares.cc

@@ -60,7 +60,6 @@
 
 #include <address_sorting/address_sorting.h>
 
-#include "absl/container/flat_hash_set.h"
 #include "absl/strings/str_cat.h"
 
 #include "src/core/ext/filters/client_channel/lb_policy/grpclb/grpclb_balancer_addresses.h"

src/core/ext/filters/client_channel/resolver/dns/c_ares/grpc_ares_wrapper.cc

@@ -19,7 +19,6 @@
 #include <grpc/support/port_platform.h>
 
 #include <algorithm>
-#include <initializer_list>
 #include <vector>
 
 #include "absl/strings/string_view.h"

src/core/ext/filters/client_channel/resolver/dns/native/dns_resolver.cc

@@ -18,7 +18,6 @@
 
 #include <algorithm>
 #include <memory>
-#include <string>
 #include <utility>
 #include <vector>
 

src/core/ext/filters/client_channel/resolver/polling_resolver.cc

@@ -28,7 +28,6 @@
 #include "absl/status/status.h"
 #include "absl/status/statusor.h"
 #include "absl/strings/str_cat.h"
-#include "absl/strings/string_view.h"
 #include "absl/strings/strip.h"
 
 #include <grpc/support/log.h>
@@ -39,6 +38,7 @@
 #include "src/core/lib/gprpp/ref_counted_ptr.h"
 #include "src/core/lib/gprpp/work_serializer.h"
 #include "src/core/lib/iomgr/exec_ctx.h"
+#include "src/core/lib/resolver/endpoint_addresses.h"
 #include "src/core/lib/service_config/service_config.h"
 #include "src/core/lib/uri/uri_parser.h"
 

src/core/ext/filters/client_channel/resolver/xds/xds_resolver.cc

@@ -21,7 +21,6 @@
 
 #include <algorithm>
 #include <functional>
-#include <initializer_list>
 #include <map>
 #include <memory>
 #include <string>

src/core/ext/filters/client_channel/retry_filter.cc

@@ -21,7 +21,6 @@
 #include <string>
 
 #include "absl/status/statusor.h"
-#include "absl/strings/string_view.h"
 #include "absl/strings/strip.h"
 #include "absl/types/optional.h"
 

src/core/ext/filters/client_channel/retry_filter_legacy_call_data.cc

@@ -20,7 +20,6 @@
 
 #include <memory>
 #include <new>
-#include <string>
 
 #include "absl/status/status.h"
 #include "absl/strings/str_cat.h"

src/core/ext/filters/client_channel/subchannel.cc

@@ -24,7 +24,6 @@
 #include <algorithm>
 #include <memory>
 #include <new>
-#include <string>
 #include <utility>
 
 #include "absl/status/statusor.h"

src/core/ext/filters/client_channel/subchannel_stream_client.cc

@@ -21,7 +21,6 @@
 #include <inttypes.h>
 #include <stdio.h>
 
-#include <string>
 #include <utility>
 
 #include <grpc/status.h>

src/core/ext/filters/fault_injection/fault_injection_filter.cc

@@ -27,6 +27,7 @@
 #include <type_traits>
 #include <utility>
 
+#include "absl/meta/type_traits.h"
 #include "absl/status/status.h"
 #include "absl/strings/numbers.h"
 #include "absl/strings/str_cat.h"

src/core/ext/filters/http/client/http_client_filter.cc

@@ -21,7 +21,6 @@
 
 #include <algorithm>
 #include <functional>
-#include <initializer_list>
 #include <memory>
 #include <string>
 #include <utility>
@@ -44,7 +43,6 @@
 #include "src/core/lib/promise/latch.h"
 #include "src/core/lib/promise/map.h"
 #include "src/core/lib/promise/pipe.h"
-#include "src/core/lib/promise/poll.h"
 #include "src/core/lib/promise/race.h"
 #include "src/core/lib/resource_quota/arena.h"
 #include "src/core/lib/slice/percent_encoding.h"

src/core/ext/filters/http/message_compress/compression_filter.cc

@@ -19,12 +19,9 @@
 #include <inttypes.h>
 
 #include <functional>
-#include <initializer_list>
 #include <memory>
-#include <string>
 #include <utility>
 
-#include "absl/meta/type_traits.h"
 #include "absl/status/status.h"
 #include "absl/strings/str_cat.h"
 #include "absl/strings/str_format.h"
@@ -49,7 +46,6 @@
 #include "src/core/lib/promise/context.h"
 #include "src/core/lib/promise/latch.h"
 #include "src/core/lib/promise/pipe.h"
-#include "src/core/lib/promise/poll.h"
 #include "src/core/lib/promise/prioritized_race.h"
 #include "src/core/lib/resource_quota/arena.h"
 #include "src/core/lib/slice/slice_buffer.h"

src/core/ext/filters/http/server/http_server_filter.cc

@@ -22,11 +22,9 @@
 
 #include <functional>
 #include <memory>
-#include <string>
 #include <utility>
 
 #include "absl/base/attributes.h"
-#include "absl/meta/type_traits.h"
 #include "absl/strings/string_view.h"
 #include "absl/types/optional.h"
 

src/core/ext/filters/load_reporting/server_load_reporting_filter.cc

@@ -25,12 +25,11 @@
 #include <stdlib.h>
 
 #include <functional>
-#include <initializer_list>
 #include <memory>
 #include <string>
 #include <utility>
 
-#include "absl/meta/type_traits.h"
+#include "absl/container/inlined_vector.h"
 #include "absl/status/status.h"
 #include "absl/strings/ascii.h"
 #include "absl/strings/str_cat.h"

src/core/ext/filters/logging/logging_filter.cc

@@ -65,7 +65,6 @@
 #include "src/core/lib/promise/context.h"
 #include "src/core/lib/promise/map.h"
 #include "src/core/lib/promise/pipe.h"
-#include "src/core/lib/promise/poll.h"
 #include "src/core/lib/resolver/resolver_registry.h"
 #include "src/core/lib/resource_quota/arena.h"
 #include "src/core/lib/slice/slice.h"

src/core/ext/filters/message_size/message_size_filter.cc

@@ -21,8 +21,6 @@
 #include <inttypes.h>
 
 #include <functional>
-#include <initializer_list>
-#include <string>
 #include <utility>
 
 #include "absl/strings/str_format.h"
@@ -40,7 +38,6 @@
 #include "src/core/lib/promise/activity.h"
 #include "src/core/lib/promise/context.h"
 #include "src/core/lib/promise/latch.h"
-#include "src/core/lib/promise/poll.h"
 #include "src/core/lib/promise/race.h"
 #include "src/core/lib/resource_quota/arena.h"
 #include "src/core/lib/service_config/service_config_call_data.h"

src/core/ext/filters/rbac/rbac_filter.cc

@@ -38,6 +38,7 @@
 #include "src/core/lib/security/authorization/grpc_authorization_engine.h"
 #include "src/core/lib/security/context/security_context.h"
 #include "src/core/lib/service_config/service_config_call_data.h"
+#include "src/core/lib/transport/metadata_batch.h"
 #include "src/core/lib/transport/transport_fwd.h"
 #include "src/core/lib/transport/transport_impl.h"
 

src/core/ext/filters/server_config_selector/server_config_selector_filter.cc

@@ -40,6 +40,7 @@
 #include "src/core/lib/resource_quota/arena.h"
 #include "src/core/lib/service_config/service_config.h"
 #include "src/core/lib/service_config/service_config_call_data.h"
+#include "src/core/lib/transport/metadata_batch.h"
 #include "src/core/lib/transport/transport.h"
 
 namespace grpc_core {

src/core/ext/filters/stateful_session/stateful_session_filter.cc

@@ -37,7 +37,6 @@
 #include "absl/types/optional.h"
 
 #include <grpc/support/log.h>
-#include <grpc/support/time.h>
 
 #include "src/core/ext/filters/client_channel/resolver/xds/xds_resolver.h"
 #include "src/core/ext/filters/stateful_session/stateful_session_service_config_parser.h"
@@ -50,7 +49,6 @@
 #include "src/core/lib/promise/context.h"
 #include "src/core/lib/promise/map.h"
 #include "src/core/lib/promise/pipe.h"
-#include "src/core/lib/promise/poll.h"
 #include "src/core/lib/resource_quota/arena.h"
 #include "src/core/lib/service_config/service_config_call_data.h"
 #include "src/core/lib/slice/slice.h"

src/core/ext/gcp/metadata_query.cc

@@ -22,7 +22,6 @@
 
 #include <string.h>
 
-#include <initializer_list>
 #include <memory>
 #include <utility>
 

src/core/ext/transport/chaotic_good/client_transport.h

@@ -39,6 +39,7 @@
 #include "src/core/lib/promise/pipe.h"
 #include "src/core/lib/promise/seq.h"
 #include "src/core/lib/slice/slice_buffer.h"
+#include "src/core/lib/transport/metadata_batch.h"  // IWYU pragma: keep
 #include "src/core/lib/transport/promise_endpoint.h"
 #include "src/core/lib/transport/transport.h"
 
@@ -112,4 +113,4 @@ class ClientTransport {
 }  // namespace chaotic_good
 }  // namespace grpc_core
 
-#endif  // GRPC_SRC_CORE_EXT_TRANSPORT_CHAOTIC_GOOD_CLIENT_TRANSPORT_H
+#endif  // GRPC_SRC_CORE_EXT_TRANSPORT_CHAOTIC_GOOD_CLIENT_TRANSPORT_H

src/core/ext/transport/chttp2/client/chttp2_connector.cc

@@ -22,7 +22,6 @@
 
 #include <stdint.h>
 
-#include <initializer_list>
 #include <string>
 #include <type_traits>
 #include <utility>
@@ -33,7 +32,6 @@
 
 #include <grpc/grpc.h>
 #include <grpc/grpc_posix.h>
-#include <grpc/grpc_security.h>
 #include <grpc/impl/channel_arg_names.h>
 #include <grpc/slice_buffer.h>
 #include <grpc/status.h>

src/core/ext/transport/chttp2/server/chttp2_server.cc

@@ -24,7 +24,6 @@
 #include <string.h>
 
 #include <algorithm>
-#include <initializer_list>
 #include <map>
 #include <memory>
 #include <string>

src/core/ext/transport/chttp2/transport/chttp2_transport.cc

@@ -24,7 +24,6 @@
 #include <string.h>
 
 #include <algorithm>
-#include <initializer_list>
 #include <limits>
 #include <memory>
 #include <new>

src/core/ext/transport/chttp2/transport/flow_control.cc

@@ -24,7 +24,6 @@
 
 #include <algorithm>
 #include <cmath>
-#include <initializer_list>
 #include <ostream>
 #include <string>
 #include <tuple>

src/core/ext/transport/chttp2/transport/frame_data.cc

@@ -22,8 +22,6 @@
 
 #include <stdlib.h>
 
-#include <initializer_list>
-
 #include "absl/status/status.h"
 #include "absl/strings/str_format.h"
 

src/core/ext/transport/chttp2/transport/frame_goaway.cc

@@ -22,8 +22,6 @@
 
 #include <string.h>
 
-#include <initializer_list>
-
 #include "absl/base/attributes.h"
 #include "absl/status/status.h"
 #include "absl/strings/str_format.h"

src/core/ext/transport/chttp2/transport/frame_ping.cc

@@ -24,8 +24,6 @@
 #include <string.h>
 
 #include <algorithm>
-#include <initializer_list>
-#include <string>
 
 #include "absl/container/flat_hash_map.h"
 #include "absl/status/status.h"

src/core/ext/transport/chttp2/transport/frame_rst_stream.cc

@@ -22,8 +22,6 @@
 
 #include <stddef.h>
 
-#include <initializer_list>
-
 #include "absl/random/distributions.h"
 #include "absl/status/status.h"
 #include "absl/strings/str_cat.h"

src/core/ext/transport/chttp2/transport/frame_settings.cc

@@ -22,13 +22,11 @@
 
 #include <string.h>
 
-#include <initializer_list>
 #include <string>
 
 #include "absl/base/attributes.h"
 #include "absl/status/status.h"
 #include "absl/strings/str_format.h"
-#include "absl/strings/string_view.h"
 
 #include <grpc/slice_buffer.h>
 #include <grpc/support/log.h>

src/core/ext/transport/chttp2/transport/frame_window_update.cc

@@ -22,8 +22,6 @@
 
 #include <stddef.h>
 
-#include <initializer_list>
-
 #include "absl/status/status.h"
 #include "absl/strings/str_cat.h"
 #include "absl/strings/str_format.h"

src/core/ext/transport/chttp2/transport/hpack_parse_result.cc

@@ -18,8 +18,6 @@
 
 #include <stddef.h>
 
-#include <initializer_list>
-
 #include "absl/strings/str_format.h"
 
 #include "src/core/ext/transport/chttp2/transport/hpack_constants.h"

src/core/ext/transport/chttp2/transport/internal.h

@@ -28,7 +28,6 @@
 #include <utility>
 
 #include "absl/container/flat_hash_map.h"
-#include "absl/meta/type_traits.h"
 #include "absl/random/random.h"
 #include "absl/status/status.h"
 #include "absl/strings/string_view.h"

src/core/ext/transport/chttp2/transport/ping_rate_policy.cc

@@ -18,7 +18,6 @@
 
 #include <algorithm>
 #include <ostream>
-#include <utility>
 
 #include "absl/strings/str_cat.h"
 #include "absl/types/optional.h"

src/core/ext/transport/chttp2/transport/writing.cc

@@ -28,11 +28,9 @@
 
 #include "absl/container/flat_hash_map.h"
 #include "absl/status/status.h"
-#include "absl/strings/string_view.h"
 #include "absl/types/optional.h"
 
 #include <grpc/event_engine/event_engine.h>
-#include <grpc/slice.h>
 #include <grpc/slice_buffer.h>
 #include <grpc/support/log.h>
 

src/core/ext/transport/cronet/transport/cronet_transport.cc

@@ -24,7 +24,6 @@
 #include <stdlib.h>
 #include <string.h>
 
-#include <initializer_list>
 #include <new>
 #include <string>
 #include <utility>

src/core/ext/xds/file_watcher_certificate_provider_factory.cc

@@ -21,7 +21,6 @@
 #include "src/core/ext/xds/file_watcher_certificate_provider_factory.h"
 
 #include <algorithm>
-#include <initializer_list>
 #include <map>
 #include <memory>
 #include <vector>

src/core/ext/xds/xds_api.cc

@@ -21,7 +21,6 @@
 #include <stdint.h>
 #include <stdlib.h>
 
-#include <algorithm>
 #include <set>
 #include <string>
 #include <vector>

src/core/ext/xds/xds_bootstrap_grpc.cc

@@ -21,7 +21,6 @@
 #include <stdlib.h>
 
 #include <algorithm>
-#include <initializer_list>
 #include <set>
 #include <utility>
 #include <vector>

src/core/ext/xds/xds_client.cc

@@ -22,6 +22,7 @@
 #include <string.h>
 
 #include <algorithm>
+#include <functional>
 #include <type_traits>
 
 #include "absl/strings/match.h"

src/core/ext/xds/xds_client_stats.h

@@ -23,7 +23,6 @@
 
 #include <atomic>
 #include <cstdint>
-#include <initializer_list>
 #include <map>
 #include <string>
 #include <utility>

src/core/ext/xds/xds_cluster.h

@@ -33,6 +33,8 @@
 #include "envoy/extensions/transport_sockets/tls/v3/tls.upbdefs.h"
 #include "upb/reflection/def.h"
 
+#include <grpc/support/json.h>
+
 #include "src/core/ext/filters/client_channel/lb_policy/outlier_detection/outlier_detection.h"
 #include "src/core/ext/xds/xds_bootstrap.h"
 #include "src/core/ext/xds/xds_bootstrap_grpc.h"

src/core/ext/xds/xds_common_types.cc

@@ -22,7 +22,6 @@
 #include <stdint.h>
 
 #include <algorithm>
-#include <initializer_list>
 #include <map>
 #include <utility>
 

src/core/ext/xds/xds_endpoint.cc

@@ -55,6 +55,8 @@
 #include "src/core/lib/gprpp/validation_errors.h"
 #include "src/core/lib/iomgr/resolved_address.h"
 
+// IWYU pragma: no_include "absl/meta/type_traits.h"
+
 namespace grpc_core {
 
 namespace {

src/core/ext/xds/xds_health_status.cc

@@ -18,6 +18,8 @@
 
 #include "src/core/ext/xds/xds_health_status.h"
 
+#include <string>
+
 #include "envoy/config/core/v3/health_check.upb.h"
 
 namespace grpc_core {

src/core/ext/xds/xds_http_filters.cc

@@ -18,7 +18,6 @@
 
 #include "src/core/ext/xds/xds_http_filters.h"
 
-#include <algorithm>
 #include <map>
 #include <utility>
 #include <vector>

src/core/ext/xds/xds_listener.cc

@@ -20,7 +20,6 @@
 
 #include <stdint.h>
 
-#include <initializer_list>
 #include <set>
 #include <utility>
 
@@ -37,7 +36,6 @@
 #include "envoy/config/listener/v3/listener.upb.h"
 #include "envoy/config/listener/v3/listener.upbdefs.h"
 #include "envoy/config/listener/v3/listener_components.upb.h"
-#include "envoy/config/rbac/v3/rbac.upb.h"
 #include "envoy/config/route/v3/route.upb.h"
 #include "envoy/extensions/filters/network/http_connection_manager/v3/http_connection_manager.upb.h"
 #include "envoy/extensions/filters/network/http_connection_manager/v3/http_connection_manager.upbdefs.h"
@@ -45,7 +43,6 @@
 #include "google/protobuf/any.upb.h"
 #include "google/protobuf/duration.upb.h"
 #include "google/protobuf/wrappers.upb.h"
-#include "upb/base/string_view.h"
 #include "upb/text/encode.h"
 
 #include <grpc/support/log.h>
@@ -60,6 +57,7 @@
 #include "src/core/lib/gprpp/match.h"
 #include "src/core/lib/gprpp/validation_errors.h"
 #include "src/core/lib/iomgr/sockaddr.h"
+#include "src/core/lib/matchers/matchers.h"
 
 namespace grpc_core {
 

src/core/ext/xds/xds_route_config.cc

@@ -21,7 +21,6 @@
 #include <stddef.h>
 #include <stdint.h>
 
-#include <initializer_list>
 #include <limits>
 #include <map>
 #include <memory>

src/core/ext/xds/xds_transport_grpc.cc

@@ -22,6 +22,7 @@
 
 #include <functional>
 #include <memory>
+#include <string_view>
 #include <utility>
 
 #include "absl/strings/str_cat.h"

src/core/lib/address_utils/sockaddr_utils.cc

@@ -27,7 +27,6 @@
 #endif
 #include <string.h>
 
-#include <initializer_list>
 #include <string>
 #include <utility>
 

src/core/lib/avl/avl.h

@@ -20,6 +20,7 @@
 #include <stdlib.h>
 
 #include <algorithm>  // IWYU pragma: keep
+#include <iterator>
 #include <utility>
 
 #include "src/core/lib/gpr/useful.h"

src/core/lib/channel/call_tracer.cc

@@ -20,7 +20,6 @@
 
 #include "src/core/lib/channel/call_tracer.h"
 
-#include <algorithm>
 #include <utility>
 #include <vector>
 

src/core/lib/channel/channel_args.cc

@@ -25,7 +25,6 @@
 #include <string.h>
 
 #include <algorithm>
-#include <initializer_list>
 #include <map>
 #include <memory>
 #include <string>

src/core/lib/channel/channel_args_preconditioning.cc

@@ -16,7 +16,6 @@
 
 #include "src/core/lib/channel/channel_args_preconditioning.h"
 
-#include <algorithm>
 #include <utility>
 
 namespace grpc_core {

src/core/lib/channel/channel_trace.cc

@@ -20,7 +20,7 @@
 
 #include "src/core/lib/channel/channel_trace.h"
 
-#include <algorithm>
+#include <memory>
 #include <utility>
 
 #include "absl/strings/str_cat.h"

src/core/lib/channel/connected_channel.cc

@@ -23,7 +23,6 @@
 #include <inttypes.h>
 
 #include <functional>
-#include <initializer_list>
 #include <memory>
 #include <string>
 #include <type_traits>
@@ -32,7 +31,6 @@
 #include "absl/status/status.h"
 #include "absl/status/statusor.h"
 #include "absl/types/optional.h"
-#include "absl/types/variant.h"
 
 #include <grpc/grpc.h>
 #include <grpc/status.h>

src/core/lib/channel/promise_based_filter.cc

@@ -17,7 +17,6 @@
 #include "src/core/lib/channel/promise_based_filter.h"
 
 #include <algorithm>
-#include <initializer_list>
 #include <memory>
 #include <string>
 #include <utility>

src/core/lib/channel/promise_based_filter.h

@@ -25,7 +25,6 @@
 #include <stdlib.h>
 
 #include <atomic>
-#include <initializer_list>
 #include <memory>
 #include <new>
 #include <string>

src/core/lib/channel/server_call_tracer_filter.cc

@@ -36,7 +36,6 @@
 #include "src/core/lib/promise/context.h"
 #include "src/core/lib/promise/map.h"
 #include "src/core/lib/promise/pipe.h"
-#include "src/core/lib/promise/poll.h"
 #include "src/core/lib/surface/channel_init.h"
 #include "src/core/lib/surface/channel_stack_type.h"
 #include "src/core/lib/transport/transport.h"

src/core/lib/channel/status_util.cc

@@ -22,7 +22,6 @@
 
 #include <string.h>
 
-#include <algorithm>
 #include <vector>
 
 #include "absl/strings/str_cat.h"

src/core/lib/compression/compression_internal.cc

@@ -22,6 +22,8 @@
 
 #include <stdlib.h>
 
+#include <string>
+
 #include "absl/container/inlined_vector.h"
 #include "absl/strings/ascii.h"
 #include "absl/strings/str_format.h"

src/core/lib/config/config_vars.cc

@@ -20,7 +20,6 @@
 
 #include "src/core/lib/config/config_vars.h"
 
-#include <algorithm>
 #include <vector>
 
 #include "absl/flags/flag.h"

src/core/lib/config/config_vars_non_generated.cc

@@ -14,8 +14,6 @@
 
 #include <grpc/support/port_platform.h>
 
-#include <stdint.h>
-
 #include <atomic>
 #include <string>
 

src/core/lib/config/core_configuration.cc

@@ -16,7 +16,6 @@
 
 #include "src/core/lib/config/core_configuration.h"
 
-#include <algorithm>
 #include <atomic>
 #include <utility>
 #include <vector>

src/core/lib/event_engine/ares_resolver.cc

@@ -15,8 +15,6 @@
 
 #include "src/core/lib/event_engine/ares_resolver.h"
 
-#include <stdint.h>
-
 #include <string>
 #include <vector>
 
@@ -47,7 +45,6 @@
 
 #include <algorithm>
 #include <chrono>
-#include <initializer_list>
 #include <memory>
 #include <type_traits>
 #include <utility>

src/core/lib/event_engine/channel_args_endpoint_config.cc

@@ -15,6 +15,8 @@
 
 #include "src/core/lib/event_engine/channel_args_endpoint_config.h"
 
+#include <string>
+
 #include "absl/types/optional.h"
 
 #include <grpc/event_engine/event_engine.h>

src/core/lib/event_engine/event_engine.cc

@@ -13,8 +13,6 @@
 // limitations under the License.
 #include <grpc/support/port_platform.h>
 
-#include <stdint.h>
-
 #include <grpc/event_engine/event_engine.h>
 
 namespace grpc_event_engine {

src/core/lib/event_engine/posix_engine/ev_epoll1_linux.cc

@@ -18,7 +18,6 @@
 #include <stdint.h>
 
 #include <atomic>
-#include <initializer_list>
 #include <memory>
 
 #include "absl/status/status.h"

src/core/lib/event_engine/posix_engine/ev_poll_posix.cc

@@ -19,7 +19,6 @@
 #include <stdint.h>
 
 #include <atomic>
-#include <initializer_list>
 #include <list>
 #include <memory>
 #include <utility>

src/core/lib/event_engine/posix_engine/event_poller_posix_default.cc

@@ -14,6 +14,8 @@
 
 #include <grpc/support/port_platform.h>
 
+#include <string>
+
 #include "absl/strings/str_split.h"
 #include "absl/strings/string_view.h"
 

src/core/lib/event_engine/posix_engine/internal_errqueue.cc

@@ -16,8 +16,6 @@
 
 #include "src/core/lib/event_engine/posix_engine/internal_errqueue.h"
 
-#include <string>
-
 #include <grpc/support/log.h>
 
 #include "src/core/lib/iomgr/port.h"

src/core/lib/event_engine/posix_engine/posix_endpoint.h

@@ -29,7 +29,6 @@
 #include "absl/container/flat_hash_map.h"
 #include "absl/functional/any_invocable.h"
 #include "absl/hash/hash.h"
-#include "absl/meta/type_traits.h"
 #include "absl/status/status.h"
 #include "absl/status/statusor.h"
 

src/core/lib/event_engine/posix_engine/posix_engine.cc

@@ -27,7 +27,6 @@
 
 #include "absl/cleanup/cleanup.h"
 #include "absl/functional/any_invocable.h"
-#include "absl/meta/type_traits.h"
 #include "absl/status/status.h"
 #include "absl/strings/str_cat.h"
 

src/core/lib/event_engine/posix_engine/tcp_socket_utils.cc

@@ -17,13 +17,11 @@
 #include "src/core/lib/event_engine/posix_engine/tcp_socket_utils.h"
 
 #include <errno.h>
-#include <inttypes.h>
 #include <limits.h>
 
 #include "absl/cleanup/cleanup.h"
 #include "absl/status/statusor.h"
 #include "absl/strings/str_cat.h"
-#include "absl/strings/string_view.h"
 #include "absl/types/optional.h"
 
 #include <grpc/event_engine/event_engine.h>

src/core/lib/event_engine/posix_engine/wakeup_fd_eventfd.cc

@@ -17,7 +17,6 @@
 #include <utility>
 
 #include "absl/strings/str_cat.h"
-#include "absl/strings/string_view.h"
 
 #include "src/core/lib/gprpp/crash.h"  // IWYU pragma: keep
 #include "src/core/lib/iomgr/port.h"

src/core/lib/event_engine/posix_engine/wakeup_fd_pipe.cc

@@ -18,7 +18,6 @@
 #include <utility>
 
 #include "absl/strings/str_cat.h"
-#include "absl/strings/string_view.h"
 
 #include "src/core/lib/gprpp/crash.h"  // IWYU pragma: keep
 #include "src/core/lib/iomgr/port.h"

src/core/lib/event_engine/slice_buffer.cc

@@ -18,7 +18,6 @@
 
 #include <grpc/event_engine/slice.h>
 #include <grpc/event_engine/slice_buffer.h>
-#include <grpc/slice.h>
 #include <grpc/slice_buffer.h>
 
 #include "src/core/lib/slice/slice.h"

src/core/lib/event_engine/tcp_socket_utils.cc

@@ -45,7 +45,6 @@
 #include <stdlib.h>
 #include <string.h>
 
-#include <initializer_list>
 #include <utility>
 
 #include "absl/status/status.h"