From 796b572217ff779fbbdaac7b4fca7ee9a1313653 Mon Sep 17 00:00:00 2001 From: Noah Eisen Date: Fri, 19 Jan 2018 00:15:24 -0800 Subject: [PATCH 1/4] Actually check header files --- tools/dockerfile/grpc_clang_tidy/clang_tidy_all_the_things.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/dockerfile/grpc_clang_tidy/clang_tidy_all_the_things.sh b/tools/dockerfile/grpc_clang_tidy/clang_tidy_all_the_things.sh index 1a82dd52b79..e1932ed0bf1 100755 --- a/tools/dockerfile/grpc_clang_tidy/clang_tidy_all_the_things.sh +++ b/tools/dockerfile/grpc_clang_tidy/clang_tidy_all_the_things.sh @@ -20,5 +20,5 @@ CLANG_TIDY=${CLANG_TIDY:-clang-tidy-5.0} cd ${CLANG_TIDY_ROOT} -find src/core src/cpp test/core test/cpp -name '*.h' -or -name '*.cc' -print0 \ +find src/core src/cpp test/core test/cpp -name '*.h' -print0 -or -name '*.cc' -print0 \ | xargs -0 tools/distrib/run_clang_tidy.py "$@" From fe0ac0d6c9506cab52dae4df6bfd466cec345f5e Mon Sep 17 00:00:00 2001 From: Noah Eisen Date: Fri, 19 Jan 2018 00:15:44 -0800 Subject: [PATCH 2/4] Add google clang-tidy check for free --- tools/distrib/run_clang_tidy.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/distrib/run_clang_tidy.py b/tools/distrib/run_clang_tidy.py index bc61d4e79a7..78c2e6559c8 100755 --- a/tools/distrib/run_clang_tidy.py +++ b/tools/distrib/run_clang_tidy.py @@ -26,6 +26,9 @@ import jobset GRPC_CHECKS = [ 'modernize-use-nullptr', + 'google-build-namespaces', + 'google-build-explicit-make-pair', + 'google-readability-namespace-comments', ] extra_args = [ From 93563bc0dc41bc93b8ac988f3baf57a16013d68b Mon Sep 17 00:00:00 2001 From: Noah Eisen Date: Fri, 19 Jan 2018 09:54:49 -0800 Subject: [PATCH 3/4] remote stale import --- test/cpp/qps/driver.cc | 1 - 1 file changed, 1 deletion(-) diff --git a/test/cpp/qps/driver.cc b/test/cpp/qps/driver.cc index 22d039d4b72..4e960907a2d 100644 --- a/test/cpp/qps/driver.cc +++ b/test/cpp/qps/driver.cc @@ -33,7 +33,6 @@ #include "src/core/lib/profiling/timers.h" #include "src/core/lib/support/env.h" -#include "src/proto/grpc/testing/services.grpc.pb.h" #include "test/core/util/port.h" #include "test/core/util/test_config.h" #include "test/cpp/qps/client.h" From a1ad7d8cb7ef2368c38e86ef785d3495c43370fa Mon Sep 17 00:00:00 2001 From: ncteisen Date: Mon, 22 Jan 2018 07:50:55 -0800 Subject: [PATCH 4/4] Remote namespace comment, will fix later --- tools/distrib/run_clang_tidy.py | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/distrib/run_clang_tidy.py b/tools/distrib/run_clang_tidy.py index 78c2e6559c8..337e6b43c86 100755 --- a/tools/distrib/run_clang_tidy.py +++ b/tools/distrib/run_clang_tidy.py @@ -28,7 +28,6 @@ GRPC_CHECKS = [ 'modernize-use-nullptr', 'google-build-namespaces', 'google-build-explicit-make-pair', - 'google-readability-namespace-comments', ] extra_args = [