Fix warning

pull/35631/head
Yash Tibrewal 1 year ago
parent e0b80d01a2
commit ba1a9cecc2
  1. 2
      test/cpp/ext/otel/otel_test_library.cc
  2. 9
      test/cpp/ext/otel/otel_test_library.h

@ -89,7 +89,7 @@ void OpenTelemetryPluginEnd2EndTest::Init(Options config) {
auto meter_provider = auto meter_provider =
std::make_shared<opentelemetry::sdk::metrics::MeterProvider>( std::make_shared<opentelemetry::sdk::metrics::MeterProvider>(
std::make_unique<opentelemetry::sdk::metrics::ViewRegistry>(), std::make_unique<opentelemetry::sdk::metrics::ViewRegistry>(),
std::move(config.resource)); *config.resource);
reader_.reset(new grpc::testing::MockMetricReader); reader_.reset(new grpc::testing::MockMetricReader);
meter_provider->AddMetricReader(reader_); meter_provider->AddMetricReader(reader_);
grpc_core::CoreConfiguration::Reset(); grpc_core::CoreConfiguration::Reset();

@ -64,7 +64,7 @@ class OpenTelemetryPluginEnd2EndTest : public ::testing::Test {
} }
Options& set_resource(const opentelemetry::sdk::resource::Resource& res) { Options& set_resource(const opentelemetry::sdk::resource::Resource& res) {
resource = res; resource = std::make_unique<opentelemetry::sdk::resource::Resource>(res);
return *this; return *this;
} }
@ -120,8 +120,11 @@ class OpenTelemetryPluginEnd2EndTest : public ::testing::Test {
} }
absl::flat_hash_set<absl::string_view> metric_names; absl::flat_hash_set<absl::string_view> metric_names;
opentelemetry::sdk::resource::Resource resource = // TODO(yashykt): opentelemetry::sdk::resource::Resource doesn't have a copy
opentelemetry::sdk::resource::Resource::Create({}); // assignment operator so wrapping it in a unique_ptr till it is fixed.
std::unique_ptr<opentelemetry::sdk::resource::Resource> resource =
std::make_unique<opentelemetry::sdk::resource::Resource>(
opentelemetry::sdk::resource::Resource::Create({}));
std::unique_ptr<grpc::internal::LabelsInjector> labels_injector; std::unique_ptr<grpc::internal::LabelsInjector> labels_injector;
bool use_meter_provider = true; bool use_meter_provider = true;
std::map<std::string, std::string> labels_to_inject; std::map<std::string, std::string> labels_to_inject;

Loading…
Cancel
Save