[Gpr_To_Absl_Logging] Fix code review comments

8 months ago · b8d0ad494a
parent 131977d4f6
commit b8d0ad494a
2 changed files with 3 additions and 1 deletions
--- a/src/php/ext/grpc/php_grpc.c
+++ b/src/php/ext/grpc/php_grpc.c
@ -247,6 +247,9 @@ void apply_ini_settings(TSRMLS_D) {
  }
 }

+
+/* {{{ PHP_MINIT_FUNCTION
+ */
 PHP_MINIT_FUNCTION(grpc) {
  REGISTER_INI_ENTRIES();

--- a/tools/run_tests/sanity/banned_functions.py
+++ b/tools/run_tests/sanity/banned_functions.py
@ -34,7 +34,6 @@ BANNED_EXCEPT = {
        "./src/core/util/log.cc",
        "./src/core/util/posix/log.cc",
        "./src/core/util/windows/log.cc",
-        "./src/php/ext/grpc/php_grpc.c",
        "./src/ruby/ext/grpc/rb_grpc_imports.generated.c",
        "./src/ruby/ext/grpc/rb_grpc_imports.generated.h",
        "./test/core/end2end/tests/no_logging.cc",