address review comments

pull/19792/head
Jan Tattermusch 6 years ago
parent cb6d3a0623
commit b876b35457
  1. 4
      src/csharp/Grpc.Core.Api/SerializationContext.cs
  2. 3
      src/csharp/Grpc.Core.Tests/Internal/DefaultSerializationContextTest.cs

@ -28,7 +28,7 @@ namespace Grpc.Core
{ {
/// <summary> /// <summary>
/// Use the byte array as serialized form of current message and mark serialization process as complete. /// Use the byte array as serialized form of current message and mark serialization process as complete.
/// <c>Complete()</c> can only be called once. By calling this method the caller gives up the ownership of the /// <c>Complete(byte[])</c> can only be called once. By calling this method the caller gives up the ownership of the
/// payload which must not be accessed afterwards. /// payload which must not be accessed afterwards.
/// </summary> /// </summary>
/// <param name="payload">the serialized form of current message</param> /// <param name="payload">the serialized form of current message</param>
@ -47,7 +47,7 @@ namespace Grpc.Core
} }
/// <summary> /// <summary>
/// Complete the payload written to the buffer writer. Complete() can only be called once. /// Complete the payload written to the buffer writer. <c>Complete()</c> can only be called once.
/// </summary> /// </summary>
public virtual void Complete() public virtual void Complete()
{ {

@ -189,9 +189,6 @@ namespace Grpc.Core.Internal.Tests
} }
} }
// other ideas:
// AdjustTailSpace(0) if previous tail size is 0... (better for SliceBufferSafeHandle)
private DefaultSerializationContext.UsageScope NewDefaultSerializationContextScope() private DefaultSerializationContext.UsageScope NewDefaultSerializationContextScope()
{ {
return new DefaultSerializationContext.UsageScope(new DefaultSerializationContext()); return new DefaultSerializationContext.UsageScope(new DefaultSerializationContext());

Loading…
Cancel
Save