Adopte reviewer's suggestion

pull/17793/head
Lidi Zheng 6 years ago
parent 95d4120f46
commit b60c5cdc82
  1. 2
      src/python/grpcio_tests/tests/qps/README.md
  2. 4
      src/python/grpcio_tests/tests/qps/basic_benchmark_test.sh

@ -21,7 +21,7 @@ Here I picked the top 2 most representative scenarios of them, and reduce their
## Why keep the scenario file if it can be generated?
Well... The `tools/run_tests/performance/scenario_config.py` is 1274 lines long. The intention of building these benchmark tools is reducing the complexity of existing infrastructure code. Depending on something that is
Well... The `tools/run_tests/performance/scenario_config.py` is 1274 lines long. The intention of building these benchmark tools is reducing the complexity of existing infrastructure code. So, instead of calling layers of abstraction to generate the scenario file, keeping a valid static copy is more preferable.
## How to run it?

@ -22,10 +22,10 @@ SCENARIOS_FILE=src/python/grpcio_tests/tests/qps/scenarios.json
function join { local IFS="$1"; shift; echo "$*"; }
if [[ -e "${SCENARIOS_FILE}" ]]; then
echo "Running against scenarios.json:"
echo "Running against ${SCENARIOS_FILE}:"
cat "${SCENARIOS_FILE}"
else
echo "Failed to find scenarios.json!"
echo "Failed to find ${SCENARIOS_FILE}!"
exit 1
fi

Loading…
Cancel
Save