Reviewer comments

pull/23177/head
Yash Tibrewal 5 years ago
parent 5041fcc1ca
commit b57a11a82b
  1. 11
      src/core/ext/filters/client_channel/service_config_channel_arg_filter.cc

@ -37,8 +37,8 @@ class ServiceConfigChannelArgChannelData {
args->channel_args, GRPC_ARG_SERVICE_CONFIG); args->channel_args, GRPC_ARG_SERVICE_CONFIG);
if (service_config_str != nullptr) { if (service_config_str != nullptr) {
grpc_error* service_config_error = GRPC_ERROR_NONE; grpc_error* service_config_error = GRPC_ERROR_NONE;
auto service_config = grpc_core::ServiceConfig::Create( auto service_config =
service_config_str, &service_config_error); ServiceConfig::Create(service_config_str, &service_config_error);
if (service_config_error == GRPC_ERROR_NONE) { if (service_config_error == GRPC_ERROR_NONE) {
service_config_ = std::move(service_config); service_config_ = std::move(service_config);
} else { } else {
@ -48,12 +48,12 @@ class ServiceConfigChannelArgChannelData {
} }
} }
grpc_core::RefCountedPtr<grpc_core::ServiceConfig> service_config() const { RefCountedPtr<ServiceConfig> service_config() const {
return service_config_; return service_config_;
} }
private: private:
grpc_core::RefCountedPtr<grpc_core::ServiceConfig> service_config_; RefCountedPtr<ServiceConfig> service_config_;
}; };
class ServiceConfigChannelArgCallData { class ServiceConfigChannelArgCallData {
@ -62,8 +62,7 @@ class ServiceConfigChannelArgCallData {
const grpc_call_element_args* args) { const grpc_call_element_args* args) {
ServiceConfigChannelArgChannelData* chand = ServiceConfigChannelArgChannelData* chand =
static_cast<ServiceConfigChannelArgChannelData*>(elem->channel_data); static_cast<ServiceConfigChannelArgChannelData*>(elem->channel_data);
grpc_core::RefCountedPtr<grpc_core::ServiceConfig> service_config = RefCountedPtr<ServiceConfig> service_config = chand->service_config();
chand->service_config();
if (service_config != nullptr) { if (service_config != nullptr) {
GPR_DEBUG_ASSERT(args->context != nullptr); GPR_DEBUG_ASSERT(args->context != nullptr);
const auto* method_params_vector = const auto* method_params_vector =

Loading…
Cancel
Save