Create GRPC_USE_TRACERS to support OSS/internal difference

pull/15516/head
ncteisen 7 years ago
parent 18ce0cf26e
commit b500281f91
  1. 20
      src/core/lib/debug/trace.h

@ -57,14 +57,14 @@ class TraceFlag {
const char* name() const { return name_; } const char* name() const { return name_; }
// This following define may be commented out to ensure that the compiler // Use the symbol GRPC_USE_TRACERS to determine if tracers will be enabled in
// deletes any "if (tracer.enabled()) {...}" codeblocks. This is useful to // opt builds (tracers are always on in dbg builds). The default in OSS is for
// test the performance impact tracers have on the system. // tracers to be on since we support binary distributions of gRPC for the
// // wrapped language (wr don't want to force recompilation to get tracing).
// #define COMPILE_OUT_ALL_TRACERS_IN_OPT_BUILD // Internally, however, for performance reasons, we compile them out by
#ifdef COMPILE_OUT_ALL_TRACERS_IN_OPT_BUILD // default, since internal build systems make recompiling trivial.
bool enabled() { return false; } #define GRPC_USE_TRACERS // tracers on by default in OSS
#else #if defined(GRPC_USE_TRACERS) || !defined(NDEBUG)
bool enabled() { bool enabled() {
#ifdef GRPC_THREADSAFE_TRACER #ifdef GRPC_THREADSAFE_TRACER
return gpr_atm_no_barrier_load(&value_) != 0; return gpr_atm_no_barrier_load(&value_) != 0;
@ -72,7 +72,9 @@ class TraceFlag {
return value_; return value_;
#endif // GRPC_THREADSAFE_TRACER #endif // GRPC_THREADSAFE_TRACER
} }
#endif // COMPILE_OUT_ALL_TRACERS_IN_OPT_BUILD #else
bool enabled() { return false; }
#endif /* defined(GRPC_USE_TRACERS) || !defined(NDEBUG) */
private: private:
friend void grpc_core::testing::grpc_tracer_enable_flag(TraceFlag* flag); friend void grpc_core::testing::grpc_tracer_enable_flag(TraceFlag* flag);

Loading…
Cancel
Save