Stop double caching

5 years ago · b45acf15d1
parent ae9ce800b1
commit b45acf15d1
1 changed files with 2 additions and 6 deletions
--- a/src/core/lib/security/credentials/google_default/google_default_credentials.cc
+++ b/src/core/lib/security/credentials/google_default/google_default_credentials.cc
@ -366,12 +366,8 @@ void grpc_flush_cached_google_default_credentials(void) {
 }

 bool is_on_gce(void) {
-  bool on_gce;
-  if (GPR_UNLIKELY(
-          !(on_gce = g_is_on_gce.Load(grpc_core::MemoryOrder::ACQUIRE)))) {
-    on_gce = g_gce_tenancy_checker();
-    g_is_on_gce.Store(on_gce, grpc_core::MemoryOrder::RELEASE);
-  }
+  bool on_gce = g_gce_tenancy_checker();
+  g_is_on_gce.Store(on_gce, grpc_core::MemoryOrder::RELEASE);
  return on_gce;
 }