From b44de399c1539d793504e03573d64228ee0f4733 Mon Sep 17 00:00:00 2001 From: Yash Tibrewal Date: Tue, 1 Oct 2024 15:21:44 -0700 Subject: [PATCH] [Chttp2Server] Remove unnecessary ExecCtx Flush (#37824) This seems to be a vestige from around 8 years ago. The code has changed a lot since then, and this makes no sense anymore. (Making this change separately to be safe.) Closes #37824 COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/37824 from yashykt:RemoveUnnecessaryExecCtxStuff 97a7625033df07ce5fcd24b915d76942ba24e912 PiperOrigin-RevId: 681184980 --- src/core/ext/transport/chttp2/server/chttp2_server.cc | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/core/ext/transport/chttp2/server/chttp2_server.cc b/src/core/ext/transport/chttp2/server/chttp2_server.cc index 212493f95f7..3ebc5758950 100644 --- a/src/core/ext/transport/chttp2/server/chttp2_server.cc +++ b/src/core/ext/transport/chttp2/server/chttp2_server.cc @@ -783,15 +783,11 @@ Chttp2ServerListener::Chttp2ServerListener( } Chttp2ServerListener::~Chttp2ServerListener() { - // Flush queued work before destroying handshaker factory, since that - // may do a synchronous unref. - ExecCtx::Get()->Flush(); if (passive_listener_ != nullptr) { passive_listener_->ListenerDestroyed(); } if (on_destroy_done_ != nullptr) { ExecCtx::Run(DEBUG_LOCATION, on_destroy_done_, absl::OkStatus()); - ExecCtx::Get()->Flush(); } }