Merge pull request #22179 from jtattermusch/start_marking_as_flaky

Allow marking bazel test as flaky, under certain rules
pull/22187/head
Jan Tattermusch 5 years ago committed by GitHub
commit b430c46e1b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 4
      bazel/grpc_build_system.bzl
  2. 1
      test/core/transport/chttp2/BUILD
  3. 1
      test/cpp/end2end/BUILD
  4. 2
      test/cpp/microbenchmarks/BUILD

@ -168,7 +168,7 @@ def ios_cc_test(
deps = ios_test_deps,
)
def grpc_cc_test(name, srcs = [], deps = [], external_deps = [], args = [], data = [], uses_polling = True, language = "C++", size = "medium", timeout = None, tags = [], exec_compatible_with = [], exec_properties = {}, shard_count = None):
def grpc_cc_test(name, srcs = [], deps = [], external_deps = [], args = [], data = [], uses_polling = True, language = "C++", size = "medium", timeout = None, tags = [], exec_compatible_with = [], exec_properties = {}, shard_count = None, flaky = None):
copts = if_mac(["-DGRPC_CFSTREAM"])
if language.upper() == "C":
copts = copts + if_not_windows(["-std=c99"])
@ -187,6 +187,7 @@ def grpc_cc_test(name, srcs = [], deps = [], external_deps = [], args = [], data
"exec_compatible_with": exec_compatible_with,
"exec_properties": exec_properties,
"shard_count": shard_count,
"flaky": flaky,
}
if uses_polling:
# the vanilla version of the test should run on platforms that only
@ -218,6 +219,7 @@ def grpc_cc_test(name, srcs = [], deps = [], external_deps = [], args = [], data
exec_compatible_with = exec_compatible_with,
exec_properties = exec_properties,
shard_count = shard_count,
flaky = flaky,
)
else:
# the test behavior doesn't depend on polling, just generate the test

@ -134,6 +134,7 @@ grpc_cc_test(
external_deps = [
"gtest",
],
flaky = True, # TODO(b/148399919)
language = "C++",
deps = [
"//:gpr",

@ -502,6 +502,7 @@ grpc_cc_test(
external_deps = [
"gtest",
],
flaky = True, # TODO(b/144705388)
shard_count = 10,
tags = [
"no_test_ios",

@ -205,6 +205,7 @@ grpc_cc_test(
srcs = [
"bm_fullstack_streaming_pump.cc",
],
flaky = True, # TODO(b/150422385)
tags = [
"no_mac", # to emulate "excluded_poll_engines: poll"
"no_windows",
@ -248,6 +249,7 @@ grpc_cc_test(
grpc_cc_test(
name = "bm_metadata",
srcs = ["bm_metadata.cc"],
flaky = True, # TODO(b/149998903)
tags = [
"no_mac",
"no_windows",

Loading…
Cancel
Save