Fix fault injection filter to still run the original trailing metadata closure when no error (#25926)

4 years ago · b2f91eeb36
parent 72632aebd7
commit b2f91eeb36
1 changed files with 4 additions and 2 deletions
--- a/src/core/ext/filters/fault_injection/fault_injection_filter.cc
+++ b/src/core/ext/filters/fault_injection/fault_injection_filter.cc
@ -468,9 +468,11 @@ void CallData::HijackedRecvTrailingMetadataReady(void* arg, grpc_error* error) {
  if (calld->abort_error_ != GRPC_ERROR_NONE) {
    error = grpc_error_add_child(GRPC_ERROR_REF(error),
                                 GRPC_ERROR_REF(calld->abort_error_));
-    Closure::Run(DEBUG_LOCATION, calld->original_recv_trailing_metadata_ready_,
-                 error);
+  } else {
+    error = GRPC_ERROR_REF(error);
  }
+  Closure::Run(DEBUG_LOCATION, calld->original_recv_trailing_metadata_ready_,
+               error);
 }

 }  // namespace