Merge pull request #20555 from jtattermusch/workaround_slice_test_compiler_bug

work around slice_test compiler bug (for windows bazel opt build)
5 years ago · b0c87fd26b
parent f841c3ea30 18fb48de59
commit b0c87fd26b
1 changed files with 6 additions and 0 deletions
--- a/test/core/slice/slice_test.cc
+++ b/test/core/slice/slice_test.cc
@ -243,7 +243,13 @@ static void test_slice_interning(void) {
  grpc_init();
  grpc_slice src1 = grpc_slice_from_copied_string("hello123456789123456789");
  grpc_slice src2 = grpc_slice_from_copied_string("hello123456789123456789");
+
+  // Explicitly checking that the slices are at different addresses prevents
+  // failure with windows opt 64bit build.
+  // See https://github.com/grpc/grpc/issues/20519
+  GPR_ASSERT(&src1 != &src2);
  GPR_ASSERT(GRPC_SLICE_START_PTR(src1) != GRPC_SLICE_START_PTR(src2));
+
  grpc_slice interned1 = grpc_slice_intern(src1);
  grpc_slice interned2 = grpc_slice_intern(src2);
  GPR_ASSERT(GRPC_SLICE_START_PTR(interned1) ==