Merge pull request #20647 from vjpai/remove_warn_14

Remove unused parameter warnings (14 of 20)
reviewable/pr18856/r15^2
Vijay Pai 5 years ago committed by GitHub
commit ad1a3723d6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 2
      test/core/tsi/alts/zero_copy_frame_protector/alts_grpc_record_protocol_test.cc
  2. 2
      test/core/tsi/alts/zero_copy_frame_protector/alts_zero_copy_grpc_protector_test.cc
  3. 2
      test/core/tsi/fake_transport_security_test.cc
  4. 2
      test/core/util/one_corpus_entry_fuzzer.cc
  5. 2
      test/core/util/reconnect_server.cc
  6. 6
      test/core/util/test_tcp_server.cc
  7. 2
      test/cpp/client/client_channel_stress_test.cc
  8. 2
      test/cpp/common/channel_arguments_test.cc
  9. 4
      test/cpp/common/channel_filter_test.cc
  10. 4
      test/cpp/common/timer_test.cc

@ -444,7 +444,7 @@ static void alts_grpc_record_protocol_tests(
alts_grpc_record_protocol_test_fixture_destroy(fixture_5); alts_grpc_record_protocol_test_fixture_destroy(fixture_5);
} }
int main(int argc, char** argv) { int main(int /*argc*/, char** /*argv*/) {
alts_grpc_record_protocol_tests( alts_grpc_record_protocol_tests(
&test_fixture_integrity_only_no_rekey_no_extra_copy_create); &test_fixture_integrity_only_no_rekey_no_extra_copy_create);
alts_grpc_record_protocol_tests(&test_fixture_integrity_only_rekey_create); alts_grpc_record_protocol_tests(&test_fixture_integrity_only_rekey_create);

@ -295,7 +295,7 @@ static void alts_zero_copy_protector_seal_unseal_large_buffer_tests(
alts_zero_copy_grpc_protector_test_fixture_destroy(fixture); alts_zero_copy_grpc_protector_test_fixture_destroy(fixture);
} }
int main(int argc, char** argv) { int main(int /*argc*/, char** /*argv*/) {
alts_zero_copy_protector_seal_unseal_small_buffer_tests( alts_zero_copy_protector_seal_unseal_small_buffer_tests(
/*enable_extra_copy=*/false); /*enable_extra_copy=*/false);
alts_zero_copy_protector_seal_unseal_small_buffer_tests( alts_zero_copy_protector_seal_unseal_small_buffer_tests(

@ -58,7 +58,7 @@ static void fake_test_check_handshaker_peers(tsi_test_fixture* fixture) {
validate_handshaker_peers(fixture->server_result); validate_handshaker_peers(fixture->server_result);
} }
static void fake_test_destruct(tsi_test_fixture* fixture) {} static void fake_test_destruct(tsi_test_fixture* /*fixture*/) {}
static const struct tsi_test_fixture_vtable vtable = { static const struct tsi_test_fixture_vtable vtable = {
fake_test_setup_handshakers, fake_test_check_handshaker_peers, fake_test_setup_handshakers, fake_test_check_handshaker_peers,

@ -29,7 +29,7 @@ extern "C" int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size);
extern bool squelch; extern bool squelch;
extern bool leak_check; extern bool leak_check;
int main(int argc, char** argv) { int main(int /*argc*/, char** argv) {
grpc_slice buffer; grpc_slice buffer;
squelch = false; squelch = false;
leak_check = false; leak_check = false;

@ -56,7 +56,7 @@ static void pretty_print_backoffs(reconnect_server* server) {
} }
static void on_connect(void* arg, grpc_endpoint* tcp, static void on_connect(void* arg, grpc_endpoint* tcp,
grpc_pollset* accepting_pollset, grpc_pollset* /*accepting_pollset*/,
grpc_tcp_server_acceptor* acceptor) { grpc_tcp_server_acceptor* acceptor) {
gpr_free(acceptor); gpr_free(acceptor);
char* peer; char* peer;

@ -34,7 +34,7 @@
#include "test/core/util/port.h" #include "test/core/util/port.h"
#include "test/core/util/test_config.h" #include "test/core/util/test_config.h"
static void on_server_destroyed(void* data, grpc_error* error) { static void on_server_destroyed(void* data, grpc_error* /*error*/) {
test_tcp_server* server = static_cast<test_tcp_server*>(data); test_tcp_server* server = static_cast<test_tcp_server*>(data);
server->shutdown = 1; server->shutdown = 1;
} }
@ -87,8 +87,8 @@ void test_tcp_server_poll(test_tcp_server* server, int milliseconds) {
gpr_mu_unlock(server->mu); gpr_mu_unlock(server->mu);
} }
static void do_nothing(void* arg, grpc_error* error) {} static void do_nothing(void* /*arg*/, grpc_error* /*error*/) {}
static void finish_pollset(void* arg, grpc_error* error) { static void finish_pollset(void* arg, grpc_error* /*error*/) {
grpc_pollset_destroy(static_cast<grpc_pollset*>(arg)); grpc_pollset_destroy(static_cast<grpc_pollset*>(arg));
} }

@ -73,7 +73,7 @@ class BalancerServiceImpl : public LoadBalancer::Service {
explicit BalancerServiceImpl(const std::vector<int>& all_backend_ports) explicit BalancerServiceImpl(const std::vector<int>& all_backend_ports)
: all_backend_ports_(all_backend_ports) {} : all_backend_ports_(all_backend_ports) {}
Status BalanceLoad(ServerContext* context, Stream* stream) override { Status BalanceLoad(ServerContext* /*context*/, Stream* stream) override {
gpr_log(GPR_INFO, "LB[%p]: Start BalanceLoad.", this); gpr_log(GPR_INFO, "LB[%p]: Start BalanceLoad.", this);
LoadBalanceRequest request; LoadBalanceRequest request;
stream->Read(&request); stream->Read(&request);

@ -36,7 +36,7 @@ class TestSocketMutator : public grpc_socket_mutator {
public: public:
TestSocketMutator(); TestSocketMutator();
bool MutateFd(int fd) { bool MutateFd(int /*fd*/) {
// Do nothing on the fd // Do nothing on the fd
return true; return true;
} }

@ -28,7 +28,7 @@ class MyChannelData : public ChannelData {
public: public:
MyChannelData() {} MyChannelData() {}
grpc_error* Init(grpc_channel_element* elem, grpc_error* Init(grpc_channel_element* /*elem*/,
grpc_channel_element_args* args) override { grpc_channel_element_args* args) override {
(void)args->channel_args; // Make sure field is available. (void)args->channel_args; // Make sure field is available.
return GRPC_ERROR_NONE; return GRPC_ERROR_NONE;
@ -39,7 +39,7 @@ class MyCallData : public CallData {
public: public:
MyCallData() {} MyCallData() {}
grpc_error* Init(grpc_call_element* elem, grpc_error* Init(grpc_call_element* /*elem*/,
const grpc_call_element_args* args) override { const grpc_call_element_args* args) override {
(void)args->path; // Make sure field is available. (void)args->path; // Make sure field is available.
return GRPC_ERROR_NONE; return GRPC_ERROR_NONE;

@ -176,7 +176,7 @@ TEST_F(TimerTest, DISABLED_CancelRace) {
grpc_timer* arg = (i != 0) ? &timers[i - 1] : nullptr; grpc_timer* arg = (i != 0) ? &timers[i - 1] : nullptr;
grpc_timer_init(&timers[i], grpc_core::ExecCtx::Get()->Now() + 100, grpc_timer_init(&timers[i], grpc_core::ExecCtx::Get()->Now() + 100,
GRPC_CLOSURE_CREATE( GRPC_CLOSURE_CREATE(
[](void* arg, grpc_error* error) { [](void* arg, grpc_error* /*error*/) {
grpc_timer* timer = static_cast<grpc_timer*>(arg); grpc_timer* timer = static_cast<grpc_timer*>(arg);
if (timer) { if (timer) {
grpc_timer_cancel(timer); grpc_timer_cancel(timer);
@ -206,7 +206,7 @@ TEST_F(TimerTest, DISABLED_CancelNextTimer) {
} }
grpc_timer_init(&timers[i], grpc_core::ExecCtx::Get()->Now() + 100, grpc_timer_init(&timers[i], grpc_core::ExecCtx::Get()->Now() + 100,
GRPC_CLOSURE_CREATE( GRPC_CLOSURE_CREATE(
[](void* arg, grpc_error* error) { [](void* arg, grpc_error* /*error*/) {
grpc_timer* timer = static_cast<grpc_timer*>(arg); grpc_timer* timer = static_cast<grpc_timer*>(arg);
if (timer) { if (timer) {
grpc_timer_cancel(timer); grpc_timer_cancel(timer);

Loading…
Cancel
Save