Use a gerund for a function name

pull/23203/head
Richard Belleville 5 years ago
parent 236a089ca6
commit ac08c9ba28
  1. 2
      src/core/lib/security/credentials/google_default/compute_engine_channel_credentials.cc
  2. 6
      src/core/lib/security/credentials/google_default/google_default_credentials.cc
  3. 2
      src/core/lib/security/credentials/google_default/google_default_credentials.h

@ -50,7 +50,7 @@ grpc_channel_credentials* grpc_compute_engine_channel_credentials_create(
GRPC_API_TRACE("grpc_gce_channel_credentials_create(%p)", 1, (reserved));
GPR_ASSERT(grpc_core::internal::is_on_gce());
GPR_ASSERT(grpc_core::internal::running_on_gce());
grpc_channel_credentials* ssl_creds =
grpc_ssl_credentials_create(nullptr, nullptr, nullptr, nullptr);

@ -88,7 +88,7 @@ grpc_google_default_channel_credentials::create_security_connector(
bool use_alts =
is_grpclb_load_balancer || is_backend_from_grpclb_load_balancer;
/* Return failure if ALTS is selected but not running on GCE. */
if (use_alts && !grpc_core::internal::is_on_gce()) {
if (use_alts && !grpc_core::internal::running_on_gce()) {
gpr_log(GPR_ERROR, "ALTS is selected, but not running on GCE.");
return nullptr;
}
@ -300,7 +300,7 @@ grpc_channel_credentials* grpc_google_default_credentials_create() {
/* Try a platform-provided hint for GCE. */
if (!g_metadata_server_available) {
g_metadata_server_available = grpc_core::internal::is_on_gce();
g_metadata_server_available = grpc_core::internal::running_on_gce();
}
/* TODO: Add a platform-provided hint for GAE. */
@ -363,7 +363,7 @@ void grpc_flush_cached_google_default_credentials(void) {
gpr_mu_unlock(&g_state_mu);
}
bool is_on_gce(void) { return g_gce_tenancy_checker(); }
bool running_on_gce(void) { return g_gce_tenancy_checker(); }
} // namespace internal
} // namespace grpc_core

@ -77,7 +77,7 @@ typedef bool (*grpc_gce_tenancy_checker)(void);
void set_gce_tenancy_checker_for_testing(grpc_gce_tenancy_checker checker);
bool is_on_gce(void);
bool running_on_gce(void);
// TEST-ONLY. Reset the internal global state.
void grpc_flush_cached_google_default_credentials(void);

Loading…
Cancel
Save