From ab2b28d576fcc2472911bb181216a6b932f55bde Mon Sep 17 00:00:00 2001 From: Tanvi Jagtap <139093547+tanvi-jagtap@users.noreply.github.com> Date: Sat, 29 Jun 2024 00:26:51 -0700 Subject: [PATCH] [Gpr_To_Absl_Logging] Reducing log spam (#37106) [Gpr_To_Absl_Logging] Reducing log spam because of complaints from user Closes #37106 COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/37106 from tanvi-jagtap:reduce_verbosity 044c5aade1a61e2c7ec45f17ed1e70e345f9a004 PiperOrigin-RevId: 647905894 --- src/core/client_channel/subchannel.cc | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/src/core/client_channel/subchannel.cc b/src/core/client_channel/subchannel.cc index 9a76c22ae30..4021216ce9c 100644 --- a/src/core/client_channel/subchannel.cc +++ b/src/core/client_channel/subchannel.cc @@ -759,8 +759,10 @@ void Subchannel::OnRetryTimer() { void Subchannel::OnRetryTimerLocked() { if (shutdown_) return; - LOG(INFO) << "subchannel " << this << " " << key_.ToString() - << ": backoff delay elapsed, reporting IDLE"; + if (GRPC_TRACE_FLAG_ENABLED(subchannel)) { + LOG(INFO) << "subchannel " << this << " " << key_.ToString() + << ": backoff delay elapsed, reporting IDLE"; + } SetConnectivityStateLocked(GRPC_CHANNEL_IDLE, absl::OkStatus()); } @@ -804,10 +806,12 @@ void Subchannel::OnConnectingFinishedLocked(grpc_error_handle error) { if (connecting_result_.transport == nullptr || !PublishTransportLocked()) { const Duration time_until_next_attempt = next_attempt_time_ - Timestamp::Now(); - LOG(INFO) << "subchannel " << this << " " << key_.ToString() - << ": connect failed (" << StatusToString(error) - << "), backing off for " << time_until_next_attempt.millis() - << " ms"; + if (GRPC_TRACE_FLAG_ENABLED(subchannel)) { + LOG(INFO) << "subchannel " << this << " " << key_.ToString() + << ": connect failed (" << StatusToString(error) + << "), backing off for " << time_until_next_attempt.millis() + << " ms"; + } SetConnectivityStateLocked(GRPC_CHANNEL_TRANSIENT_FAILURE, grpc_error_to_absl_status(error)); retry_timer_handle_ = event_engine_->RunAfter(