Merge pull request #8467 from ncteisen/node_unimplemented_method

Implement Node Unimplemented Method Interop Test
pull/8484/head
Noah Eisen 8 years ago committed by GitHub
commit ab0c5de658
  1. 16
      src/node/interop/interop_client.js
  2. 4
      src/node/test/interop_sanity_test.js

@ -375,7 +375,8 @@ function statusCodeAndMessage(client, done) {
duplex.end();
}
function unimplementedMethod(client, done) {
// NOTE: the client param to this function is from UnimplementedService
function unimplementedService(client, done) {
client.unimplementedCall({}, function(err, resp) {
assert(err);
assert.strictEqual(err.code, grpc.status.UNIMPLEMENTED);
@ -384,6 +385,15 @@ function unimplementedMethod(client, done) {
});
}
// NOTE: the client param to this function is from TestService
function unimplementedMethod(client, done) {
client.unimplementedCall({}, function(err, resp) {
assert(err);
assert.strictEqual(err.code, grpc.status.UNIMPLEMENTED);
done();
});
}
/**
* Run one of the authentication tests.
* @param {string} expected_user The expected username in the response
@ -527,8 +537,10 @@ var test_cases = {
Client: testProto.TestService},
status_code_and_message: {run: statusCodeAndMessage,
Client: testProto.TestService},
unimplemented_method: {run: unimplementedMethod,
unimplemented_service: {run: unimplementedService,
Client: testProto.UnimplementedService},
unimplemented_method: {run: unimplementedMethod,
Client: testProto.TestService},
compute_engine_creds: {run: computeEngineCreds,
Client: testProto.TestService,
getCreds: getApplicationCreds},

@ -98,6 +98,10 @@ describe('Interop tests', function() {
interop_client.runTest(port, name_override, 'status_code_and_message',
true, true, done);
});
it('should pass unimplemented_service', function(done) {
interop_client.runTest(port, name_override, 'unimplemented_service',
true, true, done);
});
it('should pass unimplemented_method', function(done) {
interop_client.runTest(port, name_override, 'unimplemented_method',
true, true, done);

Loading…
Cancel
Save