From a923eff71fc79563d40a55ced17b5130e7805cca Mon Sep 17 00:00:00 2001 From: Jan Tattermusch Date: Tue, 2 Nov 2021 13:52:02 +0100 Subject: [PATCH] Rename experimental benchmark job from "..._v2" to "..._gke_experimental" (#27869) * make it obvious which gke benchmark script is experimental * add cfg file for new kokoro jobs with a more fitting name * update performance readme after renaming _v2 benchmark job * fix typo --- .../grpc_e2e_performance_gke_experiment.cfg | 25 +++++++++++++++++++ ...=> grpc_e2e_performance_gke_experiment.sh} | 0 .../linux/grpc_e2e_performance_v2.cfg | 2 +- tools/run_tests/performance/README.md | 6 ++--- 4 files changed, 29 insertions(+), 4 deletions(-) create mode 100644 tools/internal_ci/linux/grpc_e2e_performance_gke_experiment.cfg rename tools/internal_ci/linux/{grpc_e2e_performance_v2.sh => grpc_e2e_performance_gke_experiment.sh} (100%) diff --git a/tools/internal_ci/linux/grpc_e2e_performance_gke_experiment.cfg b/tools/internal_ci/linux/grpc_e2e_performance_gke_experiment.cfg new file mode 100644 index 00000000000..4b49380a563 --- /dev/null +++ b/tools/internal_ci/linux/grpc_e2e_performance_gke_experiment.cfg @@ -0,0 +1,25 @@ +# Copyright 2021 The gRPC Authors +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# Config file for the internal CI (in protobuf text format) + +# Location of the continuous shell script in repository. +build_file: "grpc/tools/internal_ci/linux/grpc_e2e_performance_gke_experiment.sh" +timeout_mins: 720 +action { + define_artifacts { + regex: "**/*sponge_log.*" + regex: "**/github/grpc/runner/**" + } +} diff --git a/tools/internal_ci/linux/grpc_e2e_performance_v2.sh b/tools/internal_ci/linux/grpc_e2e_performance_gke_experiment.sh similarity index 100% rename from tools/internal_ci/linux/grpc_e2e_performance_v2.sh rename to tools/internal_ci/linux/grpc_e2e_performance_gke_experiment.sh diff --git a/tools/internal_ci/linux/grpc_e2e_performance_v2.cfg b/tools/internal_ci/linux/grpc_e2e_performance_v2.cfg index a384c8a0d52..4b49380a563 100644 --- a/tools/internal_ci/linux/grpc_e2e_performance_v2.cfg +++ b/tools/internal_ci/linux/grpc_e2e_performance_v2.cfg @@ -15,7 +15,7 @@ # Config file for the internal CI (in protobuf text format) # Location of the continuous shell script in repository. -build_file: "grpc/tools/internal_ci/linux/grpc_e2e_performance_v2.sh" +build_file: "grpc/tools/internal_ci/linux/grpc_e2e_performance_gke_experiment.sh" timeout_mins: 720 action { define_artifacts { diff --git a/tools/run_tests/performance/README.md b/tools/run_tests/performance/README.md index a912302f41b..ecf02842de0 100644 --- a/tools/run_tests/performance/README.md +++ b/tools/run_tests/performance/README.md @@ -16,7 +16,7 @@ repository, [grpc/test-infra]. These scripts, together with tools defined in [grpc/test-infra], are used in the continuous integration setup defined in [grpc_e2e_performance_gke.sh] and -[grpc_e2e_performance_v2.sh]. +[grpc_e2e_performance_gke_experiment.sh]. #### Generating scenarios @@ -299,11 +299,11 @@ For more information, see the in [grpc/test-infra]. For usage examples, see the continuous integration setup defined in -[grpc_e2e_performance_gke.sh] and [grpc_e2e_performance_v2.sh]. +[grpc_e2e_performance_gke.sh] and [grpc_e2e_performance_gke_experiment.sh]. [grpc/test-infra]: https://github.com/grpc/test-infra [grpc_e2e_performance_gke.sh]: ../../internal_ci/linux/grpc_e2e_performance_gke.sh -[grpc_e2e_performance_v2.sh]: ../../internal_ci/linux/grpc_e2e_performance_v2.sh +[grpc_e2e_performance_gke_experiment.sh]: ../../internal_ci/linux/grpc_e2e_performance_gke_experiment.sh ## Approach 2: Running benchmarks locally via legacy tooling (still useful sometimes)