Merge pull request #20131 from apolcyn/log_alts_errors

Log errors in ALTS handshaker initial op completion cb
5 years ago · a8b0b14a5f
parent 06f85fc987 d1dae7d9d8
commit a8b0b14a5f
1 changed files with 8 additions and 1 deletions
--- a/src/core/tsi/alts/handshaker/alts_tsi_handshaker.cc
+++ b/src/core/tsi/alts/handshaker/alts_tsi_handshaker.cc
@ -251,7 +251,14 @@ static void on_handshaker_service_resp_recv(void* arg, grpc_error* error) {
    gpr_log(GPR_ERROR, "ALTS handshaker client is nullptr");
    return;
  }
-  alts_handshaker_client_handle_response(client, true);
+  bool success = true;
+  if (error != GRPC_ERROR_NONE) {
+    gpr_log(GPR_ERROR,
+            "ALTS handshaker on_handshaker_service_resp_recv error: %s",
+            grpc_error_string(error));
+    success = false;
+  }
+  alts_handshaker_client_handle_response(client, success);
 }

 /* gRPC provided callback used when dedicatd CQ and thread are used.