Merge pull request #17510 from vjpai/bb_api

Add API comments indicating that byte buffer copy is size-independent
pull/17519/head
Vijay Pai 6 years ago committed by GitHub
commit a8688d3bd3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 11
      include/grpcpp/impl/codegen/byte_buffer.h

@ -93,7 +93,9 @@ class ByteBuffer final {
} }
/// Constuct a byte buffer by referencing elements of existing buffer /// Constuct a byte buffer by referencing elements of existing buffer
/// \a buf. Wrapper of core function grpc_byte_buffer_copy /// \a buf. Wrapper of core function grpc_byte_buffer_copy . This is not
/// a deep copy; it is just a referencing. As a result, its performance is
/// size-independent.
ByteBuffer(const ByteBuffer& buf); ByteBuffer(const ByteBuffer& buf);
~ByteBuffer() { ~ByteBuffer() {
@ -102,6 +104,9 @@ class ByteBuffer final {
} }
} }
/// Wrapper of core function grpc_byte_buffer_copy . This is not
/// a deep copy; it is just a referencing. As a result, its performance is
/// size-independent.
ByteBuffer& operator=(const ByteBuffer&); ByteBuffer& operator=(const ByteBuffer&);
/// Dump (read) the buffer contents into \a slices. /// Dump (read) the buffer contents into \a slices.
@ -117,7 +122,9 @@ class ByteBuffer final {
/// Make a duplicate copy of the internals of this byte /// Make a duplicate copy of the internals of this byte
/// buffer so that we have our own owned version of it. /// buffer so that we have our own owned version of it.
/// bbuf.Duplicate(); is equivalent to bbuf=bbuf; but is actually readable /// bbuf.Duplicate(); is equivalent to bbuf=bbuf; but is actually readable.
/// This is not a deep copy; it is a referencing and its performance
/// is size-independent.
void Duplicate() { void Duplicate() {
buffer_ = g_core_codegen_interface->grpc_byte_buffer_copy(buffer_); buffer_ = g_core_codegen_interface->grpc_byte_buffer_copy(buffer_);
} }

Loading…
Cancel
Save