From a83a7ff3545a9687fa319b739759e6e5b22d0628 Mon Sep 17 00:00:00 2001 From: Tanvi Jagtap Date: Wed, 31 Jul 2024 23:42:37 -0700 Subject: [PATCH] [Gpr_To_Absl_Logging] Change VLOG(2) to LOG(INFO) for experiment Change VLOG(2) to LOG(INFO) for experiment status in Google3. PiperOrigin-RevId: 658285149 --- src/core/lib/experiments/config.cc | 25 +++++++++++++++---------- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/src/core/lib/experiments/config.cc b/src/core/lib/experiments/config.cc index a9d93f7fe8e..ac1cf883860 100644 --- a/src/core/lib/experiments/config.cc +++ b/src/core/lib/experiments/config.cc @@ -220,6 +220,11 @@ bool IsTestExperimentEnabled(size_t experiment_id) { return (*g_test_experiments)[experiment_id]; } +// This is VLOG(2) for Open Source gRPC because of a lot of log noise +// complaints. However, internally we want LOG(INFO) so that it is easier for us +// to debug prod issues. +#define GRPC_EXPERIMENT_LOG VLOG(2) + void PrintExperimentsList() { std::map experiment_status; std::set defaulted_on_experiments; @@ -254,20 +259,20 @@ void PrintExperimentsList() { } if (experiment_status.empty()) { if (!defaulted_on_experiments.empty()) { - VLOG(2) << "gRPC experiments enabled: " - << absl::StrJoin(defaulted_on_experiments, ", "); + GRPC_EXPERIMENT_LOG << "gRPC experiments enabled: " + << absl::StrJoin(defaulted_on_experiments, ", "); } } else { if (defaulted_on_experiments.empty()) { - VLOG(2) << "gRPC experiments: " - << absl::StrJoin(experiment_status, ", ", - absl::PairFormatter(":")); + GRPC_EXPERIMENT_LOG << "gRPC experiments: " + << absl::StrJoin(experiment_status, ", ", + absl::PairFormatter(":")); } else { - VLOG(2) << "gRPC experiments: " - << absl::StrJoin(experiment_status, ", ", - absl::PairFormatter(":")) - << "; default-enabled: " - << absl::StrJoin(defaulted_on_experiments, ", "); + GRPC_EXPERIMENT_LOG << "gRPC experiments: " + << absl::StrJoin(experiment_status, ", ", + absl::PairFormatter(":")) + << "; default-enabled: " + << absl::StrJoin(defaulted_on_experiments, ", "); } } }