From 9891e8f953ac86807cc5bb826ed274fcf63c73f5 Mon Sep 17 00:00:00 2001 From: Robbie Shade Date: Mon, 25 Jan 2016 13:19:32 -0500 Subject: [PATCH 1/2] Add comments to grpc_transport_stream_op structure --- src/core/transport/transport.h | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/src/core/transport/transport.h b/src/core/transport/transport.h index f94f0ae76e1..73b62d663bf 100644 --- a/src/core/transport/transport.h +++ b/src/core/transport/transport.h @@ -81,16 +81,28 @@ void grpc_stream_unref(grpc_exec_ctx *exec_ctx, grpc_stream_refcount *refcount); /* Transport stream op: a set of operations to perform on a transport against a single stream */ typedef struct grpc_transport_stream_op { + /** Send initial metadata to the peer, from the provided metadata batch. */ grpc_metadata_batch *send_initial_metadata; + + /** Send trailing metadata to the peer, from the provided metadata batch. */ grpc_metadata_batch *send_trailing_metadata; + /** Send message data to the peer, from the provided byte stream. */ grpc_byte_stream *send_message; + /** Receive initial metadata from the stream, into provided metadata batch. */ grpc_metadata_batch *recv_initial_metadata; + + /** Receive message data from the stream, into provided byte stream. */ grpc_byte_stream **recv_message; + /** Should be enqueued when one message is ready to be processed. */ grpc_closure *recv_message_ready; + + /** Receive trailing metadata from the stream, into provided metadata batch. */ grpc_metadata_batch *recv_trailing_metadata; + /** Should be enqueued when all requested operations (excluding recv_message + which has its own closure) in a given batch have been completed. */ grpc_closure *on_complete; /** If != GRPC_STATUS_OK, cancel this stream */ From cdc182e80c22b0d09fb357e2f97fa9fd9ffa10b3 Mon Sep 17 00:00:00 2001 From: Robbie Shade Date: Fri, 29 Jan 2016 09:39:57 -0500 Subject: [PATCH 2/2] Update copyright, clang-format for line wrapping of comment. --- src/core/transport/transport.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/core/transport/transport.h b/src/core/transport/transport.h index 73b62d663bf..f5cac77adcc 100644 --- a/src/core/transport/transport.h +++ b/src/core/transport/transport.h @@ -1,6 +1,6 @@ /* * - * Copyright 2015, Google Inc. + * Copyright 2015-2016, Google Inc. * All rights reserved. * * Redistribution and use in source and binary forms, with or without @@ -98,7 +98,8 @@ typedef struct grpc_transport_stream_op { /** Should be enqueued when one message is ready to be processed. */ grpc_closure *recv_message_ready; - /** Receive trailing metadata from the stream, into provided metadata batch. */ + /** Receive trailing metadata from the stream, into provided metadata batch. + */ grpc_metadata_batch *recv_trailing_metadata; /** Should be enqueued when all requested operations (excluding recv_message