From a422c8ffe3e57040fa47bb6c5579e50967d41775 Mon Sep 17 00:00:00 2001 From: Yousuk Seung Date: Wed, 2 Oct 2024 15:16:10 -0700 Subject: [PATCH] [experiments] retry work_serializer_dispatch with posix (#37839) All known flakes/bugs have been fixed. Closes #37839 COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/37839 from yousukseung:work_serializer_dispatch a82a068ebfd5d5f19c014e68321829f7c9216332 PiperOrigin-RevId: 681609545 --- bazel/experiments.bzl | 16 ++++++---------- src/core/lib/experiments/experiments.cc | 2 +- src/core/lib/experiments/experiments.h | 3 ++- src/core/lib/experiments/rollouts.yaml | 2 +- 4 files changed, 10 insertions(+), 13 deletions(-) diff --git a/bazel/experiments.bzl b/bazel/experiments.bzl index 0709155657e..830d4a076d2 100644 --- a/bazel/experiments.bzl +++ b/bazel/experiments.bzl @@ -138,10 +138,6 @@ EXPERIMENTS = { "core_end2end_test": [ "event_engine_client", "local_connector_secure", - "work_serializer_dispatch", - ], - "cpp_end2end_test": [ - "work_serializer_dispatch", ], "endpoint_test": [ "tcp_frame_size_tuning", @@ -155,16 +151,10 @@ EXPERIMENTS = { "tcp_frame_size_tuning", "tcp_rcv_lowat", ], - "lb_unit_test": [ - "work_serializer_dispatch", - ], "resource_quota_test": [ "free_large_allocator", "unconstrained_max_quota_buffer_size", ], - "xds_end2end_test": [ - "work_serializer_dispatch", - ], }, "on": { "cancel_ares_query_test": [ @@ -172,6 +162,10 @@ EXPERIMENTS = { ], "core_end2end_test": [ "event_engine_listener", + "work_serializer_dispatch", + ], + "cpp_end2end_test": [ + "work_serializer_dispatch", ], "cpp_lb_end2end_test": [ "pick_first_new", @@ -181,12 +175,14 @@ EXPERIMENTS = { ], "lb_unit_test": [ "pick_first_new", + "work_serializer_dispatch", ], "resolver_component_tests_runner_invoker": [ "event_engine_dns", ], "xds_end2end_test": [ "pick_first_new", + "work_serializer_dispatch", ], }, }, diff --git a/src/core/lib/experiments/experiments.cc b/src/core/lib/experiments/experiments.cc index 7a6522410d7..8464f0756a0 100644 --- a/src/core/lib/experiments/experiments.cc +++ b/src/core/lib/experiments/experiments.cc @@ -462,7 +462,7 @@ const ExperimentMetadata g_experiment_metadata[] = { additional_constraints_work_serializer_clears_time_cache, nullptr, 0, true, true}, {"work_serializer_dispatch", description_work_serializer_dispatch, - additional_constraints_work_serializer_dispatch, nullptr, 0, false, true}, + additional_constraints_work_serializer_dispatch, nullptr, 0, true, true}, }; } // namespace grpc_core diff --git a/src/core/lib/experiments/experiments.h b/src/core/lib/experiments/experiments.h index ca6c0734a81..8aa59e12f9b 100644 --- a/src/core/lib/experiments/experiments.h +++ b/src/core/lib/experiments/experiments.h @@ -155,7 +155,8 @@ inline bool IsTraceRecordCallopsEnabled() { return true; } inline bool IsUnconstrainedMaxQuotaBufferSizeEnabled() { return false; } #define GRPC_EXPERIMENT_IS_INCLUDED_WORK_SERIALIZER_CLEARS_TIME_CACHE inline bool IsWorkSerializerClearsTimeCacheEnabled() { return true; } -inline bool IsWorkSerializerDispatchEnabled() { return false; } +#define GRPC_EXPERIMENT_IS_INCLUDED_WORK_SERIALIZER_DISPATCH +inline bool IsWorkSerializerDispatchEnabled() { return true; } #endif #else diff --git a/src/core/lib/experiments/rollouts.yaml b/src/core/lib/experiments/rollouts.yaml index 36ef43d8b40..eb86f1d851e 100644 --- a/src/core/lib/experiments/rollouts.yaml +++ b/src/core/lib/experiments/rollouts.yaml @@ -112,6 +112,6 @@ default: # TODO(ysseung): Not fully tested. ios: broken - posix: false + posix: true # TODO(ysseung): Test flakes not fully resolved. windows: broken