From a414dbd304aa14c7066a110e2ce4e6e1ff748fcf Mon Sep 17 00:00:00 2001 From: Craig Tiller Date: Tue, 3 Jan 2023 11:00:30 -0800 Subject: [PATCH] Revert #30349 (#32008) * [iwyu] Add missing #include to fix build breakage with LLVM after https://github.com/llvm/llvm-project/commit/e0a66116fcccd59d12485810f5311efafa134ea5 * Update IWYU mappings New libc++ doesn't provide when including . * run iwyu Co-authored-by: alexfh --- .../lb_policy/grpclb/client_load_reporting_filter.cc | 1 + src/core/ext/filters/client_channel/lb_policy/grpclb/grpclb.cc | 1 + .../lb_policy/outlier_detection/outlier_detection.cc | 1 + .../ext/filters/client_channel/lb_policy/priority/priority.cc | 1 + src/core/ext/filters/client_channel/lb_policy/rls/rls.cc | 1 + src/core/ext/filters/client_channel/lb_policy/xds/cds.cc | 1 + .../filters/client_channel/lb_policy/xds/xds_cluster_manager.cc | 1 + .../filters/client_channel/lb_policy/xds/xds_cluster_resolver.cc | 1 + src/core/ext/filters/client_channel/resolver/polling_resolver.cc | 1 + src/core/ext/filters/client_channel/resolver/xds/xds_resolver.cc | 1 + src/core/ext/filters/fault_injection/fault_injection_filter.cc | 1 + src/core/ext/filters/http/message_compress/compression_filter.cc | 1 + src/core/ext/transport/chttp2/client/chttp2_connector.cc | 1 + src/core/ext/xds/xds_client.cc | 1 + src/core/lib/channel/channel_args.h | 1 + src/core/lib/channel/promise_based_filter.h | 1 + src/core/lib/event_engine/posix_engine/posix_engine.cc | 1 + src/core/lib/gprpp/manual_constructor.h | 1 + src/core/lib/gprpp/no_destruct.h | 1 + src/core/lib/gprpp/ref_counted_ptr.h | 1 + src/core/lib/gprpp/table.h | 1 + src/core/lib/promise/arena_promise.h | 1 + src/core/lib/promise/context.h | 1 + src/core/lib/promise/detail/basic_join.h | 1 + src/core/lib/promise/detail/promise_factory.h | 1 + src/core/lib/promise/for_each.h | 1 + src/core/lib/promise/map.h | 1 + src/core/lib/promise/seq.h | 1 + src/core/lib/promise/try_concurrently.h | 1 + src/core/lib/promise/try_seq.h | 1 + src/core/lib/surface/call.cc | 1 + src/core/lib/transport/metadata_batch.h | 1 + src/core/lib/transport/parsed_metadata.h | 1 + src/cpp/server/server_cc.cc | 1 + test/core/event_engine/posix/posix_endpoint_test.cc | 1 + test/core/event_engine/test_suite/client_test.cc | 1 + test/core/event_engine/test_suite/server_test.cc | 1 + test/core/event_engine/work_queue/work_queue_fuzzer.cc | 1 + test/core/promise/pipe_test.cc | 1 + test/core/xds/xds_transport_fake.cc | 1 + tools/distrib/iwyu_mappings.imp | 1 - 41 files changed, 40 insertions(+), 1 deletion(-) diff --git a/src/core/ext/filters/client_channel/lb_policy/grpclb/client_load_reporting_filter.cc b/src/core/ext/filters/client_channel/lb_policy/grpclb/client_load_reporting_filter.cc index 5215dc1cb3e..45e875ba2a6 100644 --- a/src/core/ext/filters/client_channel/lb_policy/grpclb/client_load_reporting_filter.cc +++ b/src/core/ext/filters/client_channel/lb_policy/grpclb/client_load_reporting_filter.cc @@ -22,6 +22,7 @@ #include #include +#include #include #include "absl/meta/type_traits.h" diff --git a/src/core/ext/filters/client_channel/lb_policy/grpclb/grpclb.cc b/src/core/ext/filters/client_channel/lb_policy/grpclb/grpclb.cc index 11ddaa255bd..de61e3ca544 100644 --- a/src/core/ext/filters/client_channel/lb_policy/grpclb/grpclb.cc +++ b/src/core/ext/filters/client_channel/lb_policy/grpclb/grpclb.cc @@ -65,6 +65,7 @@ #include #include #include +#include #include #include diff --git a/src/core/ext/filters/client_channel/lb_policy/outlier_detection/outlier_detection.cc b/src/core/ext/filters/client_channel/lb_policy/outlier_detection/outlier_detection.cc index cab44e56c51..e013286e3d0 100644 --- a/src/core/ext/filters/client_channel/lb_policy/outlier_detection/outlier_detection.cc +++ b/src/core/ext/filters/client_channel/lb_policy/outlier_detection/outlier_detection.cc @@ -28,6 +28,7 @@ #include #include #include +#include #include #include diff --git a/src/core/ext/filters/client_channel/lb_policy/priority/priority.cc b/src/core/ext/filters/client_channel/lb_policy/priority/priority.cc index b4b2f08bbb4..e5f66e1a493 100644 --- a/src/core/ext/filters/client_channel/lb_policy/priority/priority.cc +++ b/src/core/ext/filters/client_channel/lb_policy/priority/priority.cc @@ -23,6 +23,7 @@ #include #include #include +#include #include #include diff --git a/src/core/ext/filters/client_channel/lb_policy/rls/rls.cc b/src/core/ext/filters/client_channel/lb_policy/rls/rls.cc index d4d2c91bce9..ebf0f63b21a 100644 --- a/src/core/ext/filters/client_channel/lb_policy/rls/rls.cc +++ b/src/core/ext/filters/client_channel/lb_policy/rls/rls.cc @@ -34,6 +34,7 @@ #include #include #include +#include #include #include #include diff --git a/src/core/ext/filters/client_channel/lb_policy/xds/cds.cc b/src/core/ext/filters/client_channel/lb_policy/xds/cds.cc index ead4c3dc493..397b181c8cc 100644 --- a/src/core/ext/filters/client_channel/lb_policy/xds/cds.cc +++ b/src/core/ext/filters/client_channel/lb_policy/xds/cds.cc @@ -21,6 +21,7 @@ #include #include #include +#include #include #include diff --git a/src/core/ext/filters/client_channel/lb_policy/xds/xds_cluster_manager.cc b/src/core/ext/filters/client_channel/lb_policy/xds/xds_cluster_manager.cc index c9a66c16e0d..ab423053299 100644 --- a/src/core/ext/filters/client_channel/lb_policy/xds/xds_cluster_manager.cc +++ b/src/core/ext/filters/client_channel/lb_policy/xds/xds_cluster_manager.cc @@ -22,6 +22,7 @@ #include #include #include +#include #include #include diff --git a/src/core/ext/filters/client_channel/lb_policy/xds/xds_cluster_resolver.cc b/src/core/ext/filters/client_channel/lb_policy/xds/xds_cluster_resolver.cc index 0eb5e0b4dce..66e481789f0 100644 --- a/src/core/ext/filters/client_channel/lb_policy/xds/xds_cluster_resolver.cc +++ b/src/core/ext/filters/client_channel/lb_policy/xds/xds_cluster_resolver.cc @@ -24,6 +24,7 @@ #include #include #include +#include #include #include diff --git a/src/core/ext/filters/client_channel/resolver/polling_resolver.cc b/src/core/ext/filters/client_channel/resolver/polling_resolver.cc index 8f85a67fa77..c74a5ef3868 100644 --- a/src/core/ext/filters/client_channel/resolver/polling_resolver.cc +++ b/src/core/ext/filters/client_channel/resolver/polling_resolver.cc @@ -21,6 +21,7 @@ #include #include +#include #include #include diff --git a/src/core/ext/filters/client_channel/resolver/xds/xds_resolver.cc b/src/core/ext/filters/client_channel/resolver/xds/xds_resolver.cc index f39e8eb34ca..5ade1ece0e9 100644 --- a/src/core/ext/filters/client_channel/resolver/xds/xds_resolver.cc +++ b/src/core/ext/filters/client_channel/resolver/xds/xds_resolver.cc @@ -24,6 +24,7 @@ #include #include #include +#include #include #include diff --git a/src/core/ext/filters/fault_injection/fault_injection_filter.cc b/src/core/ext/filters/fault_injection/fault_injection_filter.cc index 9ba17b48ced..f1db4e22b4b 100644 --- a/src/core/ext/filters/fault_injection/fault_injection_filter.cc +++ b/src/core/ext/filters/fault_injection/fault_injection_filter.cc @@ -24,6 +24,7 @@ #include #include #include +#include #include #include "absl/status/status.h" diff --git a/src/core/ext/filters/http/message_compress/compression_filter.cc b/src/core/ext/filters/http/message_compress/compression_filter.cc index 88241209a4d..b1708ffea1b 100644 --- a/src/core/ext/filters/http/message_compress/compression_filter.cc +++ b/src/core/ext/filters/http/message_compress/compression_filter.cc @@ -20,6 +20,7 @@ #include #include +#include #include #include "absl/meta/type_traits.h" diff --git a/src/core/ext/transport/chttp2/client/chttp2_connector.cc b/src/core/ext/transport/chttp2/client/chttp2_connector.cc index 6f701c8a0be..fa4c16a46c3 100644 --- a/src/core/ext/transport/chttp2/client/chttp2_connector.cc +++ b/src/core/ext/transport/chttp2/client/chttp2_connector.cc @@ -23,6 +23,7 @@ #include #include +#include #include #include "absl/status/status.h" diff --git a/src/core/ext/xds/xds_client.cc b/src/core/ext/xds/xds_client.cc index cc939f3bc25..9f5d935647c 100644 --- a/src/core/ext/xds/xds_client.cc +++ b/src/core/ext/xds/xds_client.cc @@ -22,6 +22,7 @@ #include #include +#include #include "absl/strings/match.h" #include "absl/strings/str_cat.h" diff --git a/src/core/lib/channel/channel_args.h b/src/core/lib/channel/channel_args.h index 08fddf7d814..04e91e9d936 100644 --- a/src/core/lib/channel/channel_args.h +++ b/src/core/lib/channel/channel_args.h @@ -27,6 +27,7 @@ #include #include #include +#include #include #include "absl/meta/type_traits.h" diff --git a/src/core/lib/channel/promise_based_filter.h b/src/core/lib/channel/promise_based_filter.h index a9914f6c4ad..0bbac170307 100644 --- a/src/core/lib/channel/promise_based_filter.h +++ b/src/core/lib/channel/promise_based_filter.h @@ -31,6 +31,7 @@ #include #include #include +#include #include #include "absl/container/inlined_vector.h" diff --git a/src/core/lib/event_engine/posix_engine/posix_engine.cc b/src/core/lib/event_engine/posix_engine/posix_engine.cc index 1b55d899537..6116d63a20e 100644 --- a/src/core/lib/event_engine/posix_engine/posix_engine.cc +++ b/src/core/lib/event_engine/posix_engine/posix_engine.cc @@ -21,6 +21,7 @@ #include #include #include +#include #include #include "absl/cleanup/cleanup.h" diff --git a/src/core/lib/gprpp/manual_constructor.h b/src/core/lib/gprpp/manual_constructor.h index f8064d3870a..786edf3a171 100644 --- a/src/core/lib/gprpp/manual_constructor.h +++ b/src/core/lib/gprpp/manual_constructor.h @@ -25,6 +25,7 @@ #include +#include #include #include "src/core/lib/gprpp/construct_destruct.h" diff --git a/src/core/lib/gprpp/no_destruct.h b/src/core/lib/gprpp/no_destruct.h index 0e839e3ca73..e8692e16d81 100644 --- a/src/core/lib/gprpp/no_destruct.h +++ b/src/core/lib/gprpp/no_destruct.h @@ -17,6 +17,7 @@ #include +#include #include #include "src/core/lib/gprpp/construct_destruct.h" diff --git a/src/core/lib/gprpp/ref_counted_ptr.h b/src/core/lib/gprpp/ref_counted_ptr.h index 6a66ad6e0e3..3e5b71a9047 100644 --- a/src/core/lib/gprpp/ref_counted_ptr.h +++ b/src/core/lib/gprpp/ref_counted_ptr.h @@ -22,6 +22,7 @@ #include #include +#include #include #include "src/core/lib/gprpp/debug_location.h" diff --git a/src/core/lib/gprpp/table.h b/src/core/lib/gprpp/table.h index 5cf6c788420..35088f2dbdb 100644 --- a/src/core/lib/gprpp/table.h +++ b/src/core/lib/gprpp/table.h @@ -21,6 +21,7 @@ #include #include +#include #include #include "absl/meta/type_traits.h" diff --git a/src/core/lib/promise/arena_promise.h b/src/core/lib/promise/arena_promise.h index 5ab1db8686d..030743af538 100644 --- a/src/core/lib/promise/arena_promise.h +++ b/src/core/lib/promise/arena_promise.h @@ -20,6 +20,7 @@ #include #include +#include #include #include "absl/meta/type_traits.h" diff --git a/src/core/lib/promise/context.h b/src/core/lib/promise/context.h index 9dc9c4923dd..be53a92155c 100644 --- a/src/core/lib/promise/context.h +++ b/src/core/lib/promise/context.h @@ -17,6 +17,7 @@ #include +#include #include #include diff --git a/src/core/lib/promise/detail/basic_join.h b/src/core/lib/promise/detail/basic_join.h index b1d0d4cd7e0..2632b69c23b 100644 --- a/src/core/lib/promise/detail/basic_join.h +++ b/src/core/lib/promise/detail/basic_join.h @@ -22,6 +22,7 @@ #include #include +#include #include #include "absl/types/variant.h" diff --git a/src/core/lib/promise/detail/promise_factory.h b/src/core/lib/promise/detail/promise_factory.h index f7a3f223a0d..5c6da1e335b 100644 --- a/src/core/lib/promise/detail/promise_factory.h +++ b/src/core/lib/promise/detail/promise_factory.h @@ -17,6 +17,7 @@ #include +#include #include #include "absl/meta/type_traits.h" diff --git a/src/core/lib/promise/for_each.h b/src/core/lib/promise/for_each.h index a17e56ffe14..ec0b23eae66 100644 --- a/src/core/lib/promise/for_each.h +++ b/src/core/lib/promise/for_each.h @@ -17,6 +17,7 @@ #include +#include #include #include "absl/status/status.h" diff --git a/src/core/lib/promise/map.h b/src/core/lib/promise/map.h index 1ead82217a9..d4090beb69d 100644 --- a/src/core/lib/promise/map.h +++ b/src/core/lib/promise/map.h @@ -20,6 +20,7 @@ #include #include +#include #include #include "absl/types/variant.h" diff --git a/src/core/lib/promise/seq.h b/src/core/lib/promise/seq.h index ea2cefc5b61..1ab7e0afa38 100644 --- a/src/core/lib/promise/seq.h +++ b/src/core/lib/promise/seq.h @@ -17,6 +17,7 @@ #include +#include #include #include "src/core/lib/promise/detail/basic_seq.h" diff --git a/src/core/lib/promise/try_concurrently.h b/src/core/lib/promise/try_concurrently.h index a6f19cf5d5f..954050bafa9 100644 --- a/src/core/lib/promise/try_concurrently.h +++ b/src/core/lib/promise/try_concurrently.h @@ -20,6 +20,7 @@ #include #include +#include #include #include "absl/types/variant.h" diff --git a/src/core/lib/promise/try_seq.h b/src/core/lib/promise/try_seq.h index 6409c445b91..df0fd8d8053 100644 --- a/src/core/lib/promise/try_seq.h +++ b/src/core/lib/promise/try_seq.h @@ -17,6 +17,7 @@ #include +#include #include #include "absl/meta/type_traits.h" diff --git a/src/core/lib/surface/call.cc b/src/core/lib/surface/call.cc index 3bc4681bfec..05faba4f29d 100644 --- a/src/core/lib/surface/call.cc +++ b/src/core/lib/surface/call.cc @@ -29,6 +29,7 @@ #include #include #include +#include #include #include diff --git a/src/core/lib/transport/metadata_batch.h b/src/core/lib/transport/metadata_batch.h index d4b6821f5e2..f16473320a8 100644 --- a/src/core/lib/transport/metadata_batch.h +++ b/src/core/lib/transport/metadata_batch.h @@ -25,6 +25,7 @@ #include #include +#include #include #include "absl/container/inlined_vector.h" diff --git a/src/core/lib/transport/parsed_metadata.h b/src/core/lib/transport/parsed_metadata.h index 30f0d3cf5c8..22188555c78 100644 --- a/src/core/lib/transport/parsed_metadata.h +++ b/src/core/lib/transport/parsed_metadata.h @@ -21,6 +21,7 @@ #include #include +#include #include #include "absl/functional/function_ref.h" diff --git a/src/cpp/server/server_cc.cc b/src/cpp/server/server_cc.cc index c08603bf70d..bc64cf319a6 100644 --- a/src/cpp/server/server_cc.cc +++ b/src/cpp/server/server_cc.cc @@ -25,6 +25,7 @@ #include #include #include +#include #include #include diff --git a/test/core/event_engine/posix/posix_endpoint_test.cc b/test/core/event_engine/posix/posix_endpoint_test.cc index db69a42a72f..cb2e5534088 100644 --- a/test/core/event_engine/posix/posix_endpoint_test.cc +++ b/test/core/event_engine/posix/posix_endpoint_test.cc @@ -21,6 +21,7 @@ #include #include #include +#include #include #include "absl/status/statusor.h" diff --git a/test/core/event_engine/test_suite/client_test.cc b/test/core/event_engine/test_suite/client_test.cc index 0b05b3e8e7f..7c998bcd3cd 100644 --- a/test/core/event_engine/test_suite/client_test.cc +++ b/test/core/event_engine/test_suite/client_test.cc @@ -21,6 +21,7 @@ #include #include #include +#include #include #include diff --git a/test/core/event_engine/test_suite/server_test.cc b/test/core/event_engine/test_suite/server_test.cc index af4c8dab665..84c322da9b8 100644 --- a/test/core/event_engine/test_suite/server_test.cc +++ b/test/core/event_engine/test_suite/server_test.cc @@ -21,6 +21,7 @@ #include #include #include +#include #include #include diff --git a/test/core/event_engine/work_queue/work_queue_fuzzer.cc b/test/core/event_engine/work_queue/work_queue_fuzzer.cc index 31cbf2117de..28aa682cce2 100644 --- a/test/core/event_engine/work_queue/work_queue_fuzzer.cc +++ b/test/core/event_engine/work_queue/work_queue_fuzzer.cc @@ -16,6 +16,7 @@ #include #include +#include #include #include "absl/functional/any_invocable.h" diff --git a/test/core/promise/pipe_test.cc b/test/core/promise/pipe_test.cc index 6f8599eb562..bcf1adbe276 100644 --- a/test/core/promise/pipe_test.cc +++ b/test/core/promise/pipe_test.cc @@ -16,6 +16,7 @@ #include #include +#include #include #include "absl/status/status.h" diff --git a/test/core/xds/xds_transport_fake.cc b/test/core/xds/xds_transport_fake.cc index fad9e481d48..3aeeb264630 100644 --- a/test/core/xds/xds_transport_fake.cc +++ b/test/core/xds/xds_transport_fake.cc @@ -22,6 +22,7 @@ #include #include +#include #include #include diff --git a/tools/distrib/iwyu_mappings.imp b/tools/distrib/iwyu_mappings.imp index 036298461b1..3f993a9aee5 100644 --- a/tools/distrib/iwyu_mappings.imp +++ b/tools/distrib/iwyu_mappings.imp @@ -4,7 +4,6 @@ { include: ["", "public", "\"src/core/lib/iomgr/sockaddr.h\"", "public"]}, { include: ["", "private", "", "public"] }, { include: ["", "private", "", "public"] }, - { include: ["", "public", "", "public" ] }, # workaround: https://github.com/include-what-you-use/include-what-you-use/issues/908 { symbol: ["std::max", "private", "", "public" ] }, ]