Revert "[flakes] Update flakiness (#31121)" (#31173)

This reverts commit bdc799af73.

build_autogenerated.yaml

@@ -3646,6 +3646,7 @@ targets:
 - name: activity_test
   gtest: true
   build: test
+  run: false
   language: c++
   headers:
   - src/core/lib/gprpp/atomic_utils.h
@@ -4997,6 +4998,7 @@ targets:
 - name: client_lb_end2end_test
   gtest: true
   build: test
+  run: false
   language: c++
   headers:
   - src/cpp/server/orca/orca_interceptor.h
@@ -6707,7 +6709,6 @@ targets:
 - name: grpc_tls_certificate_provider_test
   gtest: true
   build: test
-  run: false
   language: c++
   headers:
   - test/core/util/cmdline.h
@@ -8066,6 +8067,7 @@ targets:
 - name: periodic_update_test
   gtest: true
   build: test
+  run: false
   language: c++
   headers:
   - src/core/ext/upb-generated/google/protobuf/any.upb.h
@@ -8786,6 +8788,7 @@ targets:
 - name: secure_endpoint_test
   gtest: true
   build: test
+  run: false
   language: c++
   headers:
   - test/core/iomgr/endpoint_tests.h
@@ -10161,6 +10164,7 @@ targets:
 - name: timer_test
   gtest: true
   build: test
+  run: false
   language: c++
   headers: []
   src:
@@ -10230,6 +10234,7 @@ targets:
 - name: too_many_pings_test
   gtest: true
   build: test
+  run: false
   language: c++
   headers:
   - test/core/end2end/cq_verifier.h
@@ -10785,6 +10790,7 @@ targets:
 - name: work_serializer_test
   gtest: true
   build: test
+  run: false
   language: c++
   headers: []
   src:
@@ -10932,6 +10938,7 @@ targets:
 - name: xds_cluster_type_end2end_test
   gtest: true
   build: test
+  run: false
   language: c++
   headers:
   - test/cpp/end2end/connection_attempt_injector.h
@@ -10990,6 +10997,7 @@ targets:
 - name: xds_core_end2end_test
   gtest: true
   build: test
+  run: false
   language: c++
   headers:
   - test/cpp/end2end/counted_service.h
@@ -11153,6 +11161,7 @@ targets:
 - name: xds_end2end_test
   gtest: true
   build: test
+  run: false
   language: c++
   headers:
   - test/cpp/end2end/counted_service.h
@@ -11230,6 +11239,7 @@ targets:
 - name: xds_fault_injection_end2end_test
   gtest: true
   build: test
+  run: false
   language: c++
   headers:
   - test/cpp/end2end/counted_service.h
@@ -11373,6 +11383,7 @@ targets:
 - name: xds_outlier_detection_end2end_test
   gtest: true
   build: test
+  run: false
   language: c++
   headers:
   - test/cpp/end2end/counted_service.h
@@ -11431,6 +11442,7 @@ targets:
 - name: xds_ring_hash_end2end_test
   gtest: true
   build: test
+  run: false
   language: c++
   headers:
   - test/cpp/end2end/connection_attempt_injector.h
@@ -11548,6 +11560,7 @@ targets:
 - name: xds_routing_end2end_test
   gtest: true
   build: test
+  run: false
   language: c++
   headers:
   - test/cpp/end2end/counted_service.h

test/core/end2end/flaky.bzl

@@ -13,14 +13,50 @@
 # limitations under the License.
 """A list of flaky tests, consumed by generate_tests.bzl to set flaky attrs."""
 FLAKY_TESTS = [
-    "h2_full+pipe_test@retry_per_attempt_recv_timeout",
+    "h2_compress_test@max_connection_age",
+    "h2_full+pipe_test@max_connection_age",
     "h2_full_no_retry_test@max_connection_age",
-    "h2_insecure_test@retry_per_attempt_recv_timeout",
-    "h2_local_abstract_uds_percent_encoded_test@resource_quota_server",
+    "h2_full_test@max_connection_age",
+    "h2_full_test@max_connection_idle",
+    "h2_http_proxy_test@max_connection_age",
+    "h2_http_proxy_test@retry_per_attempt_recv_timeout",
+    "h2_insecure_test@max_connection_idle",
+    "h2_local_abstract_uds_percent_encoded_test@max_connection_idle",
+    "h2_local_ipv4_test@max_connection_idle",
+    "h2_local_ipv6_test@max_connection_idle",
+    "h2_local_uds_percent_encoded_test@max_connection_idle",
+    "h2_local_uds_test@max_connection_idle",
+    "h2_oauth2_test@max_connection_idle",
+    "h2_oauth2_tls12_test@max_connection_idle",
     "h2_proxy_test@cancel_with_status",
-    "h2_ssl_proxy_test@cancel_after_accept",
+    "h2_sockpair_1byte_test@max_connection_age",
+    "h2_ssl_cred_reload_test@max_connection_idle",
+    "h2_ssl_cred_reload_tls12_test@max_connection_age",
     "h2_ssl_proxy_test@retry_transparent_not_sent_on_wire",
-    "h2_ssl_tls13_test@cancel_after_invoke",
-    "h2_ssl_tls13_test@retry_per_attempt_recv_timeout",
-    "h2_uds_abstract_test@resource_quota_server",
+    "h2_ssl_test@max_connection_idle",
+    "h2_ssl_test@retry_cancellation",
+    "h2_tls_certwatch_async_tls1_3_test@connectivity",
+    "h2_tls_certwatch_async_tls1_3_test@max_connection_idle",
+    "h2_tls_certwatch_async_tls1_3_test@retry_cancellation",
+    "h2_tls_certwatch_async_tls1_3_test@simple_delayed_request",
+    "h2_tls_certwatch_sync_tls1_2_test@connectivity",
+    "h2_tls_certwatch_sync_tls1_2_test@max_connection_idle",
+    "h2_tls_certwatch_sync_tls1_2_test@retry_cancellation",
+    "h2_tls_certwatch_sync_tls1_2_test@simple_delayed_request",
+    "h2_tls_simple_test@connectivity",
+    "h2_tls_simple_test@max_connection_idle",
+    "h2_tls_simple_test@simple_delayed_request",
+    "h2_tls_static_async_tls1_3_test@connectivity",
+    "h2_tls_static_async_tls1_3_test@max_connection_idle",
+    "h2_tls_static_async_tls1_3_test@retry_cancellation",
+    "h2_tls_static_async_tls1_3_test@simple_delayed_request",
+    "h2_tls_test@connectivity",
+    "h2_tls_test@hpack_size",
+    "h2_tls_test@invoke_large_request",
+    "h2_tls_test@max_connection_idle",
+    "h2_tls_test@resource_quota_server",
+    "h2_tls_test@retry_cancellation",
+    "h2_tls_test@simple_delayed_request",
+    "h2_uds_abstract_test@max_connection_age",
+    "h2_uds_test@max_connection_idle",
 ]

test/core/gprpp/BUILD

@@ -392,6 +392,7 @@ grpc_cc_test(
     external_deps = [
         "gtest",
     ],
+    flaky = True,
     language = "C++",
     shard_count = 5,
     tags = [

test/core/promise/BUILD

@@ -243,6 +243,7 @@ grpc_cc_test(
     name = "activity_test",
     srcs = ["activity_test.cc"],
     external_deps = ["gtest"],
+    flaky = True,
     language = "c++",
     tags = ["promise_test"],
     uses_event_engine = False,

test/core/resource_quota/BUILD

@@ -74,6 +74,7 @@ grpc_cc_test(
     name = "periodic_update_test",
     srcs = ["periodic_update_test.cc"],
     external_deps = ["gtest"],
+    flaky = True,
     language = "c++",
     uses_event_engine = False,
     uses_polling = False,

test/core/security/BUILD

@@ -42,7 +42,6 @@ grpc_fuzzer(
         "//src/core/tsi/test_creds:server1.key",
         "//src/core/tsi/test_creds:server1.pem",
     ],
-    flaky = True,
     language = "C++",
     tags = ["no_windows"],
     deps = [
@@ -165,6 +164,7 @@ grpc_cc_test(
     name = "secure_endpoint_test",
     srcs = ["secure_endpoint_test.cc"],
     external_deps = ["gtest"],
+    flaky = True,
     language = "C++",
     deps = [
         "//:gpr",
@@ -398,7 +398,6 @@ grpc_cc_test(
         "//src/core/tsi/test_creds:server1.pem",
     ],
     external_deps = ["gtest"],
-    flaky = True,
     language = "C++",
     deps = [
         "//:gpr",

test/core/transport/chttp2/BUILD

@@ -261,6 +261,7 @@ grpc_cc_test(
     timeout = "long",  # Required for internal test infrastructure (cl/325757166)
     srcs = ["too_many_pings_test.cc"],
     external_deps = ["gtest"],
+    flaky = True,
     shard_count = 7,
     deps = [
         "//:gpr",

test/cpp/common/BUILD

@@ -38,6 +38,7 @@ grpc_cc_test(
     external_deps = [
         "gtest",
     ],
+    flaky = True,
     deps = [
         "//:grpc++",
         "//test/core/util:grpc_test_util",

test/cpp/end2end/BUILD

@@ -486,6 +486,7 @@ grpc_cc_test(
     external_deps = [
         "gtest",
     ],
+    flaky = True,  # TODO(b/151315347)
     tags = ["no_windows"],  # TODO(jtattermusch): fix test on windows
     deps = [
         ":connection_attempt_injector",

test/cpp/end2end/xds/BUILD

@@ -108,6 +108,7 @@ grpc_cc_test(
     external_deps = [
         "gtest",
     ],
+    flaky = True,  # TODO(b/144705388)
     linkstatic = True,  # Fixes dyld error on MacOS
     shard_count = 50,
     tags = [
@@ -176,6 +177,7 @@ grpc_cc_test(
     external_deps = [
         "gtest",
     ],
+    flaky = True,  # TODO(b/144705388)
     linkstatic = True,  # Fixes dyld error on MacOS
     tags = [
         "no_test_ios",
@@ -200,6 +202,7 @@ grpc_cc_test(
     external_deps = [
         "gtest",
     ],
+    flaky = True,
     linkstatic = True,  # Fixes dyld error on MacOS
     shard_count = 15,
     tags = [
@@ -248,6 +251,7 @@ grpc_cc_test(
     external_deps = [
         "gtest",
     ],
+    flaky = True,
     linkstatic = True,  # Fixes dyld error on MacOS
     shard_count = 5,
     tags = [
@@ -274,6 +278,7 @@ grpc_cc_test(
     external_deps = [
         "gtest",
     ],
+    flaky = True,
     linkstatic = True,  # Fixes dyld error on MacOS
     tags = [
         "no_test_ios",
@@ -298,6 +303,7 @@ grpc_cc_test(
     external_deps = [
         "gtest",
     ],
+    flaky = True,  # TODO(b/144705388)
     linkstatic = True,  # Fixes dyld error on MacOS
     shard_count = 10,
     tags = [
@@ -351,6 +357,7 @@ grpc_cc_test(
     external_deps = [
         "gtest",
     ],
+    flaky = True,  # TODO(b/144705388)
     linkstatic = True,  # Fixes dyld error on MacOS
     shard_count = 10,
     tags = [

test/cpp/microbenchmarks/BUILD

@@ -243,6 +243,7 @@ grpc_cc_test(
         "bm_fullstack_streaming_ping_pong.cc",
     ],
     args = grpc_benchmark_args(),
+    flaky = True,
     tags = [
         "no_mac",  # to emulate "excluded_poll_engines: poll"
         "no_windows",

tools/run_tests/generated/tests.json

@@ -415,30 +415,6 @@
     ],
     "uses_polling": false
   },
-  {
-    "args": [],
-    "benchmark": false,
-    "ci_platforms": [
-      "linux",
-      "mac",
-      "posix",
-      "windows"
-    ],
-    "cpu_cost": 1.0,
-    "exclude_configs": [],
-    "exclude_iomgrs": [],
-    "flaky": false,
-    "gtest": true,
-    "language": "c++",
-    "name": "activity_test",
-    "platforms": [
-      "linux",
-      "mac",
-      "posix",
-      "windows"
-    ],
-    "uses_polling": false
-  },
   {
     "args": [],
     "benchmark": false,
@@ -2039,28 +2015,6 @@
     ],
     "uses_polling": true
   },
-  {
-    "args": [],
-    "benchmark": false,
-    "ci_platforms": [
-      "linux",
-      "mac",
-      "posix"
-    ],
-    "cpu_cost": 1.0,
-    "exclude_configs": [],
-    "exclude_iomgrs": [],
-    "flaky": false,
-    "gtest": true,
-    "language": "c++",
-    "name": "client_lb_end2end_test",
-    "platforms": [
-      "linux",
-      "mac",
-      "posix"
-    ],
-    "uses_polling": true
-  },
   {
     "args": [],
     "benchmark": false,
@@ -3555,6 +3509,30 @@
     ],
     "uses_polling": true
   },
+  {
+    "args": [],
+    "benchmark": false,
+    "ci_platforms": [
+      "linux",
+      "mac",
+      "posix",
+      "windows"
+    ],
+    "cpu_cost": 1.0,
+    "exclude_configs": [],
+    "exclude_iomgrs": [],
+    "flaky": false,
+    "gtest": true,
+    "language": "c++",
+    "name": "grpc_tls_certificate_provider_test",
+    "platforms": [
+      "linux",
+      "mac",
+      "posix",
+      "windows"
+    ],
+    "uses_polling": true
+  },
   {
     "args": [],
     "benchmark": false,
@@ -5141,30 +5119,6 @@
     ],
     "uses_polling": false
   },
-  {
-    "args": [],
-    "benchmark": false,
-    "ci_platforms": [
-      "linux",
-      "mac",
-      "posix",
-      "windows"
-    ],
-    "cpu_cost": 1.0,
-    "exclude_configs": [],
-    "exclude_iomgrs": [],
-    "flaky": false,
-    "gtest": true,
-    "language": "c++",
-    "name": "periodic_update_test",
-    "platforms": [
-      "linux",
-      "mac",
-      "posix",
-      "windows"
-    ],
-    "uses_polling": false
-  },
   {
     "args": [],
     "benchmark": false,
@@ -5787,30 +5741,6 @@
     ],
     "uses_polling": true
   },
-  {
-    "args": [],
-    "benchmark": false,
-    "ci_platforms": [
-      "linux",
-      "mac",
-      "posix",
-      "windows"
-    ],
-    "cpu_cost": 1.0,
-    "exclude_configs": [],
-    "exclude_iomgrs": [],
-    "flaky": false,
-    "gtest": true,
-    "language": "c++",
-    "name": "secure_endpoint_test",
-    "platforms": [
-      "linux",
-      "mac",
-      "posix",
-      "windows"
-    ],
-    "uses_polling": true
-  },
   {
     "args": [],
     "benchmark": false,
@@ -7489,30 +7419,6 @@
     ],
     "uses_polling": false
   },
-  {
-    "args": [],
-    "benchmark": false,
-    "ci_platforms": [
-      "linux",
-      "mac",
-      "posix",
-      "windows"
-    ],
-    "cpu_cost": 1.0,
-    "exclude_configs": [],
-    "exclude_iomgrs": [],
-    "flaky": false,
-    "gtest": true,
-    "language": "c++",
-    "name": "timer_test",
-    "platforms": [
-      "linux",
-      "mac",
-      "posix",
-      "windows"
-    ],
-    "uses_polling": true
-  },
   {
     "args": [],
     "benchmark": false,
@@ -7585,30 +7491,6 @@
     ],
     "uses_polling": true
   },
-  {
-    "args": [],
-    "benchmark": false,
-    "ci_platforms": [
-      "linux",
-      "mac",
-      "posix",
-      "windows"
-    ],
-    "cpu_cost": 1.0,
-    "exclude_configs": [],
-    "exclude_iomgrs": [],
-    "flaky": false,
-    "gtest": true,
-    "language": "c++",
-    "name": "too_many_pings_test",
-    "platforms": [
-      "linux",
-      "mac",
-      "posix",
-      "windows"
-    ],
-    "uses_polling": true
-  },
   {
     "args": [],
     "benchmark": false,
@@ -8059,28 +7941,6 @@
     ],
     "uses_polling": true
   },
-  {
-    "args": [],
-    "benchmark": false,
-    "ci_platforms": [
-      "linux",
-      "mac",
-      "posix"
-    ],
-    "cpu_cost": 1.0,
-    "exclude_configs": [],
-    "exclude_iomgrs": [],
-    "flaky": false,
-    "gtest": true,
-    "language": "c++",
-    "name": "work_serializer_test",
-    "platforms": [
-      "linux",
-      "mac",
-      "posix"
-    ],
-    "uses_polling": true
-  },
   {
     "args": [],
     "benchmark": false,
@@ -8175,50 +8035,6 @@
     ],
     "uses_polling": false
   },
-  {
-    "args": [],
-    "benchmark": false,
-    "ci_platforms": [
-      "linux",
-      "mac",
-      "posix"
-    ],
-    "cpu_cost": 1.0,
-    "exclude_configs": [],
-    "exclude_iomgrs": [],
-    "flaky": false,
-    "gtest": true,
-    "language": "c++",
-    "name": "xds_cluster_type_end2end_test",
-    "platforms": [
-      "linux",
-      "mac",
-      "posix"
-    ],
-    "uses_polling": true
-  },
-  {
-    "args": [],
-    "benchmark": false,
-    "ci_platforms": [
-      "linux",
-      "mac",
-      "posix"
-    ],
-    "cpu_cost": 1.0,
-    "exclude_configs": [],
-    "exclude_iomgrs": [],
-    "flaky": false,
-    "gtest": true,
-    "language": "c++",
-    "name": "xds_core_end2end_test",
-    "platforms": [
-      "linux",
-      "mac",
-      "posix"
-    ],
-    "uses_polling": true
-  },
   {
     "args": [],
     "benchmark": false,
@@ -8289,28 +8105,6 @@
     ],
     "uses_polling": true
   },
-  {
-    "args": [],
-    "benchmark": false,
-    "ci_platforms": [
-      "linux",
-      "mac",
-      "posix"
-    ],
-    "cpu_cost": 1.0,
-    "exclude_configs": [],
-    "exclude_iomgrs": [],
-    "flaky": false,
-    "gtest": true,
-    "language": "c++",
-    "name": "xds_end2end_test",
-    "platforms": [
-      "linux",
-      "mac",
-      "posix"
-    ],
-    "uses_polling": true
-  },
   {
     "args": [],
     "benchmark": false,
@@ -8335,28 +8129,6 @@
     ],
     "uses_polling": false
   },
-  {
-    "args": [],
-    "benchmark": false,
-    "ci_platforms": [
-      "linux",
-      "mac",
-      "posix"
-    ],
-    "cpu_cost": 1.0,
-    "exclude_configs": [],
-    "exclude_iomgrs": [],
-    "flaky": false,
-    "gtest": true,
-    "language": "c++",
-    "name": "xds_fault_injection_end2end_test",
-    "platforms": [
-      "linux",
-      "mac",
-      "posix"
-    ],
-    "uses_polling": true
-  },
   {
     "args": [],
     "benchmark": false,
@@ -8381,50 +8153,6 @@
     ],
     "uses_polling": false
   },
-  {
-    "args": [],
-    "benchmark": false,
-    "ci_platforms": [
-      "linux",
-      "mac",
-      "posix"
-    ],
-    "cpu_cost": 1.0,
-    "exclude_configs": [],
-    "exclude_iomgrs": [],
-    "flaky": false,
-    "gtest": true,
-    "language": "c++",
-    "name": "xds_outlier_detection_end2end_test",
-    "platforms": [
-      "linux",
-      "mac",
-      "posix"
-    ],
-    "uses_polling": true
-  },
-  {
-    "args": [],
-    "benchmark": false,
-    "ci_platforms": [
-      "linux",
-      "mac",
-      "posix"
-    ],
-    "cpu_cost": 1.0,
-    "exclude_configs": [],
-    "exclude_iomgrs": [],
-    "flaky": false,
-    "gtest": true,
-    "language": "c++",
-    "name": "xds_ring_hash_end2end_test",
-    "platforms": [
-      "linux",
-      "mac",
-      "posix"
-    ],
-    "uses_polling": true
-  },
   {
     "args": [],
     "benchmark": false,
@@ -8447,28 +8175,6 @@
     ],
     "uses_polling": true
   },
-  {
-    "args": [],
-    "benchmark": false,
-    "ci_platforms": [
-      "linux",
-      "mac",
-      "posix"
-    ],
-    "cpu_cost": 1.0,
-    "exclude_configs": [],
-    "exclude_iomgrs": [],
-    "flaky": false,
-    "gtest": true,
-    "language": "c++",
-    "name": "xds_routing_end2end_test",
-    "platforms": [
-      "linux",
-      "mac",
-      "posix"
-    ],
-    "uses_polling": true
-  },
   {
     "args": [],
     "boringssl": true,