From a0fc3a8dda29873d6b11008fd10156ac4867f39a Mon Sep 17 00:00:00 2001 From: Jan Tattermusch Date: Wed, 24 Feb 2021 20:05:49 +0100 Subject: [PATCH] Update PHP's grpc_php_plugin instructions (#25544) See https://github.com/grpc/grpc/issues/25350. (This also needs to be fixed in grpc.io) --- src/php/README.md | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/src/php/README.md b/src/php/README.md index 6a3858f503d..7c0aac9e3ad 100644 --- a/src/php/README.md +++ b/src/php/README.md @@ -161,21 +161,22 @@ You need the `grpc_php_plugin` to generate the PHP client stub classes. This plugin works with the main `protoc` binary to generate classes that you can import into your project. -It should already been compiled when you run `make` from the root directory -of this repo. The plugin can be found in the `bins/opt` directory. We are -planning to provide a better way to download and install the plugin -in the future. - -You can also just build the `grpc_php_plugin` by running: +You can build `grpc_php_plugin` with `cmake`: ```sh $ git clone -b RELEASE_TAG_HERE https://github.com/grpc/grpc $ cd grpc $ git submodule update --init -$ make grpc_php_plugin +$ mkdir -p cmake/build +$ cd cmake/build +$ cmake ../.. +$ make protoc grpc_php_plugin ``` -Alternatively, you can also build the `grpc_php_plugin` with `bazel` now: +The commands above will make `protoc` and `grpc_php_plugin` available +in `cmake/build/third_party/protobuf/protoc` and `cmake/build/grpc_php_plugin`. + +Alternatively, you can also build the `grpc_php_plugin` with `bazel`: ```sh $ bazel build @com_google_protobuf//:protoc