GCP Observability: Fix view names for started and completed rpcs (#31898)

pull/31899/head
Yash Tibrewal 2 years ago committed by GitHub
parent efdae293fb
commit a0f00f0956
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 6
      include/grpcpp/opencensus.h
  2. 44
      src/cpp/ext/filters/census/views.cc
  3. 8
      src/cpp/ext/gcp/observability.cc

@ -74,6 +74,12 @@ extern const absl::string_view kRpcServerServerLatencyMeasureName;
extern const absl::string_view kRpcServerStartedRpcsMeasureName; extern const absl::string_view kRpcServerStartedRpcsMeasureName;
// Canonical gRPC view definitions. // Canonical gRPC view definitions.
const ::opencensus::stats::ViewDescriptor& ClientStartedRpcs();
const ::opencensus::stats::ViewDescriptor& ClientCompletedRpcs();
const ::opencensus::stats::ViewDescriptor& ServerStartedRpcs();
const ::opencensus::stats::ViewDescriptor& ServerCompletedRpcs();
const ::opencensus::stats::ViewDescriptor& ClientSentMessagesPerRpcCumulative(); const ::opencensus::stats::ViewDescriptor& ClientSentMessagesPerRpcCumulative();
const ::opencensus::stats::ViewDescriptor& ClientSentBytesPerRpcCumulative(); const ::opencensus::stats::ViewDescriptor& ClientSentBytesPerRpcCumulative();
const ::opencensus::stats::ViewDescriptor& const ::opencensus::stats::ViewDescriptor&

@ -88,6 +88,50 @@ void RegisterOpenCensusViewsForExport() {
namespace experimental { namespace experimental {
// client
const ViewDescriptor& ClientStartedRpcs() {
const static ViewDescriptor descriptor =
ViewDescriptor()
.set_name("grpc.io/client/started_rpcs")
.set_measure(kRpcClientStartedRpcsMeasureName)
.set_aggregation(Aggregation::Count())
.add_column(ClientMethodTagKey());
return descriptor;
}
const ViewDescriptor& ClientCompletedRpcs() {
const static ViewDescriptor descriptor =
ViewDescriptor()
.set_name("grpc.io/client/completed_rpcs")
.set_measure(kRpcClientRoundtripLatencyMeasureName)
.set_aggregation(Aggregation::Count())
.add_column(ClientMethodTagKey())
.add_column(ClientStatusTagKey());
return descriptor;
}
// server
const ViewDescriptor& ServerStartedRpcs() {
const static ViewDescriptor descriptor =
ViewDescriptor()
.set_name("grpc.io/server/started_rpcs")
.set_measure(kRpcServerStartedRpcsMeasureName)
.set_aggregation(Aggregation::Count())
.add_column(ServerMethodTagKey());
return descriptor;
}
const ViewDescriptor& ServerCompletedRpcs() {
const static ViewDescriptor descriptor =
ViewDescriptor()
.set_name("grpc.io/server/completed_rpcs")
.set_measure(kRpcServerServerLatencyMeasureName)
.set_aggregation(Aggregation::Count())
.add_column(ServerMethodTagKey())
.add_column(ServerStatusTagKey());
return descriptor;
}
// client cumulative // client cumulative
const ViewDescriptor& ClientSentBytesPerRpcCumulative() { const ViewDescriptor& ClientSentBytesPerRpcCumulative() {
const static ViewDescriptor descriptor = const static ViewDescriptor descriptor =

@ -59,11 +59,11 @@ constexpr char kGoogleStackdriverStatsAddress[] = "monitoring.googleapis.com";
void RegisterOpenCensusViewsForGcpObservability() { void RegisterOpenCensusViewsForGcpObservability() {
// Register client default views for GCP observability // Register client default views for GCP observability
ClientStartedRpcsCumulative().RegisterForExport(); ClientStartedRpcs().RegisterForExport();
ClientCompletedRpcsCumulative().RegisterForExport(); ClientCompletedRpcs().RegisterForExport();
// Register server default views for GCP observability // Register server default views for GCP observability
ServerStartedRpcsCumulative().RegisterForExport(); ServerStartedRpcs().RegisterForExport();
ServerCompletedRpcsCumulative().RegisterForExport(); ServerCompletedRpcs().RegisterForExport();
} }
} // namespace } // namespace

Loading…
Cancel
Save