don't hold unnecessary ref

src/core/lib/security/credentials/external/external_account_credentials.cc

@@ -135,13 +135,11 @@ void ExternalAccountCredentials::HttpFetchBody::OnHttpResponse(
 // 4. Finish token fetch - Return back the response that contains an access
 // token in FinishTokenFetch().
 ExternalAccountCredentials::ExternalFetchRequest::ExternalFetchRequest(
-    WeakRefCountedPtr<ExternalAccountCredentials> creds, Timestamp deadline,
+    ExternalAccountCredentials* creds, Timestamp deadline,
     absl::AnyInvocable<void(
         absl::StatusOr<RefCountedPtr<TokenFetcherCredentials::Token>>)>
         on_done)
-    : creds_(std::move(creds)),
+    : creds_(creds), deadline_(deadline), on_done_(std::move(on_done)) {
-      deadline_(deadline),
-      on_done_(std::move(on_done)) {
   fetch_body_ = creds_->RetrieveSubjectToken(
       deadline,
       [self = RefAsSubclass<ExternalFetchRequest>()](
@@ -631,9 +629,7 @@ ExternalAccountCredentials::FetchToken(
     absl::AnyInvocable<void(absl::StatusOr<RefCountedPtr<Token>>)>
         on_done) {
   return MakeOrphanable<ExternalFetchRequest>(
-// FIXME: does not need to hold a ref, since on_done is holding one
+      this, deadline, std::move(on_done));
-      WeakRefAsSubclass<ExternalAccountCredentials>(), deadline,
-      std::move(on_done));
 }
 
 }  // namespace grpc_core

src/core/lib/security/credentials/external/external_account_credentials.h

@@ -144,8 +144,7 @@ class ExternalAccountCredentials : public TokenFetcherCredentials {
   class ExternalFetchRequest : public FetchRequest {
    public:
     ExternalFetchRequest(
-        WeakRefCountedPtr<ExternalAccountCredentials> creds,
+        ExternalAccountCredentials* creds, Timestamp deadline,
-        Timestamp deadline,
         absl::AnyInvocable<void(
             absl::StatusOr<RefCountedPtr<TokenFetcherCredentials::Token>>)>
             on_done);
@@ -171,7 +170,7 @@ class ExternalAccountCredentials : public TokenFetcherCredentials {
     bool MaybeFailLocked(absl::Status status)
         ABSL_EXCLUSIVE_LOCKS_REQUIRED(&mu_);
 
-    WeakRefCountedPtr<ExternalAccountCredentials> creds_;
+    ExternalAccountCredentials* creds_;
     Timestamp deadline_;
     absl::AnyInvocable<
         void(absl::StatusOr<RefCountedPtr<TokenFetcherCredentials::Token>>)>