From 8f13439302b1b416f83c276e90e8de6cdf9bdec6 Mon Sep 17 00:00:00 2001 From: Adam Date: Mon, 24 Jul 2017 22:43:38 +0200 Subject: [PATCH 1/2] Fix issue from google/protobuf#1745 - javascript allow dot in filename --- src/compiler/node_generator.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/src/compiler/node_generator.cc b/src/compiler/node_generator.cc index 249ba086a57..355c11fcfcb 100644 --- a/src/compiler/node_generator.cc +++ b/src/compiler/node_generator.cc @@ -47,6 +47,7 @@ grpc::string ModuleAlias(const grpc::string filename) { grpc::string basename = grpc_generator::StripProto(filename); basename = grpc_generator::StringReplace(basename, "-", "$"); basename = grpc_generator::StringReplace(basename, "/", "_"); + basename = grpc_generator::StringReplace(basename, “.”, "_"); return basename + "_pb"; } From a178f406627916547037b63eb036f32d5db7c6d7 Mon Sep 17 00:00:00 2001 From: Adam Date: Mon, 24 Jul 2017 23:01:14 +0200 Subject: [PATCH 2/2] Fix quotation marks --- src/compiler/node_generator.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/node_generator.cc b/src/compiler/node_generator.cc index 355c11fcfcb..c0fef9128f1 100644 --- a/src/compiler/node_generator.cc +++ b/src/compiler/node_generator.cc @@ -47,7 +47,7 @@ grpc::string ModuleAlias(const grpc::string filename) { grpc::string basename = grpc_generator::StripProto(filename); basename = grpc_generator::StringReplace(basename, "-", "$"); basename = grpc_generator::StringReplace(basename, "/", "_"); - basename = grpc_generator::StringReplace(basename, “.”, "_"); + basename = grpc_generator::StringReplace(basename, ".", "_"); return basename + "_pb"; }