Merge branch 'master' of github.com:grpc/grpc into the-ultimate-showdown

Conflicts:
	src/node/ext/call.cc
	src/node/ext/channel.cc
pull/2612/head
Nicolas "Pixel" Noble 9 years ago
commit 9b6248fc6d
  1. 125
      src/csharp/Grpc.Auth/GoogleCredential.cs
  2. 27
      src/csharp/Grpc.Auth/Grpc.Auth.csproj
  3. 24
      src/csharp/Grpc.Auth/OAuth2Interceptors.cs
  4. 4
      src/csharp/Grpc.Auth/app.config
  5. 4
      src/csharp/Grpc.Auth/packages.config
  6. 6
      src/csharp/Grpc.Core.Tests/ChannelOptionsTest.cs
  7. 6
      src/csharp/Grpc.Core.Tests/ChannelTest.cs
  8. 6
      src/csharp/Grpc.Core.Tests/ClientServerTest.cs
  9. 4
      src/csharp/Grpc.Core.Tests/CompressionTest.cs
  10. 31
      src/csharp/Grpc.Core.Tests/ContextPropagationTest.cs
  11. 12
      src/csharp/Grpc.Core.Tests/MockServiceHelper.cs
  12. 4
      src/csharp/Grpc.Core.Tests/ResponseHeadersTest.cs
  13. 72
      src/csharp/Grpc.Core/CallInvocationDetails.cs
  14. 86
      src/csharp/Grpc.Core/CallOptions.cs
  15. 46
      src/csharp/Grpc.Core/Calls.cs
  16. 24
      src/csharp/Grpc.Core/Channel.cs
  17. 6
      src/csharp/Grpc.Core/ChannelOptions.cs
  18. 29
      src/csharp/Grpc.Core/ClientBase.cs
  19. 58
      src/csharp/Grpc.Core/ContextPropagationToken.cs
  20. 1
      src/csharp/Grpc.Core/Grpc.Core.csproj
  21. 20
      src/csharp/Grpc.Core/GrpcEnvironment.cs
  22. 17
      src/csharp/Grpc.Core/Internal/AsyncCall.cs
  23. 2
      src/csharp/Grpc.Core/Internal/Timespec.cs
  24. 4
      src/csharp/Grpc.Core/KeyCertificatePair.cs
  25. 11
      src/csharp/Grpc.Core/Logging/ConsoleLogger.cs
  26. 6
      src/csharp/Grpc.Core/Logging/ILogger.cs
  27. 23
      src/csharp/Grpc.Core/Marshaller.cs
  28. 8
      src/csharp/Grpc.Core/Metadata.cs
  29. 58
      src/csharp/Grpc.Core/Method.cs
  30. 14
      src/csharp/Grpc.Core/RpcException.cs
  31. 2
      src/csharp/Grpc.Core/Server.cs
  32. 2
      src/csharp/Grpc.Core/ServerCredentials.cs
  33. 4
      src/csharp/Grpc.Core/ServerMethods.cs
  34. 4
      src/csharp/Grpc.Core/ServerPort.cs
  35. 8
      src/csharp/Grpc.Core/ServerServiceDefinition.cs
  36. 13
      src/csharp/Grpc.Core/Status.cs
  37. 156
      src/csharp/Grpc.Core/StatusCode.cs
  38. 9
      src/csharp/Grpc.Core/Utils/AsyncStreamExtensions.cs
  39. 3
      src/csharp/Grpc.Core/Utils/BenchmarkUtil.cs
  40. 57
      src/csharp/Grpc.Core/Utils/ExceptionHelper.cs
  41. 25
      src/csharp/Grpc.Core/Utils/Preconditions.cs
  42. 34
      src/csharp/Grpc.Core/Version.cs
  43. 37
      src/csharp/Grpc.Core/VersionInfo.cs
  44. 10
      src/csharp/Grpc.Examples.Tests/MathClientServerTests.cs
  45. 10
      src/csharp/Grpc.Examples/MathExamples.cs
  46. 7
      src/csharp/Grpc.Examples/MathServiceImpl.cs
  47. 8
      src/csharp/Grpc.HealthCheck.Tests/HealthServiceImplTest.cs
  48. 4
      src/csharp/Grpc.IntegrationTesting.Client/app.config
  49. 4
      src/csharp/Grpc.IntegrationTesting.Server/app.config
  50. 38
      src/csharp/Grpc.IntegrationTesting/Grpc.IntegrationTesting.csproj
  51. 86
      src/csharp/Grpc.IntegrationTesting/InteropClient.cs
  52. 4
      src/csharp/Grpc.IntegrationTesting/TestServiceImpl.cs
  53. 4
      src/csharp/Grpc.IntegrationTesting/app.config
  54. 4
      src/csharp/Grpc.IntegrationTesting/packages.config
  55. 2
      src/node/examples/perf_test.js
  56. 17
      src/node/ext/call.cc
  57. 25
      src/node/ext/channel.cc
  58. 6
      src/node/ext/channel.h
  59. 11
      src/node/interop/interop_client.js
  60. 59
      src/node/src/client.js
  61. 5
      src/node/test/call_test.js
  62. 8
      src/node/test/end_to_end_test.js
  63. 2
      src/python/grpcio/grpc/_adapter/_c/types/server.c
  64. 5
      src/ruby/ext/grpc/rb_channel.c
  65. 2
      src/ruby/lib/grpc/generic/client_stub.rb
  66. 2
      src/ruby/spec/call_spec.rb
  67. 4
      src/ruby/spec/channel_spec.rb
  68. 2
      src/ruby/spec/client_server_spec.rb
  69. 2
      src/ruby/spec/generic/active_call_spec.rb
  70. 2
      test/core/security/verify_jwt.c
  71. 2
      test/cpp/end2end/end2end_test.cc

@ -1,125 +0,0 @@
#region Copyright notice and license
// Copyright 2015, Google Inc.
// All rights reserved.
//
// Redistribution and use in source and binary forms, with or without
// modification, are permitted provided that the following conditions are
// met:
//
// * Redistributions of source code must retain the above copyright
// notice, this list of conditions and the following disclaimer.
// * Redistributions in binary form must reproduce the above
// copyright notice, this list of conditions and the following disclaimer
// in the documentation and/or other materials provided with the
// distribution.
// * Neither the name of Google Inc. nor the names of its
// contributors may be used to endorse or promote products derived from
// this software without specific prior written permission.
//
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
#endregion
using System;
using System.Collections.Generic;
using System.IO;
using System.Security.Cryptography;
using System.Threading;
using System.Threading.Tasks;
using Google.Apis.Auth.OAuth2;
using Google.Apis.Auth.OAuth2.Responses;
using Newtonsoft.Json.Linq;
using Org.BouncyCastle.Crypto.Parameters;
using Org.BouncyCastle.Security;
namespace Grpc.Auth
{
// TODO(jtattermusch): Remove this class once possible.
/// <summary>
/// A temporary placeholder for Google credential from
/// Google Auth library for .NET. It emulates the usage pattern
/// for Usable auth.
/// </summary>
public class GoogleCredential
{
private const string GoogleApplicationCredentialsEnvName = "GOOGLE_APPLICATION_CREDENTIALS";
private const string ClientEmailFieldName = "client_email";
private const string PrivateKeyFieldName = "private_key";
private ServiceCredential credential;
private GoogleCredential(ServiceCredential credential)
{
this.credential = credential;
}
public static GoogleCredential GetApplicationDefault()
{
return new GoogleCredential(null);
}
public bool IsCreateScopedRequired
{
get
{
return true;
}
}
public GoogleCredential CreateScoped(IEnumerable<string> scopes)
{
var credsPath = Environment.GetEnvironmentVariable(GoogleApplicationCredentialsEnvName);
if (credsPath == null)
{
// Default to ComputeCredentials if path to JSON key is not set.
// ComputeCredential is not scoped actually, but for our use case it's
// fine to treat is as such.
return new GoogleCredential(new ComputeCredential(new ComputeCredential.Initializer()));
}
JObject jsonCredentialParameters = JObject.Parse(File.ReadAllText(credsPath));
string clientEmail = jsonCredentialParameters.GetValue(ClientEmailFieldName).Value<string>();
string privateKeyString = jsonCredentialParameters.GetValue(PrivateKeyFieldName).Value<string>();
var serviceCredential = new ServiceAccountCredential(
new ServiceAccountCredential.Initializer(clientEmail)
{
Scopes = scopes,
}.FromPrivateKey(privateKeyString));
return new GoogleCredential(serviceCredential);
}
public Task<bool> RequestAccessTokenAsync(CancellationToken taskCancellationToken)
{
return credential.RequestAccessTokenAsync(taskCancellationToken);
}
public TokenResponse Token
{
get
{
return credential.Token;
}
}
internal ServiceCredential InternalCredential
{
get
{
return credential;
}
}
}
}

@ -11,7 +11,7 @@
<AssemblyName>Grpc.Auth</AssemblyName> <AssemblyName>Grpc.Auth</AssemblyName>
<TargetFrameworkVersion>v4.5</TargetFrameworkVersion> <TargetFrameworkVersion>v4.5</TargetFrameworkVersion>
<DocumentationFile>bin\$(Configuration)\Grpc.Auth.Xml</DocumentationFile> <DocumentationFile>bin\$(Configuration)\Grpc.Auth.Xml</DocumentationFile>
<NuGetPackageImportStamp>9b408026</NuGetPackageImportStamp> <NuGetPackageImportStamp>4f8487a9</NuGetPackageImportStamp>
</PropertyGroup> </PropertyGroup>
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' "> <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
<DebugSymbols>true</DebugSymbols> <DebugSymbols>true</DebugSymbols>
@ -41,28 +41,32 @@
<AssemblyOriginatorKeyFile>C:\keys\Grpc.snk</AssemblyOriginatorKeyFile> <AssemblyOriginatorKeyFile>C:\keys\Grpc.snk</AssemblyOriginatorKeyFile>
</PropertyGroup> </PropertyGroup>
<ItemGroup> <ItemGroup>
<Reference Include="BouncyCastle.Crypto"> <Reference Include="BouncyCastle.Crypto, Version=1.7.4137.9688, Culture=neutral, PublicKeyToken=a4292a325f69b123, processorArchitecture=MSIL">
<SpecificVersion>False</SpecificVersion>
<HintPath>..\packages\BouncyCastle.1.7.0\lib\Net40-Client\BouncyCastle.Crypto.dll</HintPath> <HintPath>..\packages\BouncyCastle.1.7.0\lib\Net40-Client\BouncyCastle.Crypto.dll</HintPath>
</Reference> </Reference>
<Reference Include="Google.Apis.Auth, Version=1.9.2.27817, Culture=neutral, PublicKeyToken=4b01fa6e34db77ab, processorArchitecture=MSIL"> <Reference Include="Google.Apis.Auth, Version=1.9.3.19379, Culture=neutral, PublicKeyToken=4b01fa6e34db77ab, processorArchitecture=MSIL">
<SpecificVersion>False</SpecificVersion> <SpecificVersion>False</SpecificVersion>
<HintPath>..\packages\Google.Apis.Auth.1.9.2\lib\net40\Google.Apis.Auth.dll</HintPath> <HintPath>..\packages\Google.Apis.Auth.1.9.3\lib\net40\Google.Apis.Auth.dll</HintPath>
</Reference> </Reference>
<Reference Include="Google.Apis.Auth.PlatformServices, Version=1.9.2.27820, Culture=neutral, PublicKeyToken=4b01fa6e34db77ab, processorArchitecture=MSIL"> <Reference Include="Google.Apis.Auth.PlatformServices, Version=1.9.3.19383, Culture=neutral, PublicKeyToken=4b01fa6e34db77ab, processorArchitecture=MSIL">
<SpecificVersion>False</SpecificVersion> <SpecificVersion>False</SpecificVersion>
<HintPath>..\packages\Google.Apis.Auth.1.9.2\lib\net40\Google.Apis.Auth.PlatformServices.dll</HintPath> <HintPath>..\packages\Google.Apis.Auth.1.9.3\lib\net40\Google.Apis.Auth.PlatformServices.dll</HintPath>
</Reference> </Reference>
<Reference Include="Google.Apis.Core, Version=1.9.2.27816, Culture=neutral, PublicKeyToken=4b01fa6e34db77ab, processorArchitecture=MSIL"> <Reference Include="Google.Apis.Core, Version=1.9.3.19379, Culture=neutral, PublicKeyToken=4b01fa6e34db77ab, processorArchitecture=MSIL">
<SpecificVersion>False</SpecificVersion> <SpecificVersion>False</SpecificVersion>
<HintPath>..\packages\Google.Apis.Core.1.9.2\lib\portable-net40+sl50+win+wpa81+wp80\Google.Apis.Core.dll</HintPath> <HintPath>..\packages\Google.Apis.Core.1.9.3\lib\portable-net40+sl50+win+wpa81+wp80\Google.Apis.Core.dll</HintPath>
</Reference> </Reference>
<Reference Include="Microsoft.Threading.Tasks"> <Reference Include="Microsoft.Threading.Tasks, Version=1.0.12.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL">
<SpecificVersion>False</SpecificVersion>
<HintPath>..\packages\Microsoft.Bcl.Async.1.0.168\lib\net40\Microsoft.Threading.Tasks.dll</HintPath> <HintPath>..\packages\Microsoft.Bcl.Async.1.0.168\lib\net40\Microsoft.Threading.Tasks.dll</HintPath>
</Reference> </Reference>
<Reference Include="Microsoft.Threading.Tasks.Extensions"> <Reference Include="Microsoft.Threading.Tasks.Extensions, Version=1.0.12.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL">
<SpecificVersion>False</SpecificVersion>
<HintPath>..\packages\Microsoft.Bcl.Async.1.0.168\lib\net40\Microsoft.Threading.Tasks.Extensions.dll</HintPath> <HintPath>..\packages\Microsoft.Bcl.Async.1.0.168\lib\net40\Microsoft.Threading.Tasks.Extensions.dll</HintPath>
</Reference> </Reference>
<Reference Include="Microsoft.Threading.Tasks.Extensions.Desktop"> <Reference Include="Microsoft.Threading.Tasks.Extensions.Desktop, Version=1.0.168.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL">
<SpecificVersion>False</SpecificVersion>
<HintPath>..\packages\Microsoft.Bcl.Async.1.0.168\lib\net40\Microsoft.Threading.Tasks.Extensions.Desktop.dll</HintPath> <HintPath>..\packages\Microsoft.Bcl.Async.1.0.168\lib\net40\Microsoft.Threading.Tasks.Extensions.Desktop.dll</HintPath>
</Reference> </Reference>
<Reference Include="Newtonsoft.Json, Version=7.0.0.0, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed, processorArchitecture=MSIL"> <Reference Include="Newtonsoft.Json, Version=7.0.0.0, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed, processorArchitecture=MSIL">
@ -87,7 +91,6 @@
<Link>Version.cs</Link> <Link>Version.cs</Link>
</Compile> </Compile>
<Compile Include="Properties\AssemblyInfo.cs" /> <Compile Include="Properties\AssemblyInfo.cs" />
<Compile Include="GoogleCredential.cs" />
<Compile Include="OAuth2Interceptors.cs" /> <Compile Include="OAuth2Interceptors.cs" />
</ItemGroup> </ItemGroup>
<Import Project="$(MSBuildBinPath)\Microsoft.CSharp.targets" /> <Import Project="$(MSBuildBinPath)\Microsoft.CSharp.targets" />

@ -54,7 +54,7 @@ namespace Grpc.Auth
/// </summary> /// </summary>
public static MetadataInterceptorDelegate FromCredential(GoogleCredential googleCredential) public static MetadataInterceptorDelegate FromCredential(GoogleCredential googleCredential)
{ {
var interceptor = new OAuth2Interceptor(googleCredential.InternalCredential, SystemClock.Default); var interceptor = new OAuth2Interceptor(googleCredential, SystemClock.Default);
return new MetadataInterceptorDelegate(interceptor.InterceptHeaders); return new MetadataInterceptorDelegate(interceptor.InterceptHeaders);
} }
@ -66,7 +66,7 @@ namespace Grpc.Auth
public static MetadataInterceptorDelegate FromAccessToken(string oauth2Token) public static MetadataInterceptorDelegate FromAccessToken(string oauth2Token)
{ {
Preconditions.CheckNotNull(oauth2Token); Preconditions.CheckNotNull(oauth2Token);
return new MetadataInterceptorDelegate((metadata) => return new MetadataInterceptorDelegate((authUri, metadata) =>
{ {
metadata.Add(OAuth2Interceptor.CreateBearerTokenHeader(oauth2Token)); metadata.Add(OAuth2Interceptor.CreateBearerTokenHeader(oauth2Token));
}); });
@ -80,10 +80,10 @@ namespace Grpc.Auth
private const string AuthorizationHeader = "Authorization"; private const string AuthorizationHeader = "Authorization";
private const string Schema = "Bearer"; private const string Schema = "Bearer";
private ServiceCredential credential; private ITokenAccess credential;
private IClock clock; private IClock clock;
public OAuth2Interceptor(ServiceCredential credential, IClock clock) public OAuth2Interceptor(ITokenAccess credential, IClock clock)
{ {
this.credential = credential; this.credential = credential;
this.clock = clock; this.clock = clock;
@ -94,23 +94,15 @@ namespace Grpc.Auth
/// </summary> /// </summary>
/// <param name="cancellationToken"></param> /// <param name="cancellationToken"></param>
/// <returns></returns> /// <returns></returns>
public string GetAccessToken(CancellationToken cancellationToken) public string GetAccessToken(string authUri, CancellationToken cancellationToken)
{ {
if (credential.Token == null || credential.Token.IsExpired(clock))
{
// TODO(jtattermusch): Parallel requests will spawn multiple requests to refresh the token once the token expires.
// TODO(jtattermusch): Rethink synchronous wait to obtain the result. // TODO(jtattermusch): Rethink synchronous wait to obtain the result.
if (!credential.RequestAccessTokenAsync(cancellationToken).Result) return credential.GetAccessTokenForRequestAsync(authUri, cancellationToken: cancellationToken).GetAwaiter().GetResult();
{
throw new InvalidOperationException("The access token has expired but we can't refresh it");
}
}
return credential.Token.AccessToken;
} }
public void InterceptHeaders(Metadata metadata) public void InterceptHeaders(string authUri, Metadata metadata)
{ {
var accessToken = GetAccessToken(CancellationToken.None); var accessToken = GetAccessToken(authUri, CancellationToken.None);
metadata.Add(CreateBearerTokenHeader(accessToken)); metadata.Add(CreateBearerTokenHeader(accessToken));
} }

@ -10,6 +10,10 @@
<assemblyIdentity name="System.Net.Http" publicKeyToken="b03f5f7f11d50a3a" culture="neutral" /> <assemblyIdentity name="System.Net.Http" publicKeyToken="b03f5f7f11d50a3a" culture="neutral" />
<bindingRedirect oldVersion="0.0.0.0-4.2.28.0" newVersion="4.0.0.0" /> <bindingRedirect oldVersion="0.0.0.0-4.2.28.0" newVersion="4.0.0.0" />
</dependentAssembly> </dependentAssembly>
<dependentAssembly>
<assemblyIdentity name="Google.Apis.Core" publicKeyToken="4b01fa6e34db77ab" culture="neutral" />
<bindingRedirect oldVersion="0.0.0.0-1.9.2.38523" newVersion="1.9.2.38523" />
</dependentAssembly>
</assemblyBinding> </assemblyBinding>
</runtime> </runtime>
</configuration> </configuration>

@ -1,8 +1,8 @@
<?xml version="1.0" encoding="utf-8"?> <?xml version="1.0" encoding="utf-8"?>
<packages> <packages>
<package id="BouncyCastle" version="1.7.0" targetFramework="net45" /> <package id="BouncyCastle" version="1.7.0" targetFramework="net45" />
<package id="Google.Apis.Auth" version="1.9.2" targetFramework="net45" /> <package id="Google.Apis.Auth" version="1.9.3" targetFramework="net45" />
<package id="Google.Apis.Core" version="1.9.2" targetFramework="net45" /> <package id="Google.Apis.Core" version="1.9.3" targetFramework="net45" />
<package id="Microsoft.Bcl" version="1.1.10" targetFramework="net45" /> <package id="Microsoft.Bcl" version="1.1.10" targetFramework="net45" />
<package id="Microsoft.Bcl.Async" version="1.0.168" targetFramework="net45" /> <package id="Microsoft.Bcl.Async" version="1.0.168" targetFramework="net45" />
<package id="Microsoft.Bcl.Build" version="1.0.21" targetFramework="net45" /> <package id="Microsoft.Bcl.Build" version="1.0.21" targetFramework="net45" />

@ -67,9 +67,9 @@ namespace Grpc.Core.Internal.Tests
[Test] [Test]
public void ConstructorPreconditions() public void ConstructorPreconditions()
{ {
Assert.Throws(typeof(NullReferenceException), () => { new ChannelOption(null, "abc"); }); Assert.Throws(typeof(ArgumentNullException), () => { new ChannelOption(null, "abc"); });
Assert.Throws(typeof(NullReferenceException), () => { new ChannelOption(null, 1); }); Assert.Throws(typeof(ArgumentNullException), () => { new ChannelOption(null, 1); });
Assert.Throws(typeof(NullReferenceException), () => { new ChannelOption("abc", null); }); Assert.Throws(typeof(ArgumentNullException), () => { new ChannelOption("abc", null); });
} }
[Test] [Test]

@ -50,7 +50,7 @@ namespace Grpc.Core.Tests
[Test] [Test]
public void Constructor_RejectsInvalidParams() public void Constructor_RejectsInvalidParams()
{ {
Assert.Throws(typeof(NullReferenceException), () => new Channel(null, Credentials.Insecure)); Assert.Throws(typeof(ArgumentNullException), () => new Channel(null, Credentials.Insecure));
} }
[Test] [Test]
@ -72,11 +72,11 @@ namespace Grpc.Core.Tests
} }
[Test] [Test]
public void Target() public void ResolvedTarget()
{ {
using (var channel = new Channel("127.0.0.1", Credentials.Insecure)) using (var channel = new Channel("127.0.0.1", Credentials.Insecure))
{ {
Assert.IsTrue(channel.Target.Contains("127.0.0.1")); Assert.IsTrue(channel.ResolvedTarget.Contains("127.0.0.1"));
} }
} }

@ -138,7 +138,7 @@ namespace Grpc.Core.Tests
helper.ClientStreamingHandler = new ClientStreamingServerMethod<string, string>(async (requestStream, context) => helper.ClientStreamingHandler = new ClientStreamingServerMethod<string, string>(async (requestStream, context) =>
{ {
string result = ""; string result = "";
await requestStream.ForEach(async (request) => await requestStream.ForEachAsync(async (request) =>
{ {
result += request; result += request;
}); });
@ -147,7 +147,7 @@ namespace Grpc.Core.Tests
}); });
var call = Calls.AsyncClientStreamingCall(helper.CreateClientStreamingCall()); var call = Calls.AsyncClientStreamingCall(helper.CreateClientStreamingCall());
await call.RequestStream.WriteAll(new string[] { "A", "B", "C" }); await call.RequestStream.WriteAllAsync(new string[] { "A", "B", "C" });
Assert.AreEqual("ABC", await call.ResponseAsync); Assert.AreEqual("ABC", await call.ResponseAsync);
} }
@ -159,7 +159,7 @@ namespace Grpc.Core.Tests
helper.ClientStreamingHandler = new ClientStreamingServerMethod<string, string>(async (requestStream, context) => helper.ClientStreamingHandler = new ClientStreamingServerMethod<string, string>(async (requestStream, context) =>
{ {
barrier.SetResult(null); barrier.SetResult(null);
await requestStream.ToList(); await requestStream.ToListAsync();
return ""; return "";
}); });

@ -90,7 +90,7 @@ namespace Grpc.Core.Tests
{ {
helper.DuplexStreamingHandler = new DuplexStreamingServerMethod<string, string>(async (requestStream, responseStream, context) => helper.DuplexStreamingHandler = new DuplexStreamingServerMethod<string, string>(async (requestStream, responseStream, context) =>
{ {
await requestStream.ToList(); await requestStream.ToListAsync();
context.WriteOptions = new WriteOptions(WriteFlags.NoCompress); context.WriteOptions = new WriteOptions(WriteFlags.NoCompress);
@ -122,7 +122,7 @@ namespace Grpc.Core.Tests
await call.RequestStream.CompleteAsync(); await call.RequestStream.CompleteAsync();
await call.ResponseStream.ToList(); await call.ResponseStream.ToListAsync();
} }
} }
} }

@ -110,6 +110,14 @@ namespace Grpc.Core.Tests
helper.ClientStreamingHandler = new ClientStreamingServerMethod<string, string>(async (requestStream, context) => helper.ClientStreamingHandler = new ClientStreamingServerMethod<string, string>(async (requestStream, context) =>
{ {
Assert.Throws(typeof(ArgumentException), () =>
{
// Trying to override deadline while propagating deadline from parent call will throw.
Calls.BlockingUnaryCall(helper.CreateUnaryCall(
new CallOptions(deadline: DateTime.UtcNow.AddDays(8),
propagationToken: context.CreatePropagationToken())), "");
});
var callOptions = new CallOptions(propagationToken: context.CreatePropagationToken()); var callOptions = new CallOptions(propagationToken: context.CreatePropagationToken());
return await Calls.AsyncUnaryCall(helper.CreateUnaryCall(callOptions), "xyz"); return await Calls.AsyncUnaryCall(helper.CreateUnaryCall(callOptions), "xyz");
}); });
@ -118,5 +126,28 @@ namespace Grpc.Core.Tests
await call.RequestStream.CompleteAsync(); await call.RequestStream.CompleteAsync();
Assert.AreEqual("PASS", await call); Assert.AreEqual("PASS", await call);
} }
[Test]
public async Task SuppressDeadlinePropagation()
{
helper.UnaryHandler = new UnaryServerMethod<string, string>(async (request, context) =>
{
Assert.AreEqual(DateTime.MaxValue, context.Deadline);
return "PASS";
});
helper.ClientStreamingHandler = new ClientStreamingServerMethod<string, string>(async (requestStream, context) =>
{
Assert.IsTrue(context.CancellationToken.CanBeCanceled);
var callOptions = new CallOptions(propagationToken: context.CreatePropagationToken(new ContextPropagationOptions(propagateDeadline: false)));
return await Calls.AsyncUnaryCall(helper.CreateUnaryCall(callOptions), "xyz");
});
var cts = new CancellationTokenSource();
var call = Calls.AsyncClientStreamingCall(helper.CreateClientStreamingCall(new CallOptions(deadline: DateTime.UtcNow.AddDays(7))));
await call.RequestStream.CompleteAsync();
Assert.AreEqual("PASS", await call);
}
} }
} }

@ -153,27 +153,23 @@ namespace Grpc.Core.Tests
return channel; return channel;
} }
public CallInvocationDetails<string, string> CreateUnaryCall(CallOptions options = null) public CallInvocationDetails<string, string> CreateUnaryCall(CallOptions options = default(CallOptions))
{ {
options = options ?? new CallOptions();
return new CallInvocationDetails<string, string>(channel, UnaryMethod, options); return new CallInvocationDetails<string, string>(channel, UnaryMethod, options);
} }
public CallInvocationDetails<string, string> CreateClientStreamingCall(CallOptions options = null) public CallInvocationDetails<string, string> CreateClientStreamingCall(CallOptions options = default(CallOptions))
{ {
options = options ?? new CallOptions();
return new CallInvocationDetails<string, string>(channel, ClientStreamingMethod, options); return new CallInvocationDetails<string, string>(channel, ClientStreamingMethod, options);
} }
public CallInvocationDetails<string, string> CreateServerStreamingCall(CallOptions options = null) public CallInvocationDetails<string, string> CreateServerStreamingCall(CallOptions options = default(CallOptions))
{ {
options = options ?? new CallOptions();
return new CallInvocationDetails<string, string>(channel, ServerStreamingMethod, options); return new CallInvocationDetails<string, string>(channel, ServerStreamingMethod, options);
} }
public CallInvocationDetails<string, string> CreateDuplexStreamingCall(CallOptions options = null) public CallInvocationDetails<string, string> CreateDuplexStreamingCall(CallOptions options = default(CallOptions))
{ {
options = options ?? new CallOptions();
return new CallInvocationDetails<string, string>(channel, DuplexStreamingMethod, options); return new CallInvocationDetails<string, string>(channel, DuplexStreamingMethod, options);
} }

@ -84,7 +84,7 @@ namespace Grpc.Core.Tests
{ {
helper.UnaryHandler = new UnaryServerMethod<string, string>(async (request, context) => helper.UnaryHandler = new UnaryServerMethod<string, string>(async (request, context) =>
{ {
Assert.Throws(typeof(NullReferenceException), async () => await context.WriteResponseHeadersAsync(null)); Assert.Throws(typeof(ArgumentNullException), async () => await context.WriteResponseHeadersAsync(null));
return "PASS"; return "PASS";
}); });
@ -129,7 +129,7 @@ namespace Grpc.Core.Tests
}); });
var call = Calls.AsyncServerStreamingCall(helper.CreateServerStreamingCall(), ""); var call = Calls.AsyncServerStreamingCall(helper.CreateServerStreamingCall(), "");
var responses = await call.ResponseStream.ToList(); var responses = await call.ResponseStream.ToListAsync();
CollectionAssert.AreEqual(new[] { "A", "B" }, responses); CollectionAssert.AreEqual(new[] { "A", "B" }, responses);
} }
} }

@ -40,30 +40,60 @@ namespace Grpc.Core
/// <summary> /// <summary>
/// Details about a client-side call to be invoked. /// Details about a client-side call to be invoked.
/// </summary> /// </summary>
public class CallInvocationDetails<TRequest, TResponse> public struct CallInvocationDetails<TRequest, TResponse>
{ {
readonly Channel channel; readonly Channel channel;
readonly string method; readonly string method;
readonly string host; readonly string host;
readonly Marshaller<TRequest> requestMarshaller; readonly Marshaller<TRequest> requestMarshaller;
readonly Marshaller<TResponse> responseMarshaller; readonly Marshaller<TResponse> responseMarshaller;
readonly CallOptions options; CallOptions options;
/// <summary>
/// Initializes a new instance of the <see cref="Grpc.Core.CallInvocationDetails`2"/> struct.
/// </summary>
/// <param name="channel">Channel to use for this call.</param>
/// <param name="method">Method to call.</param>
/// <param name="options">Call options.</param>
public CallInvocationDetails(Channel channel, Method<TRequest, TResponse> method, CallOptions options) : public CallInvocationDetails(Channel channel, Method<TRequest, TResponse> method, CallOptions options) :
this(channel, method.FullName, null, method.RequestMarshaller, method.ResponseMarshaller, options) this(channel, method, null, options)
{
}
/// <summary>
/// Initializes a new instance of the <see cref="Grpc.Core.CallInvocationDetails`2"/> struct.
/// </summary>
/// <param name="channel">Channel to use for this call.</param>
/// <param name="method">Method to call.</param>
/// <param name="host">Host that contains the method. if <c>null</c>, default host will be used.</param>
/// <param name="options">Call options.</param>
public CallInvocationDetails(Channel channel, Method<TRequest, TResponse> method, string host, CallOptions options) :
this(channel, method.FullName, host, method.RequestMarshaller, method.ResponseMarshaller, options)
{ {
} }
/// <summary>
/// Initializes a new instance of the <see cref="Grpc.Core.CallInvocationDetails`2"/> struct.
/// </summary>
/// <param name="channel">Channel to use for this call.</param>
/// <param name="method">Qualified method name.</param>
/// <param name="host">Host that contains the method.</param>
/// <param name="requestMarshaller">Request marshaller.</param>
/// <param name="responseMarshaller">Response marshaller.</param>
/// <param name="options">Call options.</param>
public CallInvocationDetails(Channel channel, string method, string host, Marshaller<TRequest> requestMarshaller, Marshaller<TResponse> responseMarshaller, CallOptions options) public CallInvocationDetails(Channel channel, string method, string host, Marshaller<TRequest> requestMarshaller, Marshaller<TResponse> responseMarshaller, CallOptions options)
{ {
this.channel = Preconditions.CheckNotNull(channel); this.channel = Preconditions.CheckNotNull(channel, "channel");
this.method = Preconditions.CheckNotNull(method); this.method = Preconditions.CheckNotNull(method, "method");
this.host = host; this.host = host;
this.requestMarshaller = Preconditions.CheckNotNull(requestMarshaller); this.requestMarshaller = Preconditions.CheckNotNull(requestMarshaller, "requestMarshaller");
this.responseMarshaller = Preconditions.CheckNotNull(responseMarshaller); this.responseMarshaller = Preconditions.CheckNotNull(responseMarshaller, "responseMarshaller");
this.options = Preconditions.CheckNotNull(options); this.options = options;
} }
/// <summary>
/// Get channel associated with this call.
/// </summary>
public Channel Channel public Channel Channel
{ {
get get
@ -72,6 +102,9 @@ namespace Grpc.Core
} }
} }
/// <summary>
/// Gets name of method to be called.
/// </summary>
public string Method public string Method
{ {
get get
@ -80,6 +113,9 @@ namespace Grpc.Core
} }
} }
/// <summary>
/// Get name of host.
/// </summary>
public string Host public string Host
{ {
get get
@ -88,6 +124,9 @@ namespace Grpc.Core
} }
} }
/// <summary>
/// Gets marshaller used to serialize requests.
/// </summary>
public Marshaller<TRequest> RequestMarshaller public Marshaller<TRequest> RequestMarshaller
{ {
get get
@ -96,6 +135,9 @@ namespace Grpc.Core
} }
} }
/// <summary>
/// Gets marshaller used to deserialized responses.
/// </summary>
public Marshaller<TResponse> ResponseMarshaller public Marshaller<TResponse> ResponseMarshaller
{ {
get get
@ -104,6 +146,9 @@ namespace Grpc.Core
} }
} }
/// <summary>
/// Gets the call options.
/// </summary>
public CallOptions Options public CallOptions Options
{ {
get get
@ -111,5 +156,16 @@ namespace Grpc.Core
return options; return options;
} }
} }
/// <summary>
/// Returns new instance of <see cref="CallInvocationDetails"/> with
/// <c>Options</c> set to the value provided. Values of all other fields are preserved.
/// </summary>
public CallInvocationDetails<TRequest, TResponse> WithOptions(CallOptions options)
{
var newDetails = this;
newDetails.options = options;
return newDetails;
}
} }
} }

@ -42,29 +42,28 @@ namespace Grpc.Core
/// <summary> /// <summary>
/// Options for calls made by client. /// Options for calls made by client.
/// </summary> /// </summary>
public class CallOptions public struct CallOptions
{ {
readonly Metadata headers; Metadata headers;
readonly DateTime deadline; DateTime? deadline;
readonly CancellationToken cancellationToken; CancellationToken cancellationToken;
readonly WriteOptions writeOptions; WriteOptions writeOptions;
readonly ContextPropagationToken propagationToken; ContextPropagationToken propagationToken;
/// <summary> /// <summary>
/// Creates a new instance of <c>CallOptions</c>. /// Creates a new instance of <c>CallOptions</c> struct.
/// </summary> /// </summary>
/// <param name="headers">Headers to be sent with the call.</param> /// <param name="headers">Headers to be sent with the call.</param>
/// <param name="deadline">Deadline for the call to finish. null means no deadline.</param> /// <param name="deadline">Deadline for the call to finish. null means no deadline.</param>
/// <param name="cancellationToken">Can be used to request cancellation of the call.</param> /// <param name="cancellationToken">Can be used to request cancellation of the call.</param>
/// <param name="writeOptions">Write options that will be used for this call.</param> /// <param name="writeOptions">Write options that will be used for this call.</param>
/// <param name="propagationToken">Context propagation token obtained from <see cref="ServerCallContext"/>.</param> /// <param name="propagationToken">Context propagation token obtained from <see cref="ServerCallContext"/>.</param>
public CallOptions(Metadata headers = null, DateTime? deadline = null, CancellationToken? cancellationToken = null, public CallOptions(Metadata headers = null, DateTime? deadline = null, CancellationToken cancellationToken = default(CancellationToken),
WriteOptions writeOptions = null, ContextPropagationToken propagationToken = null) WriteOptions writeOptions = null, ContextPropagationToken propagationToken = null)
{ {
// TODO(jtattermusch): consider only creating metadata object once it's really needed. this.headers = headers;
this.headers = headers ?? new Metadata(); this.deadline = deadline;
this.deadline = deadline ?? (propagationToken != null ? propagationToken.Deadline : DateTime.MaxValue); this.cancellationToken = cancellationToken;
this.cancellationToken = cancellationToken ?? (propagationToken != null ? propagationToken.CancellationToken : CancellationToken.None);
this.writeOptions = writeOptions; this.writeOptions = writeOptions;
this.propagationToken = propagationToken; this.propagationToken = propagationToken;
} }
@ -80,7 +79,7 @@ namespace Grpc.Core
/// <summary> /// <summary>
/// Call deadline. /// Call deadline.
/// </summary> /// </summary>
public DateTime Deadline public DateTime? Deadline
{ {
get { return deadline; } get { return deadline; }
} }
@ -114,5 +113,66 @@ namespace Grpc.Core
return this.propagationToken; return this.propagationToken;
} }
} }
/// <summary>
/// Returns new instance of <see cref="CallOptions"/> with
/// <c>Headers</c> set to the value provided. Values of all other fields are preserved.
/// </summary>
public CallOptions WithHeaders(Metadata headers)
{
var newOptions = this;
newOptions.headers = headers;
return newOptions;
}
/// <summary>
/// Returns new instance of <see cref="CallOptions"/> with
/// <c>Deadline</c> set to the value provided. Values of all other fields are preserved.
/// </summary>
public CallOptions WithDeadline(DateTime deadline)
{
var newOptions = this;
newOptions.deadline = deadline;
return newOptions;
}
/// <summary>
/// Returns new instance of <see cref="CallOptions"/> with
/// <c>CancellationToken</c> set to the value provided. Values of all other fields are preserved.
/// </summary>
public CallOptions WithCancellationToken(CancellationToken cancellationToken)
{
var newOptions = this;
newOptions.cancellationToken = cancellationToken;
return newOptions;
}
/// <summary>
/// Returns a new instance of <see cref="CallOptions"/> with
/// all previously unset values set to their defaults and deadline and cancellation
/// token propagated when appropriate.
/// </summary>
internal CallOptions Normalize()
{
var newOptions = this;
if (propagationToken != null)
{
if (propagationToken.Options.IsPropagateDeadline)
{
Preconditions.CheckArgument(!newOptions.deadline.HasValue,
"Cannot propagate deadline from parent call. The deadline has already been set explicitly.");
newOptions.deadline = propagationToken.ParentDeadline;
}
if (propagationToken.Options.IsPropagateCancellation)
{
Preconditions.CheckArgument(!newOptions.cancellationToken.CanBeCanceled,
"Cannot propagate cancellation token from parent call. The cancellation token has already been set to a non-default value.");
}
}
newOptions.headers = newOptions.headers ?? Metadata.Empty;
newOptions.deadline = newOptions.deadline ?? DateTime.MaxValue;
return newOptions;
}
} }
} }

@ -31,8 +31,6 @@
#endregion #endregion
using System;
using System.Threading;
using System.Threading.Tasks; using System.Threading.Tasks;
using Grpc.Core.Internal; using Grpc.Core.Internal;
@ -40,9 +38,20 @@ namespace Grpc.Core
{ {
/// <summary> /// <summary>
/// Helper methods for generated clients to make RPC calls. /// Helper methods for generated clients to make RPC calls.
/// Most users will use this class only indirectly and will be
/// making calls using client object generated from protocol
/// buffer definition files.
/// </summary> /// </summary>
public static class Calls public static class Calls
{ {
/// <summary>
/// Invokes a simple remote call in a blocking fashion.
/// </summary>
/// <returns>The response.</returns>
/// <param name="call">The call defintion.</param>
/// <param name="req">Request message.</param>
/// <typeparam name="TRequest">Type of request message.</typeparam>
/// <typeparam name="TResponse">The of response message.</typeparam>
public static TResponse BlockingUnaryCall<TRequest, TResponse>(CallInvocationDetails<TRequest, TResponse> call, TRequest req) public static TResponse BlockingUnaryCall<TRequest, TResponse>(CallInvocationDetails<TRequest, TResponse> call, TRequest req)
where TRequest : class where TRequest : class
where TResponse : class where TResponse : class
@ -51,6 +60,14 @@ namespace Grpc.Core
return asyncCall.UnaryCall(req); return asyncCall.UnaryCall(req);
} }
/// <summary>
/// Invokes a simple remote call asynchronously.
/// </summary>
/// <returns>An awaitable call object providing access to the response.</returns>
/// <param name="call">The call defintion.</param>
/// <param name="req">Request message.</param>
/// <typeparam name="TRequest">Type of request message.</typeparam>
/// <typeparam name="TResponse">The of response message.</typeparam>
public static AsyncUnaryCall<TResponse> AsyncUnaryCall<TRequest, TResponse>(CallInvocationDetails<TRequest, TResponse> call, TRequest req) public static AsyncUnaryCall<TResponse> AsyncUnaryCall<TRequest, TResponse>(CallInvocationDetails<TRequest, TResponse> call, TRequest req)
where TRequest : class where TRequest : class
where TResponse : class where TResponse : class
@ -60,6 +77,15 @@ namespace Grpc.Core
return new AsyncUnaryCall<TResponse>(asyncResult, asyncCall.GetStatus, asyncCall.GetTrailers, asyncCall.Cancel); return new AsyncUnaryCall<TResponse>(asyncResult, asyncCall.GetStatus, asyncCall.GetTrailers, asyncCall.Cancel);
} }
/// <summary>
/// Invokes a server streaming call asynchronously.
/// In server streaming scenario, client sends on request and server responds with a stream of responses.
/// </summary>
/// <returns>A call object providing access to the asynchronous response stream.</returns>
/// <param name="call">The call defintion.</param>
/// <param name="req">Request message.</param>
/// <typeparam name="TRequest">Type of request message.</typeparam>
/// <typeparam name="TResponse">The of response messages.</typeparam>
public static AsyncServerStreamingCall<TResponse> AsyncServerStreamingCall<TRequest, TResponse>(CallInvocationDetails<TRequest, TResponse> call, TRequest req) public static AsyncServerStreamingCall<TResponse> AsyncServerStreamingCall<TRequest, TResponse>(CallInvocationDetails<TRequest, TResponse> call, TRequest req)
where TRequest : class where TRequest : class
where TResponse : class where TResponse : class
@ -70,6 +96,13 @@ namespace Grpc.Core
return new AsyncServerStreamingCall<TResponse>(responseStream, asyncCall.GetStatus, asyncCall.GetTrailers, asyncCall.Cancel); return new AsyncServerStreamingCall<TResponse>(responseStream, asyncCall.GetStatus, asyncCall.GetTrailers, asyncCall.Cancel);
} }
/// <summary>
/// Invokes a client streaming call asynchronously.
/// In client streaming scenario, client sends a stream of requests and server responds with a single response.
/// </summary>
/// <returns>An awaitable call object providing access to the response.</returns>
/// <typeparam name="TRequest">Type of request messages.</typeparam>
/// <typeparam name="TResponse">The of response message.</typeparam>
public static AsyncClientStreamingCall<TRequest, TResponse> AsyncClientStreamingCall<TRequest, TResponse>(CallInvocationDetails<TRequest, TResponse> call) public static AsyncClientStreamingCall<TRequest, TResponse> AsyncClientStreamingCall<TRequest, TResponse>(CallInvocationDetails<TRequest, TResponse> call)
where TRequest : class where TRequest : class
where TResponse : class where TResponse : class
@ -80,6 +113,15 @@ namespace Grpc.Core
return new AsyncClientStreamingCall<TRequest, TResponse>(requestStream, resultTask, asyncCall.GetStatus, asyncCall.GetTrailers, asyncCall.Cancel); return new AsyncClientStreamingCall<TRequest, TResponse>(requestStream, resultTask, asyncCall.GetStatus, asyncCall.GetTrailers, asyncCall.Cancel);
} }
/// <summary>
/// Invokes a duplex streaming call asynchronously.
/// In duplex streaming scenario, client sends a stream of requests and server responds with a stream of responses.
/// The response stream is completely independent and both side can be sending messages at the same time.
/// </summary>
/// <returns>A call object providing access to the asynchronous request and response streams.</returns>
/// <param name="call">The call definition.</param>
/// <typeparam name="TRequest">Type of request messages.</typeparam>
/// <typeparam name="TResponse">Type of reponse messages.</typeparam>
public static AsyncDuplexStreamingCall<TRequest, TResponse> AsyncDuplexStreamingCall<TRequest, TResponse>(CallInvocationDetails<TRequest, TResponse> call) public static AsyncDuplexStreamingCall<TRequest, TResponse> AsyncDuplexStreamingCall<TRequest, TResponse>(CallInvocationDetails<TRequest, TResponse> call)
where TRequest : class where TRequest : class
where TResponse : class where TResponse : class

@ -49,6 +49,7 @@ namespace Grpc.Core
{ {
static readonly ILogger Logger = GrpcEnvironment.Logger.ForType<Channel>(); static readonly ILogger Logger = GrpcEnvironment.Logger.ForType<Channel>();
readonly string target;
readonly GrpcEnvironment environment; readonly GrpcEnvironment environment;
readonly ChannelSafeHandle handle; readonly ChannelSafeHandle handle;
readonly List<ChannelOption> options; readonly List<ChannelOption> options;
@ -58,12 +59,12 @@ namespace Grpc.Core
/// Creates a channel that connects to a specific host. /// Creates a channel that connects to a specific host.
/// Port will default to 80 for an unsecure channel and to 443 for a secure channel. /// Port will default to 80 for an unsecure channel and to 443 for a secure channel.
/// </summary> /// </summary>
/// <param name="host">The name or IP address of the host.</param> /// <param name="target">Target of the channel.</param>
/// <param name="credentials">Credentials to secure the channel.</param> /// <param name="credentials">Credentials to secure the channel.</param>
/// <param name="options">Channel options.</param> /// <param name="options">Channel options.</param>
public Channel(string host, Credentials credentials, IEnumerable<ChannelOption> options = null) public Channel(string target, Credentials credentials, IEnumerable<ChannelOption> options = null)
{ {
Preconditions.CheckNotNull(host); this.target = Preconditions.CheckNotNull(target, "target");
this.environment = GrpcEnvironment.GetInstance(); this.environment = GrpcEnvironment.GetInstance();
this.options = options != null ? new List<ChannelOption>(options) : new List<ChannelOption>(); this.options = options != null ? new List<ChannelOption>(options) : new List<ChannelOption>();
@ -73,11 +74,11 @@ namespace Grpc.Core
{ {
if (nativeCredentials != null) if (nativeCredentials != null)
{ {
this.handle = ChannelSafeHandle.CreateSecure(nativeCredentials, host, nativeChannelArgs); this.handle = ChannelSafeHandle.CreateSecure(nativeCredentials, target, nativeChannelArgs);
} }
else else
{ {
this.handle = ChannelSafeHandle.CreateInsecure(host, nativeChannelArgs); this.handle = ChannelSafeHandle.CreateInsecure(target, nativeChannelArgs);
} }
} }
} }
@ -131,8 +132,8 @@ namespace Grpc.Core
return tcs.Task; return tcs.Task;
} }
/// <summary> Address of the remote endpoint in URI format.</summary> /// <summary>Resolved address of the remote endpoint in URI format.</summary>
public string Target public string ResolvedTarget
{ {
get get
{ {
@ -140,6 +141,15 @@ namespace Grpc.Core
} }
} }
/// <summary>The original target used to create the channel.</summary>
public string Target
{
get
{
return this.target;
}
}
/// <summary> /// <summary>
/// Allows explicitly requesting channel to connect without starting an RPC. /// Allows explicitly requesting channel to connect without starting an RPC.
/// Returned task completes once state Ready was seen. If the deadline is reached, /// Returned task completes once state Ready was seen. If the deadline is reached,

@ -63,8 +63,8 @@ namespace Grpc.Core
public ChannelOption(string name, string stringValue) public ChannelOption(string name, string stringValue)
{ {
this.type = OptionType.String; this.type = OptionType.String;
this.name = Preconditions.CheckNotNull(name); this.name = Preconditions.CheckNotNull(name, "name");
this.stringValue = Preconditions.CheckNotNull(stringValue); this.stringValue = Preconditions.CheckNotNull(stringValue, "stringValue");
} }
/// <summary> /// <summary>
@ -75,7 +75,7 @@ namespace Grpc.Core
public ChannelOption(string name, int intValue) public ChannelOption(string name, int intValue)
{ {
this.type = OptionType.Integer; this.type = OptionType.Integer;
this.name = Preconditions.CheckNotNull(name); this.name = Preconditions.CheckNotNull(name, "name");
this.intValue = intValue; this.intValue = intValue;
} }

@ -35,21 +35,26 @@ using System;
using System.Collections.Generic; using System.Collections.Generic;
using Grpc.Core.Internal; using Grpc.Core.Internal;
using System.Text.RegularExpressions;
namespace Grpc.Core namespace Grpc.Core
{ {
public delegate void MetadataInterceptorDelegate(Metadata metadata); public delegate void MetadataInterceptorDelegate(string authUri, Metadata metadata);
/// <summary> /// <summary>
/// Base class for client-side stubs. /// Base class for client-side stubs.
/// </summary> /// </summary>
public abstract class ClientBase public abstract class ClientBase
{ {
static readonly Regex TrailingPortPattern = new Regex(":[0-9]+/?$");
readonly Channel channel; readonly Channel channel;
readonly string authUriBase;
public ClientBase(Channel channel) public ClientBase(Channel channel)
{ {
this.channel = channel; this.channel = channel;
// TODO(jtattermush): we shouldn't need to hand-curate the channel.Target contents.
this.authUriBase = "https://" + TrailingPortPattern.Replace(channel.Target, "") + "/";
} }
/// <summary> /// <summary>
@ -62,6 +67,18 @@ namespace Grpc.Core
set; set;
} }
/// <summary>
/// gRPC supports multiple "hosts" being served by a single server.
/// This property can be used to set the target host explicitly.
/// By default, this will be set to <c>null</c> with the meaning
/// "use default host".
/// </summary>
public string Host
{
get;
set;
}
/// <summary> /// <summary>
/// Channel associated with this client. /// Channel associated with this client.
/// </summary> /// </summary>
@ -83,10 +100,14 @@ namespace Grpc.Core
var interceptor = HeaderInterceptor; var interceptor = HeaderInterceptor;
if (interceptor != null) if (interceptor != null)
{ {
interceptor(options.Headers); if (options.Headers == null)
options.Headers.Freeze(); {
options = options.WithHeaders(new Metadata());
}
var authUri = authUriBase + method.ServiceName;
interceptor(authUri, options.Headers);
} }
return new CallInvocationDetails<TRequest, TResponse>(channel, method, options); return new CallInvocationDetails<TRequest, TResponse>(channel, method, Host, options);
} }
} }
} }

@ -52,7 +52,7 @@ namespace Grpc.Core
/// <summary> /// <summary>
/// Default propagation mask used by C core. /// Default propagation mask used by C core.
/// </summary> /// </summary>
const ContextPropagationFlags DefaultCoreMask = (ContextPropagationFlags)0xffff; private const ContextPropagationFlags DefaultCoreMask = (ContextPropagationFlags)0xffff;
/// <summary> /// <summary>
/// Default propagation mask used by C# - we want to propagate deadline /// Default propagation mask used by C# - we want to propagate deadline
@ -74,6 +74,9 @@ namespace Grpc.Core
this.options = options ?? ContextPropagationOptions.Default; this.options = options ?? ContextPropagationOptions.Default;
} }
/// <summary>
/// Gets the native handle of the parent call.
/// </summary>
internal CallSafeHandle ParentCall internal CallSafeHandle ParentCall
{ {
get get
@ -82,7 +85,10 @@ namespace Grpc.Core
} }
} }
internal DateTime Deadline /// <summary>
/// Gets the parent call's deadline.
/// </summary>
internal DateTime ParentDeadline
{ {
get get
{ {
@ -90,7 +96,10 @@ namespace Grpc.Core
} }
} }
internal CancellationToken CancellationToken /// <summary>
/// Gets the parent call's cancellation token.
/// </summary>
internal CancellationToken ParentCancellationToken
{ {
get get
{ {
@ -98,6 +107,9 @@ namespace Grpc.Core
} }
} }
/// <summary>
/// Get the context propagation options.
/// </summary>
internal ContextPropagationOptions Options internal ContextPropagationOptions Options
{ {
get get
@ -105,16 +117,6 @@ namespace Grpc.Core
return this.options; return this.options;
} }
} }
internal bool IsPropagateDeadline
{
get { return false; }
}
internal bool IsPropagateCancellation
{
get { return false; }
}
} }
/// <summary> /// <summary>
@ -122,7 +124,37 @@ namespace Grpc.Core
/// </summary> /// </summary>
public class ContextPropagationOptions public class ContextPropagationOptions
{ {
/// <summary>
/// The context propagation options that will be used by default.
/// </summary>
public static readonly ContextPropagationOptions Default = new ContextPropagationOptions(); public static readonly ContextPropagationOptions Default = new ContextPropagationOptions();
bool propagateDeadline;
bool propagateCancellation;
/// <summary>
/// Creates new context propagation options.
/// </summary>
/// <param name="propagateDeadline">If set to <c>true</c> parent call's deadline will be propagated to the child call.</param>
/// <param name="propagateCancellation">If set to <c>true</c> parent call's cancellation token will be propagated to the child call.</param>
public ContextPropagationOptions(bool propagateDeadline = true, bool propagateCancellation = true)
{
this.propagateDeadline = propagateDeadline;
this.propagateCancellation = propagateCancellation;
}
/// <value><c>true</c> if parent call's deadline should be propagated to the child call.</value>
public bool IsPropagateDeadline
{
get { return this.propagateDeadline; }
}
/// <value><c>true</c> if parent call's cancellation token should be propagated to the child call.</value>
public bool IsPropagateCancellation
{
get { return this.propagateCancellation; }
}
} }
/// <summary> /// <summary>

@ -77,7 +77,6 @@
<Compile Include="ServerServiceDefinition.cs" /> <Compile Include="ServerServiceDefinition.cs" />
<Compile Include="Utils\AsyncStreamExtensions.cs" /> <Compile Include="Utils\AsyncStreamExtensions.cs" />
<Compile Include="Utils\BenchmarkUtil.cs" /> <Compile Include="Utils\BenchmarkUtil.cs" />
<Compile Include="Utils\ExceptionHelper.cs" />
<Compile Include="Internal\CredentialsSafeHandle.cs" /> <Compile Include="Internal\CredentialsSafeHandle.cs" />
<Compile Include="Credentials.cs" /> <Compile Include="Credentials.cs" />
<Compile Include="Internal\ChannelArgsSafeHandle.cs" /> <Compile Include="Internal\ChannelArgsSafeHandle.cs" />

@ -115,7 +115,7 @@ namespace Grpc.Core
/// </summary> /// </summary>
public static void SetLogger(ILogger customLogger) public static void SetLogger(ILogger customLogger)
{ {
Preconditions.CheckNotNull(customLogger); Preconditions.CheckNotNull(customLogger, "customLogger");
logger = customLogger; logger = customLogger;
} }
@ -192,23 +192,5 @@ namespace Grpc.Core
Logger.Info("gRPC shutdown."); Logger.Info("gRPC shutdown.");
} }
/// <summary>
/// Shuts down this environment asynchronously.
/// </summary>
private Task CloseAsync()
{
return Task.Run(() =>
{
try
{
Close();
}
catch (Exception e)
{
Logger.Error(e, "Error occured while shutting down GrpcEnvironment.");
}
});
}
} }
} }

@ -63,7 +63,7 @@ namespace Grpc.Core.Internal
public AsyncCall(CallInvocationDetails<TRequest, TResponse> callDetails) public AsyncCall(CallInvocationDetails<TRequest, TResponse> callDetails)
: base(callDetails.RequestMarshaller.Serializer, callDetails.ResponseMarshaller.Deserializer) : base(callDetails.RequestMarshaller.Serializer, callDetails.ResponseMarshaller.Deserializer)
{ {
this.details = callDetails; this.details = callDetails.WithOptions(callDetails.Options.Normalize());
this.initialMetadataSent = true; // we always send metadata at the very beginning of the call. this.initialMetadataSent = true; // we always send metadata at the very beginning of the call.
} }
@ -109,15 +109,9 @@ namespace Grpc.Core.Internal
} }
} }
try
{
// Once the blocking call returns, the result should be available synchronously. // Once the blocking call returns, the result should be available synchronously.
return unaryResponseTcs.Task.Result; // Note that GetAwaiter().GetResult() doesn't wrap exceptions in AggregateException.
} return unaryResponseTcs.Task.GetAwaiter().GetResult();
catch (AggregateException ae)
{
throw ExceptionHelper.UnwrapRpcException(ae);
}
} }
} }
@ -324,12 +318,11 @@ namespace Grpc.Core.Internal
private void Initialize(CompletionQueueSafeHandle cq) private void Initialize(CompletionQueueSafeHandle cq)
{ {
var propagationToken = details.Options.PropagationToken; var parentCall = details.Options.PropagationToken != null ? details.Options.PropagationToken.ParentCall : CallSafeHandle.NullInstance;
var parentCall = propagationToken != null ? propagationToken.ParentCall : CallSafeHandle.NullInstance;
var call = details.Channel.Handle.CreateCall(details.Channel.Environment.CompletionRegistry, var call = details.Channel.Handle.CreateCall(details.Channel.Environment.CompletionRegistry,
parentCall, ContextPropagationToken.DefaultMask, cq, parentCall, ContextPropagationToken.DefaultMask, cq,
details.Method, details.Host, Timespec.FromDateTime(details.Options.Deadline)); details.Method, details.Host, Timespec.FromDateTime(details.Options.Deadline.Value));
details.Channel.Environment.DebugStats.ActiveClientCalls.Increment(); details.Channel.Environment.DebugStats.ActiveClientCalls.Increment();
InitializeInternal(call); InitializeInternal(call);
RegisterCancellationCallback(); RegisterCancellationCallback();

@ -211,7 +211,7 @@ namespace Grpc.Core.Internal
return Timespec.InfPast; return Timespec.InfPast;
} }
Preconditions.CheckArgument(dateTime.Kind == DateTimeKind.Utc, "dateTime"); Preconditions.CheckArgument(dateTime.Kind == DateTimeKind.Utc, "dateTime needs of kind DateTimeKind.Utc or be equal to DateTime.MaxValue or DateTime.MinValue.");
try try
{ {

@ -54,8 +54,8 @@ namespace Grpc.Core
/// <param name="privateKey">PEM encoded private key.</param> /// <param name="privateKey">PEM encoded private key.</param>
public KeyCertificatePair(string certificateChain, string privateKey) public KeyCertificatePair(string certificateChain, string privateKey)
{ {
this.certificateChain = Preconditions.CheckNotNull(certificateChain); this.certificateChain = Preconditions.CheckNotNull(certificateChain, "certificateChain");
this.privateKey = Preconditions.CheckNotNull(privateKey); this.privateKey = Preconditions.CheckNotNull(privateKey, "privateKey");
} }
/// <summary> /// <summary>

@ -42,16 +42,21 @@ namespace Grpc.Core.Logging
readonly Type forType; readonly Type forType;
readonly string forTypeString; readonly string forTypeString;
/// <summary>Creates a console logger not associated to any specific type.</summary>
public ConsoleLogger() : this(null) public ConsoleLogger() : this(null)
{ {
} }
/// <summary>Creates a console logger that logs messsage specific for given type.</summary>
private ConsoleLogger(Type forType) private ConsoleLogger(Type forType)
{ {
this.forType = forType; this.forType = forType;
this.forTypeString = forType != null ? forType.FullName + " " : ""; this.forTypeString = forType != null ? forType.FullName + " " : "";
} }
/// <summary>
/// Returns a logger associated with the specified type.
/// </summary>
public ILogger ForType<T>() public ILogger ForType<T>()
{ {
if (typeof(T) == forType) if (typeof(T) == forType)
@ -61,31 +66,37 @@ namespace Grpc.Core.Logging
return new ConsoleLogger(typeof(T)); return new ConsoleLogger(typeof(T));
} }
/// <summary>Logs a message with severity Debug.</summary>
public void Debug(string message, params object[] formatArgs) public void Debug(string message, params object[] formatArgs)
{ {
Log("D", message, formatArgs); Log("D", message, formatArgs);
} }
/// <summary>Logs a message with severity Info.</summary>
public void Info(string message, params object[] formatArgs) public void Info(string message, params object[] formatArgs)
{ {
Log("I", message, formatArgs); Log("I", message, formatArgs);
} }
/// <summary>Logs a message with severity Warning.</summary>
public void Warning(string message, params object[] formatArgs) public void Warning(string message, params object[] formatArgs)
{ {
Log("W", message, formatArgs); Log("W", message, formatArgs);
} }
/// <summary>Logs a message and an associated exception with severity Warning.</summary>
public void Warning(Exception exception, string message, params object[] formatArgs) public void Warning(Exception exception, string message, params object[] formatArgs)
{ {
Log("W", message + " " + exception, formatArgs); Log("W", message + " " + exception, formatArgs);
} }
/// <summary>Logs a message with severity Error.</summary>
public void Error(string message, params object[] formatArgs) public void Error(string message, params object[] formatArgs)
{ {
Log("E", message, formatArgs); Log("E", message, formatArgs);
} }
/// <summary>Logs a message and an associated exception with severity Error.</summary>
public void Error(Exception exception, string message, params object[] formatArgs) public void Error(Exception exception, string message, params object[] formatArgs)
{ {
Log("E", message + " " + exception, formatArgs); Log("E", message + " " + exception, formatArgs);

@ -42,16 +42,22 @@ namespace Grpc.Core.Logging
/// <summary>Returns a logger associated with the specified type.</summary> /// <summary>Returns a logger associated with the specified type.</summary>
ILogger ForType<T>(); ILogger ForType<T>();
/// <summary>Logs a message with severity Debug.</summary>
void Debug(string message, params object[] formatArgs); void Debug(string message, params object[] formatArgs);
/// <summary>Logs a message with severity Info.</summary>
void Info(string message, params object[] formatArgs); void Info(string message, params object[] formatArgs);
/// <summary>Logs a message with severity Warning.</summary>
void Warning(string message, params object[] formatArgs); void Warning(string message, params object[] formatArgs);
/// <summary>Logs a message and an associated exception with severity Warning.</summary>
void Warning(Exception exception, string message, params object[] formatArgs); void Warning(Exception exception, string message, params object[] formatArgs);
/// <summary>Logs a message with severity Error.</summary>
void Error(string message, params object[] formatArgs); void Error(string message, params object[] formatArgs);
/// <summary>Logs a message and an associated exception with severity Error.</summary>
void Error(Exception exception, string message, params object[] formatArgs); void Error(Exception exception, string message, params object[] formatArgs);
} }
} }

@ -37,19 +37,27 @@ using Grpc.Core.Utils;
namespace Grpc.Core namespace Grpc.Core
{ {
/// <summary> /// <summary>
/// For serializing and deserializing messages. /// Encapsulates the logic for serializing and deserializing messages.
/// </summary> /// </summary>
public struct Marshaller<T> public struct Marshaller<T>
{ {
readonly Func<T, byte[]> serializer; readonly Func<T, byte[]> serializer;
readonly Func<byte[], T> deserializer; readonly Func<byte[], T> deserializer;
/// <summary>
/// Initializes a new marshaller.
/// </summary>
/// <param name="serializer">Function that will be used to serialize messages.</param>
/// <param name="deserializer">Function that will be used to deserialize messages.</param>
public Marshaller(Func<T, byte[]> serializer, Func<byte[], T> deserializer) public Marshaller(Func<T, byte[]> serializer, Func<byte[], T> deserializer)
{ {
this.serializer = Preconditions.CheckNotNull(serializer); this.serializer = Preconditions.CheckNotNull(serializer, "serializer");
this.deserializer = Preconditions.CheckNotNull(deserializer); this.deserializer = Preconditions.CheckNotNull(deserializer, "deserializer");
} }
/// <summary>
/// Gets the serializer function.
/// </summary>
public Func<T, byte[]> Serializer public Func<T, byte[]> Serializer
{ {
get get
@ -58,6 +66,9 @@ namespace Grpc.Core
} }
} }
/// <summary>
/// Gets the deserializer function.
/// </summary>
public Func<byte[], T> Deserializer public Func<byte[], T> Deserializer
{ {
get get
@ -72,11 +83,17 @@ namespace Grpc.Core
/// </summary> /// </summary>
public static class Marshallers public static class Marshallers
{ {
/// <summary>
/// Creates a marshaller from specified serializer and deserializer.
/// </summary>
public static Marshaller<T> Create<T>(Func<T, byte[]> serializer, Func<byte[], T> deserializer) public static Marshaller<T> Create<T>(Func<T, byte[]> serializer, Func<byte[], T> deserializer)
{ {
return new Marshaller<T>(serializer, deserializer); return new Marshaller<T>(serializer, deserializer);
} }
/// <summary>
/// Returns a marshaller for <c>string</c> type. This is useful for testing.
/// </summary>
public static Marshaller<string> StringMarshaller public static Marshaller<string> StringMarshaller
{ {
get get

@ -186,15 +186,15 @@ namespace Grpc.Core
public Entry(string key, byte[] valueBytes) public Entry(string key, byte[] valueBytes)
{ {
this.key = Preconditions.CheckNotNull(key); this.key = Preconditions.CheckNotNull(key, "key");
this.value = null; this.value = null;
this.valueBytes = Preconditions.CheckNotNull(valueBytes); this.valueBytes = Preconditions.CheckNotNull(valueBytes, "valueBytes");
} }
public Entry(string key, string value) public Entry(string key, string value)
{ {
this.key = Preconditions.CheckNotNull(key); this.key = Preconditions.CheckNotNull(key, "key");
this.value = Preconditions.CheckNotNull(value); this.value = Preconditions.CheckNotNull(value, "value");
this.valueBytes = null; this.valueBytes = null;
} }

@ -41,14 +41,21 @@ namespace Grpc.Core
/// </summary> /// </summary>
public enum MethodType public enum MethodType
{ {
Unary, // Unary request, unary response. /// <summary>Single request sent from client, single response received from server.</summary>
ClientStreaming, // Streaming request, unary response. Unary,
ServerStreaming, // Unary request, streaming response.
DuplexStreaming // Streaming request, streaming response. /// <summary>Stream of request sent from client, single response received from server.</summary>
ClientStreaming,
/// <summary>Single request sent from client, stream of responses received from server.</summary>
ServerStreaming,
/// <summary>Both server and client can stream arbitrary number of requests and responses simultaneously.</summary>
DuplexStreaming
} }
/// <summary> /// <summary>
/// A description of a service method. /// A description of a remote method.
/// </summary> /// </summary>
public class Method<TRequest, TResponse> public class Method<TRequest, TResponse>
{ {
@ -59,16 +66,27 @@ namespace Grpc.Core
readonly Marshaller<TResponse> responseMarshaller; readonly Marshaller<TResponse> responseMarshaller;
readonly string fullName; readonly string fullName;
/// <summary>
/// Initializes a new instance of the <c>Method</c> class.
/// </summary>
/// <param name="type">Type of method.</param>
/// <param name="serviceName">Name of service this method belongs to.</param>
/// <param name="name">Unqualified name of the method.</param>
/// <param name="requestMarshaller">Marshaller used for request messages.</param>
/// <param name="responseMarshaller">Marshaller used for response messages.</param>
public Method(MethodType type, string serviceName, string name, Marshaller<TRequest> requestMarshaller, Marshaller<TResponse> responseMarshaller) public Method(MethodType type, string serviceName, string name, Marshaller<TRequest> requestMarshaller, Marshaller<TResponse> responseMarshaller)
{ {
this.type = type; this.type = type;
this.serviceName = Preconditions.CheckNotNull(serviceName); this.serviceName = Preconditions.CheckNotNull(serviceName, "serviceName");
this.name = Preconditions.CheckNotNull(name); this.name = Preconditions.CheckNotNull(name, "name");
this.requestMarshaller = Preconditions.CheckNotNull(requestMarshaller); this.requestMarshaller = Preconditions.CheckNotNull(requestMarshaller, "requestMarshaller");
this.responseMarshaller = Preconditions.CheckNotNull(responseMarshaller); this.responseMarshaller = Preconditions.CheckNotNull(responseMarshaller, "responseMarshaller");
this.fullName = GetFullName(serviceName); this.fullName = GetFullName(serviceName, name);
} }
/// <summary>
/// Gets the type of the method.
/// </summary>
public MethodType Type public MethodType Type
{ {
get get
@ -77,6 +95,9 @@ namespace Grpc.Core
} }
} }
/// <summary>
/// Gets the name of the service to which this method belongs.
/// </summary>
public string ServiceName public string ServiceName
{ {
get get
@ -85,6 +106,9 @@ namespace Grpc.Core
} }
} }
/// <summary>
/// Gets the unqualified name of the method.
/// </summary>
public string Name public string Name
{ {
get get
@ -93,6 +117,9 @@ namespace Grpc.Core
} }
} }
/// <summary>
/// Gets the marshaller used for request messages.
/// </summary>
public Marshaller<TRequest> RequestMarshaller public Marshaller<TRequest> RequestMarshaller
{ {
get get
@ -101,6 +128,9 @@ namespace Grpc.Core
} }
} }
/// <summary>
/// Gets the marshaller used for response messages.
/// </summary>
public Marshaller<TResponse> ResponseMarshaller public Marshaller<TResponse> ResponseMarshaller
{ {
get get
@ -109,6 +139,10 @@ namespace Grpc.Core
} }
} }
/// <summary>
/// Gets the fully qualified name of the method. On the server side, methods are dispatched
/// based on this name.
/// </summary>
public string FullName public string FullName
{ {
get get
@ -120,9 +154,9 @@ namespace Grpc.Core
/// <summary> /// <summary>
/// Gets full name of the method including the service name. /// Gets full name of the method including the service name.
/// </summary> /// </summary>
internal string GetFullName(string serviceName) internal static string GetFullName(string serviceName, string methodName)
{ {
return "/" + Preconditions.CheckNotNull(serviceName) + "/" + this.Name; return "/" + serviceName + "/" + methodName;
} }
} }
} }

@ -36,22 +36,34 @@ using System;
namespace Grpc.Core namespace Grpc.Core
{ {
/// <summary> /// <summary>
/// Thrown when remote procedure call fails. /// Thrown when remote procedure call fails. Every <c>RpcException</c> is associated with a resulting <see cref="Status"/> of the call.
/// </summary> /// </summary>
public class RpcException : Exception public class RpcException : Exception
{ {
private readonly Status status; private readonly Status status;
/// <summary>
/// Creates a new <c>RpcException</c> associated with given status.
/// </summary>
/// <param name="status">Resulting status of a call.</param>
public RpcException(Status status) : base(status.ToString()) public RpcException(Status status) : base(status.ToString())
{ {
this.status = status; this.status = status;
} }
/// <summary>
/// Creates a new <c>RpcException</c> associated with given status and message.
/// </summary>
/// <param name="status">Resulting status of a call.</param>
/// <param name="message">The exception message.</param>
public RpcException(Status status, string message) : base(message) public RpcException(Status status, string message) : base(message)
{ {
this.status = status; this.status = status;
} }
/// <summary>
/// Resulting status of the call.
/// </summary>
public Status Status public Status Status
{ {
get get

@ -192,7 +192,7 @@ namespace Grpc.Core
{ {
lock (myLock) lock (myLock)
{ {
Preconditions.CheckNotNull(serverPort.Credentials); Preconditions.CheckNotNull(serverPort.Credentials, "serverPort");
Preconditions.CheckState(!startRequested); Preconditions.CheckState(!startRequested);
var address = string.Format("{0}:{1}", serverPort.Host, serverPort.Port); var address = string.Format("{0}:{1}", serverPort.Host, serverPort.Port);
int boundPort; int boundPort;

@ -91,7 +91,7 @@ namespace Grpc.Core
{ {
this.keyCertificatePairs = new List<KeyCertificatePair>(keyCertificatePairs).AsReadOnly(); this.keyCertificatePairs = new List<KeyCertificatePair>(keyCertificatePairs).AsReadOnly();
Preconditions.CheckArgument(this.keyCertificatePairs.Count > 0, Preconditions.CheckArgument(this.keyCertificatePairs.Count > 0,
"At least one KeyCertificatePair needs to be provided"); "At least one KeyCertificatePair needs to be provided.");
if (forceClientAuth) if (forceClientAuth)
{ {
Preconditions.CheckNotNull(rootCertificates, Preconditions.CheckNotNull(rootCertificates,

@ -31,12 +31,8 @@
#endregion #endregion
using System;
using System.Threading;
using System.Threading.Tasks; using System.Threading.Tasks;
using Grpc.Core.Internal;
namespace Grpc.Core namespace Grpc.Core
{ {
/// <summary> /// <summary>

@ -62,9 +62,9 @@ namespace Grpc.Core
/// <param name="credentials">credentials to use to secure this port.</param> /// <param name="credentials">credentials to use to secure this port.</param>
public ServerPort(string host, int port, ServerCredentials credentials) public ServerPort(string host, int port, ServerCredentials credentials)
{ {
this.host = Preconditions.CheckNotNull(host); this.host = Preconditions.CheckNotNull(host, "host");
this.port = port; this.port = port;
this.credentials = Preconditions.CheckNotNull(credentials); this.credentials = Preconditions.CheckNotNull(credentials, "credentials");
} }
/// <summary> /// <summary>

@ -79,7 +79,7 @@ namespace Grpc.Core
where TRequest : class where TRequest : class
where TResponse : class where TResponse : class
{ {
callHandlers.Add(method.GetFullName(serviceName), ServerCalls.UnaryCall(method, handler)); callHandlers.Add(method.FullName, ServerCalls.UnaryCall(method, handler));
return this; return this;
} }
@ -89,7 +89,7 @@ namespace Grpc.Core
where TRequest : class where TRequest : class
where TResponse : class where TResponse : class
{ {
callHandlers.Add(method.GetFullName(serviceName), ServerCalls.ClientStreamingCall(method, handler)); callHandlers.Add(method.FullName, ServerCalls.ClientStreamingCall(method, handler));
return this; return this;
} }
@ -99,7 +99,7 @@ namespace Grpc.Core
where TRequest : class where TRequest : class
where TResponse : class where TResponse : class
{ {
callHandlers.Add(method.GetFullName(serviceName), ServerCalls.ServerStreamingCall(method, handler)); callHandlers.Add(method.FullName, ServerCalls.ServerStreamingCall(method, handler));
return this; return this;
} }
@ -109,7 +109,7 @@ namespace Grpc.Core
where TRequest : class where TRequest : class
where TResponse : class where TResponse : class
{ {
callHandlers.Add(method.GetFullName(serviceName), ServerCalls.DuplexStreamingCall(method, handler)); callHandlers.Add(method.FullName, ServerCalls.DuplexStreamingCall(method, handler));
return this; return this;
} }

@ -29,13 +29,12 @@
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
#endregion #endregion
using System; using Grpc.Core.Utils;
using System.Runtime.InteropServices;
namespace Grpc.Core namespace Grpc.Core
{ {
/// <summary> /// <summary>
/// Represents RPC result. /// Represents RPC result, which consists of <see cref="StatusCode"/> and an optional detail string.
/// </summary> /// </summary>
public struct Status public struct Status
{ {
@ -52,6 +51,11 @@ namespace Grpc.Core
readonly StatusCode statusCode; readonly StatusCode statusCode;
readonly string detail; readonly string detail;
/// <summary>
/// Creates a new instance of <c>Status</c>.
/// </summary>
/// <param name="statusCode">Status code.</param>
/// <param name="detail">Detail.</param>
public Status(StatusCode statusCode, string detail) public Status(StatusCode statusCode, string detail)
{ {
this.statusCode = statusCode; this.statusCode = statusCode;
@ -80,6 +84,9 @@ namespace Grpc.Core
} }
} }
/// <summary>
/// Returns a <see cref="System.String"/> that represents the current <see cref="Grpc.Core.Status"/>.
/// </summary>
public override string ToString() public override string ToString()
{ {
return string.Format("Status(StatusCode={0}, Detail=\"{1}\")", statusCode, detail); return string.Format("Status(StatusCode={0}, Detail=\"{1}\")", statusCode, detail);

@ -31,8 +31,6 @@
#endregion #endregion
using System;
namespace Grpc.Core namespace Grpc.Core
{ {
/// <summary> /// <summary>
@ -41,101 +39,101 @@ namespace Grpc.Core
/// </summary> /// </summary>
public enum StatusCode public enum StatusCode
{ {
/* Not an error; returned on success */ /// <summary>Not an error; returned on success.</summary>
OK = 0, OK = 0,
/* The operation was cancelled (typically by the caller). */
/// <summary>The operation was cancelled (typically by the caller).</summary>
Cancelled = 1, Cancelled = 1,
/* Unknown error. An example of where this error may be returned is
if a Status value received from another address space belongs to /// <summary>
an error-space that is not known in this address space. Also /// Unknown error. An example of where this error may be returned is
errors raised by APIs that do not return enough error information /// if a Status value received from another address space belongs to
may be converted to this error. */ /// an error-space that is not known in this address space. Also
/// errors raised by APIs that do not return enough error information
/// may be converted to this error.
/// </summary>
Unknown = 2, Unknown = 2,
/* Client specified an invalid argument. Note that this differs
from FAILED_PRECONDITION. INVALID_ARGUMENT indicates arguments /// <summary>
that are problematic regardless of the state of the system /// Client specified an invalid argument. Note that this differs
(e.g., a malformed file name). */ /// from FAILED_PRECONDITION. INVALID_ARGUMENT indicates arguments
/// that are problematic regardless of the state of the system
/// (e.g., a malformed file name).
/// </summary>
InvalidArgument = 3, InvalidArgument = 3,
/* Deadline expired before operation could complete. For operations
that change the state of the system, this error may be returned /// <summary>
even if the operation has completed successfully. For example, a /// Deadline expired before operation could complete. For operations
successful response from a server could have been delayed long /// that change the state of the system, this error may be returned
enough for the deadline to expire. */ /// even if the operation has completed successfully. For example, a
/// successful response from a server could have been delayed long
/// enough for the deadline to expire.
/// </summary>
DeadlineExceeded = 4, DeadlineExceeded = 4,
/* Some requested entity (e.g., file or directory) was not found. */
/// <summary>Some requested entity (e.g., file or directory) was not found.</summary>
NotFound = 5, NotFound = 5,
/* Some entity that we attempted to create (e.g., file or directory)
already exists. */ /// <summary>Some entity that we attempted to create (e.g., file or directory) already exists.</summary>
AlreadyExists = 6, AlreadyExists = 6,
/* The caller does not have permission to execute the specified
operation. PERMISSION_DENIED must not be used for rejections /// <summary>
caused by exhausting some resource (use RESOURCE_EXHAUSTED /// The caller does not have permission to execute the specified
instead for those errors). PERMISSION_DENIED must not be /// operation. PERMISSION_DENIED must not be used for rejections
used if the caller can not be identified (use UNAUTHENTICATED /// caused by exhausting some resource (use RESOURCE_EXHAUSTED
instead for those errors). */ /// instead for those errors). PERMISSION_DENIED must not be
/// used if the caller can not be identified (use UNAUTHENTICATED
/// instead for those errors).
/// </summary>
PermissionDenied = 7, PermissionDenied = 7,
/* The request does not have valid authentication credentials for the
operation. */ /// <summary>The request does not have valid authentication credentials for the operation.</summary>
Unauthenticated = 16, Unauthenticated = 16,
/* Some resource has been exhausted, perhaps a per-user quota, or
perhaps the entire file system is out of space. */ /// <summary>
/// Some resource has been exhausted, perhaps a per-user quota, or
/// perhaps the entire file system is out of space.
/// </summary>
ResourceExhausted = 8, ResourceExhausted = 8,
/* Operation was rejected because the system is not in a state
required for the operation's execution. For example, directory /// <summary>
to be deleted may be non-empty, an rmdir operation is applied to /// Operation was rejected because the system is not in a state
a non-directory, etc. /// required for the operation's execution. For example, directory
/// to be deleted may be non-empty, an rmdir operation is applied to
A litmus test that may help a service implementor in deciding /// a non-directory, etc.
between FAILED_PRECONDITION, ABORTED, and UNAVAILABLE: /// </summary>
(a) Use UNAVAILABLE if the client can retry just the failing call.
(b) Use ABORTED if the client should retry at a higher-level
(e.g., restarting a read-modify-write sequence).
(c) Use FAILED_PRECONDITION if the client should not retry until
the system state has been explicitly fixed. E.g., if an "rmdir"
fails because the directory is non-empty, FAILED_PRECONDITION
should be returned since the client should not retry unless
they have first fixed up the directory by deleting files from it.
(d) Use FAILED_PRECONDITION if the client performs conditional
REST Get/Update/Delete on a resource and the resource on the
server does not match the condition. E.g., conflicting
read-modify-write on the same resource. */
FailedPrecondition = 9, FailedPrecondition = 9,
/* The operation was aborted, typically due to a concurrency issue
like sequencer check failures, transaction aborts, etc.
See litmus test above for deciding between FAILED_PRECONDITION, /// <summary>
ABORTED, and UNAVAILABLE. */ /// The operation was aborted, typically due to a concurrency issue
/// like sequencer check failures, transaction aborts, etc.
/// </summary>
Aborted = 10, Aborted = 10,
/* Operation was attempted past the valid range. E.g., seeking or
reading past end of file. /// <summary>
/// Operation was attempted past the valid range. E.g., seeking or
Unlike INVALID_ARGUMENT, this error indicates a problem that may /// reading past end of file.
be fixed if the system state changes. For example, a 32-bit file /// </summary>
system will generate INVALID_ARGUMENT if asked to read at an
offset that is not in the range [0,2^32-1], but it will generate
OUT_OF_RANGE if asked to read from an offset past the current
file size.
There is a fair bit of overlap between FAILED_PRECONDITION and
OUT_OF_RANGE. We recommend using OUT_OF_RANGE (the more specific
error) when it applies so that callers who are iterating through
a space can easily look for an OUT_OF_RANGE error to detect when
they are done. */
OutOfRange = 11, OutOfRange = 11,
/* Operation is not implemented or not supported/enabled in this service. */
/// <summary>Operation is not implemented or not supported/enabled in this service.</summary>
Unimplemented = 12, Unimplemented = 12,
/* Internal errors. Means some invariants expected by underlying
system has been broken. If you see one of these errors, /// <summary>
something is very broken. */ /// Internal errors. Means some invariants expected by underlying
/// system has been broken. If you see one of these errors,
/// something is very broken.
/// </summary>
Internal = 13, Internal = 13,
/* The service is currently unavailable. This is a most likely a
transient condition and may be corrected by retrying with
a backoff.
See litmus test above for deciding between FAILED_PRECONDITION, /// <summary>
ABORTED, and UNAVAILABLE. */ /// The service is currently unavailable. This is a most likely a
/// transient condition and may be corrected by retrying with
/// a backoff.
/// </summary>
Unavailable = 14, Unavailable = 14,
/* Unrecoverable data loss or corruption. */
/// <summary>Unrecoverable data loss or corruption.</summary>
DataLoss = 15 DataLoss = 15
} }
} }

@ -33,7 +33,6 @@
using System; using System;
using System.Collections.Generic; using System.Collections.Generic;
using System.Linq;
using System.Threading.Tasks; using System.Threading.Tasks;
namespace Grpc.Core.Utils namespace Grpc.Core.Utils
@ -46,7 +45,7 @@ namespace Grpc.Core.Utils
/// <summary> /// <summary>
/// Reads the entire stream and executes an async action for each element. /// Reads the entire stream and executes an async action for each element.
/// </summary> /// </summary>
public static async Task ForEach<T>(this IAsyncStreamReader<T> streamReader, Func<T, Task> asyncAction) public static async Task ForEachAsync<T>(this IAsyncStreamReader<T> streamReader, Func<T, Task> asyncAction)
where T : class where T : class
{ {
while (await streamReader.MoveNext()) while (await streamReader.MoveNext())
@ -58,7 +57,7 @@ namespace Grpc.Core.Utils
/// <summary> /// <summary>
/// Reads the entire stream and creates a list containing all the elements read. /// Reads the entire stream and creates a list containing all the elements read.
/// </summary> /// </summary>
public static async Task<List<T>> ToList<T>(this IAsyncStreamReader<T> streamReader) public static async Task<List<T>> ToListAsync<T>(this IAsyncStreamReader<T> streamReader)
where T : class where T : class
{ {
var result = new List<T>(); var result = new List<T>();
@ -73,7 +72,7 @@ namespace Grpc.Core.Utils
/// Writes all elements from given enumerable to the stream. /// Writes all elements from given enumerable to the stream.
/// Completes the stream afterwards unless close = false. /// Completes the stream afterwards unless close = false.
/// </summary> /// </summary>
public static async Task WriteAll<T>(this IClientStreamWriter<T> streamWriter, IEnumerable<T> elements, bool complete = true) public static async Task WriteAllAsync<T>(this IClientStreamWriter<T> streamWriter, IEnumerable<T> elements, bool complete = true)
where T : class where T : class
{ {
foreach (var element in elements) foreach (var element in elements)
@ -89,7 +88,7 @@ namespace Grpc.Core.Utils
/// <summary> /// <summary>
/// Writes all elements from given enumerable to the stream. /// Writes all elements from given enumerable to the stream.
/// </summary> /// </summary>
public static async Task WriteAll<T>(this IServerStreamWriter<T> streamWriter, IEnumerable<T> elements) public static async Task WriteAllAsync<T>(this IServerStreamWriter<T> streamWriter, IEnumerable<T> elements)
where T : class where T : class
{ {
foreach (var element in elements) foreach (var element in elements)

@ -39,6 +39,9 @@ using System.Threading.Tasks;
namespace Grpc.Core.Utils namespace Grpc.Core.Utils
{ {
/// <summary>
/// Utility methods to run microbenchmarks.
/// </summary>
public static class BenchmarkUtil public static class BenchmarkUtil
{ {
/// <summary> /// <summary>

@ -1,57 +0,0 @@
#region Copyright notice and license
// Copyright 2015, Google Inc.
// All rights reserved.
//
// Redistribution and use in source and binary forms, with or without
// modification, are permitted provided that the following conditions are
// met:
//
// * Redistributions of source code must retain the above copyright
// notice, this list of conditions and the following disclaimer.
// * Redistributions in binary form must reproduce the above
// copyright notice, this list of conditions and the following disclaimer
// in the documentation and/or other materials provided with the
// distribution.
// * Neither the name of Google Inc. nor the names of its
// contributors may be used to endorse or promote products derived from
// this software without specific prior written permission.
//
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
#endregion
using System;
namespace Grpc.Core.Utils
{
public static class ExceptionHelper
{
/// <summary>
/// If inner exceptions contain RpcException, rethrows it.
/// Otherwise, rethrows the original aggregate exception.
/// Always throws, the exception return type is here only to make the.
/// </summary>
public static Exception UnwrapRpcException(AggregateException ae)
{
foreach (var e in ae.InnerExceptions)
{
if (e is RpcException)
{
throw e;
}
}
throw ae;
}
}
}

@ -32,17 +32,16 @@
#endregion #endregion
using System; using System;
using System.Collections.Concurrent;
using System.Collections.Generic;
using System.Diagnostics;
using System.Threading.Tasks;
namespace Grpc.Core.Utils namespace Grpc.Core.Utils
{ {
/// <summary>
/// Utility methods to simplify checking preconditions in the code.
/// </summary>
public static class Preconditions public static class Preconditions
{ {
/// <summary> /// <summary>
/// Throws ArgumentException if condition is false. /// Throws <see cref="ArgumentException"/> if condition is false.
/// </summary> /// </summary>
public static void CheckArgument(bool condition) public static void CheckArgument(bool condition)
{ {
@ -53,7 +52,7 @@ namespace Grpc.Core.Utils
} }
/// <summary> /// <summary>
/// Throws ArgumentException with given message if condition is false. /// Throws <see cref="ArgumentException"/> with given message if condition is false.
/// </summary> /// </summary>
public static void CheckArgument(bool condition, string errorMessage) public static void CheckArgument(bool condition, string errorMessage)
{ {
@ -64,31 +63,31 @@ namespace Grpc.Core.Utils
} }
/// <summary> /// <summary>
/// Throws NullReferenceException if reference is null. /// Throws <see cref="ArgumentNullException"/> if reference is null.
/// </summary> /// </summary>
public static T CheckNotNull<T>(T reference) public static T CheckNotNull<T>(T reference)
{ {
if (reference == null) if (reference == null)
{ {
throw new NullReferenceException(); throw new ArgumentNullException();
} }
return reference; return reference;
} }
/// <summary> /// <summary>
/// Throws NullReferenceException with given message if reference is null. /// Throws <see cref="ArgumentNullException"/> if reference is null.
/// </summary> /// </summary>
public static T CheckNotNull<T>(T reference, string errorMessage) public static T CheckNotNull<T>(T reference, string paramName)
{ {
if (reference == null) if (reference == null)
{ {
throw new NullReferenceException(errorMessage); throw new ArgumentNullException(paramName);
} }
return reference; return reference;
} }
/// <summary> /// <summary>
/// Throws InvalidOperationException if condition is false. /// Throws <see cref="InvalidOperationException"/> if condition is false.
/// </summary> /// </summary>
public static void CheckState(bool condition) public static void CheckState(bool condition)
{ {
@ -99,7 +98,7 @@ namespace Grpc.Core.Utils
} }
/// <summary> /// <summary>
/// Throws InvalidOperationException with given message if condition is false. /// Throws <see cref="InvalidOperationException"/> with given message if condition is false.
/// </summary> /// </summary>
public static void CheckState(bool condition, string errorMessage) public static void CheckState(bool condition, string errorMessage)
{ {

@ -1,5 +1,37 @@
#region Copyright notice and license
// Copyright 2015, Google Inc.
// All rights reserved.
//
// Redistribution and use in source and binary forms, with or without
// modification, are permitted provided that the following conditions are
// met:
//
// * Redistributions of source code must retain the above copyright
// notice, this list of conditions and the following disclaimer.
// * Redistributions in binary form must reproduce the above
// copyright notice, this list of conditions and the following disclaimer
// in the documentation and/or other materials provided with the
// distribution.
// * Neither the name of Google Inc. nor the names of its
// contributors may be used to endorse or promote products derived from
// this software without specific prior written permission.
//
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
#endregion
using System.Reflection; using System.Reflection;
using System.Runtime.CompilerServices;
// The current version of gRPC C#. // The current version of gRPC C#.
[assembly: AssemblyVersion(Grpc.Core.VersionInfo.CurrentVersion + ".0")] [assembly: AssemblyVersion(Grpc.Core.VersionInfo.CurrentVersion + ".0")]

@ -1,8 +1,41 @@
using System.Reflection; #region Copyright notice and license
using System.Runtime.CompilerServices;
// Copyright 2015, Google Inc.
// All rights reserved.
//
// Redistribution and use in source and binary forms, with or without
// modification, are permitted provided that the following conditions are
// met:
//
// * Redistributions of source code must retain the above copyright
// notice, this list of conditions and the following disclaimer.
// * Redistributions in binary form must reproduce the above
// copyright notice, this list of conditions and the following disclaimer
// in the documentation and/or other materials provided with the
// distribution.
// * Neither the name of Google Inc. nor the names of its
// contributors may be used to endorse or promote products derived from
// this software without specific prior written permission.
//
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
#endregion
namespace Grpc.Core namespace Grpc.Core
{ {
/// <summary>
/// Provides info about current version of gRPC.
/// </summary>
public static class VersionInfo public static class VersionInfo
{ {
/// <summary> /// <summary>

@ -109,7 +109,7 @@ namespace math.Tests
{ {
using (var call = client.Fib(new FibArgs.Builder { Limit = 6 }.Build())) using (var call = client.Fib(new FibArgs.Builder { Limit = 6 }.Build()))
{ {
var responses = await call.ResponseStream.ToList(); var responses = await call.ResponseStream.ToListAsync();
CollectionAssert.AreEqual(new List<long> { 1, 1, 2, 3, 5, 8 }, CollectionAssert.AreEqual(new List<long> { 1, 1, 2, 3, 5, 8 },
responses.ConvertAll((n) => n.Num_)); responses.ConvertAll((n) => n.Num_));
} }
@ -151,7 +151,7 @@ namespace math.Tests
using (var call = client.Fib(new FibArgs.Builder { Limit = 0 }.Build(), using (var call = client.Fib(new FibArgs.Builder { Limit = 0 }.Build(),
deadline: DateTime.UtcNow.AddMilliseconds(500))) deadline: DateTime.UtcNow.AddMilliseconds(500)))
{ {
var ex = Assert.Throws<RpcException>(async () => await call.ResponseStream.ToList()); var ex = Assert.Throws<RpcException>(async () => await call.ResponseStream.ToListAsync());
// We can't guarantee the status code always DeadlineExceeded. See issue #2685. // We can't guarantee the status code always DeadlineExceeded. See issue #2685.
Assert.Contains(ex.Status.StatusCode, new[] { StatusCode.DeadlineExceeded, StatusCode.Internal }); Assert.Contains(ex.Status.StatusCode, new[] { StatusCode.DeadlineExceeded, StatusCode.Internal });
@ -167,7 +167,7 @@ namespace math.Tests
var numbers = new List<long> { 10, 20, 30 }.ConvertAll( var numbers = new List<long> { 10, 20, 30 }.ConvertAll(
n => Num.CreateBuilder().SetNum_(n).Build()); n => Num.CreateBuilder().SetNum_(n).Build());
await call.RequestStream.WriteAll(numbers); await call.RequestStream.WriteAllAsync(numbers);
var result = await call.ResponseAsync; var result = await call.ResponseAsync;
Assert.AreEqual(60, result.Num_); Assert.AreEqual(60, result.Num_);
} }
@ -185,8 +185,8 @@ namespace math.Tests
using (var call = client.DivMany()) using (var call = client.DivMany())
{ {
await call.RequestStream.WriteAll(divArgsList); await call.RequestStream.WriteAllAsync(divArgsList);
var result = await call.ResponseStream.ToList(); var result = await call.ResponseStream.ToListAsync();
CollectionAssert.AreEqual(new long[] { 3, 4, 3 }, result.ConvertAll((divReply) => divReply.Quotient)); CollectionAssert.AreEqual(new long[] { 3, 4, 3 }, result.ConvertAll((divReply) => divReply.Quotient));
CollectionAssert.AreEqual(new long[] { 1, 16, 1 }, result.ConvertAll((divReply) => divReply.Remainder)); CollectionAssert.AreEqual(new long[] { 1, 16, 1 }, result.ConvertAll((divReply) => divReply.Remainder));

@ -54,7 +54,7 @@ namespace math
{ {
using (var call = client.Fib(new FibArgs.Builder { Limit = 5 }.Build())) using (var call = client.Fib(new FibArgs.Builder { Limit = 5 }.Build()))
{ {
List<Num> result = await call.ResponseStream.ToList(); List<Num> result = await call.ResponseStream.ToListAsync();
Console.WriteLine("Fib Result: " + string.Join("|", result)); Console.WriteLine("Fib Result: " + string.Join("|", result));
} }
} }
@ -70,7 +70,7 @@ namespace math
using (var call = client.Sum()) using (var call = client.Sum())
{ {
await call.RequestStream.WriteAll(numbers); await call.RequestStream.WriteAllAsync(numbers);
Console.WriteLine("Sum Result: " + await call.ResponseAsync); Console.WriteLine("Sum Result: " + await call.ResponseAsync);
} }
} }
@ -85,8 +85,8 @@ namespace math
}; };
using (var call = client.DivMany()) using (var call = client.DivMany())
{ {
await call.RequestStream.WriteAll(divArgsList); await call.RequestStream.WriteAllAsync(divArgsList);
Console.WriteLine("DivMany Result: " + string.Join("|", await call.ResponseStream.ToList())); Console.WriteLine("DivMany Result: " + string.Join("|", await call.ResponseStream.ToListAsync()));
} }
} }
@ -102,7 +102,7 @@ namespace math
Num sum; Num sum;
using (var sumCall = client.Sum()) using (var sumCall = client.Sum())
{ {
await sumCall.RequestStream.WriteAll(numbers); await sumCall.RequestStream.WriteAllAsync(numbers);
sum = await sumCall.ResponseAsync; sum = await sumCall.ResponseAsync;
} }

@ -75,7 +75,7 @@ namespace math
public async Task<Num> Sum(IAsyncStreamReader<Num> requestStream, ServerCallContext context) public async Task<Num> Sum(IAsyncStreamReader<Num> requestStream, ServerCallContext context)
{ {
long sum = 0; long sum = 0;
await requestStream.ForEach(async num => await requestStream.ForEachAsync(async num =>
{ {
sum += num.Num_; sum += num.Num_;
}); });
@ -84,10 +84,7 @@ namespace math
public async Task DivMany(IAsyncStreamReader<DivArgs> requestStream, IServerStreamWriter<DivReply> responseStream, ServerCallContext context) public async Task DivMany(IAsyncStreamReader<DivArgs> requestStream, IServerStreamWriter<DivReply> responseStream, ServerCallContext context)
{ {
await requestStream.ForEach(async divArgs => await requestStream.ForEachAsync(async divArgs => await responseStream.WriteAsync(DivInternal(divArgs)));
{
await responseStream.WriteAsync(DivInternal(divArgs));
});
} }
static DivReply DivInternal(DivArgs args) static DivReply DivInternal(DivArgs args)

@ -92,11 +92,11 @@ namespace Grpc.HealthCheck.Tests
public void NullsRejected() public void NullsRejected()
{ {
var impl = new HealthServiceImpl(); var impl = new HealthServiceImpl();
Assert.Throws(typeof(NullReferenceException), () => impl.SetStatus(null, "", HealthCheckResponse.Types.ServingStatus.SERVING)); Assert.Throws(typeof(ArgumentNullException), () => impl.SetStatus(null, "", HealthCheckResponse.Types.ServingStatus.SERVING));
Assert.Throws(typeof(NullReferenceException), () => impl.SetStatus("", null, HealthCheckResponse.Types.ServingStatus.SERVING)); Assert.Throws(typeof(ArgumentNullException), () => impl.SetStatus("", null, HealthCheckResponse.Types.ServingStatus.SERVING));
Assert.Throws(typeof(NullReferenceException), () => impl.ClearStatus(null, "")); Assert.Throws(typeof(ArgumentNullException), () => impl.ClearStatus(null, ""));
Assert.Throws(typeof(NullReferenceException), () => impl.ClearStatus("", null)); Assert.Throws(typeof(ArgumentNullException), () => impl.ClearStatus("", null));
} }
private static HealthCheckResponse.Types.ServingStatus GetStatusHelper(HealthServiceImpl impl, string host, string service) private static HealthCheckResponse.Types.ServingStatus GetStatusHelper(HealthServiceImpl impl, string host, string service)

@ -10,6 +10,10 @@
<assemblyIdentity name="System.Net.Http" publicKeyToken="b03f5f7f11d50a3a" culture="neutral" /> <assemblyIdentity name="System.Net.Http" publicKeyToken="b03f5f7f11d50a3a" culture="neutral" />
<bindingRedirect oldVersion="0.0.0.0-4.2.28.0" newVersion="4.0.0.0" /> <bindingRedirect oldVersion="0.0.0.0-4.2.28.0" newVersion="4.0.0.0" />
</dependentAssembly> </dependentAssembly>
<dependentAssembly>
<assemblyIdentity name="Google.Apis.Core" publicKeyToken="4b01fa6e34db77ab" culture="neutral" />
<bindingRedirect oldVersion="0.0.0.0-1.9.2.38523" newVersion="1.9.2.38523" />
</dependentAssembly>
</assemblyBinding> </assemblyBinding>
</runtime> </runtime>
</configuration> </configuration>

@ -10,6 +10,10 @@
<assemblyIdentity name="System.Net.Http" publicKeyToken="b03f5f7f11d50a3a" culture="neutral" /> <assemblyIdentity name="System.Net.Http" publicKeyToken="b03f5f7f11d50a3a" culture="neutral" />
<bindingRedirect oldVersion="0.0.0.0-4.2.28.0" newVersion="4.0.0.0" /> <bindingRedirect oldVersion="0.0.0.0-4.2.28.0" newVersion="4.0.0.0" />
</dependentAssembly> </dependentAssembly>
<dependentAssembly>
<assemblyIdentity name="Google.Apis.Core" publicKeyToken="4b01fa6e34db77ab" culture="neutral" />
<bindingRedirect oldVersion="0.0.0.0-1.9.2.38523" newVersion="1.9.2.38523" />
</dependentAssembly>
</assemblyBinding> </assemblyBinding>
</runtime> </runtime>
</configuration> </configuration>

@ -8,7 +8,7 @@
<RootNamespace>Grpc.IntegrationTesting</RootNamespace> <RootNamespace>Grpc.IntegrationTesting</RootNamespace>
<AssemblyName>Grpc.IntegrationTesting</AssemblyName> <AssemblyName>Grpc.IntegrationTesting</AssemblyName>
<TargetFrameworkVersion>v4.5</TargetFrameworkVersion> <TargetFrameworkVersion>v4.5</TargetFrameworkVersion>
<NuGetPackageImportStamp>041c163e</NuGetPackageImportStamp> <NuGetPackageImportStamp>6566287f</NuGetPackageImportStamp>
</PropertyGroup> </PropertyGroup>
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' "> <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
<DebugSymbols>true</DebugSymbols> <DebugSymbols>true</DebugSymbols>
@ -38,20 +38,33 @@
<AssemblyOriginatorKeyFile>C:\keys\Grpc.snk</AssemblyOriginatorKeyFile> <AssemblyOriginatorKeyFile>C:\keys\Grpc.snk</AssemblyOriginatorKeyFile>
</PropertyGroup> </PropertyGroup>
<ItemGroup> <ItemGroup>
<Reference Include="BouncyCastle.Crypto"> <Reference Include="BouncyCastle.Crypto, Version=1.7.4137.9688, Culture=neutral, PublicKeyToken=a4292a325f69b123, processorArchitecture=MSIL">
<SpecificVersion>False</SpecificVersion>
<HintPath>..\packages\BouncyCastle.1.7.0\lib\Net40-Client\BouncyCastle.Crypto.dll</HintPath> <HintPath>..\packages\BouncyCastle.1.7.0\lib\Net40-Client\BouncyCastle.Crypto.dll</HintPath>
</Reference> </Reference>
<Reference Include="Google.Apis.Auth, Version=1.9.2.27817, Culture=neutral, PublicKeyToken=4b01fa6e34db77ab, processorArchitecture=MSIL"> <Reference Include="Google.Apis.Auth, Version=1.9.3.19379, Culture=neutral, PublicKeyToken=4b01fa6e34db77ab, processorArchitecture=MSIL">
<SpecificVersion>False</SpecificVersion>
<HintPath>..\packages\Google.Apis.Auth.1.9.3\lib\net40\Google.Apis.Auth.dll</HintPath>
</Reference>
<Reference Include="Google.Apis.Auth.PlatformServices, Version=1.9.3.19383, Culture=neutral, PublicKeyToken=4b01fa6e34db77ab, processorArchitecture=MSIL">
<SpecificVersion>False</SpecificVersion>
<HintPath>..\packages\Google.Apis.Auth.1.9.3\lib\net40\Google.Apis.Auth.PlatformServices.dll</HintPath>
</Reference>
<Reference Include="Google.Apis.Core, Version=1.9.3.19379, Culture=neutral, PublicKeyToken=4b01fa6e34db77ab, processorArchitecture=MSIL">
<SpecificVersion>False</SpecificVersion>
<HintPath>..\packages\Google.Apis.Core.1.9.3\lib\portable-net40+sl50+win+wpa81+wp80\Google.Apis.Core.dll</HintPath>
</Reference>
<Reference Include="Microsoft.Threading.Tasks, Version=1.0.12.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL">
<SpecificVersion>False</SpecificVersion> <SpecificVersion>False</SpecificVersion>
<HintPath>..\packages\Google.Apis.Auth.1.9.2\lib\net40\Google.Apis.Auth.dll</HintPath> <HintPath>..\packages\Microsoft.Bcl.Async.1.0.168\lib\net40\Microsoft.Threading.Tasks.dll</HintPath>
</Reference> </Reference>
<Reference Include="Google.Apis.Auth.PlatformServices, Version=1.9.2.27820, Culture=neutral, PublicKeyToken=4b01fa6e34db77ab, processorArchitecture=MSIL"> <Reference Include="Microsoft.Threading.Tasks.Extensions, Version=1.0.12.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL">
<SpecificVersion>False</SpecificVersion> <SpecificVersion>False</SpecificVersion>
<HintPath>..\packages\Google.Apis.Auth.1.9.2\lib\net40\Google.Apis.Auth.PlatformServices.dll</HintPath> <HintPath>..\packages\Microsoft.Bcl.Async.1.0.168\lib\net40\Microsoft.Threading.Tasks.Extensions.dll</HintPath>
</Reference> </Reference>
<Reference Include="Google.Apis.Core, Version=1.9.2.27816, Culture=neutral, PublicKeyToken=4b01fa6e34db77ab, processorArchitecture=MSIL"> <Reference Include="Microsoft.Threading.Tasks.Extensions.Desktop, Version=1.0.168.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL">
<SpecificVersion>False</SpecificVersion> <SpecificVersion>False</SpecificVersion>
<HintPath>..\packages\Google.Apis.Core.1.9.2\lib\portable-net40+sl50+win+wpa81+wp80\Google.Apis.Core.dll</HintPath> <HintPath>..\packages\Microsoft.Bcl.Async.1.0.168\lib\net40\Microsoft.Threading.Tasks.Extensions.Desktop.dll</HintPath>
</Reference> </Reference>
<Reference Include="Newtonsoft.Json, Version=7.0.0.0, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed, processorArchitecture=MSIL"> <Reference Include="Newtonsoft.Json, Version=7.0.0.0, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed, processorArchitecture=MSIL">
<SpecificVersion>False</SpecificVersion> <SpecificVersion>False</SpecificVersion>
@ -78,15 +91,6 @@
<HintPath>..\packages\Microsoft.Net.Http.2.2.29\lib\net45\System.Net.Http.Primitives.dll</HintPath> <HintPath>..\packages\Microsoft.Net.Http.2.2.29\lib\net45\System.Net.Http.Primitives.dll</HintPath>
</Reference> </Reference>
<Reference Include="System.Net.Http.WebRequest" /> <Reference Include="System.Net.Http.WebRequest" />
<Reference Include="Microsoft.Threading.Tasks">
<HintPath>..\packages\Microsoft.Bcl.Async.1.0.168\lib\net40\Microsoft.Threading.Tasks.dll</HintPath>
</Reference>
<Reference Include="Microsoft.Threading.Tasks.Extensions">
<HintPath>..\packages\Microsoft.Bcl.Async.1.0.168\lib\net40\Microsoft.Threading.Tasks.Extensions.dll</HintPath>
</Reference>
<Reference Include="Microsoft.Threading.Tasks.Extensions.Desktop">
<HintPath>..\packages\Microsoft.Bcl.Async.1.0.168\lib\net40\Microsoft.Threading.Tasks.Extensions.Desktop.dll</HintPath>
</Reference>
</ItemGroup> </ItemGroup>
<ItemGroup> <ItemGroup>
<Compile Include="..\Grpc.Core\Version.cs"> <Compile Include="..\Grpc.Core\Version.cs">

@ -43,6 +43,7 @@ using Grpc.Auth;
using Grpc.Core; using Grpc.Core;
using Grpc.Core.Utils; using Grpc.Core.Utils;
using NUnit.Framework; using NUnit.Framework;
using Google.Apis.Auth.OAuth2;
namespace Grpc.IntegrationTesting namespace Grpc.IntegrationTesting
{ {
@ -97,10 +98,10 @@ namespace Grpc.IntegrationTesting
} }
var interopClient = new InteropClient(options); var interopClient = new InteropClient(options);
interopClient.Run(); interopClient.Run().Wait();
} }
private void Run() private async Task Run()
{ {
Credentials credentials = null; Credentials credentials = null;
if (options.useTls) if (options.useTls)
@ -120,17 +121,7 @@ namespace Grpc.IntegrationTesting
using (Channel channel = new Channel(options.serverHost, options.serverPort.Value, credentials, channelOptions)) using (Channel channel = new Channel(options.serverHost, options.serverPort.Value, credentials, channelOptions))
{ {
TestService.TestServiceClient client = new TestService.TestServiceClient(channel); TestService.TestServiceClient client = new TestService.TestServiceClient(channel);
if (options.testCase == "service_account_creds" || options.testCase == "compute_engine_creds") await RunTestCaseAsync(options.testCase, client);
{
var credential = GoogleCredential.GetApplicationDefault();
if (credential.IsCreateScopedRequired)
{
credential = credential.CreateScoped(new[] { AuthScope });
}
client.HeaderInterceptor = OAuth2Interceptors.FromCredential(credential);
}
RunTestCaseAsync(options.testCase, client).Wait();
} }
GrpcEnvironment.Shutdown(); GrpcEnvironment.Shutdown();
} }
@ -158,16 +149,19 @@ namespace Grpc.IntegrationTesting
await RunEmptyStreamAsync(client); await RunEmptyStreamAsync(client);
break; break;
case "service_account_creds": case "service_account_creds":
RunServiceAccountCreds(client); await RunServiceAccountCredsAsync(client);
break; break;
case "compute_engine_creds": case "compute_engine_creds":
RunComputeEngineCreds(client); await RunComputeEngineCredsAsync(client);
break;
case "jwt_token_creds":
await RunJwtTokenCredsAsync(client);
break; break;
case "oauth2_auth_token": case "oauth2_auth_token":
RunOAuth2AuthToken(client); await RunOAuth2AuthTokenAsync(client);
break; break;
case "per_rpc_creds": case "per_rpc_creds":
RunPerRpcCreds(client); await RunPerRpcCredsAsync(client);
break; break;
case "cancel_after_begin": case "cancel_after_begin":
await RunCancelAfterBeginAsync(client); await RunCancelAfterBeginAsync(client);
@ -215,7 +209,7 @@ namespace Grpc.IntegrationTesting
using (var call = client.StreamingInputCall()) using (var call = client.StreamingInputCall())
{ {
await call.RequestStream.WriteAll(bodySizes); await call.RequestStream.WriteAllAsync(bodySizes);
var response = await call.ResponseAsync; var response = await call.ResponseAsync;
Assert.AreEqual(74922, response.AggregatedPayloadSize); Assert.AreEqual(74922, response.AggregatedPayloadSize);
@ -237,7 +231,7 @@ namespace Grpc.IntegrationTesting
using (var call = client.StreamingOutputCall(request)) using (var call = client.StreamingOutputCall(request))
{ {
var responseList = await call.ResponseStream.ToList(); var responseList = await call.ResponseStream.ToListAsync();
foreach (var res in responseList) foreach (var res in responseList)
{ {
Assert.AreEqual(PayloadType.COMPRESSABLE, res.Payload.Type); Assert.AreEqual(PayloadType.COMPRESSABLE, res.Payload.Type);
@ -303,15 +297,19 @@ namespace Grpc.IntegrationTesting
{ {
await call.RequestStream.CompleteAsync(); await call.RequestStream.CompleteAsync();
var responseList = await call.ResponseStream.ToList(); var responseList = await call.ResponseStream.ToListAsync();
Assert.AreEqual(0, responseList.Count); Assert.AreEqual(0, responseList.Count);
} }
Console.WriteLine("Passed!"); Console.WriteLine("Passed!");
} }
public static void RunServiceAccountCreds(TestService.ITestServiceClient client) public static async Task RunServiceAccountCredsAsync(TestService.TestServiceClient client)
{ {
Console.WriteLine("running service_account_creds"); Console.WriteLine("running service_account_creds");
var credential = await GoogleCredential.GetApplicationDefaultAsync();
credential = credential.CreateScoped(new[] { AuthScope });
client.HeaderInterceptor = OAuth2Interceptors.FromCredential(credential);
var request = SimpleRequest.CreateBuilder() var request = SimpleRequest.CreateBuilder()
.SetResponseType(PayloadType.COMPRESSABLE) .SetResponseType(PayloadType.COMPRESSABLE)
.SetResponseSize(314159) .SetResponseSize(314159)
@ -329,9 +327,13 @@ namespace Grpc.IntegrationTesting
Console.WriteLine("Passed!"); Console.WriteLine("Passed!");
} }
public static void RunComputeEngineCreds(TestService.ITestServiceClient client) public static async Task RunComputeEngineCredsAsync(TestService.TestServiceClient client)
{ {
Console.WriteLine("running compute_engine_creds"); Console.WriteLine("running compute_engine_creds");
var credential = await GoogleCredential.GetApplicationDefaultAsync();
Assert.IsFalse(credential.IsCreateScopedRequired);
client.HeaderInterceptor = OAuth2Interceptors.FromCredential(credential);
var request = SimpleRequest.CreateBuilder() var request = SimpleRequest.CreateBuilder()
.SetResponseType(PayloadType.COMPRESSABLE) .SetResponseType(PayloadType.COMPRESSABLE)
.SetResponseSize(314159) .SetResponseSize(314159)
@ -349,12 +351,35 @@ namespace Grpc.IntegrationTesting
Console.WriteLine("Passed!"); Console.WriteLine("Passed!");
} }
public static void RunOAuth2AuthToken(TestService.TestServiceClient client) public static async Task RunJwtTokenCredsAsync(TestService.TestServiceClient client)
{
Console.WriteLine("running jwt_token_creds");
var credential = await GoogleCredential.GetApplicationDefaultAsync();
// check this a credential with scope support, but don't add the scope.
Assert.IsTrue(credential.IsCreateScopedRequired);
client.HeaderInterceptor = OAuth2Interceptors.FromCredential(credential);
var request = SimpleRequest.CreateBuilder()
.SetResponseType(PayloadType.COMPRESSABLE)
.SetResponseSize(314159)
.SetPayload(CreateZerosPayload(271828))
.SetFillUsername(true)
.SetFillOauthScope(true)
.Build();
var response = client.UnaryCall(request);
Assert.AreEqual(PayloadType.COMPRESSABLE, response.Payload.Type);
Assert.AreEqual(314159, response.Payload.Body.Length);
Assert.AreEqual(ServiceAccountUser, response.Username);
Console.WriteLine("Passed!");
}
public static async Task RunOAuth2AuthTokenAsync(TestService.TestServiceClient client)
{ {
Console.WriteLine("running oauth2_auth_token"); Console.WriteLine("running oauth2_auth_token");
var credential = GoogleCredential.GetApplicationDefault().CreateScoped(new[] { AuthScope }); ITokenAccess credential = (await GoogleCredential.GetApplicationDefaultAsync()).CreateScoped(new[] { AuthScope });
Assert.IsTrue(credential.RequestAccessTokenAsync(CancellationToken.None).Result); string oauth2Token = await credential.GetAccessTokenForRequestAsync();
string oauth2Token = credential.Token.AccessToken;
client.HeaderInterceptor = OAuth2Interceptors.FromAccessToken(oauth2Token); client.HeaderInterceptor = OAuth2Interceptors.FromAccessToken(oauth2Token);
@ -370,13 +395,12 @@ namespace Grpc.IntegrationTesting
Console.WriteLine("Passed!"); Console.WriteLine("Passed!");
} }
public static void RunPerRpcCreds(TestService.TestServiceClient client) public static async Task RunPerRpcCredsAsync(TestService.TestServiceClient client)
{ {
Console.WriteLine("running per_rpc_creds"); Console.WriteLine("running per_rpc_creds");
var credential = GoogleCredential.GetApplicationDefault().CreateScoped(new[] { AuthScope }); ITokenAccess credential = (await GoogleCredential.GetApplicationDefaultAsync()).CreateScoped(new[] { AuthScope });
Assert.IsTrue(credential.RequestAccessTokenAsync(CancellationToken.None).Result); string oauth2Token = await credential.GetAccessTokenForRequestAsync();
string oauth2Token = credential.Token.AccessToken;
var headerInterceptor = OAuth2Interceptors.FromAccessToken(oauth2Token); var headerInterceptor = OAuth2Interceptors.FromAccessToken(oauth2Token);
var request = SimpleRequest.CreateBuilder() var request = SimpleRequest.CreateBuilder()
@ -385,7 +409,7 @@ namespace Grpc.IntegrationTesting
.Build(); .Build();
var headers = new Metadata(); var headers = new Metadata();
headerInterceptor(headers); headerInterceptor("", headers);
var response = client.UnaryCall(request, headers: headers); var response = client.UnaryCall(request, headers: headers);
Assert.AreEqual(AuthScopeResponse, response.OauthScope); Assert.AreEqual(AuthScopeResponse, response.OauthScope);

@ -71,7 +71,7 @@ namespace grpc.testing
public async Task<StreamingInputCallResponse> StreamingInputCall(IAsyncStreamReader<StreamingInputCallRequest> requestStream, ServerCallContext context) public async Task<StreamingInputCallResponse> StreamingInputCall(IAsyncStreamReader<StreamingInputCallRequest> requestStream, ServerCallContext context)
{ {
int sum = 0; int sum = 0;
await requestStream.ForEach(async request => await requestStream.ForEachAsync(async request =>
{ {
sum += request.Payload.Body.Length; sum += request.Payload.Body.Length;
}); });
@ -80,7 +80,7 @@ namespace grpc.testing
public async Task FullDuplexCall(IAsyncStreamReader<StreamingOutputCallRequest> requestStream, IServerStreamWriter<StreamingOutputCallResponse> responseStream, ServerCallContext context) public async Task FullDuplexCall(IAsyncStreamReader<StreamingOutputCallRequest> requestStream, IServerStreamWriter<StreamingOutputCallResponse> responseStream, ServerCallContext context)
{ {
await requestStream.ForEach(async request => await requestStream.ForEachAsync(async request =>
{ {
foreach (var responseParam in request.ResponseParametersList) foreach (var responseParam in request.ResponseParametersList)
{ {

@ -10,6 +10,10 @@
<assemblyIdentity name="System.Net.Http" publicKeyToken="b03f5f7f11d50a3a" culture="neutral" /> <assemblyIdentity name="System.Net.Http" publicKeyToken="b03f5f7f11d50a3a" culture="neutral" />
<bindingRedirect oldVersion="0.0.0.0-4.2.28.0" newVersion="4.0.0.0" /> <bindingRedirect oldVersion="0.0.0.0-4.2.28.0" newVersion="4.0.0.0" />
</dependentAssembly> </dependentAssembly>
<dependentAssembly>
<assemblyIdentity name="Google.Apis.Core" publicKeyToken="4b01fa6e34db77ab" culture="neutral" />
<bindingRedirect oldVersion="0.0.0.0-1.9.2.38523" newVersion="1.9.2.38523" />
</dependentAssembly>
</assemblyBinding> </assemblyBinding>
</runtime> </runtime>
</configuration> </configuration>

@ -1,8 +1,8 @@
<?xml version="1.0" encoding="utf-8"?> <?xml version="1.0" encoding="utf-8"?>
<packages> <packages>
<package id="BouncyCastle" version="1.7.0" targetFramework="net45" /> <package id="BouncyCastle" version="1.7.0" targetFramework="net45" />
<package id="Google.Apis.Auth" version="1.9.2" targetFramework="net45" /> <package id="Google.Apis.Auth" version="1.9.3" targetFramework="net45" />
<package id="Google.Apis.Core" version="1.9.2" targetFramework="net45" /> <package id="Google.Apis.Core" version="1.9.3" targetFramework="net45" />
<package id="Google.ProtocolBuffers" version="2.4.1.521" targetFramework="net45" /> <package id="Google.ProtocolBuffers" version="2.4.1.521" targetFramework="net45" />
<package id="Ix-Async" version="1.2.3" targetFramework="net45" /> <package id="Ix-Async" version="1.2.3" targetFramework="net45" />
<package id="Microsoft.Bcl" version="1.1.10" targetFramework="net45" /> <package id="Microsoft.Bcl" version="1.1.10" targetFramework="net45" />

@ -63,7 +63,7 @@ function runTest(iterations, callback) {
var timeDiff = process.hrtime(startTime); var timeDiff = process.hrtime(startTime);
intervals[i] = timeDiff[0] * 1000000 + timeDiff[1] / 1000; intervals[i] = timeDiff[0] * 1000000 + timeDiff[1] / 1000;
next(i+1); next(i+1);
}, {}, deadline); }, {}, {deadline: deadline});
} }
} }
next(0); next(0);

@ -510,10 +510,21 @@ NAN_METHOD(Call::New) {
NanUtf8String method(args[1]); NanUtf8String method(args[1]);
double deadline = args[2]->NumberValue(); double deadline = args[2]->NumberValue();
grpc_channel *wrapped_channel = channel->GetWrappedChannel(); grpc_channel *wrapped_channel = channel->GetWrappedChannel();
grpc_call *wrapped_call = grpc_channel_create_call( grpc_call *wrapped_call;
if (args[3]->IsString()) {
NanUtf8String host_override(args[3]);
wrapped_call = grpc_channel_create_call(
wrapped_channel, NULL, GRPC_PROPAGATE_DEFAULTS, wrapped_channel, NULL, GRPC_PROPAGATE_DEFAULTS,
CompletionQueueAsyncWorker::GetQueue(), *method, channel->GetHost(), CompletionQueueAsyncWorker::GetQueue(), *method,
MillisecondsToTimespec(deadline), NULL); *host_override, MillisecondsToTimespec(deadline), NULL);
} else if (args[3]->IsUndefined() || args[3]->IsNull()) {
wrapped_call = grpc_channel_create_call(
wrapped_channel, NULL, GRPC_PROPAGATE_DEFAULTS,
CompletionQueueAsyncWorker::GetQueue(), *method,
NULL, MillisecondsToTimespec(deadline), NULL);
} else {
return NanThrowTypeError("Call's fourth argument must be a string");
}
call = new Call(wrapped_call); call = new Call(wrapped_call);
args.This()->SetHiddenValue(NanNew("channel_"), channel_object); args.This()->SetHiddenValue(NanNew("channel_"), channel_object);
} }

@ -59,14 +59,12 @@ using v8::Value;
NanCallback *Channel::constructor; NanCallback *Channel::constructor;
Persistent<FunctionTemplate> Channel::fun_tpl; Persistent<FunctionTemplate> Channel::fun_tpl;
Channel::Channel(grpc_channel *channel, NanUtf8String *host) Channel::Channel(grpc_channel *channel) : wrapped_channel(channel) {}
: wrapped_channel(channel), host(host) {}
Channel::~Channel() { Channel::~Channel() {
if (wrapped_channel != NULL) { if (wrapped_channel != NULL) {
grpc_channel_destroy(wrapped_channel); grpc_channel_destroy(wrapped_channel);
} }
delete host;
} }
void Channel::Init(Handle<Object> exports) { void Channel::Init(Handle<Object> exports) {
@ -91,8 +89,6 @@ bool Channel::HasInstance(Handle<Value> val) {
grpc_channel *Channel::GetWrappedChannel() { return this->wrapped_channel; } grpc_channel *Channel::GetWrappedChannel() { return this->wrapped_channel; }
char *Channel::GetHost() { return **this->host; }
NAN_METHOD(Channel::New) { NAN_METHOD(Channel::New) {
NanScope(); NanScope();
@ -103,8 +99,7 @@ NAN_METHOD(Channel::New) {
} }
grpc_channel *wrapped_channel; grpc_channel *wrapped_channel;
// Owned by the Channel object // Owned by the Channel object
NanUtf8String *host = new NanUtf8String(args[0]); NanUtf8String host(args[0]);
NanUtf8String *host_override = NULL;
grpc_credentials *creds; grpc_credentials *creds;
if (!Credentials::HasInstance(args[1])) { if (!Credentials::HasInstance(args[1])) {
return NanThrowTypeError( return NanThrowTypeError(
@ -116,12 +111,9 @@ NAN_METHOD(Channel::New) {
grpc_channel_args *channel_args_ptr; grpc_channel_args *channel_args_ptr;
if (args[2]->IsUndefined()) { if (args[2]->IsUndefined()) {
channel_args_ptr = NULL; channel_args_ptr = NULL;
wrapped_channel = grpc_insecure_channel_create(**host, NULL, NULL); wrapped_channel = grpc_insecure_channel_create(*host, NULL, NULL);
} else if (args[2]->IsObject()) { } else if (args[2]->IsObject()) {
Handle<Object> args_hash(args[2]->ToObject()->Clone()); Handle<Object> args_hash(args[2]->ToObject()->Clone());
if (args_hash->HasOwnProperty(NanNew(GRPC_SSL_TARGET_NAME_OVERRIDE_ARG))) {
host_override = new NanUtf8String(args_hash->Get(NanNew(GRPC_SSL_TARGET_NAME_OVERRIDE_ARG)));
}
Handle<Array> keys(args_hash->GetOwnPropertyNames()); Handle<Array> keys(args_hash->GetOwnPropertyNames());
grpc_channel_args channel_args; grpc_channel_args channel_args;
channel_args.num_args = keys->Length(); channel_args.num_args = keys->Length();
@ -153,20 +145,15 @@ NAN_METHOD(Channel::New) {
return NanThrowTypeError("Channel expects a string and an object"); return NanThrowTypeError("Channel expects a string and an object");
} }
if (creds == NULL) { if (creds == NULL) {
wrapped_channel = grpc_insecure_channel_create(**host, channel_args_ptr); wrapped_channel = grpc_insecure_channel_create(*host, channel_args_ptr);
} else { } else {
wrapped_channel = wrapped_channel =
grpc_secure_channel_create(creds, **host, channel_args_ptr); grpc_secure_channel_create(creds, *host, channel_args_ptr);
} }
if (channel_args_ptr != NULL) { if (channel_args_ptr != NULL) {
free(channel_args_ptr->args); free(channel_args_ptr->args);
} }
Channel *channel; Channel *channel = new Channel(wrapped_channel);
if (host_override == NULL) {
channel = new Channel(wrapped_channel, host);
} else {
channel = new Channel(wrapped_channel, host_override);
}
channel->Wrap(args.This()); channel->Wrap(args.This());
NanReturnValue(args.This()); NanReturnValue(args.This());
} else { } else {

@ -53,11 +53,8 @@ class Channel : public ::node::ObjectWrap {
/* Returns the grpc_channel struct that this object wraps */ /* Returns the grpc_channel struct that this object wraps */
grpc_channel *GetWrappedChannel(); grpc_channel *GetWrappedChannel();
/* Return the hostname that this channel connects to */
char *GetHost();
private: private:
explicit Channel(grpc_channel *channel, NanUtf8String *host); explicit Channel(grpc_channel *channel);
~Channel(); ~Channel();
// Prevent copying // Prevent copying
@ -71,7 +68,6 @@ class Channel : public ::node::ObjectWrap {
static v8::Persistent<v8::FunctionTemplate> fun_tpl; static v8::Persistent<v8::FunctionTemplate> fun_tpl;
grpc_channel *wrapped_channel; grpc_channel *wrapped_channel;
NanUtf8String *host;
}; };
} // namespace node } // namespace node

@ -67,7 +67,7 @@ function zeroBuffer(size) {
* primarily for use with mocha * primarily for use with mocha
*/ */
function emptyUnary(client, done) { function emptyUnary(client, done) {
var call = client.emptyCall({}, function(err, resp) { client.emptyCall({}, function(err, resp) {
assert.ifError(err); assert.ifError(err);
if (done) { if (done) {
done(); done();
@ -89,7 +89,7 @@ function largeUnary(client, done) {
body: zeroBuffer(271828) body: zeroBuffer(271828)
} }
}; };
var call = client.unaryCall(arg, function(err, resp) { client.unaryCall(arg, function(err, resp) {
assert.ifError(err); assert.ifError(err);
assert.strictEqual(resp.payload.type, 'COMPRESSABLE'); assert.strictEqual(resp.payload.type, 'COMPRESSABLE');
assert.strictEqual(resp.payload.body.length, 314159); assert.strictEqual(resp.payload.body.length, 314159);
@ -259,7 +259,7 @@ function cancelAfterFirstResponse(client, done) {
function timeoutOnSleepingServer(client, done) { function timeoutOnSleepingServer(client, done) {
var deadline = new Date(); var deadline = new Date();
deadline.setMilliseconds(deadline.getMilliseconds() + 1); deadline.setMilliseconds(deadline.getMilliseconds() + 1);
var call = client.fullDuplexCall(null, deadline); var call = client.fullDuplexCall(null, {deadline: deadline});
call.write({ call.write({
payload: {body: zeroBuffer(27182)} payload: {body: zeroBuffer(27182)}
}); });
@ -293,7 +293,7 @@ function authTest(expected_user, scope, client, done) {
fill_username: true, fill_username: true,
fill_oauth_scope: true fill_oauth_scope: true
}; };
var call = client.unaryCall(arg, function(err, resp) { client.unaryCall(arg, function(err, resp) {
assert.ifError(err); assert.ifError(err);
assert.strictEqual(resp.payload.type, 'COMPRESSABLE'); assert.strictEqual(resp.payload.type, 'COMPRESSABLE');
assert.strictEqual(resp.payload.body.length, 314159); assert.strictEqual(resp.payload.body.length, 314159);
@ -328,7 +328,7 @@ function oauth2Test(expected_user, scope, per_rpc, client, done) {
}; };
var makeTestCall = function(error, client_metadata) { var makeTestCall = function(error, client_metadata) {
assert.ifError(error); assert.ifError(error);
var call = client.unaryCall(arg, function(err, resp) { client.unaryCall(arg, function(err, resp) {
assert.ifError(err); assert.ifError(err);
assert.strictEqual(resp.username, expected_user); assert.strictEqual(resp.username, expected_user);
assert.strictEqual(resp.oauth_scope, AUTH_SCOPE_RESPONSE); assert.strictEqual(resp.oauth_scope, AUTH_SCOPE_RESPONSE);
@ -393,6 +393,7 @@ function runTest(address, host_override, test_case, tls, test_ca, done) {
creds = grpc.Credentials.createSsl(ca_data); creds = grpc.Credentials.createSsl(ca_data);
if (host_override) { if (host_override) {
options['grpc.ssl_target_name_override'] = host_override; options['grpc.ssl_target_name_override'] = host_override;
options['grpc.default_authority'] = host_override;
} }
} else { } else {
creds = grpc.Credentials.createInsecure(); creds = grpc.Credentials.createInsecure();

@ -207,6 +207,25 @@ ClientReadableStream.prototype.getPeer = getPeer;
ClientWritableStream.prototype.getPeer = getPeer; ClientWritableStream.prototype.getPeer = getPeer;
ClientDuplexStream.prototype.getPeer = getPeer; ClientDuplexStream.prototype.getPeer = getPeer;
/**
* Get a call object built with the provided options. Keys for options are
* 'deadline', which takes a date or number, and 'host', which takes a string
* and overrides the hostname to connect to.
* @param {Object} options Options map.
*/
function getCall(channel, method, options) {
var deadline;
var host;
if (options) {
deadline = options.deadline;
host = options.host;
}
if (deadline === undefined) {
deadline = Infinity;
}
return new grpc.Call(channel, method, deadline, host);
}
/** /**
* Get a function that can make unary requests to the specified method. * Get a function that can make unary requests to the specified method.
* @param {string} method The name of the method to request * @param {string} method The name of the method to request
@ -226,17 +245,13 @@ function makeUnaryRequestFunction(method, serialize, deserialize) {
* response is received * response is received
* @param {array=} metadata Array of metadata key/value pairs to add to the * @param {array=} metadata Array of metadata key/value pairs to add to the
* call * call
* @param {(number|Date)=} deadline The deadline for processing this request. * @param {Object=} options Options map
* Defaults to infinite future
* @return {EventEmitter} An event emitter for stream related events * @return {EventEmitter} An event emitter for stream related events
*/ */
function makeUnaryRequest(argument, callback, metadata, deadline) { function makeUnaryRequest(argument, callback, metadata, options) {
/* jshint validthis: true */ /* jshint validthis: true */
if (deadline === undefined) {
deadline = Infinity;
}
var emitter = new EventEmitter(); var emitter = new EventEmitter();
var call = new grpc.Call(this.channel, method, deadline); var call = getCall(this.channel, method, options);
if (metadata === null || metadata === undefined) { if (metadata === null || metadata === undefined) {
metadata = {}; metadata = {};
} }
@ -300,16 +315,12 @@ function makeClientStreamRequestFunction(method, serialize, deserialize) {
* response is received * response is received
* @param {array=} metadata Array of metadata key/value pairs to add to the * @param {array=} metadata Array of metadata key/value pairs to add to the
* call * call
* @param {(number|Date)=} deadline The deadline for processing this request. * @param {Object=} options Options map
* Defaults to infinite future
* @return {EventEmitter} An event emitter for stream related events * @return {EventEmitter} An event emitter for stream related events
*/ */
function makeClientStreamRequest(callback, metadata, deadline) { function makeClientStreamRequest(callback, metadata, options) {
/* jshint validthis: true */ /* jshint validthis: true */
if (deadline === undefined) { var call = getCall(this.channel, method, options);
deadline = Infinity;
}
var call = new grpc.Call(this.channel, method, deadline);
if (metadata === null || metadata === undefined) { if (metadata === null || metadata === undefined) {
metadata = {}; metadata = {};
} }
@ -374,16 +385,12 @@ function makeServerStreamRequestFunction(method, serialize, deserialize) {
* serialize * serialize
* @param {array=} metadata Array of metadata key/value pairs to add to the * @param {array=} metadata Array of metadata key/value pairs to add to the
* call * call
* @param {(number|Date)=} deadline The deadline for processing this request. * @param {Object} options Options map
* Defaults to infinite future
* @return {EventEmitter} An event emitter for stream related events * @return {EventEmitter} An event emitter for stream related events
*/ */
function makeServerStreamRequest(argument, metadata, deadline) { function makeServerStreamRequest(argument, metadata, options) {
/* jshint validthis: true */ /* jshint validthis: true */
if (deadline === undefined) { var call = getCall(this.channel, method, options);
deadline = Infinity;
}
var call = new grpc.Call(this.channel, method, deadline);
if (metadata === null || metadata === undefined) { if (metadata === null || metadata === undefined) {
metadata = {}; metadata = {};
} }
@ -446,16 +453,12 @@ function makeBidiStreamRequestFunction(method, serialize, deserialize) {
* @this {SurfaceClient} Client object. Must have a channel member. * @this {SurfaceClient} Client object. Must have a channel member.
* @param {array=} metadata Array of metadata key/value pairs to add to the * @param {array=} metadata Array of metadata key/value pairs to add to the
* call * call
* @param {(number|Date)=} deadline The deadline for processing this request. * @param {Options} options Options map
* Defaults to infinite future
* @return {EventEmitter} An event emitter for stream related events * @return {EventEmitter} An event emitter for stream related events
*/ */
function makeBidiStreamRequest(metadata, deadline) { function makeBidiStreamRequest(metadata, options) {
/* jshint validthis: true */ /* jshint validthis: true */
if (deadline === undefined) { var call = getCall(this.channel, method, options);
deadline = Infinity;
}
var call = new grpc.Call(this.channel, method, deadline);
if (metadata === null || metadata === undefined) { if (metadata === null || metadata === undefined) {
metadata = {}; metadata = {};
} }

@ -84,6 +84,11 @@ describe('call', function() {
new grpc.Call(channel, 'method', 0); new grpc.Call(channel, 'method', 0);
}); });
}); });
it('should accept an optional fourth string parameter', function() {
assert.doesNotThrow(function() {
new grpc.Call(channel, 'method', new Date(), 'host_override');
});
});
it('should fail with a closed channel', function() { it('should fail with a closed channel', function() {
var local_channel = new grpc.Channel('hostname', insecureCreds); var local_channel = new grpc.Channel('hostname', insecureCreds);
local_channel.close(); local_channel.close();

@ -74,8 +74,6 @@ describe('end-to-end', function() {
}); });
it('should start and end a request without error', function(complete) { it('should start and end a request without error', function(complete) {
var done = multiDone(complete, 2); var done = multiDone(complete, 2);
var deadline = new Date();
deadline.setSeconds(deadline.getSeconds() + 3);
var status_text = 'xyz'; var status_text = 'xyz';
var call = new grpc.Call(channel, var call = new grpc.Call(channel,
'dummy_method', 'dummy_method',
@ -126,8 +124,6 @@ describe('end-to-end', function() {
}); });
it('should successfully send and receive metadata', function(complete) { it('should successfully send and receive metadata', function(complete) {
var done = multiDone(complete, 2); var done = multiDone(complete, 2);
var deadline = new Date();
deadline.setSeconds(deadline.getSeconds() + 3);
var status_text = 'xyz'; var status_text = 'xyz';
var call = new grpc.Call(channel, var call = new grpc.Call(channel,
'dummy_method', 'dummy_method',
@ -184,8 +180,6 @@ describe('end-to-end', function() {
var req_text = 'client_request'; var req_text = 'client_request';
var reply_text = 'server_response'; var reply_text = 'server_response';
var done = multiDone(complete, 2); var done = multiDone(complete, 2);
var deadline = new Date();
deadline.setSeconds(deadline.getSeconds() + 3);
var status_text = 'success'; var status_text = 'success';
var call = new grpc.Call(channel, var call = new grpc.Call(channel,
'dummy_method', 'dummy_method',
@ -241,8 +235,6 @@ describe('end-to-end', function() {
it('should send multiple messages', function(complete) { it('should send multiple messages', function(complete) {
var done = multiDone(complete, 2); var done = multiDone(complete, 2);
var requests = ['req1', 'req2']; var requests = ['req1', 'req2'];
var deadline = new Date();
deadline.setSeconds(deadline.getSeconds() + 3);
var status_text = 'xyz'; var status_text = 'xyz';
var call = new grpc.Call(channel, var call = new grpc.Call(channel,
'dummy_method', 'dummy_method',

@ -96,7 +96,7 @@ Server *pygrpc_Server_new(PyTypeObject *type, PyObject *args, PyObject *kwargs)
PyObject *py_args; PyObject *py_args;
grpc_channel_args c_args; grpc_channel_args c_args;
char *keywords[] = {"cq", "args", NULL}; char *keywords[] = {"cq", "args", NULL};
if (!PyArg_ParseTupleAndKeywords(args, kwargs, "O!O:Channel", keywords, if (!PyArg_ParseTupleAndKeywords(args, kwargs, "O!O:Server", keywords,
&pygrpc_CompletionQueue_type, &cq, &py_args)) { &pygrpc_CompletionQueue_type, &cq, &py_args)) {
return NULL; return NULL;
} }

@ -203,7 +203,10 @@ static VALUE grpc_rb_channel_create_call(VALUE self, VALUE cqueue, VALUE method,
grpc_channel *ch = NULL; grpc_channel *ch = NULL;
grpc_completion_queue *cq = NULL; grpc_completion_queue *cq = NULL;
char *method_chars = StringValueCStr(method); char *method_chars = StringValueCStr(method);
char *host_chars = StringValueCStr(host); char *host_chars = NULL;
if (host != Qnil) {
host_chars = StringValueCStr(host);
}
cq = grpc_rb_get_wrapped_completion_queue(cqueue); cq = grpc_rb_get_wrapped_completion_queue(cqueue);
TypedData_Get_Struct(self, grpc_rb_channel, &grpc_channel_data_type, wrapper); TypedData_Get_Struct(self, grpc_rb_channel, &grpc_channel_data_type, wrapper);

@ -410,7 +410,7 @@ module GRPC
# @param timeout [TimeConst] # @param timeout [TimeConst]
def new_active_call(method, marshal, unmarshal, timeout = nil) def new_active_call(method, marshal, unmarshal, timeout = nil)
deadline = from_relative_time(timeout.nil? ? @timeout : timeout) deadline = from_relative_time(timeout.nil? ? @timeout : timeout)
call = @ch.create_call(@queue, method, @host, deadline) call = @ch.create_call(@queue, method, nil, deadline)
ActiveCall.new(call, @queue, marshal, unmarshal, deadline, started: false) ActiveCall.new(call, @queue, marshal, unmarshal, deadline, started: false)
end end
end end

@ -137,7 +137,7 @@ describe GRPC::Core::Call do
end end
def make_test_call def make_test_call
@ch.create_call(client_queue, 'dummy_method', 'dummy_host', deadline) @ch.create_call(client_queue, 'dummy_method', nil, deadline)
end end
def deadline def deadline

@ -117,7 +117,7 @@ describe GRPC::Core::Channel do
deadline = Time.now + 5 deadline = Time.now + 5
blk = proc do blk = proc do
ch.create_call(cq, 'dummy_method', 'dummy_host', deadline) ch.create_call(cq, 'dummy_method', nil, deadline)
end end
expect(&blk).to_not raise_error expect(&blk).to_not raise_error
end end
@ -128,7 +128,7 @@ describe GRPC::Core::Channel do
deadline = Time.now + 5 deadline = Time.now + 5
blk = proc do blk = proc do
ch.create_call(cq, 'dummy_method', 'dummy_host', deadline) ch.create_call(cq, 'dummy_method', nil, deadline)
end end
expect(&blk).to raise_error(RuntimeError) expect(&blk).to raise_error(RuntimeError)
end end

@ -61,7 +61,7 @@ shared_context 'setup: tags' do
end end
def new_client_call def new_client_call
@ch.create_call(@client_queue, '/method', 'foo.test.google.fr', deadline) @ch.create_call(@client_queue, '/method', nil, deadline)
end end
end end

@ -338,7 +338,7 @@ describe GRPC::ActiveCall do
end end
def make_test_call def make_test_call
@ch.create_call(@client_queue, '/method', 'a.dummy.host', deadline) @ch.create_call(@client_queue, '/method', nil, deadline)
end end
def deadline def deadline

@ -112,7 +112,7 @@ int main(int argc, char **argv) {
while (!sync.is_done) { while (!sync.is_done) {
grpc_pollset_worker worker; grpc_pollset_worker worker;
grpc_pollset_work(&sync.pollset, &worker, grpc_pollset_work(&sync.pollset, &worker,
gpr_inf_future(GPR_CLOCK_REALTIME)); gpr_inf_future(GPR_CLOCK_MONOTONIC));
} }
gpr_mu_unlock(GRPC_POLLSET_MU(&sync.pollset)); gpr_mu_unlock(GRPC_POLLSET_MU(&sync.pollset));

@ -117,7 +117,7 @@ class Proxy : public ::grpc::cpp::test::util::TestService::Service {
} }
private: private:
std::unique_ptr<::grpc::cpp::test::util::TestService::Stub> stub_; std::unique_ptr< ::grpc::cpp::test::util::TestService::Stub> stub_;
}; };
class TestServiceImpl : public ::grpc::cpp::test::util::TestService::Service { class TestServiceImpl : public ::grpc::cpp::test::util::TestService::Service {

Loading…
Cancel
Save