Added TODO for php.

pull/7190/head
David Garcia Quintas 9 years ago
parent 6721d4f0f1
commit 9ac997acf2
  1. 2
      src/objective-c/GRPCClient/private/NSData+GRPC.m
  2. 1
      src/php/ext/grpc/byte_buffer.c

@ -44,7 +44,7 @@ static void MallocAndCopyByteBufferToCharArray(grpc_byte_buffer *buffer,
grpc_byte_buffer_reader reader;
if (!grpc_byte_buffer_reader_init(&reader, buffer)) {
*array = NULL;
*lenght = 0;
*length = 0;
return;
}
// The slice contains uncompressed data even if compressed data was received

@ -60,6 +60,7 @@ void byte_buffer_to_string(grpc_byte_buffer *buffer, char **out_string,
size_t *out_length) {
grpc_byte_buffer_reader reader;
if (buffer == NULL || !grpc_byte_buffer_reader_init(&reader, buffer)) {
/* TODO(dgq): distinguish between the error cases. */
*out_string = NULL;
*out_length = 0;
return;

Loading…
Cancel
Save