From 93d6344ac60ccb5bb6aec5f12be42c0ba581dcfc Mon Sep 17 00:00:00 2001 From: Richard Belleville Date: Tue, 25 Jun 2019 13:25:54 -0700 Subject: [PATCH] Add todo --- examples/python/cancellation/client.py | 2 ++ examples/python/cancellation/server.py | 4 ---- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/examples/python/cancellation/client.py b/examples/python/cancellation/client.py index c3bc226be2c..20b76784622 100644 --- a/examples/python/cancellation/client.py +++ b/examples/python/cancellation/client.py @@ -92,6 +92,8 @@ def run_streaming_client(server_target, name, ideal_distance, # Enqueue a sentinel to signal the end of the stream. result_queue.put(None) + # TODO(https://github.com/grpc/grpc/issues/19464): Do everything on the + # main thread. response_thread = threading.Thread( target=iterate_responses, args=(result_generator, result_queue)) response_thread.daemon = True diff --git a/examples/python/cancellation/server.py b/examples/python/cancellation/server.py index 44b8ee26139..a316a7c2c60 100644 --- a/examples/python/cancellation/server.py +++ b/examples/python/cancellation/server.py @@ -83,10 +83,6 @@ class ResourceLimitExceededError(Exception): """Signifies the request has exceeded configured limits.""" -# TODO(rbellevi): File issue about indefinite blocking for server-side -# streaming. - - def _find_secret_of_length(target, ideal_distance, length,