From 917af9a47f6141b897e1288a71e846f054941a39 Mon Sep 17 00:00:00 2001 From: Jan Tattermusch Date: Fri, 7 Sep 2018 13:13:27 -0700 Subject: [PATCH] use finally instead of catch-throw --- src/csharp/Grpc.Core/Internal/AsyncCall.cs | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/src/csharp/Grpc.Core/Internal/AsyncCall.cs b/src/csharp/Grpc.Core/Internal/AsyncCall.cs index 0953f59a189..4cdf0ee6a72 100644 --- a/src/csharp/Grpc.Core/Internal/AsyncCall.cs +++ b/src/csharp/Grpc.Core/Internal/AsyncCall.cs @@ -125,7 +125,7 @@ namespace Grpc.Core.Internal } } } - catch (Exception) + finally { if (!callStartedOk) { @@ -134,7 +134,6 @@ namespace Grpc.Core.Internal OnFailedToStartCallLocked(); } } - throw; } // Once the blocking call returns, the result should be available synchronously. @@ -172,13 +171,12 @@ namespace Grpc.Core.Internal return unaryResponseTcs.Task; } - catch (Exception) + finally { if (!callStartedOk) { OnFailedToStartCallLocked(); } - throw; } } } @@ -210,13 +208,12 @@ namespace Grpc.Core.Internal return unaryResponseTcs.Task; } - catch (Exception) + finally { if (!callStartedOk) { OnFailedToStartCallLocked(); } - throw; } } } @@ -248,13 +245,12 @@ namespace Grpc.Core.Internal } call.StartReceiveInitialMetadata(ReceivedResponseHeadersCallback); } - catch (Exception) + finally { if (!callStartedOk) { OnFailedToStartCallLocked(); } - throw; } } } @@ -283,13 +279,12 @@ namespace Grpc.Core.Internal } call.StartReceiveInitialMetadata(ReceivedResponseHeadersCallback); } - catch (Exception) + finally { if (!callStartedOk) { OnFailedToStartCallLocked(); } - throw; } } }