Chiebot-Mirror
/
grpc
mirror of https://github.com/grpc/grpc.git
8
0
Fork 0
Code Issues Projects Releases Wiki Activity

[OTel C++] Simplify tests (#37486)

Browse Source 
It is hard to reason about tests if multiple callbacks record values for the same metrics with the same label sets.

Closes #37486

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/37486 from yashykt:SimplifyOTelPluginTest 3b4d7f90b3
PiperOrigin-RevId: 663457107
pull/37312/head
Yash Tibrewal 6 months ago committed by Copybara-Service
parent 7407dbf21d
commit 910953e7ef
1 changed files with 5 additions and 20 deletions
Whitespace
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Split View
Diff Options
Show Stats Download Patch File Download Diff File
  1. 25
      test/cpp/ext/otel/otel_plugin_test.cc

25
test/cpp/ext/otel/otel_plugin_test.cc
Unescape View File

@ -1775,14 +1775,11 @@ TEST_F(OpenTelemetryPluginCallbackMetricsTest,
auto registered_metric_callback_1 = stats_plugins.RegisterCallback(
[&](grpc_core::CallbackMetricReporter& reporter) {
++report_count_1;
reporter.Report(integer_gauge_handle, int_value_1, kLabelValuesSet1,
reporter.Report(integer_gauge_handle, int_value_1++, kLabelValuesSet1,
kOptionalLabelValuesSet1);
reporter.Report(integer_gauge_handle, int_value_1++, kLabelValuesSet2,
kOptionalLabelValuesSet2);
reporter.Report(double_gauge_handle, double_value_1, kLabelValuesSet1,
reporter.Report(double_gauge_handle, double_value_1++, kLabelValuesSet1,
kOptionalLabelValuesSet1);
reporter.Report(double_gauge_handle, double_value_1++, kLabelValuesSet2,
kOptionalLabelValuesSet2);
;
},
grpc_core::Duration::Milliseconds(100) * grpc_test_slowdown_factor(),
integer_gauge_handle, double_gauge_handle);
@ -1792,12 +1789,8 @@ TEST_F(OpenTelemetryPluginCallbackMetricsTest,
auto registered_metric_callback_2 = stats_plugins.RegisterCallback(
[&](grpc_core::CallbackMetricReporter& reporter) {
++report_count_2;
reporter.Report(integer_gauge_handle, int_value_2, kLabelValuesSet1,
kOptionalLabelValuesSet1);
reporter.Report(integer_gauge_handle, int_value_2++, kLabelValuesSet2,
kOptionalLabelValuesSet2);
reporter.Report(double_gauge_handle, double_value_2, kLabelValuesSet1,
kOptionalLabelValuesSet1);
reporter.Report(double_gauge_handle, double_value_2++, kLabelValuesSet2,
kOptionalLabelValuesSet2);
},
@ -1910,14 +1903,10 @@ TEST_F(OpenTelemetryPluginCallbackMetricsTest,
auto registered_metric_callback_1 = stats_plugins.RegisterCallback(
[&](grpc_core::CallbackMetricReporter& reporter) {
++report_count_1;
reporter.Report(integer_gauge_handle, int_value_1, kLabelValuesSet1,
reporter.Report(integer_gauge_handle, int_value_1++, kLabelValuesSet1,
kOptionalLabelValuesSet1);
reporter.Report(integer_gauge_handle, int_value_1++, kLabelValuesSet2,
kOptionalLabelValuesSet2);
reporter.Report(double_gauge_handle, double_value_1, kLabelValuesSet1,
reporter.Report(double_gauge_handle, double_value_1++, kLabelValuesSet1,
kOptionalLabelValuesSet1);
reporter.Report(double_gauge_handle, double_value_1++, kLabelValuesSet2,
kOptionalLabelValuesSet2);
},
grpc_core::Duration::Milliseconds(50) * grpc_test_slowdown_factor(),
integer_gauge_handle, double_gauge_handle);
@ -1927,12 +1916,8 @@ TEST_F(OpenTelemetryPluginCallbackMetricsTest,
auto registered_metric_callback_2 = stats_plugins.RegisterCallback(
[&](grpc_core::CallbackMetricReporter& reporter) {
++report_count_2;
reporter.Report(integer_gauge_handle, int_value_2, kLabelValuesSet1,
kOptionalLabelValuesSet1);
reporter.Report(integer_gauge_handle, int_value_2++, kLabelValuesSet2,
kOptionalLabelValuesSet2);
reporter.Report(double_gauge_handle, double_value_2, kLabelValuesSet1,
kOptionalLabelValuesSet1);
reporter.Report(double_gauge_handle, double_value_2++, kLabelValuesSet2,
kOptionalLabelValuesSet2);
},

Write Preview
Loading…
Cancel
Save