From 4396f06fe7d008886621324d4062326a4cadcbf1 Mon Sep 17 00:00:00 2001 From: ctiller <10120821+ctiller@users.noreply.github.com> Date: Wed, 24 Apr 2024 03:18:19 +0000 Subject: [PATCH] Automated change: Fix sanity tests --- src/core/lib/channel/promise_based_filter.h | 80 +++++++++---------- src/core/lib/promise/party.cc | 2 +- src/core/lib/transport/call_arena_allocator.h | 6 +- src/core/lib/transport/call_filters.h | 46 +++++------ src/core/lib/transport/interception_chain.cc | 9 +-- test/core/promise/BUILD | 4 +- test/core/promise/poll_matcher.h | 6 +- test/core/transport/BUILD | 2 +- .../client_transport_error_test.cc | 5 +- .../transport/chaotic_good/transport_test.h | 5 +- test/core/transport/test_suite/test.h | 5 +- 11 files changed, 81 insertions(+), 89 deletions(-) diff --git a/src/core/lib/channel/promise_based_filter.h b/src/core/lib/channel/promise_based_filter.h index 41d16451591..32af82253f0 100644 --- a/src/core/lib/channel/promise_based_filter.h +++ b/src/core/lib/channel/promise_based_filter.h @@ -350,7 +350,7 @@ auto MapResult(const NoInterceptor*, Promise x, void*) { } template -auto MapResult(absl::Status (Derived::Call::* fn)(ServerMetadata&), Promise x, +auto MapResult(absl::Status (Derived::Call::*fn)(ServerMetadata&), Promise x, FilterCallData* call_data) { GPR_DEBUG_ASSERT(fn == &Derived::Call::OnServerTrailingMetadata); return Map(std::move(x), [call_data](ServerMetadataHandle md) { @@ -361,7 +361,7 @@ auto MapResult(absl::Status (Derived::Call::* fn)(ServerMetadata&), Promise x, } template -auto MapResult(void (Derived::Call::* fn)(ServerMetadata&), Promise x, +auto MapResult(void (Derived::Call::*fn)(ServerMetadata&), Promise x, FilterCallData* call_data) { GPR_DEBUG_ASSERT(fn == &Derived::Call::OnServerTrailingMetadata); return Map(std::move(x), [call_data](ServerMetadataHandle md) { @@ -371,7 +371,7 @@ auto MapResult(void (Derived::Call::* fn)(ServerMetadata&), Promise x, } template -auto MapResult(void (Derived::Call::* fn)(ServerMetadata&, Derived*), Promise x, +auto MapResult(void (Derived::Call::*fn)(ServerMetadata&, Derived*), Promise x, FilterCallData* call_data) { GPR_DEBUG_ASSERT(fn == &Derived::Call::OnServerTrailingMetadata); return Map(std::move(x), [call_data](ServerMetadataHandle md) { @@ -496,7 +496,7 @@ inline void InterceptClientToServerMessage(const NoInterceptor*, void*, template inline void InterceptClientToServerMessage( - ServerMetadataHandle (Derived::Call::* fn)(const Message&), + ServerMetadataHandle (Derived::Call::*fn)(const Message&), FilterCallData* call_data, const CallArgs& call_args) { GPR_DEBUG_ASSERT(fn == &Derived::Call::OnClientToServerMessage); call_args.client_to_server_messages->InterceptAndMap( @@ -511,7 +511,7 @@ inline void InterceptClientToServerMessage( template inline void InterceptClientToServerMessage( - ServerMetadataHandle (Derived::Call::* fn)(const Message&, Derived*), + ServerMetadataHandle (Derived::Call::*fn)(const Message&, Derived*), FilterCallData* call_data, const CallArgs& call_args) { GPR_DEBUG_ASSERT(fn == &Derived::Call::OnClientToServerMessage); call_args.client_to_server_messages->InterceptAndMap( @@ -527,7 +527,7 @@ inline void InterceptClientToServerMessage( template inline void InterceptClientToServerMessage( - MessageHandle (Derived::Call::* fn)(MessageHandle, Derived*), + MessageHandle (Derived::Call::*fn)(MessageHandle, Derived*), FilterCallData* call_data, const CallArgs& call_args) { GPR_DEBUG_ASSERT(fn == &Derived::Call::OnClientToServerMessage); call_args.client_to_server_messages->InterceptAndMap( @@ -539,8 +539,7 @@ inline void InterceptClientToServerMessage( template inline void InterceptClientToServerMessage( - absl::StatusOr (Derived::Call::* fn)(MessageHandle, - Derived*), + absl::StatusOr (Derived::Call::*fn)(MessageHandle, Derived*), FilterCallData* call_data, const CallArgs& call_args) { GPR_DEBUG_ASSERT(fn == &Derived::Call::OnClientToServerMessage); call_args.client_to_server_messages->InterceptAndMap( @@ -559,7 +558,7 @@ inline void InterceptClientToServerMessage(const NoInterceptor*, void*, void*, template inline void InterceptClientToServerMessage( - ServerMetadataHandle (Derived::Call::* fn)(const Message&), + ServerMetadataHandle (Derived::Call::*fn)(const Message&), typename Derived::Call* call, Derived*, PipeBasedCallSpine* call_spine) { GPR_DEBUG_ASSERT(fn == &Derived::Call::OnClientToServerMessage); call_spine->client_to_server_messages().receiver.InterceptAndMap( @@ -573,7 +572,7 @@ inline void InterceptClientToServerMessage( template inline void InterceptClientToServerMessage( - ServerMetadataHandle (Derived::Call::* fn)(const Message&, Derived*), + ServerMetadataHandle (Derived::Call::*fn)(const Message&, Derived*), typename Derived::Call* call, Derived* channel, PipeBasedCallSpine* call_spine) { GPR_DEBUG_ASSERT(fn == &Derived::Call::OnClientToServerMessage); @@ -589,7 +588,7 @@ inline void InterceptClientToServerMessage( template inline void InterceptClientToServerMessage( - MessageHandle (Derived::Call::* fn)(MessageHandle, Derived*), + MessageHandle (Derived::Call::*fn)(MessageHandle, Derived*), typename Derived::Call* call, Derived* channel, PipeBasedCallSpine* call_spine) { GPR_DEBUG_ASSERT(fn == &Derived::Call::OnClientToServerMessage); @@ -601,8 +600,7 @@ inline void InterceptClientToServerMessage( template inline void InterceptClientToServerMessage( - absl::StatusOr (Derived::Call::* fn)(MessageHandle, - Derived*), + absl::StatusOr (Derived::Call::*fn)(MessageHandle, Derived*), typename Derived::Call* call, Derived* channel, PipeBasedCallSpine* call_spine) { GPR_DEBUG_ASSERT(fn == &Derived::Call::OnClientToServerMessage); @@ -622,8 +620,8 @@ inline void InterceptClientInitialMetadata(const NoInterceptor*, void*, void*, template inline void InterceptClientInitialMetadata( - void (Derived::Call::* fn)(ClientMetadata& md), - typename Derived::Call* call, Derived*, PipeBasedCallSpine* call_spine) { + void (Derived::Call::*fn)(ClientMetadata& md), typename Derived::Call* call, + Derived*, PipeBasedCallSpine* call_spine) { GPR_DEBUG_ASSERT(fn == &Derived::Call::OnClientInitialMetadata); call_spine->client_initial_metadata().receiver.InterceptAndMap( [call](ClientMetadataHandle md) { @@ -634,7 +632,7 @@ inline void InterceptClientInitialMetadata( template inline void InterceptClientInitialMetadata( - void (Derived::Call::* fn)(ClientMetadata& md, Derived* channel), + void (Derived::Call::*fn)(ClientMetadata& md, Derived* channel), typename Derived::Call* call, Derived* channel, PipeBasedCallSpine* call_spine) { GPR_DEBUG_ASSERT(fn == &Derived::Call::OnClientInitialMetadata); @@ -647,7 +645,7 @@ inline void InterceptClientInitialMetadata( template inline void InterceptClientInitialMetadata( - ServerMetadataHandle (Derived::Call::* fn)(ClientMetadata& md), + ServerMetadataHandle (Derived::Call::*fn)(ClientMetadata& md), typename Derived::Call* call, Derived*, PipeBasedCallSpine* call_spine) { GPR_DEBUG_ASSERT(fn == &Derived::Call::OnClientInitialMetadata); call_spine->client_initial_metadata().receiver.InterceptAndMap( @@ -662,8 +660,8 @@ inline void InterceptClientInitialMetadata( template inline void InterceptClientInitialMetadata( - ServerMetadataHandle (Derived::Call::* fn)(ClientMetadata& md, - Derived* channel), + ServerMetadataHandle (Derived::Call::*fn)(ClientMetadata& md, + Derived* channel), typename Derived::Call* call, Derived* channel, PipeBasedCallSpine* call_spine) { GPR_DEBUG_ASSERT(fn == &Derived::Call::OnClientInitialMetadata); @@ -679,7 +677,7 @@ inline void InterceptClientInitialMetadata( template inline void InterceptClientInitialMetadata( - absl::Status (Derived::Call::* fn)(ClientMetadata& md), + absl::Status (Derived::Call::*fn)(ClientMetadata& md), typename Derived::Call* call, Derived*, PipeBasedCallSpine* call_spine) { GPR_DEBUG_ASSERT(fn == &Derived::Call::OnClientInitialMetadata); call_spine->client_initial_metadata().receiver.InterceptAndMap( @@ -695,7 +693,7 @@ inline void InterceptClientInitialMetadata( template inline void InterceptClientInitialMetadata( - absl::Status (Derived::Call::* fn)(ClientMetadata& md, Derived* channel), + absl::Status (Derived::Call::*fn)(ClientMetadata& md, Derived* channel), typename Derived::Call* call, Derived* channel, PipeBasedCallSpine* call_spine) { GPR_DEBUG_ASSERT(fn == &Derived::Call::OnClientInitialMetadata); @@ -715,7 +713,7 @@ inline void InterceptClientInitialMetadata( template absl::void_t( std::declval>))> -InterceptClientInitialMetadata(Promise (Derived::Call::* promise_factory)( +InterceptClientInitialMetadata(Promise (Derived::Call::*promise_factory)( ClientMetadata& md, Derived* channel), typename Derived::Call* call, Derived* channel, PipeBasedCallSpine* call_spine) { @@ -741,7 +739,7 @@ inline void InterceptServerInitialMetadata(const NoInterceptor*, void*, template inline void InterceptServerInitialMetadata( - void (Derived::Call::* fn)(ServerMetadata&), + void (Derived::Call::*fn)(ServerMetadata&), FilterCallData* call_data, const CallArgs& call_args) { GPR_DEBUG_ASSERT(fn == &Derived::Call::OnServerInitialMetadata); call_args.server_initial_metadata->InterceptAndMap( @@ -753,7 +751,7 @@ inline void InterceptServerInitialMetadata( template inline void InterceptServerInitialMetadata( - absl::Status (Derived::Call::* fn)(ServerMetadata&), + absl::Status (Derived::Call::*fn)(ServerMetadata&), FilterCallData* call_data, const CallArgs& call_args) { GPR_DEBUG_ASSERT(fn == &Derived::Call::OnServerInitialMetadata); call_args.server_initial_metadata->InterceptAndMap( @@ -770,7 +768,7 @@ inline void InterceptServerInitialMetadata( template inline void InterceptServerInitialMetadata( - void (Derived::Call::* fn)(ServerMetadata&, Derived*), + void (Derived::Call::*fn)(ServerMetadata&, Derived*), FilterCallData* call_data, const CallArgs& call_args) { GPR_DEBUG_ASSERT(fn == &Derived::Call::OnServerInitialMetadata); call_args.server_initial_metadata->InterceptAndMap( @@ -782,7 +780,7 @@ inline void InterceptServerInitialMetadata( template inline void InterceptServerInitialMetadata( - absl::Status (Derived::Call::* fn)(ServerMetadata&, Derived*), + absl::Status (Derived::Call::*fn)(ServerMetadata&, Derived*), FilterCallData* call_data, const CallArgs& call_args) { GPR_DEBUG_ASSERT(fn == &Derived::Call::OnServerInitialMetadata); call_args.server_initial_metadata->InterceptAndMap( @@ -803,7 +801,7 @@ inline void InterceptServerInitialMetadata(const NoInterceptor*, void*, void*, template inline void InterceptServerInitialMetadata( - void (Derived::Call::* fn)(ServerMetadata&), typename Derived::Call* call, + void (Derived::Call::*fn)(ServerMetadata&), typename Derived::Call* call, Derived*, PipeBasedCallSpine* call_spine) { GPR_DEBUG_ASSERT(fn == &Derived::Call::OnServerInitialMetadata); call_spine->server_initial_metadata().sender.InterceptAndMap( @@ -815,7 +813,7 @@ inline void InterceptServerInitialMetadata( template inline void InterceptServerInitialMetadata( - absl::Status (Derived::Call::* fn)(ServerMetadata&), + absl::Status (Derived::Call::*fn)(ServerMetadata&), typename Derived::Call* call, Derived*, PipeBasedCallSpine* call_spine) { GPR_DEBUG_ASSERT(fn == &Derived::Call::OnServerInitialMetadata); call_spine->server_initial_metadata().sender.InterceptAndMap( @@ -831,7 +829,7 @@ inline void InterceptServerInitialMetadata( template inline void InterceptServerInitialMetadata( - void (Derived::Call::* fn)(ServerMetadata&, Derived*), + void (Derived::Call::*fn)(ServerMetadata&, Derived*), typename Derived::Call* call, Derived* channel, PipeBasedCallSpine* call_spine) { GPR_DEBUG_ASSERT(fn == &Derived::Call::OnServerInitialMetadata); @@ -844,7 +842,7 @@ inline void InterceptServerInitialMetadata( template inline void InterceptServerInitialMetadata( - absl::Status (Derived::Call::* fn)(ServerMetadata&, Derived*), + absl::Status (Derived::Call::*fn)(ServerMetadata&, Derived*), typename Derived::Call* call, Derived* channel, PipeBasedCallSpine* call_spine) { GPR_DEBUG_ASSERT(fn == &Derived::Call::OnServerInitialMetadata); @@ -864,7 +862,7 @@ inline void InterceptServerToClientMessage(const NoInterceptor*, void*, template inline void InterceptServerToClientMessage( - ServerMetadataHandle (Derived::Call::* fn)(const Message&), + ServerMetadataHandle (Derived::Call::*fn)(const Message&), FilterCallData* call_data, const CallArgs& call_args) { GPR_DEBUG_ASSERT(fn == &Derived::Call::OnServerToClientMessage); call_args.server_to_client_messages->InterceptAndMap( @@ -879,7 +877,7 @@ inline void InterceptServerToClientMessage( template inline void InterceptServerToClientMessage( - ServerMetadataHandle (Derived::Call::* fn)(const Message&, Derived*), + ServerMetadataHandle (Derived::Call::*fn)(const Message&, Derived*), FilterCallData* call_data, const CallArgs& call_args) { GPR_DEBUG_ASSERT(fn == &Derived::Call::OnServerToClientMessage); call_args.server_to_client_messages->InterceptAndMap( @@ -895,7 +893,7 @@ inline void InterceptServerToClientMessage( template inline void InterceptServerToClientMessage( - MessageHandle (Derived::Call::* fn)(MessageHandle, Derived*), + MessageHandle (Derived::Call::*fn)(MessageHandle, Derived*), FilterCallData* call_data, const CallArgs& call_args) { GPR_DEBUG_ASSERT(fn == &Derived::Call::OnServerToClientMessage); call_args.server_to_client_messages->InterceptAndMap( @@ -907,8 +905,7 @@ inline void InterceptServerToClientMessage( template inline void InterceptServerToClientMessage( - absl::StatusOr (Derived::Call::* fn)(MessageHandle, - Derived*), + absl::StatusOr (Derived::Call::*fn)(MessageHandle, Derived*), FilterCallData* call_data, const CallArgs& call_args) { GPR_DEBUG_ASSERT(fn == &Derived::Call::OnServerToClientMessage); call_args.server_to_client_messages->InterceptAndMap( @@ -927,7 +924,7 @@ inline void InterceptServerToClientMessage(const NoInterceptor*, void*, void*, template inline void InterceptServerToClientMessage( - ServerMetadataHandle (Derived::Call::* fn)(const Message&), + ServerMetadataHandle (Derived::Call::*fn)(const Message&), typename Derived::Call* call, Derived*, PipeBasedCallSpine* call_spine) { GPR_DEBUG_ASSERT(fn == &Derived::Call::OnServerToClientMessage); call_spine->server_to_client_messages().sender.InterceptAndMap( @@ -941,7 +938,7 @@ inline void InterceptServerToClientMessage( template inline void InterceptServerToClientMessage( - ServerMetadataHandle (Derived::Call::* fn)(const Message&, Derived*), + ServerMetadataHandle (Derived::Call::*fn)(const Message&, Derived*), typename Derived::Call* call, Derived* channel, PipeBasedCallSpine* call_spine) { GPR_DEBUG_ASSERT(fn == &Derived::Call::OnServerToClientMessage); @@ -957,7 +954,7 @@ inline void InterceptServerToClientMessage( template inline void InterceptServerToClientMessage( - MessageHandle (Derived::Call::* fn)(MessageHandle, Derived*), + MessageHandle (Derived::Call::*fn)(MessageHandle, Derived*), typename Derived::Call* call, Derived* channel, PipeBasedCallSpine* call_spine) { GPR_DEBUG_ASSERT(fn == &Derived::Call::OnServerToClientMessage); @@ -969,8 +966,7 @@ inline void InterceptServerToClientMessage( template inline void InterceptServerToClientMessage( - absl::StatusOr (Derived::Call::* fn)(MessageHandle, - Derived*), + absl::StatusOr (Derived::Call::*fn)(MessageHandle, Derived*), typename Derived::Call* call, Derived* channel, PipeBasedCallSpine* call_spine) { GPR_DEBUG_ASSERT(fn == &Derived::Call::OnServerToClientMessage); @@ -1014,7 +1010,7 @@ inline void InterceptServerTrailingMetadata( inline void InterceptFinalize(const NoInterceptor*, void*, void*) {} template -inline void InterceptFinalize(void (Call::* fn)(const grpc_call_final_info*), +inline void InterceptFinalize(void (Call::*fn)(const grpc_call_final_info*), void*, Call* call) { GPR_DEBUG_ASSERT(fn == &Call::OnFinalize); GetContext()->Add( @@ -1025,7 +1021,7 @@ inline void InterceptFinalize(void (Call::* fn)(const grpc_call_final_info*), template inline void InterceptFinalize( - void (Derived::Call::* fn)(const grpc_call_final_info*, Derived*), + void (Derived::Call::*fn)(const grpc_call_final_info*, Derived*), Derived* channel, typename Derived::Call* call) { GPR_DEBUG_ASSERT(fn == &Derived::Call::OnFinalize); GetContext()->Add( diff --git a/src/core/lib/promise/party.cc b/src/core/lib/promise/party.cc index 1d386762131..5d967a658e0 100644 --- a/src/core/lib/promise/party.cc +++ b/src/core/lib/promise/party.cc @@ -109,7 +109,7 @@ class Party::Handle final : public Wakeable { } void WakeupGeneric(WakeupMask wakeup_mask, - void (Party::* wakeup_method)(WakeupMask)) + void (Party::*wakeup_method)(WakeupMask)) ABSL_LOCKS_EXCLUDED(mu_) { mu_.Lock(); // Note that activity refcount can drop to zero, but we could win the lock diff --git a/src/core/lib/transport/call_arena_allocator.h b/src/core/lib/transport/call_arena_allocator.h index 571691f437f..1db02bf6902 100644 --- a/src/core/lib/transport/call_arena_allocator.h +++ b/src/core/lib/transport/call_arena_allocator.h @@ -12,8 +12,8 @@ // See the License for the specific language governing permissions and // limitations under the License. -#ifndef GRPC_SRC_CORE_LIB_TRANSPORT_CALL_SIZE_ESTIMATOR_H -#define GRPC_SRC_CORE_LIB_TRANSPORT_CALL_SIZE_ESTIMATOR_H +#ifndef GRPC_SRC_CORE_LIB_TRANSPORT_CALL_ARENA_ALLOCATOR_H +#define GRPC_SRC_CORE_LIB_TRANSPORT_CALL_ARENA_ALLOCATOR_H #include @@ -70,4 +70,4 @@ class CallArenaAllocator : public RefCounted { } // namespace grpc_core -#endif // GRPC_SRC_CORE_LIB_TRANSPORT_CALL_SIZE_ESTIMATOR_H +#endif // GRPC_SRC_CORE_LIB_TRANSPORT_CALL_ARENA_ALLOCATOR_H diff --git a/src/core/lib/transport/call_filters.h b/src/core/lib/transport/call_filters.h index e91e096fea2..b69b44a8df3 100644 --- a/src/core/lib/transport/call_filters.h +++ b/src/core/lib/transport/call_filters.h @@ -274,7 +274,7 @@ struct AddOpImpl { // void $INTERCEPTOR_NAME($VALUE_TYPE&) template + void (FilterType::Call::*impl)(typename T::element_type&)> struct AddOpImpl { static void Add(FilterType* channel_data, size_t call_offset, @@ -311,8 +311,8 @@ struct AddOpImpl + void (FilterType::Call::*impl)(typename T::element_type&, + FilterType*)> struct AddOpImpl< FilterType, T, void (FilterType::Call::*)(typename T::element_type&, FilterType*), impl> { @@ -352,7 +352,7 @@ struct AddOpImpl< // $VALUE_HANDLE $INTERCEPTOR_NAME($VALUE_HANDLE, FilterType*) template + T (FilterType::Call::*impl)(T, FilterType*)> struct AddOpImpl { static void Add(FilterType* channel_data, size_t call_offset, Layout>& to) { @@ -394,7 +394,7 @@ struct AddOpImpl { // absl::Status $INTERCEPTOR_NAME($VALUE_TYPE&) template + absl::Status (FilterType::Call::*impl)(typename T::element_type&)> struct AddOpImpl { @@ -439,7 +439,7 @@ struct AddOpImpl struct AddOpImpl< FilterType, T, @@ -467,8 +467,8 @@ struct AddOpImpl< // absl::Status $INTERCEPTOR_NAME($VALUE_TYPE&, FilterType*) template + absl::Status (FilterType::Call::*impl)(typename T::element_type&, + FilterType*)> struct AddOpImpl struct AddOpImpl $INTERCEPTOR_NAME($VALUE_HANDLE, FilterType*) template (FilterType::Call::* impl)(T, FilterType*)> + absl::StatusOr (FilterType::Call::*impl)(T, FilterType*)> struct AddOpImpl (FilterType::Call::*)(T, FilterType*), impl> { @@ -555,7 +555,7 @@ struct AddOpImpl struct AddOpImpl struct AddOpImpl struct AddOpImpl struct AddOpImpl + R (FilterType::Call::*impl)(typename T::element_type&)> struct AddOpImpl< FilterType, T, R (FilterType::Call::*)(typename T::element_type&), impl, absl::enable_if_t>::value>> { @@ -724,7 +724,7 @@ struct AddOpImpl< // PROMISE_RETURNING(absl::Status) $INTERCEPTOR_NAME($VALUE_TYPE&, FilterType*) template + R (FilterType::Call::*impl)(typename T::element_type&, FilterType*)> struct AddOpImpl< FilterType, T, R (FilterType::Call::*)(typename T::element_type&, FilterType*), impl, @@ -780,7 +780,7 @@ struct AddOpImpl< // PROMISE_RETURNING(absl::StatusOr<$VALUE_HANDLE>) // $INTERCEPTOR_NAME($VALUE_HANDLE, FilterType*) template + R (FilterType::Call::*impl)(T, FilterType*)> struct AddOpImpl, PromiseResult>::value>> { @@ -995,7 +995,7 @@ struct StackData { template void AddFinalizer(FilterType* channel_data, size_t call_offset, - void (FilterType::Call::* p)(const grpc_call_final_info*)) { + void (FilterType::Call::*p)(const grpc_call_final_info*)) { GPR_DEBUG_ASSERT(p == &FilterType::Call::OnFinalize); finalizers.push_back(Finalizer{ channel_data, @@ -1009,8 +1009,8 @@ struct StackData { template void AddFinalizer(FilterType* channel_data, size_t call_offset, - void (FilterType::Call::* p)(const grpc_call_final_info*, - FilterType*)) { + void (FilterType::Call::*p)(const grpc_call_final_info*, + FilterType*)) { GPR_DEBUG_ASSERT(p == &FilterType::Call::OnFinalize); finalizers.push_back(Finalizer{ channel_data, @@ -1378,10 +1378,10 @@ class CallFilters { std::string DebugString() const; private: - template >( - filters_detail::StackData::* layout_ptr)> + filters_detail::StackData::*layout_ptr)> class PipePromise { public: class Push { diff --git a/src/core/lib/transport/interception_chain.cc b/src/core/lib/transport/interception_chain.cc index a3994e6d07c..4d6ad34e315 100644 --- a/src/core/lib/transport/interception_chain.cc +++ b/src/core/lib/transport/interception_chain.cc @@ -16,11 +16,10 @@ #include -#include "call_destination.h" - #include #include "src/core/lib/gprpp/match.h" +#include "src/core/lib/transport/call_destination.h" #include "src/core/lib/transport/call_filters.h" #include "src/core/lib/transport/call_spine.h" #include "src/core/lib/transport/metadata.h" @@ -40,9 +39,9 @@ CallInitiator HijackedCall::MakeCall() { CallInitiator HijackedCall::MakeCallWithMetadata( ClientMetadataHandle metadata) { - auto call = grpc_core::MakeCallPair( - std::move(metadata), call_handler_.event_engine(), call_handler_.arena(), - nullptr, call_handler_.legacy_context()); + auto call = MakeCallPair(std::move(metadata), call_handler_.event_engine(), + call_handler_.arena(), nullptr, + call_handler_.legacy_context()); destination_->StartCall(std::move(call.handler)); return std::move(call.initiator); } diff --git a/test/core/promise/BUILD b/test/core/promise/BUILD index f848b166ceb..ac99d1a9fcd 100644 --- a/test/core/promise/BUILD +++ b/test/core/promise/BUILD @@ -23,9 +23,9 @@ grpc_cc_library( name = "poll_matcher", testonly = True, hdrs = ["poll_matcher.h"], + external_deps = ["gtest"], visibility = ["//test/core:__subpackages__"], deps = ["//src/core:poll"], - external_deps = ["gtest"], ) grpc_cc_library( @@ -505,11 +505,11 @@ grpc_cc_test( uses_event_engine = False, uses_polling = False, deps = [ + "poll_matcher", "//src/core:loop", "//src/core:map", "//src/core:notification", "//src/core:observable", - "poll_matcher" ], ) diff --git a/test/core/promise/poll_matcher.h b/test/core/promise/poll_matcher.h index e8fe4a6df7b..1c571effbcb 100644 --- a/test/core/promise/poll_matcher.h +++ b/test/core/promise/poll_matcher.h @@ -12,8 +12,8 @@ // See the License for the specific language governing permissions and // limitations under the License. -#ifndef POLL_MATCHER_H -#define POLL_MATCHER_H +#ifndef GRPC_TEST_CORE_PROMISE_POLL_MATCHER_H +#define GRPC_TEST_CORE_PROMISE_POLL_MATCHER_H #include "gmock/gmock.h" @@ -57,4 +57,4 @@ MATCHER_P(IsReady, value, "") { } // namespace grpc_core -#endif +#endif // GRPC_TEST_CORE_PROMISE_POLL_MATCHER_H diff --git a/test/core/transport/BUILD b/test/core/transport/BUILD index e1253685156..519f3c3bc38 100644 --- a/test/core/transport/BUILD +++ b/test/core/transport/BUILD @@ -45,10 +45,10 @@ grpc_cc_test( uses_event_engine = False, uses_polling = False, deps = [ + "//:grpc_base", "//src/core:interception_chain", "//src/core:resource_quota", "//test/core/promise:poll_matcher", - "//:grpc_base", ], ) diff --git a/test/core/transport/chaotic_good/client_transport_error_test.cc b/test/core/transport/chaotic_good/client_transport_error_test.cc index 9761d59033d..737f71a7aa2 100644 --- a/test/core/transport/chaotic_good/client_transport_error_test.cc +++ b/test/core/transport/chaotic_good/client_transport_error_test.cc @@ -142,9 +142,8 @@ class ClientTransportTest : public ::testing::Test { auto MakeCall(ClientMetadataHandle client_initial_metadata) { auto* arena = call_arena_allocator_->MakeArena(); - return grpc_core::MakeCallPair(std::move(client_initial_metadata), - event_engine_.get(), arena, - call_arena_allocator_, nullptr); + return MakeCallPair(std::move(client_initial_metadata), event_engine_.get(), + arena, call_arena_allocator_, nullptr); } private: diff --git a/test/core/transport/chaotic_good/transport_test.h b/test/core/transport/chaotic_good/transport_test.h index d5120fe0088..3604be1f190 100644 --- a/test/core/transport/chaotic_good/transport_test.h +++ b/test/core/transport/chaotic_good/transport_test.h @@ -44,9 +44,8 @@ class TransportTest : public ::testing::Test { auto MakeCall(ClientMetadataHandle client_initial_metadata) { auto* arena = call_arena_allocator_->MakeArena(); - return grpc_core::MakeCallPair(std::move(client_initial_metadata), - event_engine_.get(), arena, - call_arena_allocator_, nullptr); + return MakeCallPair(std::move(client_initial_metadata), event_engine_.get(), + arena, call_arena_allocator_, nullptr); } private: diff --git a/test/core/transport/test_suite/test.h b/test/core/transport/test_suite/test.h index f46c3a6ed78..1add21cdd29 100644 --- a/test/core/transport/test_suite/test.h +++ b/test/core/transport/test_suite/test.h @@ -240,9 +240,8 @@ class TransportTest : public ::testing::Test { auto MakeCall(ClientMetadataHandle client_initial_metadata) { auto* arena = call_arena_allocator_->MakeArena(); - return grpc_core::MakeCallPair(std::move(client_initial_metadata), - event_engine_.get(), arena, - call_arena_allocator_, nullptr); + return MakeCallPair(std::move(client_initial_metadata), event_engine_.get(), + arena, call_arena_allocator_, nullptr); } // Alternative for Seq for test driver code.