Merge pull request #24842 from veblush/tidy-google-build-using-namespace

[Clang-Tidy] google-build-using-namespace

.clang-tidy

@@ -10,7 +10,6 @@ Checks: '-*,
   -performance-unnecessary-copy-initialization,
   -performance-unnecessary-value-param,
   google-*,
-  -google-build-using-namespace,
   -google-explicit-constructor,
   -google-readability-casting,
   -google-runtime-int,

src/core/ext/filters/client_channel/http_connect_handshaker.cc

@@ -382,8 +382,7 @@ class HttpConnectHandshakerFactory : public HandshakerFactory {
 }  // namespace grpc_core
 
 void grpc_http_connect_register_handshaker_factory() {
-  using namespace grpc_core;
+  grpc_core::HandshakerRegistry::RegisterHandshakerFactory(
-  HandshakerRegistry::RegisterHandshakerFactory(
+      true /* at_start */, grpc_core::HANDSHAKER_CLIENT,
-      true /* at_start */, HANDSHAKER_CLIENT,
+      absl::make_unique<grpc_core::HttpConnectHandshakerFactory>());
-      absl::make_unique<HttpConnectHandshakerFactory>());
 }

src/core/lib/channel/handshaker.cc

@@ -256,7 +256,7 @@ void HandshakeManager::DoHandshake(grpc_endpoint* endpoint,
 void grpc_handshake_manager_add(grpc_handshake_manager* mgr,
                                 grpc_handshaker* handshaker) {
   // This is a transition method to aid the API change for handshakers.
-  using namespace grpc_core;
+  grpc_core::RefCountedPtr<grpc_core::Handshaker> refd_hs(
-  RefCountedPtr<Handshaker> refd_hs(static_cast<Handshaker*>(handshaker));
+      static_cast<grpc_core::Handshaker*>(handshaker));
   mgr->Add(refd_hs);
 }

test/core/handshake/readahead_handshaker_server_ssl.cc

@@ -77,11 +77,10 @@ class ReadAheadHandshakerFactory : public HandshakerFactory {
 }  // namespace grpc_core
 
 int main(int /*argc*/, char* /*argv*/[]) {
-  using namespace grpc_core;
   grpc_init();
-  HandshakerRegistry::RegisterHandshakerFactory(
+  grpc_core::HandshakerRegistry::RegisterHandshakerFactory(
-      true /* at_start */, HANDSHAKER_SERVER,
+      true /* at_start */, grpc_core::HANDSHAKER_SERVER,
-      absl::make_unique<ReadAheadHandshakerFactory>());
+      absl::make_unique<grpc_core::ReadAheadHandshakerFactory>());
   const char* full_alpn_list[] = {"grpc-exp", "h2"};
   GPR_ASSERT(server_ssl_test(full_alpn_list, 2, "grpc-exp"));
   grpc_shutdown();