use aquire release

7 years ago · 8d1a3ca5fc
parent f852c06038
commit 8d1a3ca5fc
2 changed files with 2 additions and 5 deletions
--- a/src/core/lib/iomgr/error.cc
+++ b/src/core/lib/iomgr/error.cc
@ -754,7 +754,7 @@ const char* grpc_error_string(grpc_error* err) {

  if (!gpr_atm_rel_cas(&err->atomics.error_string, 0, (gpr_atm)out)) {
    gpr_free(out);
-    out = (char*)gpr_atm_no_barrier_load(&err->atomics.error_string);
+    out = (char*)gpr_atm_acq_load(&err->atomics.error_string);
  }

  GPR_TIMER_END("grpc_error_string", 0);
--- a/src/core/lib/transport/error_utils.cc
+++ b/src/core/lib/transport/error_utils.cc
@ -71,10 +71,7 @@ void grpc_error_get_status(grpc_exec_ctx* exec_ctx, grpc_error* error,
  if (code != nullptr) *code = status;

  if (error_string != NULL && status != GRPC_STATUS_OK) {
-    const char* str = grpc_error_string(error);
-    if (str != nullptr) {
-      *error_string = gpr_strdup(str);
-    }
+    *error_string = gpr_strdup(grpc_error_string(error));
  }

  if (http_error != nullptr) {