Merge pull request #4436 from jtattermusch/csharp_shutdown_test

Fix server.KillAsync() and improve abandoned call test
pull/4465/head
Michael Lumish 9 years ago
commit 88fefe9a48
  1. 11
      src/csharp/Grpc.Core.Tests/ShutdownTest.cs
  2. 2
      src/csharp/Grpc.Core/Server.cs

@ -61,17 +61,20 @@ namespace Grpc.Core.Tests
}
[Test]
public async Task AbandonedCall()
public async Task AbandonedCall_ServerKillAsync()
{
var readyToShutdown = new TaskCompletionSource<object>();
helper.DuplexStreamingHandler = new DuplexStreamingServerMethod<string, string>(async (requestStream, responseStream, context) =>
{
readyToShutdown.SetResult(null);
await requestStream.ToListAsync();
});
var call = Calls.AsyncDuplexStreamingCall(helper.CreateDuplexStreamingCall(new CallOptions(deadline: DateTime.UtcNow.AddMilliseconds(1))));
var call = Calls.AsyncDuplexStreamingCall(helper.CreateDuplexStreamingCall());
await readyToShutdown.Task; // make sure handler is running
channel.ShutdownAsync().Wait();
server.ShutdownAsync().Wait();
await channel.ShutdownAsync(); // channel.ShutdownAsync() works even if there's a pending call.
await server.KillAsync(); // server.ShutdownAsync() would hang waiting for the call to finish.
}
}
}

@ -171,6 +171,8 @@ namespace Grpc.Core
handle.CancelAllCalls();
await shutdownTcs.Task.ConfigureAwait(false);
DisposeHandle();
await Task.Run(() => GrpcEnvironment.Release()).ConfigureAwait(false);
}
internal void AddCallReference(object call)

Loading…
Cancel
Save