calling create in default param is against code style

pull/14236/head
Jan Tattermusch 7 years ago
parent 18f27376c5
commit 889bb7fde4
  1. 9
      test/cpp/microbenchmarks/bm_fullstack_trickle.cc
  2. 26
      test/cpp/microbenchmarks/fullstack_fixtures.h
  3. 6
      test/cpp/performance/writes_per_rpc_test.cc

@ -80,8 +80,7 @@ class TrickledCHTTP2 : public EndpointPairFixture {
public:
TrickledCHTTP2(Service* service, bool streaming, size_t req_size,
size_t resp_size, size_t kilobits_per_second,
grpc_passthru_endpoint_stats* stats =
grpc_passthru_endpoint_stats_create())
grpc_passthru_endpoint_stats* stats)
: EndpointPairFixture(service, MakeEndpoints(kilobits_per_second, stats),
FixtureConfiguration()),
stats_(stats) {
@ -261,7 +260,8 @@ static void BM_PumpStreamServerToClient_Trickle(benchmark::State& state) {
EchoTestService::AsyncService service;
std::unique_ptr<TrickledCHTTP2> fixture(new TrickledCHTTP2(
&service, true, state.range(0) /* req_size */,
state.range(0) /* resp_size */, state.range(1) /* bw in kbit/s */));
state.range(0) /* resp_size */, state.range(1) /* bw in kbit/s */,
grpc_passthru_endpoint_stats_create()));
{
EchoResponse send_response;
EchoResponse recv_response;
@ -354,7 +354,8 @@ static void BM_PumpUnbalancedUnary_Trickle(benchmark::State& state) {
EchoTestService::AsyncService service;
std::unique_ptr<TrickledCHTTP2> fixture(new TrickledCHTTP2(
&service, false, state.range(0) /* req_size */,
state.range(1) /* resp_size */, state.range(2) /* bw in kbit/s */));
state.range(1) /* resp_size */, state.range(2) /* bw in kbit/s */,
grpc_passthru_endpoint_stats_create()));
EchoRequest send_request;
EchoResponse send_response;
EchoResponse recv_response;

@ -245,18 +245,20 @@ class SockPair : public EndpointPairFixture {
fixture_configuration) {}
};
class InProcessCHTTP2 : public EndpointPairFixture {
/* Use InProcessCHTTP2 instead. This class (with stats as an explicit parameter)
is here only to be able to initialize both the base class and stats_ with the
same stats instance without accessing the stats_ fields before the object is
properly initialized. */
class InProcessCHTTP2WithExplicitStats : public EndpointPairFixture {
public:
InProcessCHTTP2(Service* service,
const FixtureConfiguration& fixture_configuration =
FixtureConfiguration(),
grpc_passthru_endpoint_stats* stats =
grpc_passthru_endpoint_stats_create())
InProcessCHTTP2WithExplicitStats(
Service* service, grpc_passthru_endpoint_stats* stats,
const FixtureConfiguration& fixture_configuration)
: EndpointPairFixture(service, MakeEndpoints(stats),
fixture_configuration),
stats_(stats) {}
virtual ~InProcessCHTTP2() {
virtual ~InProcessCHTTP2WithExplicitStats() {
if (stats_ != nullptr) {
grpc_passthru_endpoint_stats_destroy(stats_);
}
@ -280,6 +282,16 @@ class InProcessCHTTP2 : public EndpointPairFixture {
}
};
class InProcessCHTTP2 : public InProcessCHTTP2WithExplicitStats {
public:
InProcessCHTTP2(Service* service,
const FixtureConfiguration& fixture_configuration =
FixtureConfiguration())
: InProcessCHTTP2WithExplicitStats(service,
grpc_passthru_endpoint_stats_create(),
fixture_configuration) {}
};
////////////////////////////////////////////////////////////////////////////////
// Minimal stack fixtures

@ -142,8 +142,7 @@ class EndpointPairFixture {
class InProcessCHTTP2 : public EndpointPairFixture {
public:
InProcessCHTTP2(Service* service, grpc_passthru_endpoint_stats* stats =
grpc_passthru_endpoint_stats_create())
InProcessCHTTP2(Service* service, grpc_passthru_endpoint_stats* stats)
: EndpointPairFixture(service, MakeEndpoints(stats)), stats_(stats) {}
virtual ~InProcessCHTTP2() {
@ -169,7 +168,8 @@ static double UnaryPingPong(int request_size, int response_size) {
const int kIterations = 10000;
EchoTestService::AsyncService service;
std::unique_ptr<InProcessCHTTP2> fixture(new InProcessCHTTP2(&service));
std::unique_ptr<InProcessCHTTP2> fixture(
new InProcessCHTTP2(&service, grpc_passthru_endpoint_stats_create()));
EchoRequest send_request;
EchoResponse send_response;
EchoResponse recv_response;

Loading…
Cancel
Save