diff --git a/test/core/event_engine/test_suite/oracle_event_engine_posix.cc b/test/core/event_engine/test_suite/oracle_event_engine_posix.cc index 3a7507ecb6d..06f375e514c 100644 --- a/test/core/event_engine/test_suite/oracle_event_engine_posix.cc +++ b/test/core/event_engine/test_suite/oracle_event_engine_posix.cc @@ -321,7 +321,7 @@ PosixOracleListener::~PosixOracleListener() { shutdown(listener_fds_[i], SHUT_RDWR); } // Send a STOP message over the pipe. - write(pipefd_[1], kStopMessage, strlen(kStopMessage)); + GPR_ASSERT(write(pipefd_[1], kStopMessage, strlen(kStopMessage)) != -1); serve_.Join(); on_shutdown_(absl::OkStatus()); } diff --git a/test/core/iomgr/tcp_posix_test.cc b/test/core/iomgr/tcp_posix_test.cc index 1b7aa68f517..e7abccc0c3d 100644 --- a/test/core/iomgr/tcp_posix_test.cc +++ b/test/core/iomgr/tcp_posix_test.cc @@ -155,7 +155,7 @@ static size_t fill_socket_partial(int fd, size_t bytes) { struct read_socket_state { grpc_endpoint* ep; - int min_progress_size; + size_t min_progress_size; size_t read_bytes; size_t target_read_bytes; grpc_slice_buffer incoming; diff --git a/test/core/memory_usage/callback_server.cc b/test/core/memory_usage/callback_server.cc index dd29c78b643..df82601c238 100644 --- a/test/core/memory_usage/callback_server.cc +++ b/test/core/memory_usage/callback_server.cc @@ -45,15 +45,15 @@ class ServerCallbackImpl final grpc::ServerUnaryReactor* UnaryCall( grpc::CallbackServerContext* context, - const grpc::testing::SimpleRequest* request, - grpc::testing::SimpleResponse* response) override { + const grpc::testing::SimpleRequest* /* request */, + grpc::testing::SimpleResponse* /* response */) override { auto* reactor = context->DefaultReactor(); reactor->Finish(grpc::Status::OK); return reactor; } grpc::ServerUnaryReactor* GetBeforeSnapshot( grpc::CallbackServerContext* context, - const grpc::testing::SimpleRequest* request, + const grpc::testing::SimpleRequest* /* request */, grpc::testing::MemorySize* response) override { gpr_log(GPR_INFO, "BeforeSnapshot RPC CALL RECEIVED"); response->set_rss(before_server_create); diff --git a/tools/internal_ci/linux/grpc_bazel_build_in_docker.sh b/tools/internal_ci/linux/grpc_bazel_build_in_docker.sh index 2d02c529d06..cd8262468c1 100755 --- a/tools/internal_ci/linux/grpc_bazel_build_in_docker.sh +++ b/tools/internal_ci/linux/grpc_bazel_build_in_docker.sh @@ -17,6 +17,9 @@ # clang compiler to check if sources can pass a set of warning options. # For now //examples/android/binder/ are excluded because it needs Android # SDK/NDK to be installed to build + +set -ex + python3 tools/run_tests/python_utils/bazel_report_helper.py --report_path bazel_build_with_strict_warnings bazel_build_with_strict_warnings/bazel_wrapper \ --bazelrc=tools/remote_build/include/test_locally_with_resultstore_results.bazelrc \ @@ -36,11 +39,11 @@ bazel_build_with_strict_warnings/bazel_wrapper \ # details. # Test that builds with --define=grpc_no_xds=true work. bazel build //test/cpp/end2end:end2end_test --define=grpc_no_xds=true + # Test that builds that need xDS do not build with --define=grpc_no_xds=true EXIT_CODE=0 bazel build //test/cpp/end2end/xds:xds_end2end_test --define=grpc_no_xds=true || EXIT_CODE=$? -if [ $EXIT_CODE -eq 0 ] -then +if [ $EXIT_CODE -eq 0 ]; then echo "Building xds_end2end_test succeeded even with --define=grpc_no_xds=true" exit 1 fi